added helpful or not button in feedback

ui/til_feedback.py

@@ -2,10 +2,10 @@ import streamlit as st
 from dotenv import load_dotenv
 from workflows.til import TilCrew
 from streamlit_extras.capture import stdout
-load_dotenv()
-
-
+from langsmith import Client
+from workflows.utils.feedback import Feedback
 
+load_dotenv()
 def main():
     st.markdown("<div class='container'>", unsafe_allow_html=True)
 
@@ -46,29 +46,74 @@ def main():
     )
 
     if st.button("Get Feedback"):
-        with st.status(
-            "🤖 **Analysing TIL...**", state="running", expanded=True
-        ) as status:
-            with st.container(height=500, border=False):
-                log_container = st.empty()
-                with stdout(log_container.code, terminator=""):
-                    feedback = TilCrew()
-                    inputs = {"content": til_content}
-                    results = feedback.kickoff(inputs=inputs)["feedback"]
-            status.update(
-                label="✅ Feedback ready!",
-                state="complete",
-                expanded=False,
-            )
-
-        for result in results:
-            st.markdown(f"#### TIL: {result['til']}")
-            st.markdown(f"**Feedback:** {result['feedback']}")
-            if result['feedback'] == "not_ok":
-                st.markdown(f"**Criteria:** {result['feedback_criteria']}")
-                st.markdown(f"**Reason:** {result['reason']}")
-                if result.get('suggestion') is not None:
-                    st.markdown(f"**Suggestion:** {result['suggestion']}")
+            with st.status(
+                "🤖 **Analysing TIL...**", state="running", expanded=True
+            ) as status:
+                with st.container(height=500, border=False):
+                    log_container = st.empty()
+                    with stdout(log_container.code, terminator=""):
+                        feedback = TilCrew()
+                        inputs = {"content": til_content}
+                        results = feedback.kickoff(inputs=inputs)
+                status.update(
+                    label="✅ Feedback ready!",
+                    state="complete",
+                    expanded=False,
+                )
+            st.session_state.results = results
+            st.session_state.run_id = results["run_id"]
+            clear_feedback_state(results)
+
+    if 'results' in st.session_state:
+            results = st.session_state.results
+            for result in results["feedback"]:
+                st.markdown(f"#### TIL: {result['til']}")
+                st.markdown(f"**Feedback:** {result['feedback']}")
+                if result['feedback'] == "not_ok":
+                    st.markdown(f"**Criteria:** {result['feedback_criteria']}")
+                    st.markdown(f"**Reason:** {result['reason']}")
+                    if result.get('suggestion') is not None:
+                        st.markdown(f"**Suggestion:** {result['suggestion']}")
+         
+                feedback_key = result['til'].replace(' ', '_')
+                feedback_given_key = f"{feedback_key}_feedback_given"
+
+                if feedback_given_key not in st.session_state:
+                    st.session_state[feedback_given_key] = False
+
+                if not st.session_state[feedback_given_key]:
+                    if st.button("helpful", key=f"helpful_{feedback_key}"):
+                            give_feedback(feedback_key, True)
+                            st.session_state[feedback_given_key] = True
+
+                    if st.button("not_helpful", key=f"not_helpful_{feedback_key}"):
+                            give_feedback(feedback_key, False)
+                            st.session_state[feedback_given_key] = True
+
+
+def give_feedback(feedback_key, is_helpful):
+        run_id = st.session_state.run_id
+        metric_type = "helpful" if is_helpful else "not_helpful"
+        metric_score = 1 if is_helpful else 0
+
+        feedback_data = Feedback(
+            metric_type=metric_type,
+            metric_score=metric_score,
+            feedback_on=feedback_key.replace('_', ' ').title() 
+        )
+        try:
+            TilCrew.post_feedback(run_id, feedback_data)
+            st.success("Feedback submitted successfully!")
+        except Exception as e:
+            st.error(f"Failed to submit feedback: {e}")
+        
+        st.session_state[f"{feedback_key}_feedback_given"] = True
+
+def clear_feedback_state(results):
+       for key in st.session_state.keys():
+        if key.endswith("_feedback_given"):
+            st.session_state[key] = False
 
 if __name__ == "__main__":
     main()
+

workflows/utils/feedback.py

@@ -2,7 +2,7 @@ from pydantic import BaseModel
 from typing import List, Optional
 
 class Feedback(BaseModel):
-    helpful_score: Optional[float]
+    helpful_score: Optional[float]=None
     metric_type: Optional[str]
     metric_score: Optional[float]
     feedback_on: Optional[str]