Merge pull request #11 from beautiful-code/bulk_til_processing

crew/til.py

@@ -3,6 +3,7 @@ from langchain_core.messages import SystemMessage
 from pydantic import BaseModel, Field
 from langchain_core.output_parsers import JsonOutputParser
 from langchain_openai import ChatOpenAI
+from typing import List
 import pprint
 
 HIGH_IMPACT_THRESHOLD = 8
@@ -16,59 +17,66 @@ class TilCrew:
         return self._final_call_on_feedback()
 
     def _final_call_on_feedback(self):
-        if self.feedback["factuality_score"] < HIGH_IMPACT_THRESHOLD:
-            return {
+        final_results = []
+        for feedback in self.feedback_results:
+            print("Final analysis of:")
+            pprint.pp(feedback)
+            result = {
+                "til": feedback.get('til', ""),
                 "feedback": "not_ok",
-                "feedback_criteria": "factuality_feedback",
-                "reason": self.feedback["factuality_reason"],
             }
+            if feedback["factuality_score"] < HIGH_IMPACT_THRESHOLD:
+                result["feedback_criteria"] = "factuality_feedback"
+                result["reason"] = feedback["factuality_reason"]
+                final_results = final_results + [result]
+                continue
 
-        if self.feedback["insightful_score"] < HIGH_IMPACT_THRESHOLD:
-            return {
-                "feedback": "not_ok",
-                "feedback_criteria": "insightful_feedback",
-                "reason": self.feedback["insightful_reason"],
-            }
+            if feedback["insightful_score"] < HIGH_IMPACT_THRESHOLD:
+                result["feedback_criteria"] = "insightful_feedback"
+                result["reason"] = feedback["insightful_reason"]
+                final_results = final_results + [result]
+                continue
 
-        if self.feedback["simplicity_score"] < LOW_IMPACT_THRESHOLD:
-            return {
-                "feedback": "not_ok",
-                "feedback_criteria": "simplicity_feedback",
-                "reason": self.feedback["simplicity_reason"],
-                "suggestion": self.feedback["final_suggestion"],
-            }
+            if feedback["simplicity_score"] < LOW_IMPACT_THRESHOLD:
+                result["feedback_criteria"] = "simplicity_feedback"
+                result["reason"] = feedback["simplicity_reason"]
+                result["suggestion"] = feedback["final_suggestion"]
+                final_results = final_results + [result]
+                continue
 
-        if self.feedback["grammatical_score"] < LOW_IMPACT_THRESHOLD:
-            return {
-                "feedback": "not_ok",
-                "feedback_criteria": "grammatical_feedback",
-                "reason": self.feedback["grammatical_reason"],
-                "suggestion": self.feedback["final_suggestion"],
-            }
+            if feedback["grammatical_score"] < LOW_IMPACT_THRESHOLD:
+                result["feedback_criteria"] = "grammatical_feedback"
+                result["reason"] = feedback["grammatical_reason"]
+                result["suggestion"] = feedback["final_suggestion"]
+                final_results = final_results + [result]
+                continue
+
+            result["feedback"] = "ok"
+            final_results = final_results + [result]
 
-        return {
-            "feedback": "ok",
-        }
+        print("Final Results:")
+        pprint.pp(final_results)
+        return final_results
 
     def _gather_feedback(self):
         feedback_chain = self._build_feedback_chain()
         pprint.pp("Analysing the TIL.....")
-        self.feedback = feedback_chain.invoke({"til_content": self.content})
+        self.feedback_results = feedback_chain.invoke({"til_content": self.content})['tils']
         print("Feedback: ")
-        pprint.pp(self.feedback)
+        pprint.pp(self.feedback_results)
 
     def _build_feedback_chain(self):
-        feedback_parser = JsonOutputParser(pydantic_object=TilFeedbackResult)
+        feedback_parser = JsonOutputParser(pydantic_object=TilFeedbackResults)
         feedback_prompt = ChatPromptTemplate.from_messages([
             SystemMessage(
                 "You are a 'Personal TIL Reviewer' who works in an Product Engineering Services company, you responsibility is to guide the user to write better TILs. "
-                "Your personal goal is to review a user's TIL and suggested edits based on the following criteria:\n"
+                "Your personal goal is to review a user's list of TILs and suggeste edits based on the following criteria:\n"
                 "1. Is the TIL insightful?"
-                "2. Is the TIL factually correct?"
+                "2. Is the TIL factually correct and accurate?"
                 "3. Is the TIL written in simple english?"
                 "4. Is the TIL grammatically correct?"
 
-                "Can you provide a score for on the scale of 10 for each of these criteria and provide reasons for the score, the reason should be presented in the POV of the Personal TIL Reviewer."
+                "Can you provide a score for on the scale of 10 for each of the TIL on each of these criteria and provide reasons for the score, the reason should be presented in the POV of the Personal TIL Reviewer."
                 f"Formatting Instructions: {feedback_parser.get_format_instructions()}"
             ),
             HumanMessagePromptTemplate.from_template("{til_content}")
@@ -82,17 +90,22 @@ class TilCrew:
 
 
 class TilFeedbackResult(BaseModel):
+    til: str = Field(description="TIL content the user has provided on which we are performing the analysis.")
     insightful_score: int = Field(
         description="TIL score on insightful criteria")
-    insightful_reason: str = Field(description="Reason for insightful_score")
+    insightful_reason: str = Field(description="Reason for low insightful_score if it is not 10")
     factuality_score: int = Field(
-        description="TIL score on factuality criteria")
-    factuality_reason: str = Field(description="Reason for factuality_score")
+        description="TIL score on factuality criteria and correctness of the statement")
+    factuality_reason: str = Field(description="Reason for low factuality_score if it is not 10")
     simplicity_score: int = Field(
         description="TIL score on simplicity criteria")
-    simplicity_reason: str = Field(description="Reason for simplicity_score")
+    simplicity_reason: str = Field(description="Reason for low simplicity_score if it is not 10")
     grammatical_score: int = Field(
         description="TIL score on grammatical criteria")
-    grammatical_reason: str = Field(description="Reason for grammatical_score")
+    grammatical_reason: str = Field(description="Reason for low grammatical_score if it is not 10")
     final_suggestion: str = Field(
         description="Final suggested version of the TIL")
+
+
+class TilFeedbackResults(BaseModel):
+    tils: List[TilFeedbackResult]

test.py

@@ -21,7 +21,7 @@ def main():
         """,
         unsafe_allow_html=True
     )
-    til_content = st.text_input('Enter what you learnt today:', 'Upon delving into the intricacies of Docker, I have acquired the capability to encapsulate our application within containers, thereby streamlining the deployment process across a multitude of heterogeneous environments.', key='til_content', help='Enter what you learnt today')
+    til_content = st.text_area('Enter what you learnt today:', 'Upon delving into the intricacies of Docker, I have acquired the capability to encapsulate our application within containers, thereby streamlining the deployment process across a multitude of heterogeneous environments.', key='til_content', help='Enter what you learnt today')
 
     if st.button("Get Feedback"):
         with st.status(
@@ -32,19 +32,21 @@ def main():
                 with stdout(log_container.code, terminator=""):
                     feedback = TilCrew()
                     inputs = {"content": til_content}
-                    result = feedback.kickoff(inputs=inputs)
+                    results = feedback.kickoff(inputs=inputs)
             status.update(
                 label="✅ Feedback ready!",
                 state="complete",
                 expanded=False,
             )
 
-        st.markdown(f"# Feedback: {result['feedback']}")
-        if result['feedback'] == "not_ok":
-          st.markdown(f"**Criteria:** {result['feedback_criteria']}")
-          st.markdown(f"**Reason:** {result['reason']}")
-          if result.get('suggestion') is not None:
-            st.markdown(f"**Suggestion:** {result['suggestion']}")
+        for result in results:
+          st.markdown(f"#### TIL: {result['til']}")
+          st.markdown(f"**Feedback:** {result['feedback']}")
+          if result['feedback'] == "not_ok":
+            st.markdown(f"**Criteria:** {result['feedback_criteria']}")
+            st.markdown(f"**Reason:** {result['reason']}")
+            if result.get('suggestion') is not None:
+              st.markdown(f"**Suggestion:** {result['suggestion']}")
 
 if __name__ == "__main__":
     main()