test: pin the share-URL routing rule so avatarimg can never return to /share/p/

scripts/test-avatar-interiors.mjs

@@ -5,10 +5,18 @@
  * still renders, it just renders at the wrong size or without the ring, and
  * nothing throws. These assert the geometry and the ordering, not just "no
  * crash".
+ *
+ * The share-URL block is here for the same reason, and it is deliberately
+ * Node-only. The browser copy of this rule lives in dist/assets/share-fix.js as
+ * a string regex, because it has to run against the served bundle before a
+ * rebuild; the routing decision itself lives in src/assets.js. These tests pin
+ * the src/ half so the two cannot drift apart silently, and the browser half is
+ * asserted separately in scripts/test-neon-ui.mjs.
  */
 import assert from 'node:assert/strict';
 import { mergeResults } from '../src/merge.js';
 import { foldText, searchAvatarInteriors } from '../src/avatar-interiors.js';
+import { shareURL } from '../src/assets.js';
 
 let passed = 0, failed = 0;
 const test = (name, fn) => {
@@ -56,6 +64,68 @@ test('a query too short to be meaningful is rejected', () => {
   assert.equal(searchAvatarInteriors('a', items).length, 0);
 });
 
+console.log('\nshare URLs');
+// ──────────────────────────────────────────────────────────────────────────
+
+const STUDIO = 'https://bep40-vai-avatar.hf.space';
+const broken = 'https://bep40-vai-avatar.hf.space/share/p/avatarimg%3Ab68dc779370dc70e';
+const fixed = `${STUDIO}/share/i/b68dc779370dc70e`;
+
+test('the reported broken URL is now the interior route', () => {
+  // The exact address from the report. `avatarimg:` is a namespace for
+  // de-duplication, not a catalogue identity, so /share/p/ resolved to nothing
+  // and vai-avatar answered "Not Found" for every interior photograph.
+  assert.equal(shareURL({ avatarImageId: 'b68dc779370dc70e', sku: 'avatarimg:b68dc779370dc70e' }), fixed);
+});
+
+test('the bug is reproducible against the old logic', () => {
+  // Pins what the fix is fixing, so the assertion above cannot pass for an
+  // unrelated reason. Without the avatarImageId branch, `sku` wins and the link
+  // is the dead one -- byte-identical to the reported URL.
+  const photo = { sku: 'avatarimg:b68dc779370dc70e' };
+  const oldRoute = `${STUDIO}/share/p/${encodeURIComponent(photo.sku)}`;
+  assert.equal(oldRoute, broken, 'the reported URL must be what the old routing produced');
+  assert.notEqual(shareURL(photo), oldRoute, 'shareURL still routes an avatarimg sku to /share/p/');
+});
+
+test('an interior is routed even when it has lost avatarImageId', () => {
+  // merge.js rewrites `id` into a namespaced tile key, so a record can arrive
+  // carrying the sku but not the original field. The prefix is unwrapped rather
+  // than treated as an identity, which is what this fallback exists for.
+  assert.equal(shareURL({ sku: 'avatarimg:b68dc779370dc70e' }), fixed);
+});
+
+test('an empty avatarimg prefix yields no share URL at all', () => {
+  // /share/i/ with nothing after it is its own 404. Returning null lets the
+  // caller omit the button rather than render a dead link.
+  assert.equal(shareURL({ sku: 'avatarimg:' }), null);
+  assert.equal(shareURL({ avatarImageId: '  ' }), null);
+});
+
+test('a real product still routes to /share/p/', () => {
+  // The fix must not disturb the route that works. A product keeps its slug, and
+  // /share/p/ resolves all three identity forms.
+  assert.equal(shareURL({ sku: 'MH800TC' }), `${STUDIO}/share/p/MH800TC`);
+  assert.equal(
+    shareURL({ sku: 'MH800TC', slug: 'mh800tc-malloca-may-hut-mui-gan-tu-am-tu-80cm' }),
+    `${STUDIO}/share/p/mh800tc-malloca-may-hut-mui-gan-tu-am-tu-80cm`,
+    'the slug must still win over the sku',
+  );
+});
+
+test('a baked interior without a sku keeps its own route', () => {
+  // No sku at all: the id branch is what answers, and it must not be captured by
+  // the avatarimg fallback.
+  assert.equal(shareURL({ id: 'a1b2c3d4e5' }), `${STUDIO}/share/i/a1b2c3d4e5`);
+});
+
+test('a record with nothing to share returns null', () => {
+  assert.equal(shareURL(null), null);
+  assert.equal(shareURL(undefined), null);
+  assert.equal(shareURL({}), null);
+  assert.equal(shareURL('nope'), null);
+});
+
 console.log('\nfeatured tiles');
 // ──────────────────────────────────────────────────────────────────────────
 
@@ -214,4 +284,4 @@ test('fewer than ten new photographs still all ring', () => {
 });
 
 console.log(`\n${passed} passed, ${failed} failed`);
-process.exit(failed ? 1 : 0);
+process.exit(failed ? 1 : 0);