refactor(user_schema): remove deprecated otpIdentifer and add mode validation

Add validation for required fields based on registration mode (OTP/OAuth) and remove deprecated otpIdentifer field

app/schemas/user_schema.py

@@ -8,11 +8,10 @@ class UserRegisterRequest(BaseModel):
     name: str
     email: EmailStr  # Mandatory for all registration modes
     phone: str  # Mandatory for all registration modes (always used as OTP identifier)
-    otpIdentifer: Optional[str] = None  # Deprecated - phone is always the OTP identifier
-    otp: Optional[str] = None
+    otp: Optional[str] = None  # Required for OTP mode
     dob: Optional[str] = None  # ISO format date string
-    oauth_token: Optional[str] = None
-    provider: Optional[Literal["google", "apple", "facebook"]] = None
+    oauth_token: Optional[str] = None  # Required for OAuth mode
+    provider: Optional[Literal["google", "apple", "facebook"]] = None  # Required for OAuth mode
     mode: Literal["otp", "oauth"]
 
     @validator('phone')
@@ -25,16 +24,16 @@ class UserRegisterRequest(BaseModel):
                 raise ValueError('Invalid phone number format')
         return v
 
-    @validator('otpIdentifer')
-    def validate_otp_identifier(cls, v):
-        if v is not None:
-            # Check if it's either email or phone
-            email_pattern = r"[^@]+@[^@]+\.[^@]+"
-            phone_cleaned = re.sub(r'[^\d+]', '', v)
-            phone_pattern = r'^\+?[1-9]\d{7,14}$'
-            
-            if not (re.match(email_pattern, v) or re.match(phone_pattern, phone_cleaned)):
-                raise ValueError('OTP identifier must be a valid email address or phone number')
+    @validator('mode')
+    def validate_mode_dependent_fields(cls, v, values):
+        if v == "otp":
+            if not values.get('otp'):
+                raise ValueError('OTP is required for OTP registration mode')
+        elif v == "oauth":
+            if not values.get('oauth_token'):
+                raise ValueError('OAuth token is required for OAuth registration mode')
+            if not values.get('provider'):
+                raise ValueError('Provider is required for OAuth registration mode')
         return v
 
 # Used in login form (optional display name prefilled from local storage)