bsmith3715 commited on
Commit
9c3c79d
·
1 Parent(s): 9c9cf50

HW3 Completed

Browse files
Files changed (1) hide show
  1. README.md +13 -1
README.md CHANGED
@@ -168,7 +168,9 @@ Simply put, this downloads the file as a temp file, we load it in with `TextFile
168
 
169
  Why do we want to support streaming? What about streaming is important, or useful?
170
 
171
- Streaming allows for the user to benefit.
 
 
172
 
173
  ### On Chat Start:
174
 
@@ -212,6 +214,11 @@ Now, we'll save that into our user session!
212
 
213
  Why are we using User Session here? What about Python makes us need to use this? Why not just store everything in a global variable?
214
 
 
 
 
 
 
215
  ### On Message
216
 
217
  First, we load our chain from the user session:
@@ -337,6 +344,11 @@ Upload a PDF file of the recent DeepSeek-R1 paper and ask the following question
337
 
338
  Does this application pass your vibe check? Are there any immediate pitfalls you're noticing?
339
 
 
 
 
 
 
340
  ## 🚧 CHALLENGE MODE 🚧
341
 
342
  For the challenge mode, please instead create a simple FastAPI backend with a simple React (or any other JS framework) frontend.
 
168
 
169
  Why do we want to support streaming? What about streaming is important, or useful?
170
 
171
+ Streaming is generally beneficial only to the user, as it produces output in a more conversational way.
172
+ It doesn't speed up any computations or token generation, but it makes it appear that something is happening at more frequent intervals
173
+ as opposed to waiting until the entire response is generated.
174
 
175
  ### On Chat Start:
176
 
 
214
 
215
  Why are we using User Session here? What about Python makes us need to use this? Why not just store everything in a global variable?
216
 
217
+ It allows multiple users to simultaneously utilize the app, but contains all the information within a conversation, unique to the user.
218
+ Therefore, no users context will be corrupted, or overwritten by another users documents (as would be the case using a global variable).
219
+ Python is unable to provide seperate user contexts, so this must be done with another option, Chainlit being a good soluation.
220
+
221
+
222
  ### On Message
223
 
224
  First, we load our chain from the user session:
 
344
 
345
  Does this application pass your vibe check? Are there any immediate pitfalls you're noticing?
346
 
347
+ The initial responses for Q1 and Q2 seem reasonable. If this were the extent of the vibe check I would be satisfied. However, the response
348
+ to Q3 being "I don't know the answer" indicates that the retrieval portion, or embedding portion of the RAG application could be improved.
349
+ The use of the characterTextSplitter could be limiting the usefullness of the retrieval, and the prompt template including instructions
350
+ to simply state "I don't know" could be improved.
351
+
352
  ## 🚧 CHALLENGE MODE 🚧
353
 
354
  For the challenge mode, please instead create a simple FastAPI backend with a simple React (or any other JS framework) frontend.