fix: persist artifacts for scored ideas

Co-authored-by: Codex <noreply@openai.com>

hackathon_advisor/agent.py

@@ -106,6 +106,7 @@ class AdvisorEngine:
             tool_events.append(event)
             response = self._whitespace_response(idea, whitespace, score)
             artifact = self._artifact(idea, score)
+            self._attach_artifact(state, idea, artifact)
             return self._result(
                 normalized,
                 corrections,
@@ -173,6 +174,11 @@ class AdvisorEngine:
             stored.append(idea.to_dict())
         state["ideas"] = stored
 
+    def _attach_artifact(self, state: dict[str, Any], idea: Idea, artifact: dict[str, Any]) -> None:
+        idea.artifact = artifact
+        self._store_idea(state, idea)
+        state["last_artifact"] = artifact
+
     def _current_idea(self, state: dict[str, Any]) -> Idea | None:
         current_id = state.get("current_idea_id")
         for item in state.get("ideas", []):
@@ -222,6 +228,7 @@ class AdvisorEngine:
             tool_events.append(event)
             response = self._whitespace_response(idea, whitespace, score)
         artifact = self._artifact(idea, score)
+        self._attach_artifact(state, idea, artifact)
         return self._result(
             normalized,
             corrections,
@@ -260,6 +267,7 @@ class AdvisorEngine:
         tool_events.append(event)
         response = self._plan_response(idea, score, plan)
         artifact = self._artifact(idea, score)
+        self._attach_artifact(state, idea, artifact)
         return self._result(normalized, corrections, response, state, tool_events, [], [], score, plan, artifact)
 
     def _compare_turn(
@@ -278,6 +286,8 @@ class AdvisorEngine:
             )
             return self._result(normalized, corrections, response, state, tool_events, [], [], None, [], {})
 
+        for idea, idea_score in ranked:
+            idea.artifact = self._artifact(idea, idea_score)
         ideas = [idea for idea, _score in ranked]
         state["ideas"] = [idea.to_dict() for idea in ideas]
         winner, score = ranked[0]
@@ -286,7 +296,8 @@ class AdvisorEngine:
         plan, event = self.tools.make_plan(winner, self._profile_context(state))
         tool_events.append(event)
         response = self._compare_response(ranked, plan)
-        artifact = self._artifact(winner, score)
+        artifact = winner.artifact or self._artifact(winner, score)
+        self._attach_artifact(state, winner, artifact)
         return self._result(normalized, corrections, response, state, tool_events, [], [], score, plan, artifact)
 
     def _project_turn(
@@ -329,6 +340,7 @@ class AdvisorEngine:
         tool_events.append(event)
         response = f"The wax seal reads {score.overall}/10, {score.verdict}, for {idea.title}."
         artifact = self._artifact(idea, score)
+        self._attach_artifact(state, idea, artifact)
         return self._result(normalized, corrections, response, state, tool_events, [], [], score, [], artifact)
 
     def _profile_turn(
@@ -360,7 +372,12 @@ class AdvisorEngine:
         idea = self._current_idea(state)
         if idea is not None:
             idea.goals = goals
+            idea.score = None
+            idea.artifact = None
             self._store_idea(state, idea)
+            last_artifact = state.get("last_artifact")
+            if isinstance(last_artifact, dict) and last_artifact.get("title") == idea.title:
+                del state["last_artifact"]
         tool_events.append(ToolEvent("set_goals", f"Set {len(goals)} goals."))
         labels = [goal_label(goal) for goal in goals]
         response = "The seal will now bias toward: " + (", ".join(labels) or "no specific goals")

hackathon_advisor/tools.py

@@ -89,6 +89,7 @@ class Idea:
     pitch: str
     goals: list[str] = field(default_factory=lambda: GOALS[:3])
     score: dict | None = None
+    artifact: dict[str, Any] | None = None
 
     def to_dict(self) -> dict:
         return {
@@ -97,6 +98,7 @@ class Idea:
             "pitch": self.pitch,
             "goals": self.goals,
             "score": self.score,
+            "artifact": self.artifact,
         }
 
 

static/app.js

@@ -712,8 +712,10 @@ function renderSelectedIdeaSeal(idea) {
 }
 
 function renderSelectedIdeaArtifact(idea) {
-  if (session.last_artifact?.title === idea.title) {
-    currentArtifact = session.last_artifact;
+  const artifact = idea.artifact || (session.last_artifact?.title === idea.title ? session.last_artifact : null);
+  if (artifact) {
+    currentArtifact = artifact;
+    session.last_artifact = artifact;
     renderWoodMap(currentArtifact.wood_map || null);
     exportButton.disabled = false;
     return;
@@ -934,6 +936,7 @@ function invalidateCurrentPlan(message) {
 
 function clearCurrentArtifactFor(idea) {
   if (!idea || currentArtifact?.title === idea.title) currentArtifact = null;
+  if (idea?.artifact) delete idea.artifact;
   if (!idea || session.last_artifact?.title === idea.title) delete session.last_artifact;
 }
 

tests/test_agent.py

@@ -33,6 +33,7 @@ def test_agent_scores_and_persists_idea() -> None:
     assert result.state["last_tool_resolution"]["call"]["name"] == "save_idea"
     assert result.state["trace"][0]["tool_resolution"]["call"]["name"] == "save_idea"
     assert result.state["last_artifact"]["title"] == result.artifact["title"]
+    assert result.state["ideas"][0]["artifact"]["title"] == result.artifact["title"]
     assert result.artifact["wood_map"]["caption"]
     assert {dot["kind"] for dot in result.artifact["wood_map"]["dots"]} >= {"idea", "echo", "inked"}
     assert result.score.to_dict()["echoes"][0]["page_number"] >= 1
@@ -133,6 +134,8 @@ def test_distinct_idea_turns_append_to_board() -> None:
     assert len(second.state["ideas"]) == 2
     assert second.state["ideas"][0]["title"] == first.artifact["title"]
     assert second.state["ideas"][1]["title"] == second.artifact["title"]
+    assert second.state["ideas"][0]["artifact"]["title"] == first.artifact["title"]
+    assert second.state["ideas"][1]["artifact"]["title"] == second.artifact["title"]
 
 
 def test_compare_ideas_reranks_board_and_selects_winner() -> None:
@@ -147,6 +150,7 @@ def test_compare_ideas_reranks_board_and_selects_winner() -> None:
     assert ranked.artifact["title"] == ranked.state["ideas"][0]["title"]
     assert ranked.state["current_idea_id"] == ranked.state["ideas"][0]["id"]
     assert ranked.state["ideas"][0]["score"]["overall"] >= ranked.state["ideas"][1]["score"]["overall"]
+    assert all(idea["artifact"]["title"] == idea["title"] for idea in ranked.state["ideas"])
     assert ranked.plan
     assert "Ranked pages:" in ranked.response
     assert ranked.tool_events[0].name == "compare_ideas"
@@ -193,6 +197,22 @@ def test_planner_profile_and_goals_update_state() -> None:
     assert "Local-first, Build notes" in targeted.response
 
 
+def test_goal_update_invalidates_current_idea_artifact() -> None:
+    index = ProjectIndex.from_files(Path("data/projects.json"), Path("data/project_index.json"))
+    first = AdvisorEngine(index).turn("A local-first archive cartographer for family photos", {})
+    target_engine = AdvisorEngine(
+        index,
+        planner=StaticPlanner(ToolCall("set_goals", {"goals": ["Field Notes"]})),
+    )
+
+    targeted = target_engine.turn("set goals", first.state)
+
+    idea = targeted.state["ideas"][0]
+    assert idea["score"] is None
+    assert idea["artifact"] is None
+    assert "last_artifact" not in targeted.state
+
+
 def test_session_goals_apply_to_new_and_current_ideas() -> None:
     index = ProjectIndex.from_files(Path("data/projects.json"), Path("data/project_index.json"))
     engine = AdvisorEngine(index)