File size: 8,160 Bytes
3959f31
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
//go:build linux

package agent

import (
	"os"
	"path/filepath"
	"testing"

	"github.com/henrygd/beszel/agent/utils"
	"github.com/henrygd/beszel/internal/entities/system"
	"github.com/stretchr/testify/assert"
	"github.com/stretchr/testify/require"
)

func TestNormalizeHexID(t *testing.T) {
	tests := []struct {
		in   string
		want string
	}{
		{"0x1002", "1002"},
		{"C2", "c2"},
		{"  15BF  ", "15bf"},
		{"0x15bf", "15bf"},
		{"", ""},
	}
	for _, tt := range tests {
		subName := tt.in
		if subName == "" {
			subName = "empty_string"
		}
		t.Run(subName, func(t *testing.T) {
			got := normalizeHexID(tt.in)
			assert.Equal(t, tt.want, got)
		})
	}
}

func TestCacheKeyForAmdgpu(t *testing.T) {
	tests := []struct {
		deviceID   string
		revisionID string
		want       string
	}{
		{"1114", "c2", "1114:c2"},
		{"15bf", "", "15bf"},
		{"1506", "c1", "1506:c1"},
	}
	for _, tt := range tests {
		got := cacheKeyForAmdgpu(tt.deviceID, tt.revisionID)
		assert.Equal(t, tt.want, got)
	}
}

func TestReadSysfsFloat(t *testing.T) {
	dir := t.TempDir()

	validPath := filepath.Join(dir, "val")
	require.NoError(t, os.WriteFile(validPath, []byte("  42.5  \n"), 0o644))
	got, err := readSysfsFloat(validPath)
	require.NoError(t, err)
	assert.Equal(t, 42.5, got)

	// Integer and scientific
	sciPath := filepath.Join(dir, "sci")
	require.NoError(t, os.WriteFile(sciPath, []byte("1e2"), 0o644))
	got, err = readSysfsFloat(sciPath)
	require.NoError(t, err)
	assert.Equal(t, 100.0, got)

	// Missing file
	_, err = readSysfsFloat(filepath.Join(dir, "missing"))
	require.Error(t, err)

	// Invalid content
	badPath := filepath.Join(dir, "bad")
	require.NoError(t, os.WriteFile(badPath, []byte("not a number"), 0o644))
	_, err = readSysfsFloat(badPath)
	require.Error(t, err)
}

func TestIsAmdGpu(t *testing.T) {
	dir := t.TempDir()
	deviceDir := filepath.Join(dir, "device")
	require.NoError(t, os.MkdirAll(deviceDir, 0o755))

	// AMD vendor 0x1002 -> true
	require.NoError(t, os.WriteFile(filepath.Join(deviceDir, "vendor"), []byte("0x1002\n"), 0o644))
	assert.True(t, isAmdGpu(dir), "vendor 0x1002 should be AMD")

	// Non-AMD vendor -> false
	require.NoError(t, os.WriteFile(filepath.Join(deviceDir, "vendor"), []byte("0x10de\n"), 0o644))
	assert.False(t, isAmdGpu(dir), "vendor 0x10de should not be AMD")

	// Missing vendor file -> false
	require.NoError(t, os.Remove(filepath.Join(deviceDir, "vendor")))
	assert.False(t, isAmdGpu(dir), "missing vendor file should be false")
}

func TestAmdgpuNameCacheRoundTrip(t *testing.T) {
	// Cache a name and retrieve it (unique key to avoid affecting other tests)
	deviceID, revisionID := "cachedev99", "00"
	cacheAmdgpuName(deviceID, revisionID, "AMD Test GPU 99 Graphics", true)

	name, found, done := getCachedAmdgpuName(deviceID, revisionID)
	assert.True(t, found)
	assert.True(t, done)
	assert.Equal(t, "AMD Test GPU 99", name)

	// Device-only key also stored
	name2, found2, _ := getCachedAmdgpuName(deviceID, "")
	assert.True(t, found2)
	assert.Equal(t, "AMD Test GPU 99", name2)

	// Cache a miss
	cacheMissingAmdgpuName("missedev99", "ab")
	_, found3, done3 := getCachedAmdgpuName("missedev99", "ab")
	assert.False(t, found3)
	assert.True(t, done3, "done should be true so caller skips file lookup")
}

func TestUpdateAmdGpuDataWithFakeSysfs(t *testing.T) {
	tests := []struct {
		name            string
		writeGTT        bool
		wantMemoryUsed  float64
		wantMemoryTotal float64
	}{
		{
			name:            "sums vram and gtt when gtt is present",
			writeGTT:        true,
			wantMemoryUsed:  utils.BytesToMegabytes(1073741824 + 536870912),
			wantMemoryTotal: utils.BytesToMegabytes(2147483648 + 4294967296),
		},
		{
			name:            "falls back to vram when gtt is missing",
			writeGTT:        false,
			wantMemoryUsed:  utils.BytesToMegabytes(1073741824),
			wantMemoryTotal: utils.BytesToMegabytes(2147483648),
		},
	}

	for _, tt := range tests {
		t.Run(tt.name, func(t *testing.T) {
			dir := t.TempDir()
			cardPath := filepath.Join(dir, "card0")
			devicePath := filepath.Join(cardPath, "device")
			hwmonPath := filepath.Join(devicePath, "hwmon", "hwmon0")
			require.NoError(t, os.MkdirAll(hwmonPath, 0o755))

			write := func(name, content string) {
				require.NoError(t, os.WriteFile(filepath.Join(devicePath, name), []byte(content), 0o644))
			}
			write("vendor", "0x1002")
			write("device", "0x1506")
			write("revision", "0xc1")
			write("gpu_busy_percent", "25")
			write("mem_info_vram_used", "1073741824")
			write("mem_info_vram_total", "2147483648")
			if tt.writeGTT {
				write("mem_info_gtt_used", "536870912")
				write("mem_info_gtt_total", "4294967296")
			}
			require.NoError(t, os.WriteFile(filepath.Join(hwmonPath, "temp1_input"), []byte("45000"), 0o644))
			require.NoError(t, os.WriteFile(filepath.Join(hwmonPath, "power1_input"), []byte("20000000"), 0o644))

			// Pre-cache name so getAmdGpuName returns a known value (it uses system amdgpu.ids path)
			cacheAmdgpuName("1506", "c1", "AMD Radeon 610M Graphics", true)

			gm := &GPUManager{GpuDataMap: make(map[string]*system.GPUData)}
			ok := gm.updateAmdGpuData(cardPath)
			require.True(t, ok)

			gpu, ok := gm.GpuDataMap["card0"]
			require.True(t, ok)
			assert.Equal(t, "AMD Radeon 610M", gpu.Name)
			assert.Equal(t, 25.0, gpu.Usage)
			assert.Equal(t, tt.wantMemoryUsed, gpu.MemoryUsed)
			assert.Equal(t, tt.wantMemoryTotal, gpu.MemoryTotal)
			assert.Equal(t, 45.0, gpu.Temperature)
			assert.Equal(t, 20.0, gpu.Power)
			assert.Equal(t, 1.0, gpu.Count)
		})
	}
}

func TestLookupAmdgpuNameInFile(t *testing.T) {
	idsPath := filepath.Join("test-data", "amdgpu.ids")

	tests := []struct {
		name       string
		deviceID   string
		revisionID string
		wantName   string
		wantExact  bool
		wantFound  bool
	}{
		{
			name:       "exact device and revision match",
			deviceID:   "1114",
			revisionID: "c2",
			wantName:   "AMD Radeon 860M Graphics",
			wantExact:  true,
			wantFound:  true,
		},
		{
			name:       "exact match 15BF revision 01 returns 760M",
			deviceID:   "15bf",
			revisionID: "01",
			wantName:   "AMD Radeon 760M Graphics",
			wantExact:  true,
			wantFound:  true,
		},
		{
			name:       "exact match 15BF revision 00 returns 780M",
			deviceID:   "15bf",
			revisionID: "00",
			wantName:   "AMD Radeon 780M Graphics",
			wantExact:  true,
			wantFound:  true,
		},
		{
			name:       "device-only match returns first entry for device",
			deviceID:   "1506",
			revisionID: "",
			wantName:   "AMD Radeon 610M",
			wantExact:  false,
			wantFound:  true,
		},
		{
			name:       "unknown device not found",
			deviceID:   "dead",
			revisionID: "00",
			wantName:   "",
			wantExact:  false,
			wantFound:  false,
		},
	}
	for _, tt := range tests {
		t.Run(tt.name, func(t *testing.T) {
			gotName, gotExact, gotFound := lookupAmdgpuNameInFile(tt.deviceID, tt.revisionID, idsPath)
			assert.Equal(t, tt.wantName, gotName, "name")
			assert.Equal(t, tt.wantExact, gotExact, "exact")
			assert.Equal(t, tt.wantFound, gotFound, "found")
		})
	}
}

func TestGetAmdGpuNameFromIdsFile(t *testing.T) {
	// Test that getAmdGpuName resolves a name when we can't inject the ids path.
	// We only verify behavior when product_name is missing and device/revision
	// would be read from sysfs; the actual lookup uses /usr/share/libdrm/amdgpu.ids.
	// So this test focuses on normalizeAmdgpuName and that lookupAmdgpuNameInFile
	// returns the expected name for our test-data file.
	idsPath := filepath.Join("test-data", "amdgpu.ids")
	name, exact, found := lookupAmdgpuNameInFile("1435", "ae", idsPath)
	require.True(t, found)
	require.True(t, exact)
	assert.Equal(t, "AMD Custom GPU 0932", name)
	assert.Equal(t, "AMD Custom GPU 0932", normalizeAmdgpuName(name))

	// " Graphics" suffix is trimmed by normalizeAmdgpuName
	name2 := "AMD Radeon 860M Graphics"
	assert.Equal(t, "AMD Radeon 860M", normalizeAmdgpuName(name2))
}