environment bug

app/golf_swing_rag.py

@@ -208,22 +208,33 @@ class GolfSwingRAG:
         self.metadata = []
         self.openai_client = None
         
-        # Initialize OpenAI client using Streamlit secrets
+        # Initialize OpenAI client - prioritize environment variables for Hugging Face deployment
         print("Initializing OpenAI client...")
         openai_key = None
         
         # Try multiple methods to get the OpenAI API key
+        # Method 1: Environment variable (primary for HF Spaces)
         try:
-            # Method 1: Direct access to OPENAI_API_KEY secret (most common for HF Spaces)
-            openai_key = st.secrets.get("OPENAI_API_KEY", "")
+            openai_key = os.getenv("OPENAI_API_KEY", "")
             if openai_key:
-                print("✓ Found OpenAI key in st.secrets['OPENAI_API_KEY']")
+                print("✓ Found OpenAI key in environment variable OPENAI_API_KEY")
             else:
-                print("No key found in st.secrets['OPENAI_API_KEY']")
+                print("No key found in environment variable OPENAI_API_KEY")
         except Exception as e:
-            print(f"Error accessing st.secrets['OPENAI_API_KEY']: {e}")
+            print(f"Error accessing environment variable OPENAI_API_KEY: {e}")
+        
+        # Method 2: Direct access to OPENAI_API_KEY secret (fallback for Streamlit)
+        if not openai_key:
+            try:
+                openai_key = st.secrets.get("OPENAI_API_KEY", "")
+                if openai_key:
+                    print("✓ Found OpenAI key in st.secrets['OPENAI_API_KEY']")
+                else:
+                    print("No key found in st.secrets['OPENAI_API_KEY']")
+            except Exception as e:
+                print(f"Error accessing st.secrets['OPENAI_API_KEY']: {e}")
         
-        # Method 2: Try nested openai structure (fallback)
+        # Method 3: Try nested openai structure (fallback)
         if not openai_key:
             try:
                 openai_key = st.secrets.get("openai", {}).get("api_key", "")
@@ -234,14 +245,6 @@ class GolfSwingRAG:
             except Exception as e:
                 print(f"Error accessing nested openai secrets: {e}")
         
-        # Method 3: Environment variable fallback
-        if not openai_key:
-            openai_key = os.getenv("OPENAI_API_KEY", "")
-            if openai_key:
-                print("✓ Found OpenAI key in environment variable OPENAI_API_KEY")
-            else:
-                print("No key found in environment variable OPENAI_API_KEY")
-        
         # Initialize client if we found a key
         if openai_key and openai_key.startswith("sk-"):
             try:

app/models/llm_analyzer.py

@@ -8,6 +8,7 @@ from openai import OpenAI
 import streamlit as st
 import re
 import numpy as np
+import os
 from .pose_estimator import calculate_joint_angles
 
 
@@ -29,26 +30,26 @@ def check_llm_services():
         }
     }
 
-    # Check Ollama configuration
+    # Check Ollama configuration - read from environment variables
     try:
-        ollama_url = st.secrets.get("ollama", {}).get("base_url", "")
-        ollama_model = st.secrets.get("ollama", {}).get("model", "")
+        ollama_url = os.environ.get("OLLAMA_BASE_URL", "")
+        ollama_model = os.environ.get("OLLAMA_MODEL", "")
         if ollama_url and ollama_model:
             services['ollama']['available'] = True
             services['ollama']['config'] = {
                 'base_url': ollama_url,
                 'model': ollama_model
             }
-    except (KeyError, FileNotFoundError, AttributeError):
+    except (KeyError, AttributeError):
         pass
 
-    # Check OpenAI configuration
+    # Check OpenAI configuration - read from environment variables
     try:
-        openai_key = st.secrets.get("openai", {}).get("api_key", "")
+        openai_key = os.environ.get("OPENAI_API_KEY", "")
         if openai_key:
             services['openai']['available'] = True
             services['openai']['config'] = {'api_key': openai_key}
-    except (KeyError, FileNotFoundError, AttributeError):
+    except (KeyError, AttributeError):
         pass
 
     return services