fix RAG system issues

Signed-off-by: Emily Chen <emilyaychen@gmail.com>

app/models/llm_analyzer.py

@@ -660,15 +660,8 @@ def parse_and_format_analysis(raw_analysis):
         cleaned_strengths = []
         for topic, desc in strength_items:
             topic_clean = topic.strip()
-            # Take first full sentence from desc
-            desc_text = desc.strip().replace('\n', ' ')
-            # Ensure we end at the first period or em dash break
-            sentence_match = re.match(r'(.+?\.)', desc_text)
-            if sentence_match:
-                desc_clean = sentence_match.group(1).strip()
-            else:
-                # Fallback: up to 180 chars
-                desc_clean = desc_text[:180].strip()
+            # Clean and preserve the full description
+            desc_clean = desc.strip().replace('\n', ' ')
             if topic_clean and desc_clean:
                 cleaned_strengths.append(f"{topic_clean}: {desc_clean}")
         # Ensure exactly three strengths

app/streamlit_app.py

@@ -373,21 +373,12 @@ def generate_enhanced_response(rag_system, query, context_chunks, user_swing_con
 
 You are a golf swing technique expert assistant analyzing this specific player's swing. 
 
-IMPORTANT: Only reference the player's swing analysis data above if the question is directly related to swing motion biomechanics (like hip rotation, shoulder turn, weight transfer, timing, etc.). 
-
-Do NOT reference swing analysis for questions about:
-- Grip (how to hold the club)
-- Setup/stance (static positioning before the swing)
-- Equipment (clubs, balls, etc.)
-- Course management
-- Mental game
-- Basic fundamentals that aren't measured during swing motion
-
-Follow this response structure:
-
-1. Synthesize information from the reference materials below to answer the user's question. Keep this to 2-4 sentences maximum. Start with "Based on [source name]," and provide clear, actionable advice about the technique.
-
-2. If the question relates to swing motion biomechanics AND you found relevant measurements in the analysis above, provide specific improvement advice comparing current state to recommendations. Otherwise, provide general advice without forcing connections to unrelated swing metrics.
+INSTRUCTIONS:
+1. Always answer golf technique questions using the reference materials below
+2. For swing motion biomechanics questions (head movement, hip rotation, weight transfer, etc.), also reference specific measurements from the player's swing analysis above when relevant
+3. For setup/stance questions, answer from the reference materials without needing to reference swing motion data
+4. Provide clear, actionable advice based on proven golf instruction
+5. IMPORTANT: Keep responses to 4 sentences or less - be concise and focused
 
 Reference Materials from Golf Instruction Database:
 {knowledge_context}"""
@@ -396,10 +387,7 @@ Reference Materials from Golf Instruction Database:
 
 {query}
 
-Remember to:
-1. Only reference my swing analysis if the question is about swing motion biomechanics
-2. Synthesize expert advice concisely (2-4 sentences max)
-3. Don't force connections between unrelated topics (e.g., don't mention wrist hinge when asking about grip)"""
+Please provide a helpful, concise response (4 sentences or less) that addresses the specific question while drawing from the relevant information in the context. If the question relates to swing motion biomechanics and you have specific measurements from my swing analysis above, include those details for personalized advice."""
 
     else:
         # Fallback to general system prompt if no swing analysis available
@@ -411,7 +399,7 @@ Instructions:
 - Reference relevant technical concepts when appropriate
 - Be encouraging and supportive
 - Synthesize information from multiple sources rather than just quoting them
-- Give clear, comprehensive explanations that golfers can understand and apply
+- IMPORTANT: Keep responses to 4 sentences or less - be concise and focused
 
 Reference Materials from Golf Instruction Database:
 {knowledge_context}"""
@@ -420,7 +408,7 @@ Reference Materials from Golf Instruction Database:
 
 {query}
 
-Please provide a helpful, detailed response that synthesizes the relevant information into clear, actionable guidance."""
+Please provide a helpful, concise response (4 sentences or less) that synthesizes the relevant information into clear, actionable guidance."""
 
     print(f"System prompt: {system_prompt}")
     print(f"User prompt: {user_prompt}")
@@ -431,7 +419,7 @@ Please provide a helpful, detailed response that synthesizes the relevant inform
                 {"role": "system", "content": system_prompt},
                 {"role": "user", "content": user_prompt}
             ],
-            max_tokens=800,
+            max_tokens=400,
             temperature=0.7
         )
         return response.choices[0].message.content
@@ -485,6 +473,21 @@ def generate_enhanced_fallback_response(query, context_chunks, user_swing_contex
                         found_relevant_measurement = True
                         break
                         
+        elif "head" in question_lower and ("movement" in question_lower or "moving" in question_lower or "steady" in question_lower):
+            # Look for head movement measurements (only if asking about head movement)
+            lines = analysis_content.split('\n')
+            for line in lines:
+                if 'head movement' in line.lower() and ('in' in line or 'inches' in line):
+                    import re
+                    lateral_match = re.search(r'head movement \(lateral\)[:\s]*(\d+\.?\d*)\s*in', line.lower())
+                    vertical_match = re.search(r'head movement \(vertical\)[:\s]*(\d+\.?\d*)\s*in', line.lower())
+                    if lateral_match or vertical_match:
+                        lateral_val = lateral_match.group(1) if lateral_match else "N/A"
+                        vertical_val = vertical_match.group(1) if vertical_match else "N/A"
+                        response_parts.append(f"I notice that your head movement is {lateral_val} inches laterally and {vertical_val} inches vertically during your swing.")
+                        found_relevant_measurement = True
+                        break
+                        
         elif "hip" in question_lower and ("rotation" in question_lower or "turn" in question_lower):
             # Look for hip rotation measurements (only if asking about hip rotation/turn)
             lines = analysis_content.split('\n')
@@ -521,9 +524,9 @@ def generate_enhanced_fallback_response(query, context_chunks, user_swing_contex
                         found_relevant_measurement = True
                         break
     
-    # Part 2: Expert recommendation (synthesized from source)
+    # Part 2: Expert recommendation (synthesized from source - keep concise)
     sentences = chunk_content.split('. ')
-    meaningful_sentences = [s.strip() for s in sentences if len(s.strip()) > 20][:3]
+    meaningful_sentences = [s.strip() for s in sentences if len(s.strip()) > 20][:2]
     expert_advice = '. '.join(meaningful_sentences[:2]) + '.'
     
     response_parts.append(f"Based on {source_title}, {expert_advice}")
@@ -531,17 +534,13 @@ def generate_enhanced_fallback_response(query, context_chunks, user_swing_contex
     # Part 3: Improvement recommendation (only connect to swing analysis if relevant)
     if user_swing_context and found_relevant_measurement and not is_non_biomechanics:
         # Only provide swing-analysis-specific advice if we found relevant measurements
-        analysis_content = user_swing_context.replace("USER'S SWING ANALYSIS:\n", "").strip()
-        response_parts.append("Based on your current measurements compared to professional standards, focus on implementing the expert advice above to address your specific swing characteristics.")
+        response_parts.append("Focus on implementing this expert advice to address your specific swing characteristics.")
     else:
         # For non-biomechanics questions or when no relevant measurements found
-        response_parts.append("Focus on implementing this expert advice to improve your technique.")
-    
-    # Combine all parts
-    final_response = "\n\n".join(response_parts)
+        response_parts.append("Focus on implementing this expert advice.")
     
-    # Add source reference
-    final_response += f"\n\n📚 **Source**: {source_title}"
+    # Combine all parts with space separation to keep it concise
+    final_response = " ".join(response_parts)
     
     return final_response