Rename functions for clarity, consolidate format_stats

_check_and_increment → _is_daily_question_allowed
_remaining → _daily_questions_remaining
_count_todays_traces → _count_traces_uploaded_today
Merge format_stats and format_stats_from_trace into one
function that handles both object and dict inputs.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

app.py

@@ -63,8 +63,8 @@ BASE_PROMPT = (
 # Global daily counter (initialized from trace repo on startup)
 # ---------------------------------------------------------------------------
 
-def _count_todays_traces() -> int:
-    """Count trace files uploaded today (UTC) from the HF dataset repo."""
+def _count_traces_uploaded_today() -> int:
+    """Initialize the daily counter from trace files already uploaded today."""
     if not hf_api or not HF_TRACES_REPO:
         return 0
     today_prefix = datetime.now(timezone.utc).strftime("%Y%m%d")
@@ -76,12 +76,12 @@ def _count_todays_traces() -> int:
         return 0
 
 
-_daily_count = _count_todays_traces()
+_daily_count = _count_traces_uploaded_today()
 _daily_date = date.today()
 
 
-def _check_and_increment() -> bool:
-    """Return True if a question is allowed, incrementing the counter."""
+def _is_daily_question_allowed() -> bool:
+    """Check whether the daily question limit has been reached, and if not, count this question."""
     global _daily_count, _daily_date
     today = date.today()
     if today != _daily_date:
@@ -99,7 +99,7 @@ def _reset_counter():
     _daily_date = date.today()
 
 
-def _remaining() -> int:
+def _daily_questions_daily_questions_remaining() -> int:
     global _daily_count, _daily_date
     today = date.today()
     if today != _daily_date:
@@ -176,31 +176,27 @@ def upload_trace(result: dict) -> None:
 # ---------------------------------------------------------------------------
 
 
-def format_stats(trace: object) -> str:
-    cached = trace.cached_tokens
-    cache_str = f" ({cached} cached)" if cached else ""
-    model_name = trace.model.split("/")[-1] if trace.model else ""
-    parts = [
-        f"*{model_name}",
-        f"{trace.prompt_tokens + trace.completion_tokens:,} tokens{cache_str}",
-        f"{len(trace.tool_calls)} tool calls",
-        f"{trace.wall_time_s:.1f}s",
-    ]
-    if trace.cost:
-        parts.append(f"${trace.cost:.4f}")
-    return " · ".join(parts) + "*"
-
+def format_stats(trace) -> str:
+    """Format trace stats for display. Accepts a Trace object or dict."""
+    if isinstance(trace, dict):
+        cached = trace.get("cached_tokens", 0)
+        model = trace.get("model", "")
+        prompt = trace.get("prompt_tokens", 0)
+        completion = trace.get("completion_tokens", 0)
+        tool_calls = trace.get("tool_calls", [])
+        wall = trace.get("wall_time_s", 0)
+        cost = trace.get("cost")
+    else:
+        cached = trace.cached_tokens
+        model = trace.model
+        prompt = trace.prompt_tokens
+        completion = trace.completion_tokens
+        tool_calls = trace.tool_calls
+        wall = trace.wall_time_s
+        cost = trace.cost
 
-def format_stats_from_trace(trace: dict) -> str:
-    cached = trace.get("cached_tokens", 0)
     cache_str = f" ({cached} cached)" if cached else ""
-    model = trace.get("model", "")
     model_name = model.split("/")[-1] if model else ""
-    prompt = trace.get("prompt_tokens", 0)
-    completion = trace.get("completion_tokens", 0)
-    tool_calls = trace.get("tool_calls", [])
-    wall = trace.get("wall_time_s", 0)
-    cost = trace.get("cost")
     parts = [
         model_name,
         f"{prompt + completion:,} tokens{cache_str}",
@@ -220,7 +216,7 @@ def format_stats_from_trace(trace: dict) -> str:
 def chat(message: str, scratch_path: str, session_cost: float):
     empty = ("", "", scratch_path, session_cost)
 
-    if not _check_and_increment():
+    if not _is_daily_question_allowed():
         yield (
             "The daily question limit has been reached. "
             "Check back tomorrow, or try it with your own documents on the "
@@ -308,8 +304,8 @@ def chat(message: str, scratch_path: str, session_cost: float):
     upload_trace(result)
     trace_html = render_trace(result, max_chars=2000)
 
-    remaining = _remaining()
-    remaining_msg = f"\n\n---\n{stats}\n\n*{remaining} question{'s' if remaining != 1 else ''} remaining today*"
+    remaining = _daily_questions_remaining()
+    remaining_msg = f"\n\n---\n*{stats}*\n\n*{remaining} question{'s' if remaining != 1 else ''} remaining today*"
 
     yield (
         f"{clean_answer}{remaining_msg}",
@@ -609,7 +605,7 @@ def build_app() -> gr.Blocks:
                     "question": data.get("question", ""),
                     "answer": clean_answer,
                     "sources": sources,
-                    "stats": format_stats_from_trace(trace),
+                    "stats": format_stats(trace),
                     "source_tag": data.get("source", ""),
                     "trace_html": trace_html,
                     "filename": safe_name,
@@ -625,7 +621,7 @@ def build_app() -> gr.Blocks:
 
 def stream_question(question: str) -> Generator[str, None, None]:
     """Streaming API — yields JSON event strings for the custom chat UI."""
-    if not _check_and_increment():
+    if not _is_daily_question_allowed():
         yield json.dumps({"type": "error", "error": "daily_limit", "remaining": 0})
         return
 
@@ -687,7 +683,7 @@ def stream_question(question: str) -> Generator[str, None, None]:
         "sources": sources,
         "stats": format_stats(trace),
         "trace_html": trace_html,
-        "remaining": _remaining(),
+        "remaining": _daily_questions_remaining(),
     })