edge_kind,source_item_type,source_number,target_item_type,target_number,confidence,evidence_source,evidence_excerpt,evidence_url,evidence_hash
references,issue,13419,pr,13398,medium,issue.body,Fix is to tokenise the inter-keyword whitespace with disjoint classes so a space only ever belongs to a separator and never to a token. PR #13398.,https://github.com/sqlalchemy/sqlalchemy/issues/13419,5438506bfae6788939d085b934c6a38ec5025f49ae5697eb445b93df01cfeb88
references,issue,13357,issue,6810,medium,issue.body,chemy-stubs` and `sqlalchemy2-stubs` are not compatible with v2) ### Verify if the api is typed - [x] The api is not in a module listed in [#6810](https://github.com/sqlalchemy/sqlalchemy/issues/6810) so it should pass type checking ### Describe the typing issue the runtime SQ...,https://github.com/sqlalchemy/sqlalchemy/issues/13357,b6af024d295fe4523765892156245d9e94053d262e6a89b5b817c4c80c6554f3
references,issue,13227,issue,12168,medium,issue.body,dation introduced in commit [95ad9fe](https://github.com/sqlalchemy/sqlalchemy/commit/95ad9fe42b888d7cdea60b7a71c833cbb8667887) (related to #12168) breaks `WriteOnlyMapped` relationships that use `default_factory=list` in Declarative Dataclass Mapping. ### Optional link from h...,https://github.com/sqlalchemy/sqlalchemy/issues/13227,416800bfd2ad52b0df2743f058ec1540841d1782647bd5e54b0c83bc655057ea
references,issue,13212,issue,4384,medium,issue.comments[5].body,it's #4384,https://github.com/sqlalchemy/sqlalchemy/issues/13212,608257f83fcd4eb21d244e469a1756dd4afae38a6b9ea9deea208d149aea9439
competes with,issue,13210,issue,13193,medium,issue.body,"namespace."") > print("" Use ap.meta (base-class direct) instead of ap.Dog.meta."") > print(""="" * 70) > ``` _Originally posted by @CaselIT in [#13193](https://github.com/sqlalchemy/sqlalchemy/issues/13193#issuecomment-4145377493)_",https://github.com/sqlalchemy/sqlalchemy/issues/13210,f126815a8d44ecba56ca77044d109a535870c3c84161fe740f6fefc7e1d40413
references,issue,13204,issue,13193,medium,issue.body,There are a couple of cases where immediateload fails when using inheritance on relationships: - loading using immediateload a relationship on an inheritance chain that's being loaded via eager loading: `select(Meta).option(anyloader(Meta.parent_cls).immediateload(ParentCls.re...,https://github.com/sqlalchemy/sqlalchemy/issues/13204,d6af10a01c4ee0b2ddd96c96d6dd926659a632a831f4840c75ab65e66fc64d2e
references,issue,13204,issue,13202,medium,issue.body,There are a couple of cases where immediateload fails when using inheritance on relationships: - loading using immediateload a relationship on an inheritance chain that's being loaded via eager loading: `select(Meta).option(anyloader(Meta.parent_cls).immediateload(ParentCls.re...,https://github.com/sqlalchemy/sqlalchemy/issues/13204,d9a355cb09796333911efbbd7d89389df5d8d79dff5a19b2f0e677a81c853616
references,issue,13157,pr,13188,medium,issue.comments[8].body,Fix submitted in #13188.,https://github.com/sqlalchemy/sqlalchemy/issues/13157,ada55c738bd7c92e605adf592e0af4304c58d91d245fa81b6e2c9bcf41c43c32
references,issue,13007,issue,13006,medium,issue.body,Follow up of #13006 Set to False the default value and remove the warning,https://github.com/sqlalchemy/sqlalchemy/issues/13007,08a3a0f3008e5ad03d320153a4b167d40723e7db07a096ac2f297b805e5dc279
references,issue,12398,issue,10668,medium,issue.body,### Describe the use case I just received the following error of in my project and have an improvement request similar to #10668 : ``` sqlalchemy.exc.InvalidRequestError: Loader strategies for ORM Path[Mapper[Cable(cable)] -> Cable.cablesides -> Mapper[CadCableSide(ca,https://github.com/sqlalchemy/sqlalchemy/issues/12398,07ceea06d0f1bb244249ac24902ba1dd7392e1e6bc595e75652f640133c4aefd
references,issue,12101,issue,5583,medium,issue.body,### Describe the use case The [Postgres docs](https://www.postgresql.org/docs/17/sql-select.html) specifically say that you should be able to have both a FOR UPDATE and a FOR SHARE in the same query: > Multiple locking clauses can be written if it is necessary to specify diffe...,https://github.com/sqlalchemy/sqlalchemy/issues/12101,bf6e8cce81a4e4ad031c254f2be259769d213b550fd5865ff2541cf9300ffea9
references,issue,12101,issue,5583,medium,issue.comments[0].body,"eems like contains_eager() + join() is more appropriate here. 3. you're asking something about the very open ended warnings/error ticket in #5583 , I guess saying that the warning we have about FOR UPDATE doesnt apply to joinedload() if one is using ""of"". I'm not really sure i...",https://github.com/sqlalchemy/sqlalchemy/issues/12101,17c075eae174372b9d516a0535f376d64013cfe63319a93676e646945ce4e8d2
references,issue,12097,issue,6515,medium,issue.body,### Describe the bug I can't use an enum type as part of a `case()` without casting. Looks very similar to https://github.com/sqlalchemy/sqlalchemy/issues/6515 ### Optional link from https://docs.sqlalchemy.org which documents the behavior that is expected _No response_ ### SQ...,https://github.com/sqlalchemy/sqlalchemy/issues/12097,d6e79d43b2f87411acce577b2cf3ca68a1757872a452446adf58cfc92d854ce0
references,issue,11686,issue,6810,medium,issue.body,chemy-stubs` and `sqlalchemy2-stubs` are not compatible with v2) ### Verify if the api is typed - [X] The api is not in a module listed in [#6810](https://github.com/sqlalchemy/sqlalchemy/issues/6810) so it should pass type checking ### Describe the typing issue An unexpected...,https://github.com/sqlalchemy/sqlalchemy/issues/11686,9cc73297c82d8d32cb900e1a3d8d7f70ccf7e50efab470ce5bbc458ff2ebcccf
references,issue,11677,pr,11678,medium,issue.comments[1].body,I openend a PR to fix this issue https://github.com/sqlalchemy/sqlalchemy/pull/11678,https://github.com/sqlalchemy/sqlalchemy/issues/11677,9e0b49d5448c315c6fd4d9122fa60aca6f1eca0749a1376d93a29f067cdfa3b6
references,issue,11620,pr,12297,medium,issue.comments[6].body,"I've posted an alternative strategy that I'd like to use, detailed on the gerrit and also on the PR at https://github.com/sqlalchemy/sqlalchemy/pull/12297#issuecomment-2733436569",https://github.com/sqlalchemy/sqlalchemy/issues/11620,d33380533bafdb0eafe088320cf5a1205e00dd6082ea55c4ed4db7d3487562b8
references,issue,10936,issue,1063,medium,issue.comments[0].body,"I thought this was related to #1063 but i dont think it is, unfortunately, meaning we have *two* post_update quagmire kinds of issues.",https://github.com/sqlalchemy/sqlalchemy/issues/10936,ff2f157a0104101412fa05baf83be57e5c834ee97522d8588382577d696d898b
references,issue,10888,issue,6810,medium,issue.comments[1].body,checked it off from this list https://github.com/sqlalchemy/sqlalchemy/issues/6810,https://github.com/sqlalchemy/sqlalchemy/issues/10888,3eccacb1573ec32ea9f2b62aa24ea620fa5a223de2497afa639acd5f9210c46e
references,issue,10859,issue,4641,medium,issue.body,"this can come in alongside #4641 this would make a change to `relationship` such that it does not set up `strategy_key` until mapper config stage, where it gets a look at i",https://github.com/sqlalchemy/sqlalchemy/issues/10859,4fa3c8f29c672e31a3f31e7da50b97ba1b44a32567b8767fa09bf25914eea3ee
references,issue,10675,issue,8626,medium,issue.comments[0].body,ted SQL is valid; migrating the from_select case off the deprecated form (e.g. via the documented derived-table alias) seems to belong with #8626. Perhaps this one can be closed as fixed?,https://github.com/sqlalchemy/sqlalchemy/issues/10675,442258191ff3c9cb059d2017041605161b946d2176fc45574c0afd12bb3c0d19
references,issue,10544,pr,10545,medium,issue.comments[0].body,try this pr to fix https://github.com/sqlalchemy/sqlalchemy/pull/10545,https://github.com/sqlalchemy/sqlalchemy/issues/10544,3e9735aae1d10aeed55e137904c1f9bd9525d9e78dc227534f6432febada58b5
references,issue,10527,issue,6810,medium,issue.body,chemy-stubs` and `sqlalchemy2-stubs` are not compatible with v2) ### Verify if the api is typed - [X] The api is not in a module listed in [#6810](https://github.com/sqlalchemy/sqlalchemy/issues/6810) so it should pass type checking ### Describe the typing issue Seems that `wi...,https://github.com/sqlalchemy/sqlalchemy/issues/10527,ca892f55a8ea3033aaff2fe75b100d85688e7c668c5fd04a3159ca754a8d06f6
references,issue,10351,issue,6810,medium,issue.body,chemy-stubs` and `sqlalchemy2-stubs` are not compatible with v2) ### Verify if the api is typed - [X] The api is not in a module listed in [#6810](https://github.com/sqlalchemy/sqlalchemy/issues/6810) so it should pass type checking ### Describe the typing issue Return type `c...,https://github.com/sqlalchemy/sqlalchemy/issues/10351,febd269ba982be5754112533d6f642aad4040a0d39bc266a4eaedb789fde186f
references,issue,10351,issue,6120,medium,issue.comments[7].body,"> though column_property() does not accept calalbles or lambdas, so still need to reduce that there was an issue for it in https://github.com/sqlalchemy/sqlalchemy/issues/6120",https://github.com/sqlalchemy/sqlalchemy/issues/10351,092642d30898c4a51a388cee4788856af8f73304d2191976f09152e65992762b
references,issue,10094,issue,5811,medium,issue.comments[0].body,"I've been missing a documentation regarding testing with async, I eventually got it to what I wanted but I don't entirely understand how it works. I've read through [this discussion](https://github.com/sqlalchemy/sqlalchemy/issues/5811) and arrived at this slightly shorter ver...",https://github.com/sqlalchemy/sqlalchemy/issues/10094,17c764e9c78ef099a9c681fa259465b3d34089012642f5fcdc4aa0e112e4157b
references,issue,9839,issue,9603,medium,issue.body,### Describe the bug We upgraded our sql alchemy version and observed a massive spike in execution time on the database. We are bulk uploading several 100k rows. We are using sql server on azure and pyodbc. We believe it relates to changes made in https://github.com/sqlalchemy...,https://github.com/sqlalchemy/sqlalchemy/issues/9839,7e31b5a59b11bf53917b4a3bd010250dd36a2bc7ed020bcc169c90145e20b042
references,issue,9839,issue,9618,medium,issue.body,### Describe the bug We upgraded our sql alchemy version and observed a massive spike in execution time on the database. We are bulk uploading several 100k rows. We are using sql server on azure and pyodbc. We believe it relates to changes made in https://github.com/sqlalchemy...,https://github.com/sqlalchemy/sqlalchemy/issues/9839,0043375355e3832918f3256ccc3f7ac1ce10f88aad9b3bd511a5c6d0d1cddc57
references,issue,9839,issue,9603,medium,issue.comments[0].body,he database. We are bulk uploading several 100k rows. We are using sql server on azure and pyodbc. We believe it relates to changes made in #9603 <https://github.com/sqlalchemy/sqlalchemy/issues/9603> or #9618 <https://github.com/sqlalchemy/sqlalchemy/issues/9618> which were i...,https://github.com/sqlalchemy/sqlalchemy/issues/9839,966c7562f852a532fe7460aada50914eb4b1d12d1179c5f6a0bdc52467c759ba
references,issue,9839,issue,9618,medium,issue.comments[0].body,"ng sql server on azure and pyodbc. We believe it relates to changes made in #9603 <https://github.com/sqlalchemy/sqlalchemy/issues/9603> or #9618 <https://github.com/sqlalchemy/sqlalchemy/issues/9618> which were implemented in 2.0.10. We are no using the ORM, but execute direc...",https://github.com/sqlalchemy/sqlalchemy/issues/9839,8d3ad4d82c8c18fb087fda45f75cd2e3b5e480988fd71c2be1dc816ee39639ff
references,issue,9839,issue,9586,medium,issue.comments[4].body,"faster than plain executemany, but still order of magnitude worse than fast executemany** performance. We can see this using the test from #9586, using the dataset at https://github.com/sqlalchemy/sqlalchemy/files/11130278/test_data.zip and the script below, which I've improve...",https://github.com/sqlalchemy/sqlalchemy/issues/9839,630196046d1345f502f6005002a1dc7811442b102d5f4780a49be0abd6a40870
references,issue,9839,issue,9603,medium,issue.comments[4].body,"0 rows in 0.1 seconds (17273.9 rows/s). SQLA: 2.0.15; imv=False; fast_em=True: Finished in 2.4 seconds. ``` When using 2.0.9 exactly, issue #9603 was released which **universally disabled insertmanyvalues** for SQL Server. Based on everything we know, **this means default perf...",https://github.com/sqlalchemy/sqlalchemy/issues/9839,0fdf498e3d52c13988631ff4b24aa75f92e382bd4b8f8ab9899de07cfbde2fdf
references,issue,9839,issue,9603,medium,issue.comments[8].body,"nsertmanyvalues"" completely in version 2.0.9 of SQL Server alone. it was turned on in 2.0.8 as well as 2.0.10. the 2.0.9 shutoff was due to #9603. im not really sure how if cloud DBs have expensive round trips that plain executemany() is better, there must be some driver level...",https://github.com/sqlalchemy/sqlalchemy/issues/9839,528fb380c65653a55798c0e7739b755d4df88a583e62926e3107f9ee1fd72fb0
references,issue,9690,issue,8285,medium,issue.comments[14].body,"for the column slice thing, super huge omission from #8285. needs an extra isinstance",https://github.com/sqlalchemy/sqlalchemy/issues/9690,f0b846ecb519431a598505424cbabbe2629bc8c12ed274da4a0feed8bf117e07
references,issue,9587,issue,6810,medium,issue.body,chemy-stubs` and `sqlalchemy2-stubs` are not compatible with v2) ### Verify if the api is typed - [X] The api is not in a module listed in [#6810](https://github.com/sqlalchemy/sqlalchemy/issues/6810) so it should pass type checking ### Confirm this is not Mypy dataclasses iss...,https://github.com/sqlalchemy/sqlalchemy/issues/9587,8f0ab012bcaefbb9dcc8fde82aebd9ec9c8df0924510f8c708fbb24da29daaf5
references,issue,9493,issue,9350,medium,issue.body,"We also seem to make inherit dataclasses attributes, while we probably should not. Not sure if it's connected to this other issue #9350 ```py from dataclasses import dataclass import sqlalchemy as sa import sqlalchemy.orm as sao import inspect class Base(sao.MappedAsDataclas",https://github.com/sqlalchemy/sqlalchemy/issues/9493,f8076fc7d0dcdc0caf479d2dd1902d754d6d52303e877db2ec988e937c80470e
references,issue,9493,issue,9410,medium,issue.body,"We also seem to make inherit dataclasses attributes, while we probably should not. Not sure if it's connected to this other issue #9350 ```py from dataclasses import dataclass import sqlalchemy as sa import sqlalchemy.orm as sao import inspect class Base(sao.MappedAsDataclass,...",https://github.com/sqlalchemy/sqlalchemy/issues/9493,7da7fa4bf320ac783e00f5247a2ede72640cfa78056a56b13cd1bb7503731229
references,issue,9410,issue,9563,medium,issue.body,"nit generated. this all comes from dataclasses, but it may be worth reiterate that 4. mention that all the dataclass limitations apply. see #9563 also 5. #9785 , back_populates / recursion issue 6. when using mixins, it is likely a good idea to use kw_only on those fields so t...",https://github.com/sqlalchemy/sqlalchemy/issues/9410,9b6db4545aaf428753491c4e682f91aee96491313572cf0eb87e8a93c8aa9846
references,issue,9410,issue,9785,medium,issue.body,"this all comes from dataclasses, but it may be worth reiterate that 4. mention that all the dataclass limitations apply. see #9563 also 5. #9785 , back_populates / recursion issue 6. when using mixins, it is likely a good idea to use kw_only on those fields so that they are no...",https://github.com/sqlalchemy/sqlalchemy/issues/9410,5bf4fd8898c49821d0a2a9c08b01149c5a9c38bdb880b5a924ffbae32ea057c0
references,issue,9410,issue,12168,medium,issue.body,"1. relationship = None issue : #9383 , #9856 - issue created: https://github.com/sqlalchemy/sqlalchemy/issues/12168 2. declared_attr on a mixin w/ dataclasses: #9408 3. order matters regarding the default value and init generated. this all comes from dataclasses, but it may be...",https://github.com/sqlalchemy/sqlalchemy/issues/9410,ba5a0365721007562e43ce750cb449600932045425b3815e98136ca7b4eb706e
references,issue,9410,issue,9350,medium,issue.comments[3].body,"We also seem to make inherit dataclasses attributes, while we probably should not. Not sure if it's connected to this other issue #9350 ```py from dataclasses import dataclass import sqlalchemy as sa import sqlalchemy.orm as sao import inspect class Base(sao.MappedAsDataclas",https://github.com/sqlalchemy/sqlalchemy/issues/9410,a7323bb4ce0f34aed7725f869799a299a1b3771c5a977eab22cdff1010cf0a22
references,issue,9410,issue,9785,medium,issue.comments[8].body,Maybe also: - #9785,https://github.com/sqlalchemy/sqlalchemy/issues/9410,0f0de7c8e307a01172f3cc983bf57fea8a684f31dbd26dc48265cb7bf49606e9
references,issue,9410,issue,9785,medium,issue.comments[9].body,> Maybe also: > > * [Using back_populates with MappedAsDataclass and asdict causing RecursionError #9785](https://github.com/sqlalchemy/sqlalchemy/issues/9785) sure. would be good to find if this has been reported as a dataclasses bug though,https://github.com/sqlalchemy/sqlalchemy/issues/9410,e9a7edbb51c0fbb8e7d03b064b9330f51b825c0e6c00d0b07c37b43267da66a3
references,issue,9410,issue,9785,medium,issue.comments[11].body,> Maybe also: > > * [Using back_populates with MappedAsDataclass and asdict causing RecursionError #9785](https://github.com/sqlalchemy/sqlalchemy/issues/9785) added to the list in the OP,https://github.com/sqlalchemy/sqlalchemy/issues/9410,ac8450cd750d88d9ca2b2d4e7346f082fe9ed5fc80b5375bf1c4c4b0ae258393
references,issue,9410,issue,9927,medium,issue.comments[13].body,#9927 I encountered this one. I am trying to use dataclass-only fields for some state things (i.e not mapped). The state variable should always b,https://github.com/sqlalchemy/sqlalchemy/issues/9410,a89a9f0c7bf2fa5fd2f9fe35d14f25d8509ac9bd2eb66bbc0989f876c87f61c7
references,issue,9410,issue,9927,medium,issue.comments[14].body,> #9927 > > I encountered this one. I am trying to use dataclass-only fields for some state things (i.e not mapped). The state variable should alwa,https://github.com/sqlalchemy/sqlalchemy/issues/9410,df46103bd062da4b2463301e827b7759968c3d338d610bea7dd705a2b063e9ea
references,issue,9410,issue,9930,medium,issue.comments[14].body,"> #9927 > > I encountered this one. I am trying to use dataclass-only fields for some state things (i.e not mapped). The state variable should always be created on object creation using the `default_factory` option. This works when creating the object and persisting, but if yo...",https://github.com/sqlalchemy/sqlalchemy/issues/9410,6aa77c0a8b6c929cac5e67b861c4fd336fb5caba5d81075396b493391fac72fc
references,issue,9301,issue,6120,medium,issue.comments[4].body,I guess https://github.com/sqlalchemy/sqlalchemy/issues/6120 could help reduce the need of this. In any case it's probably best to just document the TYPE_CHECKING version,https://github.com/sqlalchemy/sqlalchemy/issues/9301,d289d65b6458f7d56065c6c4619d8fa94a00ae33e4dddd5abc0411fd02d2b1d9
references,issue,9301,issue,6120,medium,issue.comments[5].body,"OK, column_property() is not mapped_column(), yeah I think let's document for now. i dont know what will happen with #6120 , added some notes there.",https://github.com/sqlalchemy/sqlalchemy/issues/9301,7e042644bd11e611ba9c18d395a6a3bc760bebc00d3e78bccf165103980a14b4
references,issue,9212,issue,9213,medium,issue.comments[1].body,"in the narrative docs at https://docs.sqlalchemy.org/en/20/orm/declarative_mixins.html . it just needs the `@classmethod` part discussed at #9213. I think we have actionable items on #9213 but for this one i dont see the action to take, other than maybe some more supplementary...",https://github.com/sqlalchemy/sqlalchemy/issues/9212,ae0f421cec53604dd2d04d59cd343e4561bab2d6a1d2d0e7b76ecc0127c1e1e1
references,issue,9212,issue,9213,medium,issue.comments[3].body,"in the narrative docs at https://docs.sqlalchemy.org/en/20/orm/declarative_mixins.html . it just needs the `@classmethod` part discussed at #9213. Yes, retrying with those changes, I've got it working. It's still not clear to me what generic type I should be using for an annot...",https://github.com/sqlalchemy/sqlalchemy/issues/9212,6100c6531a0dae5875a8398ff5894b968f4fa0eee7b8c532e833a5147559d650
references,issue,9154,issue,8762,medium,issue.comments[2].body,"r pypy? at some point we had to take pypy out of the testing pipeline Yes. I have two marked as failing in 1.4.46. One of them is linked to #8762, so might have been fixed already. The other was an exception message mismatch that I probably didn't report. Unfortunately, the te...",https://github.com/sqlalchemy/sqlalchemy/issues/9154,7d8d9ed321cb0b04e5587d49886261fd766e7e35406eb9ef4f15d323f7525427
references,issue,9147,issue,9832,medium,issue.body,"the event hook here: https://github.com/sqlalchemy/sqlalchemy/blob/689ebc30dcd6b9cedf01d729f748b31826720b5c/lib/sqlalchemy/orm/decl_base.py#L567-L582 that's making a global event against Mapper. Declarative should make at most just *one* event hook against Mapper, then use its...",https://github.com/sqlalchemy/sqlalchemy/issues/9147,2a0fb580bcb3916223f6c8a5ea029d9fa15d3ce1c00befe4b5122f8e66805010
references,issue,9147,issue,9832,medium,issue.comments[0].body,not sure we really need this but in any case depends on #9832,https://github.com/sqlalchemy/sqlalchemy/issues/9147,ab3a692c29a9dc2a749adccf5b8588fb317205c32c0216f36f322d0ae22ec6e0
references,issue,9082,issue,8889,medium,issue.comments[0].body,"""auto"" was added in #8889. i see this issue refers to ""auto"". nobody anywhere is going to put ""eager_defaults=False"" so this is a really non-impactful issue",https://github.com/sqlalchemy/sqlalchemy/issues/9082,f6bb8a11bdf770f7b0d1d113db5a9e835ec2ab601d7ee0c8b276f3ceed437849
references,issue,8992,issue,8989,medium,issue.body,"discovered during #8989, this is simply not implemented at all and the bind expression is ignored when it's an element of a tuple. Also, the impl of a TupleType()",https://github.com/sqlalchemy/sqlalchemy/issues/8992,46c36af5913ed4eacd3c91b7bbfe671ecce76e43945986c60a3484702423ff7b
references,issue,8431,issue,4340,medium,issue.body,"in #4340 21fbb5e38f04affb8ac4502428672b3a629c we implemented ""omit_join"" behavior for the selectinload loader strategy. We currently don't have this",https://github.com/sqlalchemy/sqlalchemy/issues/8431,be4402f25acc07f124af834cc472d01f0ce93a1dab7e9b2e830cb1cdabac7701
references,issue,7718,issue,4379,medium,issue.body,scussed in https://github.com/sqlalchemy/sqlalchemy/discussions/7717 this is very trivial and I think we will be able to make use of it for #4379 in any case: ```py from sqlalchemy import Column from sqlalchemy import DateTime from sqlalchemy import MetaData from sqlalchemy im...,https://github.com/sqlalchemy/sqlalchemy/issues/7718,2cd630fe6d98a397f5edef48e378cf59644ae84f32b281f302d6d65d94107318
references,issue,7475,issue,8574,medium,issue.comments[1].body,isables the key generation. > > I guess support for this could also be something could be added while updating this issue this was fixed in #8574,https://github.com/sqlalchemy/sqlalchemy/issues/7475,28f4bc9847f9f7c094b5fb92c6cd8c6d06557baf9d89b1bfa8ade97a731923e4
references,issue,7366,issue,3861,medium,issue.body,### Describe the bug I'm getting duplicated index objects in the `MetaData` when using `DeferredReflection`. I think a similar issue might've been fixed in https://github.com/sqlalchemy/sqlalchemy/issues/3861. Similar problem has been reported in https://stackoverflow.com/ques...,https://github.com/sqlalchemy/sqlalchemy/issues/7366,2e7d032f1638d66b0e7cdc29f6cb343737dff5fb8f2c4642346db74f964741b3
references,issue,7366,issue,8925,medium,issue.comments[8].body,"what this issue is about, this issue is about constraints which are a totally different story. the extend_existing not deduping on name is #8925.",https://github.com/sqlalchemy/sqlalchemy/issues/7366,78927e68ee67bcd9d85b529707d67f214e0655e0acdeeffb040c0255cc7bf03d
references,issue,7223,issue,7212,medium,issue.body,"Interval is an emulated type, that also subclasses `TypeDecorator`: https://github.com/sqlalchemy/sqlalchemy/blob/7f8bf038b753d3f250e0e974102c16037d1aea5d/lib/sqlalchemy/sql/sqltypes.py#L2026 This is different from the other emulated types, like Boolean and Enum, so for v2 it...",https://github.com/sqlalchemy/sqlalchemy/issues/7223,2a739c8ae6f9847b9cc92bcc42c8b20336391c2f99a707dfa83a85e5d17738cd
references,issue,7113,issue,4797,medium,issue.body,"i mean also, ""with_hint()"" is badly named. ""with_table_criteria()"" is a better name _Originally posted by @zzzeek in https://github.com/sqlalchemy/sqlalchemy/issues/4797#issuecomment-930432024_ perhaps we can generalize with_hint() into with_table_criteria() and then introduce...",https://github.com/sqlalchemy/sqlalchemy/issues/7113,50e63eb4d468685fec040fcaa2af270b82315d792dcc6482f0724f6a049322eb
references,issue,7113,issue,4797,medium,issue.comments[1].body,"""hints"" like indexing hints. other kinds of per-table constructs are placed differently, such as the for_system_time() we are looking at in #4797. So where with_hint() sends these three indicators of intent: * subject table * text that is to be treated like an indexing hint or...",https://github.com/sqlalchemy/sqlalchemy/issues/7113,89e934eead9c2694cb06fab9d5a4e9b1bb65448b5a42b79e2d873a19a103639f
references,issue,7113,issue,6040,medium,issue.comments[1].body,"this is related to #6040 as well and this could supersede it (that is, we wouldnt' have to do #6040 as written, with_hint would stay the same). i dont necessarily w",https://github.com/sqlalchemy/sqlalchemy/issues/7113,56d7ce3c7e84b5ce242d91706255611b6310561f64f25f363a8fbe7b80141570
references,issue,7035,pr,7009,medium,issue.comments[0].body,Follow up from the discussion is https://github.com/sqlalchemy/sqlalchemy/pull/7009,https://github.com/sqlalchemy/sqlalchemy/issues/7035,b8edf9fc581ea46cec663713f306e2a7bef10a64f63cef291b15e447a94c85b7
references,issue,6997,issue,6550,medium,issue.comments[3].body,"yeah it's #6550 and the line that makes this test case ""work"" is to reintroduce a clear bug: ```py diff --git a/lib/sqlalchemy/sql/elements.py b/lib/sqlalc",https://github.com/sqlalchemy/sqlalchemy/issues/6997,3f8a2010611d5690759e89811881bce5dabdbe359ee47438b15f4dc1d5d54ff4
references,issue,6810,issue,7519,medium,issue.comments[3].body,related issues: #7535 #7519 #7562 #7555,https://github.com/sqlalchemy/sqlalchemy/issues/6810,a94817bcb124b28ea4a4cb3f9602542f33c5358e01bbee372e0507b6416d0e63
references,issue,6810,issue,7535,medium,issue.comments[3].body,related issues: #7535 #7519 #7562 #7555,https://github.com/sqlalchemy/sqlalchemy/issues/6810,d4aaebc5c78c4a4b079f6de04e8d2ec772f842bc827838aecc742bfbb7f1f8d4
references,issue,6810,issue,7555,medium,issue.comments[3].body,related issues: #7535 #7519 #7562 #7555,https://github.com/sqlalchemy/sqlalchemy/issues/6810,86a8c38658bfe444b962d2f4fc6d64ed3732aa4a908bf0648049d1b015d09405
references,issue,6810,issue,7562,medium,issue.comments[3].body,related issues: #7535 #7519 #7562 #7555,https://github.com/sqlalchemy/sqlalchemy/issues/6810,6745f63f6542c2f5a3f4a02a547444ae9bdc3eb2d982a0b3f8d8cced22af3d0a
references,issue,6810,issue,7774,medium,issue.comments[16].body,"ensure assocaition proxy collection implement typing.List/Set/Dict, see #7774",https://github.com/sqlalchemy/sqlalchemy/issues/6810,f9df48673284f4383ff4a733920118d8d97a587b346e89c872f38fe3ed900bd2
references,issue,6810,pr,12384,medium,issue.comments[39].body,"I started to work on the `postgresql` dialect, first PR https://github.com/sqlalchemy/sqlalchemy/pull/12384 about the `array` module.",https://github.com/sqlalchemy/sqlalchemy/issues/6810,f6ac59568cc3c2c9f51ff0c63f889bdaa2048955b40a374c358e7a5434c2b6d3
references,issue,6810,pr,12707,medium,issue.comments[42].body,"Hi @CaselIT, When you have a moment, could you please review my [PR for `sqlalchemy.sql.base`](https://github.com/sqlalchemy/sqlalchemy/pull/12707)? Once it's acknowledged, I’d like to plan follow-up typing contributions for another untyped module( [`sqlalchemy.sql.crud`](http...",https://github.com/sqlalchemy/sqlalchemy/issues/6810,ac0bc5840d337138bb5f3e8e1afc380e5ea1e5f43025253a6c0bdff304180daf
references,issue,6810,pr,12759,medium,issue.comments[49].body,"Hi @zzzeek, @CaselIT Sorry to interrupt, but I’ve run into a typing-related question while working on the compiler module. I’ve opened a **temporary PR** to explain the issue and provide context: **Temp PR:** https://github.com/sqlalchemy/sqlalchemy/pull/12759 Would appreciate...",https://github.com/sqlalchemy/sqlalchemy/issues/6810,20604fad3923d47bc94c818a11be233a515589bba4611ae0d1a92bb812ad0415
references,issue,6612,issue,5256,medium,issue.comments[0].body,"Hi, I remembered asking a similar question. Here it is: https://github.com/sqlalchemy/sqlalchemy/issues/5256 tldr: you can use `.self_group()`",https://github.com/sqlalchemy/sqlalchemy/issues/6612,4f25441a9414f48a6ae7ca3c7cc1804700050c6f2c03aa5e4efbd23ccd552cb5
references,issue,6612,issue,3566,medium,issue.comments[1].body,"nks, I did not find the existing issue via search, but maybe my search terms were inadequate. Since your issue was closed to be tracked in, #3566, which in turn is marked resolved, should we keep one open as use case? Other than that, feel free to close.",https://github.com/sqlalchemy/sqlalchemy/issues/6612,bb574eebf4accfee90b97bac6bb48ffb38baa12807e20f718e164c6345d76a1a
references,issue,6612,issue,3566,medium,issue.comments[2].body,"s, I did not find the existing issue via search, but maybe my search terms were inadequate. > Since your issue was closed to be tracked in, #3566, which in turn is marked resolved, should we keep one open as use case? Other than that, feel free to close. Don't worry, searching...",https://github.com/sqlalchemy/sqlalchemy/issues/6612,98cea930c0dfe68467daf5ad430f7875f62fc2e83b94b62c2d2fa91c7b0cdd3f
references,issue,6612,issue,3566,medium,issue.comments[3].body,in #3566 it wasn't that clear to me what was going on but in this case I'd want to see if row valued types can signal to the compiler and/or express,https://github.com/sqlalchemy/sqlalchemy/issues/6612,200739e1b639c2e2377c8975f2819b84d36089fe843b5a9bbbd95b792c2cad6c
references,issue,6612,issue,5256,medium,issue.comments[4].body,this is an example: https://github.com/sqlalchemy/sqlalchemy/issues/5256#issue-600623503 ```sql select * from some_table where some_table is not null ``` vs ```sql select * from some_table where not (some_table is null) ``` the return values is different if a row has all null...,https://github.com/sqlalchemy/sqlalchemy/issues/6612,aba04a72b7065614496b4568f6e340647dd8eb931de59224bc70545e4d7db692
references,issue,6511,pr,12510,medium,issue.comments[4].body,"In https://github.com/sqlalchemy/sqlalchemy/pull/12510, I am proposing to an implementation for PostgreSQL. On SQLite, AFAICT, this does not seem possible as the `table_info` or `table_xinfo` pragmas apparently do not return the collation information. (On other backends, I don...",https://github.com/sqlalchemy/sqlalchemy/issues/6511,7612279ea163b2a36aa13bc4d5aedb5dbcdb37a7858195b36a2f873188688fc1
references,issue,6489,issue,3357,medium,issue.body,"as discussed at #3357, an additional execution option `dbapi_autocommit=True` that sets autocommit independently of setting an explicit isolation level would be",https://github.com/sqlalchemy/sqlalchemy/issues/6489,8ff3c555b9f2423a7d9baa5842fc200942813615af74e0c9cbc5377c84d03cc3
references,issue,6120,issue,3050,medium,issue.comments[0].body,"I originally wanted to do this in #3050, which got marked as a dupe of #3150, which allowed column_property to work with declared_attr, however, never added the lambda part of it.",https://github.com/sqlalchemy/sqlalchemy/issues/6120,d6043b3c5e5eb760d2d1e5e5dda8c0f1e069480dcce8d9be6c35e88ae11d9bc8
references,issue,6120,issue,3150,medium,issue.comments[0].body,"I originally wanted to do this in #3050, which got marked as a dupe of #3150, which allowed column_property to work with declared_attr, however, never added the lambda part of it. there was some reason that using lam",https://github.com/sqlalchemy/sqlalchemy/issues/6120,4ef91175f586af8fc0706eb90b25acc883b7b3a6c4c0732fe8319acf5aad08e7
references,issue,5583,issue,5578,medium,issue.body,"From Mike: this is not a v2 thing, this is all a right now thing. 1. all backends should be raising an error when a user behavioral intent that cannot be fulfilled is received by a dialect, so first off, the for_update_clause() in compiler.py should be looking at all of these...",https://github.com/sqlalchemy/sqlalchemy/issues/5583,43b337203449b6ffcbeeebd4140b0bc78a9429f3b5a59e9619566b4600bba140
references,issue,5352,issue,4250,medium,issue.body,` operator is supported in SQLAlchemy. So the statement `SELECT ~a.flag AS anon_1 FROM a` works and gives correct results. I've come across #4250 which seems related. ```py from sqlalchemy import * from sqlalchemy.orm import * from sqlalchemy.ext.declarative import declarative...,https://github.com/sqlalchemy/sqlalchemy/issues/5352,e52020d3fd0708eec18c9105a092d01b85cc7a4c85337b5ebff365ad86f645db
references,issue,5352,issue,4250,medium,issue.comments[0].body,hi there - how interesting that the exact test case from #4250 is still failing though I would assume in a different way from what was fixed there. this limitation has more to do with SQL Server not bei,https://github.com/sqlalchemy/sqlalchemy/issues/5352,d0e0973f42a5107dc8c1bd251d3913dab08f08188b55087c50723927b116baaa
references,issue,5350,issue,3989,medium,issue.body,"I've read https://github.com/sqlalchemy/sqlalchemy/issues/3989 but this seems unrelated. When defining a `ForeignKey` on a SQLAlchemy model, if the referenced column is given as a string (`{table_name}.{column_name}`) and the `Base.metadata` has been setup with a naming conven...",https://github.com/sqlalchemy/sqlalchemy/issues/5350,5972bb2c571f399892edd00a843c01f3f22162699af8e979c1f0899e29f2f791
references,issue,5350,issue,7706,medium,issue.comments[4].body,"the `ForeignKeyConstraint` separately via `__table_args__` works like a charm. I'd note that, when I saw this, I though that it could solve #7706. But, I still get `NoReferencedTableError`, so I assume there is in fact no way to use `referred_column`, unless you construct all...",https://github.com/sqlalchemy/sqlalchemy/issues/5350,52d7a18a4228166359944e7023eed67c299308d5d51a325e6bcb901fb83aec8d
references,issue,5123,issue,3692,medium,issue.body,"I have a `Session` model with a `hash` column of the `Binary` type, and a `User` model with a relationship of `sessions`. If I get attributes through `inspect(user).attrs`, calling `attr.load_history()` on the `sessions` attribute will cause this [string argument without an en...",https://github.com/sqlalchemy/sqlalchemy/issues/5123,47cd105d237e37c61dd3ffa204d22a8f68fa72f6f11762693b11b689346dee08
references,issue,5005,issue,5068,medium,issue.comments[10].body,"suspect #5068 is seeing the same thing, although in that issue the warning call is being emitted incorrectly as this warning has failed to be part of tes",https://github.com/sqlalchemy/sqlalchemy/issues/5005,2a2e20c4f9f7580148f1cb76e4c0a376eedf9fb27f03d07d6b380a3a676dfc9d
references,issue,4790,issue,4784,medium,issue.body,There are a handful of messages that could be improved. 1. `sqlalchemy.exc.InvalidRequestError: Naming convention including %(constraint_name)s token requires that constraint is explicitly named.` This doesn't give much of a context. Suggestion for improvement: Extend message...,https://github.com/sqlalchemy/sqlalchemy/issues/4790,b9ac29948f155235dbd3ff38cdc1712dbae235a24e0d2cd7c0e70ea745e57177
references,issue,4790,issue,4784,medium,issue.comments[4].body,"ok, here we go again... > for 2, when does it raise that error? This was an edge-case you discovered in this comment- https://github.com/sqlalchemy/sqlalchemy/issues/4784#issuecomment-516582228 > I don't understand the extra context you are adding in 1. wouldn't they want to k...",https://github.com/sqlalchemy/sqlalchemy/issues/4790,80cc2c0f3542e192c1c89a8f6faf604ce69e95399ef910f26e254e54d480c48b
closes,issue,4790,issue,4784,high,issue.comments[6].body,**jonathan vanasco** has proposed a fix for this issue in the **master** branch: **Fixes #4784 regarding constraints:** https://gerrit.sqlalchemy.org/c/sqlalchemy/sqlalchemy/+/2224,https://github.com/sqlalchemy/sqlalchemy/issues/4790,a3a655fd2257ef94dd89fad84f4ea7da479ff9bd0fa823f2bb9d8b2e14205148
references,issue,4784,issue,5151,medium,issue.comments[22].body,Note: perhaps use the enum listener example in #5151,https://github.com/sqlalchemy/sqlalchemy/issues/4784,4755062d1415cf09bb4263b99b28d7ab58c9a0be01916ef7c506960fbe3ba1a4
references,issue,4652,issue,3155,medium,issue.body,"for [Column](https://docs.sqlalchemy.org/en/13/core/metadata.html#sqlalchemy.schema.Column.params.server_default) and a couple issues here (#3155,#3444), it's still unclear how to ""correctly"" include an explicit ""ON UPDATE"" clause. The only solution I have come to so far was s...",https://github.com/sqlalchemy/sqlalchemy/issues/4652,7091d0690f411f24f8b11e545157d276113f15ec5899800865ca62804a5f736f
references,issue,4652,issue,3444,medium,issue.body,"olumn](https://docs.sqlalchemy.org/en/13/core/metadata.html#sqlalchemy.schema.Column.params.server_default) and a couple issues here (#3155,#3444), it's still unclear how to ""correctly"" include an explicit ""ON UPDATE"" clause. The only solution I have come to so far was specifi...",https://github.com/sqlalchemy/sqlalchemy/issues/4652,b2fae7f6d189d6d3ac05440064fbc7b073e638a9420417585a3b72fa6ece71db
references,issue,4652,issue,3155,medium,issue.comments[0].body,"for [Column](https://docs.sqlalchemy.org/en/13/core/metadata.html#sqlalchemy.schema.Column.params.server_default) and a couple issues here (#3155,#3444), it's still unclear how to ""correctly"" include an explicit ""ON UPDATE"" clause. > > The only solution I have come to so far w...",https://github.com/sqlalchemy/sqlalchemy/issues/4652,2c508532add8eb8a6b9cb8419b946c56a1574b51cd1626ed76e6f8f586d4f43e
references,issue,4652,issue,3444,medium,issue.comments[0].body,"olumn](https://docs.sqlalchemy.org/en/13/core/metadata.html#sqlalchemy.schema.Column.params.server_default) and a couple issues here (#3155,#3444), it's still unclear how to ""correctly"" include an explicit ""ON UPDATE"" clause. > > The only solution I have come to so far was spe...",https://github.com/sqlalchemy/sqlalchemy/issues/4652,f563149d0f6cbe61e526f83bcbbaca7ab4a92bab767e75b39283f5f169345a5b
references,issue,4641,issue,4640,medium,issue.body,with #4640 we are going to start adding mapper flags that folks will want to be able to apply across the board. so to make this easier without the nee,https://github.com/sqlalchemy/sqlalchemy/issues/4641,f4a03b391bcfc9c72613f3f90008d3099b0c5c43d6308a90b7dcdbce1c6dbd3b
references,issue,4567,issue,4360,medium,issue.body,"to be ignored on the table slippy_tiles but nothing seems to take when creating the schema from ORM, even though it is supposedly fixed in #4360 I've tried renaming the kwarg in the column definitions to sqlite_on_conflict_primary_key, sqlite_on_conflict, on_conflict, editing...",https://github.com/sqlalchemy/sqlalchemy/issues/4567,c9f080d74242225e224317e71bbae1dff8e8de902467705e1acec704a5d69495
references,issue,4289,issue,3989,medium,issue.comments[23].body,**Michael Bayer ([@zzzeek](https://github.com/zzzeek)) wrote:** note in #3989 we don't truncate naming conventions for things other than indexes.,https://github.com/sqlalchemy/sqlalchemy/issues/4289,2a2ff5f4f2087393917aca91e4535d41da63cec84bb0ac58c350cdad1f4d259f
references,issue,1063,issue,3990,medium,issue.comments[0].body,**Michael Bayer ([@zzzeek](https://github.com/zzzeek)) wrote:** Issue #3990 was marked as a duplicate of this issue.,https://github.com/sqlalchemy/sqlalchemy/issues/1063,5c17de2e384aa534011ab01aab6e73b9be174822a285c21303f68440e83d287b
references,issue,1063,issue,3496,medium,issue.comments[2].body,"**Michael Bayer ([@zzzeek](https://github.com/zzzeek)) wrote:** as tihs would also fix #3496 I'm motivated to work on this, but I'm struggling. https://gerrit.sqlalchemy.org/427",https://github.com/sqlalchemy/sqlalchemy/issues/1063,1f896a059c727a29e8fb06cc21f10cc6d37f3bd0ce9a926417b8152a8c1208a0
references,issue,12730,issue,6810,medium,issue.body,chemy-stubs` and `sqlalchemy2-stubs` are not compatible with v2) ### Verify if the api is typed - [x] The api is not in a module listed in [#6810](https://github.com/sqlalchemy/sqlalchemy/issues/6810) so it should pass type checking ### Describe the typing issue When passing m...,https://github.com/sqlalchemy/sqlalchemy/issues/12730,3842d0eec177fae874259fa4e9ea3e33a879e328b11d034e013224deadda18ad
references,issue,9618,issue,9603,medium,issue.body,"ne in https://gerrit.sqlalchemy.org/c/sqlalchemy/sqlalchemy/+/4548. Among other things this will be a real solution to the problem faced at #9603 and will also be a hedge against any other database where we can't guarantee INSERT ordering. for use_insertmanyvalues, it then bec...",https://github.com/sqlalchemy/sqlalchemy/issues/9618,275bc98ada6d49989345e61ebf9f2d01d61290bb1a826bbaaad6ec6f9492c7ec
references,issue,9618,issue,9603,medium,issue.comments[7].body,"ning(table)"", something like that 4. limit the use of insertmanyvalues **just in the unit of work**. after all that was the issue we had in #9603",https://github.com/sqlalchemy/sqlalchemy/issues/9618,09c040e81bdeaca0358effa59681e4df6040d3c0b8da7be8a8736504a8ccbb45
references,issue,9618,issue,9603,medium,issue.comments[20].body,"y, meaning if that order is off, any situation where those objects have further collections on them we'd be seeing the issue like we see in #9603. That's tens of millions of downloads per month where we would assume applications have tolerated concurrent VACUUMs and things lik...",https://github.com/sqlalchemy/sqlalchemy/issues/9618,b283236773c64ef1bd5167c56f142f85e7a8327de35e52c6b99be54049ade30d
references,issue,9603,issue,9618,medium,issue.comments[65].body,"doing a lot of thinking over at #9618. I think we can definitely restore MS-SQLs ""insertmanyvalues"" feature as long as we dont use it in the unit of work to match up primary key",https://github.com/sqlalchemy/sqlalchemy/issues/9603,8f2b5ac1afb6546a0cb8a56a1face423d713f2570269c2c95a9e327b810240ba
references,issue,9563,issue,9410,medium,issue.comments[7].body,"s or similar dataclass limitations gets reported, so maybe people are not that familiar with them? In any case i've mentioned this issue in #9410 regarding re-raise we can decide later, since it's easy to add, not that easy to remove",https://github.com/sqlalchemy/sqlalchemy/issues/9563,a87dfd77e9c7ebeb1cbccc83ff4fdbf9ea394e9b70f9e682effbc302a3ff2f44
references,issue,7774,issue,6810,medium,issue.comments[0].body,"otation to an association proxy in all cases. whether or not associationproxy accommodates `Mapped[]` right now will be resolved as part of #6810, you can use a cast() in the interim: ```py from sqlalchemy.orm import Mapped class Parent(Base): __tablename__ = ""parent"" id = Col...",https://github.com/sqlalchemy/sqlalchemy/issues/7774,d91ccb3c45294a659d2db985ac618146ffca9ff9b3821c260d12aa0dcc093cf5
references,issue,7774,issue,6810,medium,issue.comments[3].body,erialization. Here you're looking for AssocaitionList/set/dict to implement the appropriate typing collection. This will be done as part of #6810 in 2.0.,https://github.com/sqlalchemy/sqlalchemy/issues/7774,31dd4ed3777db58146ebd086102cdbfaae9967c91b5624762c575ca5a1c24133
references,issue,7774,issue,6810,medium,issue.comments[5].body,"Hey, i'm not if this is the correct ticket to place this, so please tell me if not. According to https://github.com/sqlalchemy/sqlalchemy/issues/6810, the association_proxy (so probably also the AssociationList) is already fully typed. But in this case, shouldn't `tags` be suc...",https://github.com/sqlalchemy/sqlalchemy/issues/7774,09fe6be2119eee9006741ec26ab30e864b1409e458d87a33a575401cb4a0af93
references,issue,7706,issue,5350,medium,issue.comments[0].body,"Ah sorry, I guess this may be a duplicate of #5350",https://github.com/sqlalchemy/sqlalchemy/issues/7706,82c1a816e027b666cc3b204fc6caf30893bf626d36bce2e7b80651255ace6baa
references,issue,7659,pr,8136,medium,issue.comments[18].body,"Alright, started a draft PR here for discussion https://github.com/sqlalchemy/sqlalchemy/pull/8136",https://github.com/sqlalchemy/sqlalchemy/issues/7659,21d30cde20323ca02f40a17cb515a18a41b017ee4a6bab4b1910329b697deeb3
references,issue,5578,issue,5583,medium,issue.comments[16].body,Thanks for the great explanation mike. I've taken the liberty of creating a new issue to track this. See https://github.com/sqlalchemy/sqlalchemy/issues/5583,https://github.com/sqlalchemy/sqlalchemy/issues/5578,ef8f51719f405bfe5f711673830d9ee64ddf66ae430560b98189c25592d325ea
references,issue,5256,issue,3566,medium,issue.comments[0].body,"-comparison.html after the tip note. just FYI there's a ton of PG stuff that we don't have built in right now that are along this line, see #3566 . if you want to work on this stuff it's definitely leveling up but 1.4 should be getting very good at this stuff by now :) > > Als...",https://github.com/sqlalchemy/sqlalchemy/issues/5256,97660fc0b5c1e24698abdcd0de4b9acbf303260b77d379aa7908a023d6636e70
references,issue,5256,issue,3566,medium,issue.comments[2].body,"I want to ultiamtely do everything here and in #3566. this comes up all the time. it's just if it is done quickly without consdiering PG's syntactical concepts in total, we can paint ourselves",https://github.com/sqlalchemy/sqlalchemy/issues/5256,ae21bcd22215bc615a552e5650f90f51159ea476e1726896d7873c6fb008874d
references,issue,5256,issue,3566,medium,issue.comments[3].body,"Added a comment in #3566. This can be closed, so we can track all the missing pg behaviors from a single place",https://github.com/sqlalchemy/sqlalchemy/issues/5256,3dd4c09ac674e5ebeb1966793bea320cea8059b0304dbcc81afb95cba8c6218b
references,issue,5068,issue,5005,medium,issue.comments[4].body,"hen UPDATE if ""supports_sane_rowcount"" is set to **True** Hi can you define ""failed"" please? Are you getting the same error as described in #5005 ? > In fact, it is common to disable ""supports_sane_rowcount"" as a workaround for `pyodbc` and `Microsoft ODBC Driver` does not sup...",https://github.com/sqlalchemy/sqlalchemy/issues/5068,783bd19817db559cf44997e51a84a79c0418f8134675a253c04f3c4ef4d24b1f
references,issue,4797,issue,6040,medium,issue.comments[16].body,"ere, which would be pretty weird. The ""hint text"" should be possible that it is a compiled object, not just a string and that is missing os #6040 is added.",https://github.com/sqlalchemy/sqlalchemy/issues/4797,594f606bb1fa02fc0420bbd62bf368ea2661ec500b0b08968d61b562db5f4cae
references,issue,3990,issue,1063,medium,issue.comments[0].body,**Michael Bayer ([@zzzeek](https://github.com/zzzeek)) wrote:** Duplicate of #1063.,https://github.com/sqlalchemy/sqlalchemy/issues/3990,d4566649583f858c412ee38c5ab27833a933505232fa7b82933ba8ab3f3fa1c0
references,issue,3990,issue,1063,medium,issue.comments[1].body,wrote:** post_update is currently required for any mutually-dependent FKs relationship. having it not be necessary for UPDATE only is what #1063 addresses.,https://github.com/sqlalchemy/sqlalchemy/issues/3990,2a88adcbe19e0e89623d7116b6caa32975f424144ec464109477dc581d471347
references,issue,3989,issue,4289,medium,issue.comments[6].body,"**Michael Bayer ([@zzzeek](https://github.com/zzzeek)) wrote:** we *do* truncate specifically for indexes, see #4289.",https://github.com/sqlalchemy/sqlalchemy/issues/3989,20e32b5378152b7b19290523463226fc995f9d02ba7d5598ede521606b7686a4
references,issue,3566,issue,5256,medium,issue.comments[38].body,"where at least a column is not null, while `some_table is not null` returns all the rows where all columns are not null. Consolidating from #5256",https://github.com/sqlalchemy/sqlalchemy/issues/3566,de0df4a756098293291f0a0a23d13f56fabcf1699287b5814a5aeeb38c9b408a
references,issue,3496,issue,1063,medium,issue.comments[13].body,"OK, that's a lot of code and a lot of repetition. Why do we need to emit post_update when this is only an UPDATE? This should be a dupe of #1063 which would solve the whole problem.",https://github.com/sqlalchemy/sqlalchemy/issues/3496,f3f90fa2adb9f330a7bd455b67b87bf9643c5efd2b666086b41b54dd46f833c7
references,issue,3496,issue,1063,medium,issue.comments[14].body,**Michael Bayer ([@zzzeek](https://github.com/zzzeek)) wrote:** at the moment I think #1063 can't work in every possible case. still thinking,https://github.com/sqlalchemy/sqlalchemy/issues/3496,9f1e0e106b9abc2d1b577693f29c94c39a33923628c57897ee6f3174e25f04d5
references,issue,3444,issue,3155,medium,issue.body,"**Migrated issue, originally created by Charles-Axel Dein ([@charlax](https://github.com/charlax))** This seems similar to #3155 and #2631. I have this simple script to reproduce the problem: ``` from sqlalchemy import create_engine from sqlalchemy import func from sq",https://github.com/sqlalchemy/sqlalchemy/issues/3444,42663fbc334c0c15de5e17f36a4135c784dd10f2dae1d09b5704672cf062e4a2
references,issue,3444,issue,3155,medium,issue.comments[4].body,"asically getting a model with database-level `created_at` and `updated_at` behavior requires some shenanigans that you recommend against in #3155. Sadly, wasn't able to find another way to achieve this. ``` from sqlalchemy import create_engine from sqlalchemy import func, text...",https://github.com/sqlalchemy/sqlalchemy/issues/3444,3317840278c8cd5906e1bfc41e8bf5fdc94496d26a0c64e214836b3a062987ae
references,issue,3150,issue,3050,medium,issue.body,"issue, originally created by Michael Bayer ([@zzzeek](https://github.com/zzzeek))** poc should allow us to consolidate #2670, #2952, #3149, #3050. the new descriptors include the ability to cache the result per class, or to do ""cascade"", guarantees that the callable fn is call...",https://github.com/sqlalchemy/sqlalchemy/issues/3150,01e4aeb5d5f4134154f4bbdf24a4e73eb89620673df18d4e8cdd33cd23efe9ff
references,issue,3150,issue,3050,medium,issue.comments[0].body,**Michael Bayer ([@zzzeek](https://github.com/zzzeek)) wrote:** Issue #3050 was marked as a duplicate of this issue.,https://github.com/sqlalchemy/sqlalchemy/issues/3150,f337faf9823b495e03b173b6966327a206b2d8d74bf3f0b96772e256f3634913
references,issue,3050,issue,3150,medium,issue.comments[3].body,**Michael Bayer ([@zzzeek](https://github.com/zzzeek)) wrote:** Duplicate of #3150.,https://github.com/sqlalchemy/sqlalchemy/issues/3050,24623bfdf1b3d03be5d844bbfd142a31e92c2bd8289dbde45796f324225d78d6
closes,pr,13421,issue,13420,high,pr.closingIssuesReferences,pr #13421 declares a closing reference to issue #13420.,https://github.com/sqlalchemy/sqlalchemy/pull/13421,8b33a35ff1691143cc95cea5dbf74aabb2977e184c2e60ce18f313f6bbca2bde
closes,pr,13421,issue,13420,high,pr.body,"db's AsyncCursor in version 2.0.1, the async dialect's minimum supported oracledb version is raised from 2.0.0 to 2.0.1 accordingly. Fixes: #13420 <!-- Provide a general summary of your proposed changes in the Title field above --> ### Description <!-- Describe your changes in...",https://github.com/sqlalchemy/sqlalchemy/pull/13421,dd142b73825027796dad3fd9913eafab72d85b3a1427145173e4908f67056013
review guidance,pr,13421,issue,13420,high,pr.reviews[0].body,"OK, this is **sqla-tester** setting up my work on behalf of **zzzeek** to try to get revision 20582e2eaf1cdf9cd8af94ecf216f5d5d9fb3d62 of this pull request into gerrit so we can run tests and reviews and stuff",https://github.com/sqlalchemy/sqlalchemy/pull/13421,5a7c63410de3e0030e674a680bed80f158c9153656e71d6297dc895290180827
review guidance,pr,13421,issue,13420,high,pr.reviews[1].body,"OK, this is **sqla-tester** setting up my work on behalf of **zzzeek** to try to get revision 20582e2eaf1cdf9cd8af94ecf216f5d5d9fb3d62 of this pull request into gerrit so we can run tests and reviews and stuff",https://github.com/sqlalchemy/sqlalchemy/pull/13421#pullrequestreview-4648102684,d9d3d13b996ab6cd79be43d02febd0ab28c1481af4d95a2a92a9a1e084679ef9
closes,pr,13418,issue,9693,high,pr.closingIssuesReferences,pr #13418 declares a closing reference to issue #9693.,https://github.com/sqlalchemy/sqlalchemy/pull/13418,0a2d293786e8fb8cf6c1545ef7c6f49b80e8f54e8607fc526d68ad590c99450a
closes,pr,13418,issue,9693,high,pr.body,"### Description Fixes #9693. String type collation rendering currently hardcodes quoted collation names, so a PostgreSQL schema-qualified collation such as `schema.col",https://github.com/sqlalchemy/sqlalchemy/pull/13418,d1b9b7bb626a5bc5cdf75fd272fc4fdd0c9a09a399acbee633f3d4c34ffb9d5f
follows smaller direction from,pr,13418,pr,12697,high,pr.body,"and allowing `quoted_name(""schema.collation"", quote=False)` for qualified names. This follows the smaller direction discussed in #9693 and #12697 rather than adding a new `collation_schema` attribute or reflection machinery. ### Tests - `python -m pytest test/sql/test_types.py...",https://github.com/sqlalchemy/sqlalchemy/pull/13418,24938b22dde5a0feb3751dbd7b2e18016fdd0fccfdb2deb4ef4db164aa0a74aa
review guidance,pr,13417,pr,13417,high,pr.reviews[0].body,"Sprinkling `Any` to bypass complex signatures is essentially disabling static analysis for this path. If we are going to type this, let's design proper generics/protocols instead of resorting to type erasure.",https://github.com/sqlalchemy/sqlalchemy/pull/13417,a459d9f29587bd268cd19e32d1365dba65b0271d9e4ad88681ed339e4bfc70c7
review guidance,pr,13417,pr,13417,high,pr.reviews[1].body,"Sprinkling `Any` to bypass complex signatures is essentially disabling static analysis for this path. If we are going to type this, let's design proper generics/protocols instead of resorting to type erasure.",https://github.com/sqlalchemy/sqlalchemy/pull/13417#pullrequestreview-4639758344,f45a2b057a4d68d786006009a5482d77ab8b1d2c7e2ad7e0456d91c78401fc97
review guidance,pr,13416,pr,13416,high,pr.reviews[0].body,"**1. `_sa_trivial` bypass via `functools.wraps`** The `getattr(appender, ""_sa_trivial"", None)` check is fooled if a custom override uses `@functools.wraps(InstrumentedList.append)`: wraps copies the wrapped function's `__dict__`, leaking both `_sa_instrumented` and `_sa_trivial` into the subclass...",https://github.com/sqlalchemy/sqlalchemy/pull/13416,3481d1492f240c8ac756b8d7569f8ec75c8d16071b37889a53dedee10c859599
review guidance,pr,13416,pr,13416,high,pr.reviews[1].body,"**1. `_sa_trivial` bypass via `functools.wraps`** The `getattr(appender, ""_sa_trivial"", None)` check is fooled if a custom override uses `@functools.wraps(InstrumentedList.append)`: wraps copies the wrapped function's `__dict__`, leaking both `_sa_instrumented` and `_sa_trivial` into the subclass...",https://github.com/sqlalchemy/sqlalchemy/pull/13416#pullrequestreview-4638836429,cbd54cb6baeaa553e257e4300e538d3921e2cf5df943805ec6b6b46983527dd4
closes,pr,13405,issue,13407,high,pr.closingIssuesReferences,pr #13405 declares a closing reference to issue #13407.,https://github.com/sqlalchemy/sqlalchemy/pull/13405,ff878bf6472b53d6e6572eb7e55a7e5ec2f57c2c534ddbc07d69156cdcbd2d9f
closes,pr,13405,issue,13407,high,pr.body,"(it wins uncompiled too); `-O3` compilation adds a smaller further gain (~2–6%), to weigh against the cost of a new compiled module. Fixes: #13407 ## Benchmarks `min` ms, vs `main`. Python 3.14, in-memory SQLite, 50 repeats, extension compiled at `-O3`. | case | before | after...",https://github.com/sqlalchemy/sqlalchemy/pull/13405,61f72f4fd449f8e69004f0464d4bed7cc887cedb8b12a49221cc72c897c29293
closes,pr,13405,issue,13407,high,pr.comments[0].body,"Thanks for looking into this. I've created an issue, it's #13407",https://github.com/sqlalchemy/sqlalchemy/pull/13405,6113770e4deecd804dbe769a95929d97aafee7fd010e337ca1bc2463c458b9bc
closes,pr,13404,issue,13406,high,pr.closingIssuesReferences,pr #13404 declares a closing reference to issue #13406.,https://github.com/sqlalchemy/sqlalchemy/pull/13404,9a7d89018f59c82e20d438f894c8f2ed4097e9a7f555f06c38d96c93eb16251e
closes,pr,13404,issue,13406,high,pr.body,")` semantics; the requires_uniquing fallback covers nested-eager cases. `test_subquery_relations` and `test_recursive_loaders` pass. Fixes: #13406 ### Checklist <!-- go over following points. check them with an `x` if they do apply, (they turn into clickable checkboxes once th...",https://github.com/sqlalchemy/sqlalchemy/pull/13404,76b9c8558015c2de3eaa733b001e18f3a07418c0d687fcdc06765cb1244f96f1
closes,pr,13404,issue,13406,high,pr.comments[0].body,"Hey @ollz272 thanks for continuing work on this! I've created #13406 from the discussion, so we have something to add to the fixes etc. > Still having trouble with gerrit.. sorry! no problem, feel free to kee",https://github.com/sqlalchemy/sqlalchemy/pull/13404,35194e4c2f115bdd90c6213a6dec51250a81a2b0639be55a0576103511b7edf2
closes,pr,13402,issue,10748,high,pr.closingIssuesReferences,pr #13402 declares a closing reference to issue #10748.,https://github.com/sqlalchemy/sqlalchemy/pull/13402,2ff81594ce6acdcfeb0602a855629ad1d9a7721515133cc29324b30d2c2ca232
closes,pr,13402,issue,10748,high,pr.body,gistration assertion for conflicting registrars - add regression coverage for module reload style registration and a changelog entry Closes #10748. ### Validation - `/tmp/sqlalchemy-pr-venv/bin/python -m pytest test/base/test_inspect.py -q` - `/tmp/sqlalchemy-pr-venv/bin/pytho...,https://github.com/sqlalchemy/sqlalchemy/pull/13402,c150169126683f2b1a5088f586356dac00a154712c353f36519b216309168dfa
closes,pr,13402,issue,10748,high,pr.review_comments[0].body,let's add a comment similar to the shared by mike here https://github.com/sqlalchemy/sqlalchemy/issues/10748#issuecomment-1852787222 to clarify why it's done this way,https://github.com/sqlalchemy/sqlalchemy/pull/13402,a6c68e602a88c876863c56c4cc76309bbe60cf2d2c6eccaf0415c33e7d7dba7f
review guidance,pr,13402,issue,10748,high,pr.reviews[0].body,"thanks, just a nitpick comment. otherwise it looks fine @zzzeek I think 2.1 only for this is fine",https://github.com/sqlalchemy/sqlalchemy/pull/13402,317501913ea3833a0f52017aece56f00a5964f4d16e269ab23bc92f9cc85d4e2
review guidance,pr,13402,issue,10748,high,pr.reviews[1].body,"OK, this is **sqla-tester** setting up my work on behalf of **CaselIT** to try to get revision e54815ef0092da05277efab79b90b77e44734cb9 of this pull request into gerrit so we can run tests and reviews and stuff",https://github.com/sqlalchemy/sqlalchemy/pull/13402,c2cecc1f3588b02651b4c91caebdef4cfe14f66fa65d5756883901839621ae9d
review guidance,pr,13402,issue,10748,high,pr.reviews[2].body,"thanks, just a nitpick comment. otherwise it looks fine @zzzeek I think 2.1 only for this is fine",https://github.com/sqlalchemy/sqlalchemy/pull/13402#pullrequestreview-4590614148,788250012b0125e304886586bcd8d8f88a085429a2f4d5fc15a5cba222b2a0af
review guidance,pr,13402,issue,10748,high,pr.reviews[3].body,"OK, this is **sqla-tester** setting up my work on behalf of **CaselIT** to try to get revision e54815ef0092da05277efab79b90b77e44734cb9 of this pull request into gerrit so we can run tests and reviews and stuff",https://github.com/sqlalchemy/sqlalchemy/pull/13402#pullrequestreview-4590995010,8b7a19c1abf1d46bdf74ab347e2b6a5580f42341e7f25f5882798fb27a7bb34c
closes,pr,13399,issue,13048,high,pr.closingIssuesReferences,pr #13399 declares a closing reference to issue #13048.,https://github.com/sqlalchemy/sqlalchemy/pull/13399,3cc30e8644c0575daf316f555c3cc702e33be56a7baf9238db54f2ff2ecc9bf7
closes,pr,13399,issue,13048,high,pr.body,"attach_to_table, using `Table.append_constraint(index)` allows for execution of `table.indexes.add(self)` in `Index._set_parent()`. Fixes: #13048 ### Checklist <!-- go over following points. check them with an `x` if they do apply, (they turn into clickable checkboxes once the...",https://github.com/sqlalchemy/sqlalchemy/pull/13399,1a42aa2d1aa76cff59c51a944ec4956d6836271d09c18987274c277d11e5a339
closes,pr,13398,issue,13419,high,pr.closingIssuesReferences,pr #13398 declares a closing reference to issue #13419.,https://github.com/sqlalchemy/sqlalchemy/pull/13398,84e54b42e50f97e6babf610048871a2144a6a2cb42f230b35846acad8d18b0d7
closes,pr,13398,issue,13419,high,pr.body,"Fixes: #13419 ### Description While reflecting a SQLite table, `get_unique_constraints` scans the stored `CREATE TABLE` text (taken verbatim from `sqlite",https://github.com/sqlalchemy/sqlalchemy/pull/13398,101f841ff0d119bb117dcfa991ec38fa2d324b96cf64dfbbac22122920882125
closes,pr,13398,issue,13419,high,pr.comments[1].body,"opened #13419 with the description, a runnable reproducer and the comparative timings. i've linked it here (Fixes: #13419) and renamed the changelog to 1",https://github.com/sqlalchemy/sqlalchemy/pull/13398,4ca82214ce3682b42602d1b43859eee070f6eeb396e0ec7944c1c3e080a124d3
review guidance,pr,13398,issue,13419,high,pr.reviews[0].body,LGTM. Removing the space from `[a-z0-9_ ]` successfully eliminates the ReDOS vulnerability. Thanks!,https://github.com/sqlalchemy/sqlalchemy/pull/13398,a40db8b86018771c5554bd606d95512b8aa34ee6120824ae45c4711393a7d9a3
review guidance,pr,13398,issue,13419,high,pr.reviews[1].body,LGTM. Removing the space from `[a-z0-9_ ]` successfully eliminates the ReDOS vulnerability. Thanks!,https://github.com/sqlalchemy/sqlalchemy/pull/13398#pullrequestreview-4639806810,5dc99428beff20546bc78fdba30cfec3482d38e1b8313655f6cc19d58b75ad79
closes,pr,13368,issue,11132,high,pr.closingIssuesReferences,pr #13368 declares a closing reference to issue #11132.,https://github.com/sqlalchemy/sqlalchemy/pull/13368,7c6e12a184c6bc9ef6f66bd413d16e80239504d2363aec0a844e710d63970bc9
closes,pr,13368,issue,11132,high,pr.body,"### Description Fixes #11132. Per maintainer guidance in the issue, this PR does two things: 1. **Documents the caveat**: adds a `.. warning::` to the MySQL dialect's `",https://github.com/sqlalchemy/sqlalchemy/pull/13368,6d36df49877d5ee3bc05d03915de65379011e67aced3ea8edabccb2057151240
closes,pr,13323,issue,8992,high,pr.closingIssuesReferences,pr #13323 declares a closing reference to issue #8992.,https://github.com/sqlalchemy/sqlalchemy/pull/13323,579ea63a5b64a2ddb2418ef200efbb854a90ee2c4e24c5675cb7786ac1a0e38a
closes,pr,13323,issue,8992,high,pr.body,dering expanded tuples. This matches scalar `IN` behavior for custom types and covers both `render_postcompile` and `literal_binds`. Fixes: #8992 ### Checklist This pull request is: - [ ] A documentation / typographical / small typing error fix - [x] A short code fix - Fixes:...,https://github.com/sqlalchemy/sqlalchemy/pull/13323,3fdec6052d67d3cfd6f11f8ce992e0bbb9385ee310574b703ec0e955726fb6ee
closes,pr,13303,issue,13157,high,pr.closingIssuesReferences,pr #13303 declares a closing reference to issue #13157.,https://github.com/sqlalchemy/sqlalchemy/pull/13303,e6f176baea876ba31d0a381b4a56a97ef18cedf2559f5d5cb9a7041f7e50f8da
closes,pr,13303,issue,13157,high,pr.body,"Fixes #13157. The second pass over the CHECK constraint body in `get_multi_check_constraints` used a naive ```python re.sub(r""^[\s\n]*\((.+)\)[\s\n]*$"",",https://github.com/sqlalchemy/sqlalchemy/pull/13303,482bd70a53a0a417d02073f91b6b298afb222bd5bbe26a21d5a7d421eaf9a1a7
references,pr,13303,pr,13200,medium,pr.reviews[0].body,"Hi, If you want to work on this please try at least to address the comment in the last attempt: https://github.com/sqlalchemy/sqlalchemy/pull/13200#pullrequestreview-4022937474 thanks",https://github.com/sqlalchemy/sqlalchemy/pull/13303,9aa0c45486c749d96cd0096dadc26c7ce701f399a9ecefc6b1626582bae2a6e6
review guidance,pr,13303,issue,13157,high,pr.reviews[0].body,"Hi, If you want to work on this please try at least to address the comment in the last attempt: https://github.com/sqlalchemy/sqlalchemy/pull/13200#pullrequestreview-4022937474 thanks",https://github.com/sqlalchemy/sqlalchemy/pull/13303,5ea3ea9b65ed3f915b92c8889dc1ec6a9929e588cf9930886f082f412eed228d
review guidance,pr,13303,issue,13157,high,pr.reviews[1].body,"Hi, If you want to work on this please try at least to address the comment in the last attempt: https://github.com/sqlalchemy/sqlalchemy/pull/13200#pullrequestreview-4022937474 thanks",https://github.com/sqlalchemy/sqlalchemy/pull/13303#pullrequestreview-4316297972,6c55040663cb2b04384399212898121ac1db6bf7c2e90a6988dd589dceffd615
closes,pr,13289,issue,13227,high,pr.closingIssuesReferences,pr #13289 declares a closing reference to issue #13227.,https://github.com/sqlalchemy/sqlalchemy/pull/13289,37eb954bdacaab037b33b0595f93164d64f8a4fadc255eba243f0dd6d2f2f75b
closes,pr,13289,issue,13227,high,pr.body,"### Description Fixes: #13227 When `default_factory=list` or `default` is passed to a `WriteOnlyMapped` or `DynamicMapped` relationship, it previously caused cryptic cra",https://github.com/sqlalchemy/sqlalchemy/pull/13289,9246a08505a7f683e9e467e7d71cc4488d44570c886dc7f714ad1e2f09c2e42f
review guidance,pr,13289,issue,13227,high,pr.reviews[0].body,"thanks, left a few suggestions. let's also wait mike input on whatever we should include also dynamic here",https://github.com/sqlalchemy/sqlalchemy/pull/13289,d235f2f4ef28e2a0d731ebf66599625b2e2e47ae94bf13f6f510f297eb472ce1
review guidance,pr,13289,issue,13227,high,pr.reviews[2].body,"thanks, left a few suggestions. let's also wait mike input on whatever we should include also dynamic here",https://github.com/sqlalchemy/sqlalchemy/pull/13289#pullrequestreview-4270338141,6050170996f721ab875cc454160e19f28c2b397c0859ed7e8a3c0a8dd5ad0cd9
closes,pr,13288,issue,13169,high,pr.closingIssuesReferences,pr #13288 declares a closing reference to issue #13169.,https://github.com/sqlalchemy/sqlalchemy/pull/13288,f34b97e45dac4d6778139d0ea656ad1e91660d1d801c5e6f2a32e55b61fef7a3
closes,pr,13288,issue,13169,high,pr.body,"timeout), so switching to `time.monotonic()` preserves existing behavior while fixing the precision issue. - [x] A short code fix - Fixes: #13169 - Existing pool invalidation tests cover the comparison logic",https://github.com/sqlalchemy/sqlalchemy/pull/13288,0abfd7b1e90b0eaa01886a09481e5e497668d3874e841c3aa15c1f3a1065df4a
closes,pr,13288,issue,13169,high,pr.reviews[0].body,I want to do what I propose [here](https://github.com/sqlalchemy/sqlalchemy/issues/13169#issuecomment-4060550530) which is dont hardcode time functions that are used in this way: 1. note that we also use `time.time()` in [queue.py](https://github.com/sqlalchemy/sqlalchemy/blob...,https://github.com/sqlalchemy/sqlalchemy/pull/13288,8c57424eed53156ed923fdd2b0d0771c5434b94fe26d7a4059d0e7c3d62fdf38
review guidance,pr,13288,issue,13169,high,pr.reviews[0].body,I want to do what I propose [here](https://github.com/sqlalchemy/sqlalchemy/issues/13169#issuecomment-4060550530) which is dont hardcode time functions that are used in this way: 1. note that we also use `time.time()` in [queue.py](https://github.com/sqlalchemy/sqlalchemy/blob/1e1c0084b1804eaae8b...,https://github.com/sqlalchemy/sqlalchemy/pull/13288,1e629b87be6ee4d6ab61d0090073b42dd6c606882c4aea83bc473c018d6070e2
review guidance,pr,13288,issue,13169,high,pr.reviews[1].body,I want to do what I propose [here](https://github.com/sqlalchemy/sqlalchemy/issues/13169#issuecomment-4060550530) which is dont hardcode time functions that are used in this way: 1. note that we also use `time.time()` in [queue.py](https://github.com/sqlalchemy/sqlalchemy/blob/1e1c0084b1804eaae8b...,https://github.com/sqlalchemy/sqlalchemy/pull/13288#pullrequestreview-4272286345,034614219604809546b6a8c6fe067e592b2bcc56e19691521773dc880dc281c8
closes,pr,13051,issue,13049,high,pr.closingIssuesReferences,pr #13051 declares a closing reference to issue #13049.,https://github.com/sqlalchemy/sqlalchemy/pull/13051,8296eb26e053822e0c18c2112f3d163fed5226d70235e67e7acabac69f8bbc71
closes,pr,13051,issue,13049,high,pr.body,"y of your proposed changes in the Title field above --> ### Description Added the implementations for `func.avg()` and `func.abs()`. Fixes: #13049 ### Checklist <!-- go over following points. check them with an `x` if they do apply, (they turn into clickable checkboxes once th...",https://github.com/sqlalchemy/sqlalchemy/pull/13051,ea9c1f246306b0fdda1c9f870c4e45c3cbaed37c4c01fdc402a7929bcfe4fb0e
review guidance,pr,13051,issue,13049,high,pr.reviews[0].body,thanks for this PR! left a comment,https://github.com/sqlalchemy/sqlalchemy/pull/13051,215109921f274d828a2c85b0af75d7fb9a7558291632cc1b92053b4b19bb5741
review guidance,pr,13051,issue,13049,high,pr.reviews[2].body,"as mentioned, typing should use _N which is what we already use.",https://github.com/sqlalchemy/sqlalchemy/pull/13051,8d7aa309536d9cfddeca8cab740cbb4213d228b20af65d1b66ead45bfe8fd3c6
review guidance,pr,13051,issue,13049,high,pr.reviews[3].body,thanks for this PR! left a comment,https://github.com/sqlalchemy/sqlalchemy/pull/13051#pullrequestreview-3607132945,6a3f064d1989f77e485727daf0fd430d525aa1fe04a2cc343e92567e0935c116
review guidance,pr,13051,issue,13049,high,pr.reviews[5].body,"as mentioned, typing should use _N which is what we already use.",https://github.com/sqlalchemy/sqlalchemy/pull/13051#pullrequestreview-3651720620,0a81043da7dca5e7715ccd137ea4f249dcfb2df0695ba294ddc7fb7e1ce7c249
closes,pr,12731,issue,12730,high,pr.closingIssuesReferences,pr #12731 declares a closing reference to issue #12730.,https://github.com/sqlalchemy/sqlalchemy/pull/12731,c17183527255ba4f720da821dccb14da55fcbd5c8494cc497a5d1e5711cb67b6
closes,pr,12731,issue,12730,high,pr.body,"ic type checkers like mypy and pyright currently report type errors when `DeclarativeBase` subclasses are passed. This patch resolves issue #12730 by expanding `_ForUpdateOfArgument` to include `Type[DeclarativeBase]` (and sequences containing them), aligning type hints with a...",https://github.com/sqlalchemy/sqlalchemy/pull/12731,e229fd98e49f054148ab5435722fabad83c621fe920544b4d614f3b617e0c632
review guidance,pr,12731,issue,12730,high,pr.reviews[0].body,hey there- thanks for this! I've tested locally and this just needs `_FromClauseArgument`: ```diff diff --git a/lib/sqlalchemy/sql/selectable.py b/lib/sqlalchemy/sql/selectable.py index 349f18930..f1959db43 100644 --- a/lib/sqlalchemy/sql/selectable.py +++ b/lib/sqlalchemy/sql/selectable.py @@ -1...,https://github.com/sqlalchemy/sqlalchemy/pull/12731,56c8ec85735ed23467d565f5d613ad24aab1cfa7e7f520a300da83d0884d4f23
review guidance,pr,12731,issue,12730,high,pr.reviews[1].body,hey there- thanks for this! I've tested locally and this just needs `_FromClauseArgument`: ```diff diff --git a/lib/sqlalchemy/sql/selectable.py b/lib/sqlalchemy/sql/selectable.py index 349f18930..f1959db43 100644 --- a/lib/sqlalchemy/sql/selectable.py +++ b/lib/sqlalchemy/sql/selectable.py @@ -1...,https://github.com/sqlalchemy/sqlalchemy/pull/12731#pullrequestreview-3017449473,b5fbf78afc3f78ff8ff21c75ea242733df5c408bc830e371194f9f8d4d90f1a8
references,pr,12698,pr,12510,medium,pr.body,based on #12697 (and #12510).,https://github.com/sqlalchemy/sqlalchemy/pull/12698,232cd9216938ec810a70541aa8f419426435710dd808d572e3449e0f8408ea19
references,pr,12698,pr,12697,medium,pr.body,based on #12697 (and #12510).,https://github.com/sqlalchemy/sqlalchemy/pull/12698,0b2a92baa937c27559df7bf76905cd505d94c998f22708bc0a88cb19de5eed2a
closes,pr,12697,issue,9693,high,pr.closingIssuesReferences,pr #12697 declares a closing reference to issue #9693.,https://github.com/sqlalchemy/sqlalchemy/pull/12697,6ad913c6b5408fa917cf63634cb25f5f7b99da8efb09e080ce1f254dcd072f37
closes,pr,12697,issue,9693,high,pr.body,", allowing to create respective elements with a schema-qualified collation name. Reflection is also handled for both types and domains. Fix #9693.",https://github.com/sqlalchemy/sqlalchemy/pull/12697,7568b66fa6f05145a76f6b0f78a30169306acf6a79d063b36163097e858abdf2
references,pr,12697,pr,12510,medium,pr.comments[0].body,notes: - this is based on #12510 (first 4 commits) - ~~5th commit (related to reflection caching to avoid `JOIN`s) might be worth considering apart from this PR~~,https://github.com/sqlalchemy/sqlalchemy/pull/12697,76c8713ff6bf28f4aa811e36715d72931956a907fde08d5c13c5ab5ae245a78b
references,pr,12697,pr,12510,medium,pr.comments[1].body,Rebased (and changed according to the rework of https://github.com/sqlalchemy/sqlalchemy/pull/12510).,https://github.com/sqlalchemy/sqlalchemy/pull/12697,2291b31a947d6c5963ae2edd8d4b2d5ab477ede5648dac143dbcc017c79e281f
review guidance,pr,12697,issue,9693,high,pr.reviews[0].body,hi - I'm rethinking this change as this is way too much complexity dug into compiler.py for a feature that's postgresql specific. to keep things simple for this odd use case why dont we do just this patch: ```diff diff --git a/lib/sqlalchemy/sql/compiler.py b/lib/sqlalchemy/sql/compiler.py index...,https://github.com/sqlalchemy/sqlalchemy/pull/12697,106281129c4db320594bf973ba79a495c07cf8ca5c359742292f6e42b286b098
review guidance,pr,12697,issue,9693,high,pr.reviews[1].body,hi - I'm rethinking this change as this is way too much complexity dug into compiler.py for a feature that's postgresql specific. to keep things simple for this odd use case why dont we do just this patch: ```diff diff --git a/lib/sqlalchemy/sql/compiler.py b/lib/sqlalchemy/sql/compiler.py index...,https://github.com/sqlalchemy/sqlalchemy/pull/12697#pullrequestreview-3557561271,f95b978a7d53659c15a5827c99fc06a803faa21725729d78f099e27c8fce3a94
references,pr,12433,issue,6274,medium,pr.body,"Fixes issue #6274 ### Description When `aliased()` is used on a select statement or compound select statement, it currently throws an error. The proposed sol",https://github.com/sqlalchemy/sqlalchemy/pull/12433,a6043e5b084ea7213ce5b4a20394e98ce68739aa6722af1b2a64528beb92d0d4
references,pr,12433,issue,10236,medium,pr.reviews[5].body,"OK we changed from coercion + warning to raise in #10236. So this PR needs to have a separate version for main vs. 2.0. in main, these test should expect a raise. in 2.0, we need to use expect_dep",https://github.com/sqlalchemy/sqlalchemy/pull/12433,be4783aeedcbceaa93d76f4042450f287e78ea9529277a79765f3f86c65ca58b
references,pr,12433,issue,6274,medium,pr.review_comments[4].body,"the coercion itself does the subquery() call. I tested the above patch with the original case at #6274, and if it is not working for an additional case here then I'd want to add that support to coercions, I can do that if you show me the fail",https://github.com/sqlalchemy/sqlalchemy/pull/12433,15dcc976ac9401a3c08978f9ee24a77bbed83ca065cafb0713c743c552cd9035
review guidance,pr,12433,issue,6274,high,pr.reviews[0].body,"great job. I think we can simplify the fix and also add some more test support, see inline comments",https://github.com/sqlalchemy/sqlalchemy/pull/12433,618106bb26e2d2c8a59f334ce2dfdb99946934fb87e767763a55b5b71a7f375a
review guidance,pr,12433,issue,6274,high,pr.reviews[2].body,"I would prefer just go to the ""raise informative error"" step without passing to the deprecation step, since we had an uninformative error already",https://github.com/sqlalchemy/sqlalchemy/pull/12433,92bb9b6766a9d1cf67f5dd687942dce25ce78718d291a6de879bcacf10231915
review guidance,pr,12433,issue,6274,high,pr.reviews[5].body,"OK we changed from coercion + warning to raise in #10236. So this PR needs to have a separate version for main vs. 2.0. in main, these test should expect a raise. in 2.0, we need to use expect_deprecated. the tests themselves should be in test/orm/test_deprecated.py. @CaselIT this is getting comp...",https://github.com/sqlalchemy/sqlalchemy/pull/12433,a906dc861a53fc153b704230ccb8fc8e9f1d67a882d47d291ebb6a1bf6fc076f
review guidance,pr,12433,issue,6274,high,pr.reviews[6].body,"great job. I think we can simplify the fix and also add some more test support, see inline comments",https://github.com/sqlalchemy/sqlalchemy/pull/12433#pullrequestreview-2685806442,615828423a21c42b277e21c821ff87c7b3c086d6216077a9d36d2e8517b4c8a8
review guidance,pr,12433,issue,6274,high,pr.reviews[8].body,"I would prefer just go to the ""raise informative error"" step without passing to the deprecation step, since we had an uninformative error already",https://github.com/sqlalchemy/sqlalchemy/pull/12433#pullrequestreview-2686673482,1746be3bfdfb654da33a2e2a90747a0339c0fd7863e983932bdc19a962eeea42
review guidance,pr,12433,issue,6274,high,pr.reviews[11].body,"OK we changed from coercion + warning to raise in #10236. So this PR needs to have a separate version for main vs. 2.0. in main, these test should expect a raise. in 2.0, we need to use expect_deprecated. the tests themselves should be in test/orm/test_deprecated.py. @CaselIT this is getting comp...",https://github.com/sqlalchemy/sqlalchemy/pull/12433#pullrequestreview-2687772991,655f3a1e51d8062c1ccd667b5fd9858dfd26c8455495bb820a2babd706496cc9
closes,pr,12401,issue,12398,high,pr.closingIssuesReferences,pr #12401 declares a closing reference to issue #12398.,https://github.com/sqlalchemy/sqlalchemy/pull/12401,4c9a5a64cb5f8dc9b94a0a8bede1c083ca75593faced90fefd600e43bdbdd012
closes,pr,12401,issue,12398,high,pr.body,Fixes: #12398 This PR makes the error message on conflicting loader strategies more verbose to help with debugging <!-- Provide a general summary of your,https://github.com/sqlalchemy/sqlalchemy/pull/12401,b7279e34ea3ab3503ab8ad66349209d97948f3f9edb95d622678329dadde0dcd
closes,pr,12297,issue,11620,high,pr.closingIssuesReferences,pr #12297 declares a closing reference to issue #11620.,https://github.com/sqlalchemy/sqlalchemy/pull/12297,043571e960c8828f438cf04708dcd5383cbda40802f61e7bb12aab7883794475
closes,pr,12297,issue,11620,high,pr.body,Fixes: #11620 ### Description - Refactored method in to improve readability and maintainability: - Extracted identity insert logic into helper methods: -,https://github.com/sqlalchemy/sqlalchemy/pull/12297,8bc6c6d54ef445c8a52d8ad581814597a5ccb1d95caf0a6601286639c1699cf8
review guidance,pr,12297,issue,11620,high,pr.reviews[0].body,"Thanks for the PR, I've left a few comments. Could you also add a changelog file, see https://github.com/sqlalchemy/sqlalchemy/tree/main/doc/build/changelog/unreleased_21 for examples. the number refer to the issue. Also it would be nice to have some tests. the existing ones are here https://gith...",https://github.com/sqlalchemy/sqlalchemy/pull/12297,26fb898f07d357e15d0d68a911755bb744e3989add46ca2aed748db3b606a39c
review guidance,pr,12297,issue,11620,high,pr.reviews[1].body,"OK, this is **sqla-tester** setting up my work on behalf of **zzzeek** to try to get revision d25b6e47f76dc837a049b4de53871b939ef9578c of this pull request into gerrit so we can run tests and reviews and stuff",https://github.com/sqlalchemy/sqlalchemy/pull/12297,b71ec20301d369af35dac1faa5b06e3851d6d94dacd2b8b65028ac82a51db758
review guidance,pr,12297,issue,11620,high,pr.reviews[2].body,"Thanks for the PR, I've left a few comments. Could you also add a changelog file, see https://github.com/sqlalchemy/sqlalchemy/tree/main/doc/build/changelog/unreleased_21 for examples. the number refer to the issue. Also it would be nice to have some tests. the existing ones are here https://gith...",https://github.com/sqlalchemy/sqlalchemy/pull/12297#pullrequestreview-2596953227,cb3b2c76c2f2547e68976dfed793aa26ba2a31aac6ca3c67a3c823f633b8c4d7
review guidance,pr,12297,issue,11620,high,pr.reviews[3].body,"OK, this is **sqla-tester** setting up my work on behalf of **zzzeek** to try to get revision d25b6e47f76dc837a049b4de53871b939ef9578c of this pull request into gerrit so we can run tests and reviews and stuff",https://github.com/sqlalchemy/sqlalchemy/pull/12297#pullrequestreview-2694502392,dfd7fd923ec6f6dcd2fd1986f7e15347b290279619da78686a3890a7c2ac12dd
review guidance,pr,11437,pr,11437,high,pr.reviews[0].body,"thanks for this! unfortunately I'm -1 on the automation steps being added here, these detract from the clarity of the examples and I'd rather keep the amount of source code presented to the user at an absolute minimum",https://github.com/sqlalchemy/sqlalchemy/pull/11437,8bc3213f7521ee65c1241e2b9aaf3b064c6d1f347b99faeba5be0ee0c8cccd98
review guidance,pr,11437,pr,11437,high,pr.reviews[6].body,"thanks for this! unfortunately I'm -1 on the automation steps being added here, these detract from the clarity of the examples and I'd rather keep the amount of source code presented to the user at an absolute minimum",https://github.com/sqlalchemy/sqlalchemy/pull/11437#pullrequestreview-2231815529,ea401a2a23439046765c6914c1f2e1d6cb172231bacf2768c41ec8de2603d4fa
closes,pr,11296,issue,11122,high,pr.closingIssuesReferences,pr #11296 declares a closing reference to issue #11122.,https://github.com/sqlalchemy/sqlalchemy/pull/11296,600c58e08711aacbc2bc631aeef9d4c1a59e5a8185d1de870b2941eba26f73b6
closes,pr,11296,issue,11122,high,pr.body,"y to specify storage parameters via with + fix for specifying index storage parameters (should it be split into two different PRs?). Fixes: #11122 ### Checklist <!-- go over following points. check them with an `x` if they do apply, (they turn into clickable checkboxes once th...",https://github.com/sqlalchemy/sqlalchemy/pull/11296,e9414d356a5b331d1688f7bbd6dd594e78379f710182350b2bf4d261c824541d
review guidance,pr,11296,issue,11122,high,pr.reviews[0].body,"Thanks for the change, I'm not sure about changing how the values are compiled since that's potentially a breaking change",https://github.com/sqlalchemy/sqlalchemy/pull/11296,36d58b39fc07dff029f83153fa6615b93cc7dd5a4ea766b12e897490590100fb
review guidance,pr,11296,issue,11122,high,pr.reviews[5].body,"We are looking to support lots more keywords here, with different kinds of expectations, we either have to look at the type of value and format exactly as would be seen in the examples at https://www.postgresql.org/docs/current/sql-createindex.html or we need to (and I might prefer this) build up...",https://github.com/sqlalchemy/sqlalchemy/pull/11296,40399bc4a82d8ce4233fee09a8b8ef06fe4a994e0e941abf5d8e84e9f612ccae
review guidance,pr,11296,issue,11122,high,pr.reviews[7].body,"Thanks for the change, I'm not sure about changing how the values are compiled since that's potentially a breaking change",https://github.com/sqlalchemy/sqlalchemy/pull/11296#pullrequestreview-2013144990,2c68aef18a72efbf791fd4ef02d3256f2063dacd2ff91349514a7374024056d2
review guidance,pr,11296,issue,11122,high,pr.reviews[12].body,"We are looking to support lots more keywords here, with different kinds of expectations, we either have to look at the type of value and format exactly as would be seen in the examples at https://www.postgresql.org/docs/current/sql-createindex.html or we need to (and I might prefer this) build up...",https://github.com/sqlalchemy/sqlalchemy/pull/11296#pullrequestreview-2028440250,266f31d8802d1171d68d6b2c1c78e0c6bb4a0545f2ab0654a9d247016565ae54
review guidance,pr,11107,pr,11107,high,pr.reviews[0].body,the migration to 2.0 is still using `session.query()` so is not fully migrated,https://github.com/sqlalchemy/sqlalchemy/pull/11107,4bf559f272ccf5b493a89f9228edc17ea8951bb0884d5712cc3a26a6b4edcdc5
review guidance,pr,11107,pr,11107,high,pr.reviews[3].body,the migration to 2.0 is still using `session.query()` so is not fully migrated,https://github.com/sqlalchemy/sqlalchemy/pull/11107#pullrequestreview-1918149959,62d18577d3016fd9e9e393cddf4cc694226f299b0336b519f83aa6f8ac155dd2
references,pr,10574,issue,2943,medium,pr.body,"Applied the patch mentioned in #2943, to allow overriding the validates method of a given Model, Added tests for same in test_validators. If a Child class overrides the parent",https://github.com/sqlalchemy/sqlalchemy/pull/10574,c0314c3a17ab3c872455c14cdfa0ed35a47deb409a5d11d84d29fd50d2796331
review guidance,pr,10574,issue,2943,high,pr.reviews[0].body,"OK, this is **sqla-tester** setting up my work on behalf of **zzzeek** to try to get revision d310bef35b0ac3e5b840842b62807fc4008fd086 of this pull request into gerrit so we can run tests and reviews and stuff",https://github.com/sqlalchemy/sqlalchemy/pull/10574,d0691ef6409933f386ff753171067452e920d2a4bf551fbb55e05fa3e53b550a
review guidance,pr,10574,issue,2943,high,pr.reviews[1].body,**Federico Caselli** (CaselIT) wrote: left some style suggestions View this in Gerrit at https://gerrit.sqlalchemy.org/c/sqlalchemy/sqlalchemy/+/4919,https://github.com/sqlalchemy/sqlalchemy/pull/10574,f56958eb8bac05cab420ac8068907262d7b673196314321a645540c5de7c9e86
review guidance,pr,10574,issue,2943,high,pr.reviews[3].body,"OK, this is **sqla-tester** setting up my work on behalf of **zzzeek** to try to get revision d310bef35b0ac3e5b840842b62807fc4008fd086 of this pull request into gerrit so we can run tests and reviews and stuff",https://github.com/sqlalchemy/sqlalchemy/pull/10574#pullrequestreview-1708721232,a3f112d396eb4b2d276ccb3e0a1ab3172ce74d475f3b012e606e112095289d22
review guidance,pr,10574,issue,2943,high,pr.reviews[4].body,**Federico Caselli** (CaselIT) wrote: left some style suggestions View this in Gerrit at https://gerrit.sqlalchemy.org/c/sqlalchemy/sqlalchemy/+/4919,https://github.com/sqlalchemy/sqlalchemy/pull/10574#pullrequestreview-1708876440,75068b61bec8978213ddbeb73a0e10db6a3009891a87e526144c1ba77e2d4154
references,pr,8136,issue,7659,medium,pr.body,"### Description The goal of this PR is to add tools that help with contributing to documentation, from discussion started on #7659. Goals include: - Automatic formatting of code blocks in .rst documents and in docstrings (blacken-docs) - Flake8 validation of these code",https://github.com/sqlalchemy/sqlalchemy/pull/8136,79b50572444e2972d12ad64f490a84a4bcb6646fc724b96244836c623a8531ad
closes,pr,13200,issue,13157,high,pr.closingIssuesReferences,pr #13200 declares a closing reference to issue #13157.,https://github.com/sqlalchemy/sqlalchemy/pull/13200,2d5532568dd7bf869b759163bd4efe7cf811e830cacd058a6ba4c5de36caf790
closes,pr,13200,issue,13157,high,pr.body,"verified: - `((a > 1) AND (a < 5))` → `(a > 1) AND (a < 5)` ✅ - `(a > 1)` → `a > 1` ✅ - `a > 1` → `a > 1` (no parens, unchanged) ✅ Closes: #13157",https://github.com/sqlalchemy/sqlalchemy/pull/13200,8e4b04105caf6e92158b164cdad454b047b3e0386c44c35b8b90922423aeac72
review guidance,pr,13200,issue,13157,high,pr.reviews[0].body,"Hi, This does not take into consideration string literals and has no tests. I've looked around and there is already some piece of code that does this: https://github.com/sqlalchemy/sqlalchemy/blob/a49a4f021ad9c9ff69f5482881b00f831d523a22/lib/sqlalchemy/dialects/sqlite/base.py#L2880-L2902 So the p...",https://github.com/sqlalchemy/sqlalchemy/pull/13200,7d26c3f0511c21954f29a0f147e15ca128b4a597234b47dbaabf00898140b45f
review guidance,pr,13200,issue,13157,high,pr.reviews[1].body,"Hi, This does not take into consideration string literals and has no tests. I've looked around and there is already some piece of code that does this: https://github.com/sqlalchemy/sqlalchemy/blob/a49a4f021ad9c9ff69f5482881b00f831d523a22/lib/sqlalchemy/dialects/sqlite/base.py#L2880-L2902 So the p...",https://github.com/sqlalchemy/sqlalchemy/pull/13200#pullrequestreview-4022937474,8e09c6f2087f7c4ecc7461f43ed1a5b5ebe147ca9c0d54a7474f9def9ad05e83
closes,pr,13188,issue,13157,high,pr.closingIssuesReferences,pr #13188 declares a closing reference to issue #13157.,https://github.com/sqlalchemy/sqlalchemy/pull/13188,88f9999d326046e2636a8a268deba107254360fcb3a9539f26663ee0863a8550
closes,pr,13188,issue,13157,high,pr.body,"## Summary Fixes #13157. **Root cause:** Check constraint reflection naively stripped one pair of outer parentheses, corrupting compound expressions where the firs",https://github.com/sqlalchemy/sqlalchemy/pull/13188,2ad7b32276ed41dc4d0eeb224b0c81e6155d340c223f24be17591e415ca397c5
references,pr,12707,issue,6810,medium,pr.body,"<html><head></head><body> <hr> <h2>✅ typing: improve type coverage in <code inline="""">sqlalchemy.sql.base</code> for issue #6810</h2> <h3>Overview</h3> <p>This pull request enhances the type coverage of the <code inline="""">sqlalchemy.sql.base</code> module as part of",https://github.com/sqlalchemy/sqlalchemy/pull/12707,54c9198704734d4ac78787cbb1ef63ab09a9e8fc3964dc782c65b59f1911a231
review guidance,pr,12707,issue,6810,high,pr.reviews[0].body,"great work. I've left some comments but the general code is great, thanks",https://github.com/sqlalchemy/sqlalchemy/pull/12707,2d390b9dcb809aae3ca57cc60982299cc3e6948d6d4f90cc1d1d449ab5f90eae
review guidance,pr,12707,issue,6810,high,pr.reviews[14].body,"OK, this is **sqla-tester** setting up my work on behalf of **CaselIT** to try to get revision 7374212dfc88a43f381f8380d9b4ac193f5ed10b of this pull request into gerrit so we can run tests and reviews and stuff",https://github.com/sqlalchemy/sqlalchemy/pull/12707,22807f8d076f491f6cca7fcf1f831345aac4d43fa0e2ad695e988d58d394511f
review guidance,pr,12707,issue,6810,high,pr.reviews[15].body,"great work. I've left some comments but the general code is great, thanks",https://github.com/sqlalchemy/sqlalchemy/pull/12707#pullrequestreview-3012919139,afd7d27e18f8c25a1a9ff16cf677885dc66305296a184faec657f9ec4770f167
review guidance,pr,12707,issue,6810,high,pr.reviews[29].body,"OK, this is **sqla-tester** setting up my work on behalf of **CaselIT** to try to get revision 7374212dfc88a43f381f8380d9b4ac193f5ed10b of this pull request into gerrit so we can run tests and reviews and stuff",https://github.com/sqlalchemy/sqlalchemy/pull/12707#pullrequestreview-3017531922,a594d95e326a0d2489b9f8c0454aaf4f4fa1a479b75d3144826281c2ba869eaf
references,pr,12510,issue,6511,medium,pr.body,"hand, if the column collation matches the one of the database but is explicitly set at column creation, the value is reflected. Related to #6511.",https://github.com/sqlalchemy/sqlalchemy/pull/12510,23e07a9efe71a5a4c70ea4be57b4f944670710e765840d83c6ef8d6287fa5ec3
review guidance,pr,12510,issue,6511,high,pr.reviews[0].body,"OK, this is **sqla-tester** setting up my work on behalf of **CaselIT** to try to get revision baf48b55ee59874836c97607abfdfbf4f79fce4b of this pull request into gerrit so we can run tests and reviews and stuff",https://github.com/sqlalchemy/sqlalchemy/pull/12510,5f970d9ae6d0f96c96619b3b89b047d972b0e7b2da2481da3bb5f08386d2fd7f
review guidance,pr,12510,issue,6511,high,pr.reviews[1].body,**Federico Caselli** (CaselIT) wrote: code review left on gerrit View this in Gerrit at https://gerrit.sqlalchemy.org/c/sqlalchemy/sqlalchemy/+/5993,https://github.com/sqlalchemy/sqlalchemy/pull/12510,845cdb33cd26c82885fa3b2938c4068c56cfc725816dfbbda8b2606b10d512d7
review guidance,pr,12510,issue,6511,high,pr.reviews[2].body,"OK, this is **sqla-tester** setting up my work on behalf of **CaselIT** to try to get revision 62d03e71db4c459d49043a2e45e88f6489a02e77 of this pull request into gerrit so we can run tests and reviews and stuff",https://github.com/sqlalchemy/sqlalchemy/pull/12510,9987f4e0642fae180f3a99314e5ab5fc8d5c479bdd0d84b59748331a84b7c25b
review guidance,pr,12510,issue,6511,high,pr.reviews[3].body,"OK, this is **sqla-tester** setting up my work on behalf of **CaselIT** to try to get revision c6ba75fe4ceb67a2636ffc2c432c7ce366ac0e9a of this pull request into gerrit so we can run tests and reviews and stuff",https://github.com/sqlalchemy/sqlalchemy/pull/12510,23aa12a365d466a7db2bede6ecbf59276745a99fabca5b0377c05d8f1b26565c
review guidance,pr,12510,issue,6511,high,pr.reviews[5].body,**Denis Laxalde** (dlax) wrote: code review left on gerrit View this in Gerrit at https://gerrit.sqlalchemy.org/c/sqlalchemy/sqlalchemy/+/5993 * lib/sqlalchemy/dialects/postgresql/base.py (line 3805): Done,https://github.com/sqlalchemy/sqlalchemy/pull/12510,70153ea46fc08adb2c91791febe3773bdba066c149cdd70dd66a0b84e838e6ec
review guidance,pr,12510,issue,6511,high,pr.reviews[6].body,"OK, this is **sqla-tester** setting up my work on behalf of **CaselIT** to try to get revision 4735f0ef65b4070abaab4f0632f691535803b7fd of this pull request into gerrit so we can run tests and reviews and stuff",https://github.com/sqlalchemy/sqlalchemy/pull/12510,a4c8c080e6808acf52f6cc50659de227079a204692192e240f910a20668b2873
review guidance,pr,12510,issue,6511,high,pr.reviews[10].body,"Hi, this is **sqla-tester** and I see you've pinged me for review. However, user **dlax** is not authorized to initiate CI jobs. Please wait for a project member to do this!",https://github.com/sqlalchemy/sqlalchemy/pull/12510,28226ade929d1ed8b10feaeca1dc9a86ad60bed38eb453852f93bb7e674215b5
review guidance,pr,12510,issue,6511,high,pr.reviews[12].body,"OK, this is **sqla-tester** setting up my work on behalf of **CaselIT** to try to get revision 896aa73356c7f5fb02d63f83c52ea1f45e7d3bd0 of this pull request into gerrit so we can run tests and reviews and stuff",https://github.com/sqlalchemy/sqlalchemy/pull/12510,56b6322602267817db5063cad9f9275eee1f70635b32018c48fc464cda9adfd0
review guidance,pr,12510,issue,6511,high,pr.reviews[13].body,"OK, this is **sqla-tester** setting up my work on behalf of **CaselIT** to try to get revision 4c2ba7349824fdacc26c35d36f8b95cf3a35c99a of this pull request into gerrit so we can run tests and reviews and stuff",https://github.com/sqlalchemy/sqlalchemy/pull/12510,92e6ee8731f1a4702e8987179950fc639a6a48a452b4e35b8663b1f9455f8565
review guidance,pr,12510,issue,6511,high,pr.reviews[14].body,"OK, this is **sqla-tester** setting up my work on behalf of **CaselIT** to try to get revision c0a390314eb8ff2a4f729babf25cb052b6268d0a of this pull request into gerrit so we can run tests and reviews and stuff",https://github.com/sqlalchemy/sqlalchemy/pull/12510,ab9259ccee23883acf95a9f755a68b715c5463a273f68d15d8b615471c530bf2
review guidance,pr,12510,issue,6511,high,pr.reviews[15].body,"**Federico Caselli** (CaselIT) wrote: gonna finish this one, thanks for the effort and sorry for the delay in getting to this View this in Gerrit at https://gerrit.sqlalchemy.org/c/sqlalchemy/sqlalchemy/+/5993 * lib/sqlalchemy/testing/requirements.py (line 695): should be closed",https://github.com/sqlalchemy/sqlalchemy/pull/12510,0551dd69e2cc7f1178968da00b7199f3c90861bd3eead3aa0945013168d45c91
review guidance,pr,12510,issue,6511,high,pr.reviews[16].body,**Federico Caselli** (CaselIT) wrote: In the end using a case on a scalar subquery seem to have adequate performance without requiring a separate query View this in Gerrit at https://gerrit.sqlalchemy.org/c/sqlalchemy/sqlalchemy/+/5993 * lib/sqlalchemy/testing/requirements.py (line 695): Done,https://github.com/sqlalchemy/sqlalchemy/pull/12510,195e40de9ee664bf80f78ddac9677eac2d649285ba9ee17b8843da47b1ee8d58
review guidance,pr,12510,issue,6511,high,pr.reviews[17].body,**Michael Bayer** (zzzeek) wrote: the new requirement was added to the publicly exported requirements so we should probably add a test to testing/suite/test_reflection.py also View this in Gerrit at https://gerrit.sqlalchemy.org/c/sqlalchemy/sqlalchemy/+/5993,https://github.com/sqlalchemy/sqlalchemy/pull/12510,a39c4b75d66f7dc228e4b33250327a711897801094cffd75bc43e7b2de55c821
review guidance,pr,12510,issue,6511,high,pr.reviews[20].body,**Michael Bayer** (zzzeek) wrote: code review left on gerrit View this in Gerrit at https://gerrit.sqlalchemy.org/c/sqlalchemy/sqlalchemy/+/5993,https://github.com/sqlalchemy/sqlalchemy/pull/12510,440e95e56e135d38d5e22ccb7a79428ceb93f7037a361f90aac78a875e559dfb
review guidance,pr,12510,issue,6511,high,pr.reviews[21].body,"OK, this is **sqla-tester** setting up my work on behalf of **CaselIT** to try to get revision baf48b55ee59874836c97607abfdfbf4f79fce4b of this pull request into gerrit so we can run tests and reviews and stuff",https://github.com/sqlalchemy/sqlalchemy/pull/12510#pullrequestreview-2940813344,26a63acab6be8cf41a66d9286d90bb2582321635944258047ca26bc83cf6e440
review guidance,pr,12510,issue,6511,high,pr.reviews[22].body,**Federico Caselli** (CaselIT) wrote: code review left on gerrit View this in Gerrit at https://gerrit.sqlalchemy.org/c/sqlalchemy/sqlalchemy/+/5993,https://github.com/sqlalchemy/sqlalchemy/pull/12510#pullrequestreview-2940816470,f8b939b4cd256a9e780289758d571846ee366a6c05c6438288ab461ec9ced9f6
review guidance,pr,12510,issue,6511,high,pr.reviews[23].body,"OK, this is **sqla-tester** setting up my work on behalf of **CaselIT** to try to get revision 62d03e71db4c459d49043a2e45e88f6489a02e77 of this pull request into gerrit so we can run tests and reviews and stuff",https://github.com/sqlalchemy/sqlalchemy/pull/12510#pullrequestreview-2946210674,f45829c9b9bdc7ec0a32f57733a532645111151eae1429909fad2f13fc86793f
review guidance,pr,12510,issue,6511,high,pr.reviews[24].body,"OK, this is **sqla-tester** setting up my work on behalf of **CaselIT** to try to get revision c6ba75fe4ceb67a2636ffc2c432c7ce366ac0e9a of this pull request into gerrit so we can run tests and reviews and stuff",https://github.com/sqlalchemy/sqlalchemy/pull/12510#pullrequestreview-2949167906,cd83385f422d30a3d90aad5fbdc8ed6e4e34916f4a0b2ea24e52274e31db8eea
review guidance,pr,12510,issue,6511,high,pr.reviews[26].body,**Denis Laxalde** (dlax) wrote: code review left on gerrit View this in Gerrit at https://gerrit.sqlalchemy.org/c/sqlalchemy/sqlalchemy/+/5993 * lib/sqlalchemy/dialects/postgresql/base.py (line 3805): Done,https://github.com/sqlalchemy/sqlalchemy/pull/12510#pullrequestreview-2965386418,762a71c9eaf2cbbe2f05d5d2842d908de2a65c04224f37136b62894f67993b1e
review guidance,pr,12510,issue,6511,high,pr.reviews[27].body,"OK, this is **sqla-tester** setting up my work on behalf of **CaselIT** to try to get revision 4735f0ef65b4070abaab4f0632f691535803b7fd of this pull request into gerrit so we can run tests and reviews and stuff",https://github.com/sqlalchemy/sqlalchemy/pull/12510#pullrequestreview-2966610153,d2af5caa767ba519d872ccac0ed37ba7ef8abfcd00f181a012da5192e97c726c
review guidance,pr,12510,issue,6511,high,pr.reviews[31].body,"Hi, this is **sqla-tester** and I see you've pinged me for review. However, user **dlax** is not authorized to initiate CI jobs. Please wait for a project member to do this!",https://github.com/sqlalchemy/sqlalchemy/pull/12510#pullrequestreview-2968526196,4369370d1efbf5823cdf648679278edf0fb0866b0b09dd3590ba302d27c9c9a9
review guidance,pr,12510,issue,6511,high,pr.reviews[33].body,"OK, this is **sqla-tester** setting up my work on behalf of **CaselIT** to try to get revision 896aa73356c7f5fb02d63f83c52ea1f45e7d3bd0 of this pull request into gerrit so we can run tests and reviews and stuff",https://github.com/sqlalchemy/sqlalchemy/pull/12510#pullrequestreview-3019999799,8f8f7a9bd815f75be29bac5f26ab6d70e7dc373a3d11ac95f7716b0d3829102f
review guidance,pr,12510,issue,6511,high,pr.reviews[34].body,"OK, this is **sqla-tester** setting up my work on behalf of **CaselIT** to try to get revision 4c2ba7349824fdacc26c35d36f8b95cf3a35c99a of this pull request into gerrit so we can run tests and reviews and stuff",https://github.com/sqlalchemy/sqlalchemy/pull/12510#pullrequestreview-3020360370,ab57cafe77e2e6078ccf3be3a8972a2f31cd869dd42e4da5fca69404ae1096c8
review guidance,pr,12510,issue,6511,high,pr.reviews[35].body,"OK, this is **sqla-tester** setting up my work on behalf of **CaselIT** to try to get revision c0a390314eb8ff2a4f729babf25cb052b6268d0a of this pull request into gerrit so we can run tests and reviews and stuff",https://github.com/sqlalchemy/sqlalchemy/pull/12510#pullrequestreview-3053027121,3e8a2a69581f23b69f3f18a0f63ddcfc60a5c09923b65c623071a26a15c300ec
review guidance,pr,12510,issue,6511,high,pr.reviews[36].body,"**Federico Caselli** (CaselIT) wrote: gonna finish this one, thanks for the effort and sorry for the delay in getting to this View this in Gerrit at https://gerrit.sqlalchemy.org/c/sqlalchemy/sqlalchemy/+/5993 * lib/sqlalchemy/testing/requirements.py (line 695): should be closed",https://github.com/sqlalchemy/sqlalchemy/pull/12510#pullrequestreview-3325814121,93e51b48f02f9110888ca863c137079ef57392dcda1a813ba45124ec36b04d2b
review guidance,pr,12510,issue,6511,high,pr.reviews[37].body,**Federico Caselli** (CaselIT) wrote: In the end using a case on a scalar subquery seem to have adequate performance without requiring a separate query View this in Gerrit at https://gerrit.sqlalchemy.org/c/sqlalchemy/sqlalchemy/+/5993 * lib/sqlalchemy/testing/requirements.py (line 695): Done,https://github.com/sqlalchemy/sqlalchemy/pull/12510#pullrequestreview-3325840535,dd6c313bff045dedde259b4db6504a67a5d2354639866ff356b7c59d64e9fa49
review guidance,pr,12510,issue,6511,high,pr.reviews[38].body,**Michael Bayer** (zzzeek) wrote: the new requirement was added to the publicly exported requirements so we should probably add a test to testing/suite/test_reflection.py also View this in Gerrit at https://gerrit.sqlalchemy.org/c/sqlalchemy/sqlalchemy/+/5993,https://github.com/sqlalchemy/sqlalchemy/pull/12510#pullrequestreview-3331605893,30a511fab70441df16cd920427fdebf2f883afb5a7e85902a9d574180a801fb8
review guidance,pr,12510,issue,6511,high,pr.reviews[41].body,**Michael Bayer** (zzzeek) wrote: code review left on gerrit View this in Gerrit at https://gerrit.sqlalchemy.org/c/sqlalchemy/sqlalchemy/+/5993,https://github.com/sqlalchemy/sqlalchemy/pull/12510#pullrequestreview-3335653916,b57183a1dbc33ee93e38f3ca878a08bc0ec1947d8cf6f842f9873fd6243757bd
references,pr,12384,issue,6810,medium,pr.body,.Any` by the `Any()` function through aliasing as `typing_Any` and removed unused `_type_tuple` attribute of `postgresql.array`. Related to #6810,https://github.com/sqlalchemy/sqlalchemy/pull/12384,fdca1fce9ef0fc97d5bd7c6d78b3a49fa03bf93e2eaec38c80da654f76b4a179
review guidance,pr,12384,issue,6810,high,pr.reviews[2].body,"Thanks, left a few suggestion. I think to do a better job the base array type should also be typed. let us know if you want to do this or if you prefer we take this over",https://github.com/sqlalchemy/sqlalchemy/pull/12384,ade517d45111d30465c69b4c2559ab5746681d13d467311c9b1f26f2827ba94b
review guidance,pr,12384,issue,6810,high,pr.reviews[9].body,"OK, this is **sqla-tester** setting up my work on behalf of **CaselIT** to try to get revision 78eea29f1de850afda036502974521969629de7e of this pull request into gerrit so we can run tests and reviews and stuff",https://github.com/sqlalchemy/sqlalchemy/pull/12384,f9621add2fec6c11c5652c760eef1e23526efdc9dd4be2369d79d06ed732311d
review guidance,pr,12384,issue,6810,high,pr.reviews[12].body,"Thanks, left a few suggestion. I think to do a better job the base array type should also be typed. let us know if you want to do this or if you prefer we take this over",https://github.com/sqlalchemy/sqlalchemy/pull/12384#pullrequestreview-2652402346,0f9e175574c0446b14716e36f977dc7749d4cfd2ceb535fb3de2d287c8fb2df6
review guidance,pr,12384,issue,6810,high,pr.reviews[19].body,"OK, this is **sqla-tester** setting up my work on behalf of **CaselIT** to try to get revision 78eea29f1de850afda036502974521969629de7e of this pull request into gerrit so we can run tests and reviews and stuff",https://github.com/sqlalchemy/sqlalchemy/pull/12384#pullrequestreview-2686824383,0d25dc8667389cf90ec838862ea68a5e1e31d5670953e62765459c52b90e0844
closes,pr,11678,issue,11677,high,pr.closingIssuesReferences,pr #11678 declares a closing reference to issue #11677.,https://github.com/sqlalchemy/sqlalchemy/pull/11678,2bf3fe6bd7f135a857af3bb505ec075ef532c3cb21b0fb515215ec6f52863473
closes,pr,11678,issue,11677,high,pr.body,"vide a general summary of your proposed changes in the Title field above --> ### Description <!-- Describe your changes in detail --> Fixes #11677 Changed Constraint matching regex to lazily match any character including newlines, and adding a stricter ending to the regex to e...",https://github.com/sqlalchemy/sqlalchemy/pull/11678,66b134b7d42d5cb62b98c78a5901608a6f2a354a22557f18f5193e66501f3840
review guidance,pr,11678,issue,11677,high,pr.reviews[0].body,Thanks for the great start. Tests are defined in this test class: https://github.com/sqlalchemy/sqlalchemy/blob/3ba2d1c7caba6a2df0445bb7e00366ff43961f6d/test/dialect/test_sqlite.py#L1724,https://github.com/sqlalchemy/sqlalchemy/pull/11678,931ff275ee3bfaf49ad5060c0981e793ffdd2a2d0e76563717d441b53c214ea1
review guidance,pr,11678,issue,11677,high,pr.reviews[1].body,Thanks for the great start. Tests are defined in this test class: https://github.com/sqlalchemy/sqlalchemy/blob/3ba2d1c7caba6a2df0445bb7e00366ff43961f6d/test/dialect/test_sqlite.py#L1724,https://github.com/sqlalchemy/sqlalchemy/pull/11678#pullrequestreview-2213211046,f8d7a69e5dd25a695871b411c9170ec685a1770f735b19803b19a68b645df9e3
closes,pr,10545,issue,10544,high,pr.closingIssuesReferences,pr #10545 declares a closing reference to issue #10544.,https://github.com/sqlalchemy/sqlalchemy/pull/10545,ba87e31fe032ad5dc2b054c66139dbc041b9c6242e7e49f1b1a19c00160751da
closes,pr,10545,issue,10544,high,pr.body,<!-- Provide a general summary of your proposed changes in the Title field above --> to fix the pysqlcipher broken usage in 2.0.22 with pysqlcipher3 new master ### Description issue fix : https://github.com/sqlalchemy/sqlalchemy/issues/10544 ### Checklist <!-- go over followin...,https://github.com/sqlalchemy/sqlalchemy/pull/10545,129ebef129f1272e57fd2e5c69107012e1b7ad54cef06fbd86dc068bdcc339e2
review guidance,pr,10545,issue,10544,high,pr.reviews[0].body,hi - we cant hardcode arbitrary driver names here. please use this patch ```diff diff --git a/lib/sqlalchemy/dialects/sqlite/pysqlcipher.py b/lib/sqlalchemy/dialects/sqlite/pysqlcipher.py index 28b900ea53..3b31400ef8 100644 --- a/lib/sqlalchemy/dialects/sqlite/pysqlcipher.py +++ b/lib/sqlalchemy/...,https://github.com/sqlalchemy/sqlalchemy/pull/10545,dbb9b533b86fbabb26f0110302407ed0f7c089883b985606c5b252b0381c3b83
review guidance,pr,10545,issue,10544,high,pr.reviews[1].body,hi - we cant hardcode arbitrary driver names here. please use this patch ```diff diff --git a/lib/sqlalchemy/dialects/sqlite/pysqlcipher.py b/lib/sqlalchemy/dialects/sqlite/pysqlcipher.py index 28b900ea53..3b31400ef8 100644 --- a/lib/sqlalchemy/dialects/sqlite/pysqlcipher.py +++ b/lib/sqlalchemy/...,https://github.com/sqlalchemy/sqlalchemy/pull/10545#pullrequestreview-1699608298,24022904c636ed9d436731e5be4e7310efdff5cb71f1290deddd60f4d3757863
review guidance,pr,7009,pr,7009,high,pr.reviews[0].body,"OK, this is **sqla-tester** setting up my work on behalf of **CaselIT** to try to get revision 8af63436b704389f777b78e69e8ae9ba2204241f of this pull request into gerrit so we can run tests and reviews and stuff",https://github.com/sqlalchemy/sqlalchemy/pull/7009,6455242de4b57520f6af1a0089a202e8685296106a9d1b774ae59cd3312289b5
review guidance,pr,7009,pr,7009,high,pr.reviews[1].body,"OK, this is **sqla-tester** setting up my work on behalf of **CaselIT** to try to get revision 4fa750e3d34638be7e9583d849216f6d90ca88fc of this pull request into gerrit so we can run tests and reviews and stuff",https://github.com/sqlalchemy/sqlalchemy/pull/7009,20851ec8fcb8793abe47b7664a05f83dc91ff02ddc121a0919c17cd86d67d38d
review guidance,pr,7009,pr,7009,high,pr.reviews[2].body,"OK, this is **sqla-tester** setting up my work on behalf of **CaselIT** to try to get revision 8af63436b704389f777b78e69e8ae9ba2204241f of this pull request into gerrit so we can run tests and reviews and stuff",https://github.com/sqlalchemy/sqlalchemy/pull/7009#pullrequestreview-750110542,0e8db104b6cabee05119a94c856406ab68b98c4d0e92ecbb2aa4b67b6a471bcc
review guidance,pr,7009,pr,7009,high,pr.reviews[3].body,"OK, this is **sqla-tester** setting up my work on behalf of **CaselIT** to try to get revision 4fa750e3d34638be7e9583d849216f6d90ca88fc of this pull request into gerrit so we can run tests and reviews and stuff",https://github.com/sqlalchemy/sqlalchemy/pull/7009#pullrequestreview-752093419,d9b0dab610c4951141901ac7905b47e3d12ad65e7ed8dd41eb490568d733d819
blocked by checks,pr,13421,pr,13421,medium,pr.statusCheckRollup,Blocked or unstable check/merge state. Check signal(s): code_review,https://github.com/sqlalchemy/sqlalchemy/pull/13421,4ca97d7227b134b341f37b9691646b3e7174e848bc88c25ff5e8d38e73a5a411
waiting on owner test approval,pr,13418,pr,13418,high,pr.statusCheckRollup,Pending gated check(s): gerrit_review,https://github.com/sqlalchemy/sqlalchemy/pull/13418,61dfba50c0eeb7f0cc2834eacb4d3d01ab8c4d86c56c6bc21dc2b2fe0b909640
waiting on owner test approval,pr,13417,pr,13417,high,pr.statusCheckRollup,Pending gated check(s): gerrit_review,https://github.com/sqlalchemy/sqlalchemy/pull/13417,d3b96fdc648af22b616594c9870400e252d9ae78ea7ceba319c960ddf17707a8
waiting on owner test approval,pr,13416,pr,13416,high,pr.statusCheckRollup,Pending gated check(s): gerrit_review,https://github.com/sqlalchemy/sqlalchemy/pull/13416,2961efd22cbc22842a6258e5ff4aba4fc3508da58cc6f1f1d8c1709b8120f92c
waiting on owner test approval,pr,13415,pr,13415,high,pr.statusCheckRollup,Pending gated check(s): gerrit_review,https://github.com/sqlalchemy/sqlalchemy/pull/13415,f6cfa65f493299336ac37fcb4b4c05c6e8864373c713010c69d87241ecf1e7d2
waiting on owner test approval,pr,13405,pr,13405,high,pr.statusCheckRollup,Pending gated check(s): gerrit_review,https://github.com/sqlalchemy/sqlalchemy/pull/13405,859b76e28e5a103bd5a1bce248807b95ef625540ddf717be0918bd26305d8de9
waiting on owner test approval,pr,13404,pr,13404,high,pr.statusCheckRollup,Pending gated check(s): gerrit_review,https://github.com/sqlalchemy/sqlalchemy/pull/13404,b8580da19963bed08494c6a98472b1349e239452c5d3dd7c2921e2988e2c63f0
blocked by checks,pr,13402,pr,13402,medium,pr.statusCheckRollup,Blocked or unstable check/merge state. Check signal(s): code_review,https://github.com/sqlalchemy/sqlalchemy/pull/13402,205af2d2b20fdfa500b93cde2bc6eccf20fb2d956a29683d5048f3aad06e0893
waiting on owner test approval,pr,13399,pr,13399,high,pr.statusCheckRollup,Pending gated check(s): gerrit_review,https://github.com/sqlalchemy/sqlalchemy/pull/13399,0a0bdfacb411e6062f600dd859955c351486e2b4bd34697fd4874f18e22d59f0
waiting on owner test approval,pr,13398,pr,13398,high,pr.statusCheckRollup,Pending gated check(s): gerrit_review,https://github.com/sqlalchemy/sqlalchemy/pull/13398,0d6347ce7d70ddf8e73bcc32840abe88cb11df23f773ec021fe1bc76b0cb7e91
waiting on owner test approval,pr,13368,pr,13368,high,pr.statusCheckRollup,Pending gated check(s): gerrit_review,https://github.com/sqlalchemy/sqlalchemy/pull/13368,96226c16381f76112abc5099e0acca9a3b51db3787c8620ff9fd588a78250dbf
waiting on owner test approval,pr,13323,pr,13323,high,pr.statusCheckRollup,Pending gated check(s): gerrit_review,https://github.com/sqlalchemy/sqlalchemy/pull/13323,78389ce6eeb4a2890cd6e80e3f725abd4f796eb48f0d0fa80bc89286ebeffff5
waiting on owner test approval,pr,13312,pr,13312,high,pr.statusCheckRollup,Pending gated check(s): gerrit_review,https://github.com/sqlalchemy/sqlalchemy/pull/13312,47828089285713e66aa9923b14b414935aef7fdd6c5c28f75560de59781becec
waiting on owner test approval,pr,13137,pr,13137,high,pr.statusCheckRollup,Pending gated check(s): gerrit_review,https://github.com/sqlalchemy/sqlalchemy/pull/13137,ce9a7d442ed8734db98a8cbb56446129e9e5b6a9d529ac398a04cfa63647fc37
blocked by checks,pr,12698,pr,12698,medium,pr.statusCheckRollup,Blocked or unstable check/merge state. Check signal(s): gerrit_review,https://github.com/sqlalchemy/sqlalchemy/pull/12698,4c0b8aead8d5b823481857fd3a3eeec936d6d18bcca9bf10b661e2eb5e8e5e10
blocked by checks,pr,12645,pr,12645,medium,pr.statusCheckRollup,"Blocked or unstable check/merge state. Check signal(s): pep484-3.12, gerrit_review",https://github.com/sqlalchemy/sqlalchemy/pull/12645,7d00929505240d346f4344d6613a5a6d9c4c7aab26cf92b02b9e6026728c45b3
blocked by checks,pr,12401,pr,12401,medium,pr.statusCheckRollup,"Blocked or unstable check/merge state. Check signal(s): pep484-3.14, pep8-3.14, gerrit_review",https://github.com/sqlalchemy/sqlalchemy/pull/12401,eea0631c305b31821632b6f4daa175b015d35298a1db039931faf95799f86e85
blocked by checks,pr,10574,pr,10574,medium,pr.statusCheckRollup,Blocked or unstable check/merge state. Check signal(s): DIRTY,https://github.com/sqlalchemy/sqlalchemy/pull/10574,ca40df69401cfe285aa8161a265be90a119dc8e211f4f04f45fb8f87660461c6
blocked by checks,pr,8136,pr,8136,medium,pr.statusCheckRollup,Blocked or unstable check/merge state. Check signal(s): DIRTY,https://github.com/sqlalchemy/sqlalchemy/pull/8136,842396236a5ffee80f77716feba3d33ad836cc700864aed0c5c83dc606eac817
waiting on owner test approval,pr,13188,pr,13188,high,pr.statusCheckRollup,Pending gated check(s): gerrit_review,https://github.com/sqlalchemy/sqlalchemy/pull/13188,995dc1fcc8eae2fe04383e679a29056fd8af20b46fa9d8ceeaca7109d710dfeb
blocked by checks,pr,12759,pr,12759,medium,pr.statusCheckRollup,"Blocked or unstable check/merge state. Check signal(s): test-amd64-3.13-cext-x64-ubuntu-22.04, test-amd64-3.13-nocext-x64-ubuntu-22.04, mypy-3.12, lint-3.12",https://github.com/sqlalchemy/sqlalchemy/pull/12759,0587f5a092129799c5339f254750e3d7740ef16ad25f221b87eab3d6492bd70c
blocked by checks,pr,7009,pr,7009,medium,pr.statusCheckRollup,Blocked or unstable check/merge state. Check signal(s): DIRTY,https://github.com/sqlalchemy/sqlalchemy/pull/7009,fc8f67f0f03d8dcee4f24cda4717aa80487e1cabaeb16c1c5c3ad112c8d15bef
duplicate candidate,issue,10094,issue,9410,low,title_label_similarity,"Possible related issues #10094 and #9410 shared tokens: document, far, gotchas",,a1fd3ce187e9261468f2892e639e2a61942b279f476f6b7930e63dd41f8d4762
duplicate candidate,issue,12585,issue,8795,low,title_label_similarity,"Possible related issues #12585 and #8795 shared tokens: autocommit, sqlite, support",,80339b4d46653012705cb65c6dd1b2a6b3818b01553c22b04f42443aefbd797c