feat(service-professional): Migrate from staff_id/staff_code to partner_id identifier

- Replace staff_id and staff_code references with partner_id throughout authentication flow
- Update OTP data storage in Redis to use partner_id instead of dual identifiers
- Simplify JWT token payload to use partner_id as standard identifier
- Remove redundant staff_code logging statements for cleaner logs
- Consolidate professional identifier to single partner_id field for consistency
- Maintain backward compatibility in token payload structure

app/auth/services/service_professional_auth_service.py

@@ -95,7 +95,7 @@ class ServiceProfessionalAuthService:
             professional_status = professional.get("status", "").lower()
             if professional_status != "active":
                 logger.warning(
-                    f"Inactive service professional attempted OTP: {professional.get('staff_code')}, "
+                    f"Inactive service professional attempted OTP: {professional.get('partner_id')}, "
                     f"status: {professional_status}"
                 )
                 return False, f"Service professional account is {professional_status}", 0
@@ -111,8 +111,7 @@ class ServiceProfessionalAuthService:
             # Store OTP in Redis FIRST (before attempting to send)
             otp_data = {
                 "phone": normalized_phone,
-                "staff_id": professional.get("staff_id"),
-                "staff_code": professional.get("staff_code"),
+                "partner_id": professional.get("partner_id"),
                 "otp": otp,
                 "created_at": datetime.utcnow().isoformat(),
                 "expires_at": expires_at.isoformat(),
@@ -128,7 +127,6 @@ class ServiceProfessionalAuthService:
             
             logger.info(
                 f"Service professional OTP generated and stored in Redis for {normalized_phone} "
-                f"(staff: {professional.get('staff_code')}), expires in {expires_in}s"
             )
             
             # Attempt to send OTP via WATI WhatsApp API
@@ -147,7 +145,6 @@ class ServiceProfessionalAuthService:
                 
                 logger.info(
                     f"Service professional OTP sent successfully via WATI to {normalized_phone} "
-                    f"for staff {professional.get('staff_code')}. Message ID: {message_id}"
                 )
                 return True, "OTP sent successfully via WhatsApp", expires_in
             else:
@@ -158,7 +155,6 @@ class ServiceProfessionalAuthService:
                 
                 logger.warning(
                     f"WhatsApp delivery failed for service professional {normalized_phone} "
-                    f"(staff: {professional.get('staff_code')}), but OTP is cached in Redis. Error: {wati_message}"
                 )
                 return True, "OTP generated (WhatsApp delivery pending). Please use the OTP if received.", expires_in
             
@@ -234,13 +230,12 @@ class ServiceProfessionalAuthService:
             # Verify professional is still active
             professional_status = professional.get("status", "").lower()
             if professional_status != "active":
-                logger.warning(f"Inactive service professional verified OTP: {professional.get('staff_code')}")
+                logger.warning(f"Inactive service professional verified OTP: {professional.get('partner_id')}")
                 return None, f"Service professional account is {professional_status}"
             
             # Prepare professional data for token generation
             professional_data = {
-                "staff_id": professional.get("staff_id"),
-                "staff_code": professional.get("staff_code"),
+                "partner_id": professional.get("partner_id"),
                 "name": professional.get("name"),
                 "phone": professional.get("phone"),
                 "email": professional.get("email"),
@@ -251,7 +246,6 @@ class ServiceProfessionalAuthService:
             
             logger.info(
                 f"Service professional OTP verified successfully for {normalized_phone}, "
-                f"staff: {professional.get('staff_code')}"
             )
             return professional_data, "OTP verified successfully"
             
@@ -277,11 +271,11 @@ class ServiceProfessionalAuthService:
             expires_delta = timedelta(hours=settings.TOKEN_EXPIRATION_HOURS)
             expire = datetime.utcnow() + expires_delta
             
-            # Token payload
+            # Token payload - use partner_id as the standard identifier
             token_data = {
-                "sub": professional_data["staff_id"],
-                "staff_id": professional_data["staff_id"],  # Required by SPA-MS auth dependency
-                "staff_code": professional_data["staff_code"],
+                "sub": professional_data["partner_id"],
+                "partner_id": professional_data["partner_id"],  # Standard identifier for SPA-MS
+                "partner_id": professional_data["partner_id"],  # Keep for backward compatibility
                 "user_type": "service_professional",
                 "exp": expire,
                 "iat": datetime.utcnow()