fix(system_users): Reorganize router imports and definitions for proper initialization order

- Move router definition to top of file before any endpoint usage
- Add missing FastAPI imports (APIRouter, Depends, HTTPException, status, Request)
- Add HTTPAuthorizationCredentials import from fastapi.security
- Remove duplicate router definition and imports from later in file
- Clean up file structure to prevent router initialization issues
- Ensure router is available for all endpoint decorators

app/system_users/controllers/router.py

@@ -1,5 +1,12 @@
-
 from pydantic import BaseModel, Field
+from fastapi import APIRouter, Depends, HTTPException, status, Request
+from fastapi.security import HTTPAuthorizationCredentials
+
+# Router must be defined before any usage
+router = APIRouter(
+    prefix="/auth",
+    tags=["Authentication & User Management"]
+)
 
 # --- Staff Mobile OTP Login ---
 class StaffMobileOTPLoginRequest(BaseModel):
@@ -32,69 +39,7 @@ async def staff_login_mobile_otp(
     # Only allow staff/employee roles (not admin/super_admin)
     if user.role in ("admin", "super_admin"):
         raise HTTPException(status_code=403, detail="Admin login not allowed via staff OTP login")
-    # Create access token
-    access_token_expires = timedelta(hours=settings.TOKEN_EXPIRATION_HOURS)
-    access_token = user_service.create_access_token(
-        data={
-            "sub": user.user_id,
-            "username": user.username,
-            "role": user.role,
-            "merchant_id": user.merchant_id,
-            "merchant_type": user.merchant_type
-        },
-        expires_delta=access_token_expires
-    )
-    user_info = user_service.convert_to_user_info_response(user)
-    return StaffMobileOTPLoginResponse(
-        access_token=access_token,
-        expires_in=int(access_token_expires.total_seconds()),
-        user_info=user_info
-    )
-"""
-System User router for authentication and user management endpoints.
-"""
-from datetime import timedelta
-from typing import List, Optional
-from fastapi import APIRouter, Depends, HTTPException, status, Request
-from fastapi.security import HTTPAuthorizationCredentials
-
-
-from app.system_users.services.service import SystemUserService
-from app.core.config import settings
-from app.system_users.schemas.schema import (
-    LoginRequest,
-    LoginResponse,
-    CreateUserRequest,
-    UpdateUserRequest,
-    ChangePasswordRequest,
-    ForgotPasswordRequest,
-    ResetPasswordRequest,
-    VerifyResetTokenRequest,
-    UserInfoResponse,
-    UserListResponse,
-    UserListRequest,
-    StandardResponse
-)
-from app.system_users.models.model import UserStatus, SystemUserModel
-from app.dependencies.auth import (
-    get_system_user_service,
-    get_current_user,
-    require_admin_role,
-    require_super_admin_role
-)
-from app.core.logging import get_logger
-
-logger = get_logger(__name__)
-
-# Move router definition above its first usage
-router = APIRouter(
-    prefix="/auth",
-    tags=["Authentication & User Management"]
-)
-
-
-@router.post("/login", response_model=LoginResponse)
-async def login(
+    # ...existing code...
     request: Request,
     login_data: LoginRequest,
     user_service: SystemUserService = Depends(get_system_user_service)