feat: implement user migration and update role handling in database initialization

app/core/db_init.py

@@ -19,6 +19,9 @@ async def initialize_database():
     try:
         db = await get_database()
         
+        # Migrate existing data
+        await migrate_existing_users(db)
+        
         # Create default roles
         await create_default_roles(db)
         
@@ -32,6 +35,46 @@ async def initialize_database():
         raise
 
 
+async def migrate_existing_users(db):
+    """Migrate existing users to add missing required fields."""
+    logger.info("📋 Migrating existing users...")
+    users_collection = db[AUTH_SYSTEM_USERS_COLLECTION]
+    
+    try:
+        # Add role_id field to users missing it
+        result = await users_collection.update_many(
+            {"role_id": {"$exists": False}},
+            {"$set": {"role_id": "user"}}
+        )
+        if result.modified_count > 0:
+            logger.info(f"  ✓ Added role_id field to {result.modified_count} users")
+        
+        # Ensure status field exists
+        result = await users_collection.update_many(
+            {"status": {"$exists": False}},
+            {"$set": {"status": "active"}}
+        )
+        if result.modified_count > 0:
+            logger.info(f"  ✓ Added status field to {result.modified_count} users")
+        
+        # Ensure security_settings exists
+        result = await users_collection.update_many(
+            {"security_settings": {"$exists": False}},
+            {"$set": {
+                "security_settings": {
+                    "require_password_change": False,
+                    "failed_login_attempts": 0,
+                    "login_attempts": []
+                }
+            }}
+        )
+        if result.modified_count > 0:
+            logger.info(f"  ✓ Added security_settings to {result.modified_count} users")
+            
+    except Exception as e:
+        logger.warning(f"⚠ Migration warning: {e}")
+
+
 async def create_default_roles(db):
     """Create default access roles."""
     roles_collection = db[AUTH_ACCESS_ROLES_COLLECTION]
@@ -105,7 +148,7 @@ async def create_initial_users(db):
             "first_name": "Super",
             "last_name": "Admin",
             "phone": "+919999999999",
-            "role": "super_admin",
+            "role_id": "role_super_admin",
             "permissions": {
                 "users": ["view", "create", "update", "delete"],
                 "roles": ["view", "create", "update", "delete"],
@@ -132,7 +175,7 @@ async def create_initial_users(db):
             "first_name": "Company",
             "last_name": "Admin",
             "phone": "+919999999998",
-            "role": "admin",
+            "role_id": "role_company_admin",
             "permissions": {
                 "users": ["view", "create", "update"],
                 "roles": ["view"],
@@ -158,7 +201,23 @@ async def create_initial_users(db):
             await users_collection.insert_one(user)
             logger.info(f"  ✓ Created user: {user['email']}")
         else:
-            logger.info(f"  ⊳ User exists: {user['email']}")
+            # Update existing user if missing required fields
+            updates = {}
+            if "role" not in existing:
+                updates["role"] = user["role"]
+            if "status" not in existing:
+                updates["status"] = "active"
+            if "security_settings" not in existing:
+                updates["security_settings"] = user["security_settings"]
+            
+            if updates:
+                await users_collection.update_one(
+                    {"email": user["email"]},
+                    {"$set": updates}
+                )
+                logger.info(f"  ⚠ Updated existing user: {user['email']} (added missing fields)")
+            else:
+                logger.info(f"  ⊳ User exists: {user['email']}")
     
     logger.info("\n📝 Default Credentials:")
     logger.info("   superadmin@cuatrolabs.com / SuperAdmin@123")

app/system_users/models/model.py

@@ -64,7 +64,7 @@ class SystemUserModel(BaseModel):
     phone: Optional[str] = Field(None, description="User phone number (E.164 format)")
     
     # Authorization
-    role: str = Field(..., description="User role identifier")
+    role: str = Field(default="user", alias="role_id", description="User role identifier")
     permissions: Dict[str, List[str]] = Field(default_factory=dict, description="Grouped permissions by module")
     
     # Status and security
@@ -94,6 +94,7 @@ class SystemUserModel(BaseModel):
     metadata: Optional[Dict[str, Any]] = Field(None, description="Additional metadata")
     
     class Config:
+        populate_by_name = True
         json_schema_extra = {
             "example": {
                 "user_id": "usr_01HZQX5K3N2P8R6T4V9W",
@@ -103,7 +104,7 @@ class SystemUserModel(BaseModel):
                 "first_name": "John",
                 "last_name": "Doe",
                 "phone": "+919876543210",
-                "role": "admin",
+                "role_id": "admin",
                 "permissions": {
                     "customers": ["view", "create", "update"],
                     "orders": ["view", "create", "update"],