PO decimal issue

app/sales/orders/services/service.py

@@ -10,6 +10,7 @@ import secrets
 
 from app.nosql import get_database
 from app.constants.collections import SCM_SALES_ORDERS_COLLECTION
+from app.utils.mongodb import convert_decimals_to_float
 from app.sales.orders.schemas.schema import (
     SalesOrderCreate,
     SalesOrderUpdate,
@@ -150,13 +151,11 @@ class SalesOrderService:
                 item.tax_percent,
                 item.discount_percent
             )
-            # Convert Decimal to float for MongoDB
-            item_dict["unit_price"] = float(item_dict["unit_price"])
-            item_dict["tax_percent"] = float(item_dict["tax_percent"])
-            item_dict["discount_percent"] = float(item_dict["discount_percent"])
-            item_dict["line_total"] = float(item_dict["line_total"])
             items_data.append(item_dict)
         
+        # Convert all Decimal objects to float for MongoDB compatibility
+        items_data = convert_decimals_to_float(items_data)
+        
         # Calculate summary
         summary = calculate_order_summary(items_data)
         
@@ -188,20 +187,20 @@ class SalesOrderService:
             "items": items_data,
             
             # Financial summary
-            "summary": {k: float(v) for k, v in summary.items()},
+            "summary": convert_decimals_to_float(summary),
             
             # Payment
-            "payment": {
+            "payment": convert_decimals_to_float({
                 "payment_type": payload.payment.payment_type.value,
                 "payment_status": payment_status,
                 "payment_method": payload.payment.payment_method,
                 "payment_date": payload.payment.payment_date.isoformat() if payload.payment.payment_date else None,
                 "payment_reference": payload.payment.payment_reference,
-                "amount_paid": float(amount_paid),
-                "amount_due": float(amount_due),
+                "amount_paid": amount_paid,
+                "amount_due": amount_due,
                 "credit_terms": payload.payment.credit_terms,
-                "credit_limit": float(payload.payment.credit_limit) if payload.payment.credit_limit else None
-            },
+                "credit_limit": payload.payment.credit_limit
+            }),
             
             # Fulfillment
             "fulfillment_status": FulfillmentStatus.PENDING.value,
@@ -378,17 +377,17 @@ class SalesOrderService:
             for item in update_data["items"]:
                 item_dict = item if isinstance(item, dict) else item.dict()
                 item_dict["id"] = item_dict.get("id") or f"item_{secrets.token_urlsafe(8)}"
-                item_dict["line_total"] = float(calculate_line_total(
+                item_dict["line_total"] = calculate_line_total(
                     item_dict["quantity"],
                     Decimal(str(item_dict["unit_price"])),
                     Decimal(str(item_dict.get("tax_percent", 0))),
                     Decimal(str(item_dict.get("discount_percent", 0)))
-                ))
+                )
                 items_data.append(item_dict)
             
-            update_data["items"] = items_data
+            update_data["items"] = convert_decimals_to_float(items_data)
             summary = calculate_order_summary(items_data)
-            update_data["summary"] = {k: float(v) for k, v in summary.items()}
+            update_data["summary"] = convert_decimals_to_float(summary)
         
         update_data["updated_at"] = datetime.utcnow().isoformat()
         

app/utils/mongodb.py

@@ -0,0 +1,31 @@
+"""
+MongoDB utility functions for handling data type conversions.
+"""
+from typing import Any
+from decimal import Decimal
+
+
+def convert_decimals_to_float(obj: Any) -> Any:
+    """
+    Recursively convert Decimal objects to float for MongoDB compatibility.
+    
+    MongoDB/BSON cannot encode Python Decimal objects directly.
+    This function recursively traverses data structures and converts
+    all Decimal instances to float while preserving the structure.
+    
+    Args:
+        obj: Any object that may contain Decimal instances
+        
+    Returns:
+        Object with all Decimal instances converted to float
+    """
+    if isinstance(obj, Decimal):
+        return float(obj)
+    elif isinstance(obj, dict):
+        return {key: convert_decimals_to_float(value) for key, value in obj.items()}
+    elif isinstance(obj, list):
+        return [convert_decimals_to_float(item) for item in obj]
+    elif isinstance(obj, tuple):
+        return tuple(convert_decimals_to_float(item) for item in obj)
+    else:
+        return obj