File size: 6,377 Bytes
d6afd6c
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
package com.dalab.adminservice.controller;

import static org.hamcrest.Matchers.*;
import static org.mockito.ArgumentMatchers.*;
import static org.mockito.ArgumentMatchers.any;
import static org.mockito.BDDMockito.*;
import static org.mockito.Mockito.*;
import static org.springframework.security.test.web.servlet.request.SecurityMockMvcRequestPostProcessors.*;
import static org.springframework.test.web.servlet.request.MockMvcRequestBuilders.*;
import static org.springframework.test.web.servlet.result.MockMvcResultMatchers.*;

import java.util.Collections;
import java.util.List;
import java.util.Optional;
import java.util.UUID;

import org.junit.jupiter.api.BeforeEach;
import org.junit.jupiter.api.Test;
import org.keycloak.representations.idm.RoleRepresentation;
import org.springframework.beans.factory.annotation.Autowired;
import org.springframework.boot.test.autoconfigure.web.servlet.WebMvcTest;
import org.springframework.boot.test.mock.mockito.MockBean;
import org.springframework.context.annotation.Import;
import org.springframework.http.MediaType;
import org.springframework.security.test.context.support.WithMockUser;
import org.springframework.test.web.servlet.MockMvc;

import com.dalab.adminservice.config.TestSecurityConfiguration;
import com.dalab.adminservice.dto.UserDTO;
import com.dalab.adminservice.service.IUserService;
import com.fasterxml.jackson.databind.ObjectMapper;

@WebMvcTest(UserController.class)
@Import(TestSecurityConfiguration.class)
@WithMockUser(roles = "ADMIN") // Apply to all tests in this class for brevity, can be overridden
class UserControllerTest {

    @Autowired
    private MockMvc mockMvc;

    @MockBean
    private IUserService userService;

    @Autowired
    private ObjectMapper objectMapper;

    private UserDTO userDTO;

    @BeforeEach
    void setUp() {
        userDTO = UserDTO.builder()
                .id(UUID.randomUUID().toString())
                .username("testuser")
                .email("test@example.com")
                .firstName("Test")
                .lastName("User")
                .enabled(true)
                .roles(List.of("USER"))
                .build();
    }

    @Test
    void getAllUsers_shouldReturnListOfUsers() throws Exception {
        given(userService.getAllUsers(null, null)).willReturn(Collections.singletonList(userDTO));

        mockMvc.perform(get("/api/v1/admin/users"))
                .andExpect(status().isOk())
                .andExpect(jsonPath("$", hasSize(1)))
                .andExpect(jsonPath("$[0].username").value("testuser"));
    }

    @Test
    void getUserById_whenExists_shouldReturnUser() throws Exception {
        given(userService.getUserById(userDTO.getId())).willReturn(Optional.of(userDTO));

        mockMvc.perform(get("/api/v1/admin/users/" + userDTO.getId()))
                .andExpect(status().isOk())
                .andExpect(jsonPath("$.username").value("testuser"));
    }

    @Test
    void getUserById_whenNotExists_shouldReturnNotFound() throws Exception {
        given(userService.getUserById("unknown-id")).willReturn(Optional.empty());

        mockMvc.perform(get("/api/v1/admin/users/unknown-id"))
                .andExpect(status().isNotFound());
    }
    
    @Test
    void getUserByUsername_whenExists_shouldReturnUser() throws Exception {
        given(userService.getUserByUsername("testuser")).willReturn(Optional.of(userDTO));

        mockMvc.perform(get("/api/v1/admin/users/username/testuser"))
                .andExpect(status().isOk())
                .andExpect(jsonPath("$.id").value(userDTO.getId()));
    }

    @Test
    void createUser_shouldReturnCreatedUser() throws Exception {
        given(userService.createUser(any(UserDTO.class))).willReturn(userDTO);

        mockMvc.perform(post("/api/v1/admin/users").with(csrf())
                .contentType(MediaType.APPLICATION_JSON)
                .content(objectMapper.writeValueAsString(userDTO)))
                .andExpect(status().isCreated())
                .andExpect(jsonPath("$.username").value("testuser"));
    }

    @Test
    void updateUser_shouldReturnUpdatedUser() throws Exception {
        UserDTO updatedDto = UserDTO.builder().username("updateduser").build();
        given(userService.updateUser(eq(userDTO.getId()), any(UserDTO.class))).willReturn(updatedDto);

        mockMvc.perform(put("/api/v1/admin/users/" + userDTO.getId()).with(csrf())
                .contentType(MediaType.APPLICATION_JSON)
                .content(objectMapper.writeValueAsString(updatedDto)))
                .andExpect(status().isOk())
                .andExpect(jsonPath("$.username").value("updateduser"));
    }

    @Test
    void deleteUser_shouldReturnNoContent() throws Exception {
        doNothing().when(userService).deleteUser(userDTO.getId());

        mockMvc.perform(delete("/api/v1/admin/users/" + userDTO.getId()).with(csrf()))
                .andExpect(status().isNoContent());
    }

    @Test
    void getUserRealmRoles_shouldReturnRoles() throws Exception {
        RoleRepresentation roleRep = new RoleRepresentation("USER", "User role", false);
        given(userService.getUserRealmRoles(userDTO.getId())).willReturn(Collections.singletonList(roleRep));

        mockMvc.perform(get("/api/v1/admin/users/" + userDTO.getId() + "/roles"))
                .andExpect(status().isOk())
                .andExpect(jsonPath("$[0].name").value("USER"));
    }

    @Test
    void assignRealmRolesToUser_shouldReturnNoContent() throws Exception {
        List<String> rolesToAssign = List.of("USER", "EDITOR");
        doNothing().when(userService).assignRealmRolesToUser(userDTO.getId(), rolesToAssign);

        mockMvc.perform(post("/api/v1/admin/users/" + userDTO.getId() + "/roles").with(csrf())
                .contentType(MediaType.APPLICATION_JSON)
                .content(objectMapper.writeValueAsString(rolesToAssign)))
                .andExpect(status().isNoContent());
    }
    
    @Test
    @WithMockUser(roles = "VIEWER") // Non-admin user for a modification endpoint
    void createUser_whenUnauthorized_shouldReturnForbidden() throws Exception {
         mockMvc.perform(post("/api/v1/admin/users").with(csrf())
                .contentType(MediaType.APPLICATION_JSON)
                .content(objectMapper.writeValueAsString(userDTO)))
                .andExpect(status().isForbidden());
    }
}