Spaces:
Build error
Build error
File size: 14,468 Bytes
d6afd6c |
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 |
package com.dalab.adminservice.service.impl;
import static org.junit.jupiter.api.Assertions.*;
import static org.mockito.ArgumentMatchers.*;
import static org.mockito.Mockito.*;
import java.net.URI;
import java.util.Collections;
import java.util.List;
import java.util.Optional;
import org.junit.jupiter.api.BeforeEach;
import org.junit.jupiter.api.Test;
import org.junit.jupiter.api.extension.ExtendWith;
import org.keycloak.admin.client.Keycloak;
import org.keycloak.admin.client.resource.RealmResource;
import org.keycloak.admin.client.resource.RoleMappingResource;
import org.keycloak.admin.client.resource.RoleResource;
import org.keycloak.admin.client.resource.RoleScopeResource;
import org.keycloak.admin.client.resource.RolesResource;
import org.keycloak.admin.client.resource.UserResource;
import org.keycloak.admin.client.resource.UsersResource;
import org.keycloak.representations.idm.RoleRepresentation;
import org.keycloak.representations.idm.UserRepresentation;
import org.mockito.InjectMocks;
import org.mockito.Mock;
import org.mockito.junit.jupiter.MockitoExtension;
import org.mockito.junit.jupiter.MockitoSettings;
import org.mockito.quality.Strictness;
import org.springframework.test.util.ReflectionTestUtils;
import com.dalab.adminservice.dto.UserDTO;
import com.dalab.adminservice.exception.ConflictException;
import com.dalab.adminservice.exception.NotFoundException;
import com.dalab.adminservice.mapper.UserMapper;
import jakarta.ws.rs.core.Response;
import jakarta.ws.rs.core.UriInfo;
@ExtendWith(MockitoExtension.class)
@MockitoSettings(strictness = Strictness.LENIENT)
class UserServiceImplTest {
@Mock
private Keycloak keycloakAdminClient;
@Mock
private UserMapper userMapper;
@InjectMocks
private UserServiceImpl userService;
@Mock
private RealmResource realmResource;
@Mock
private UsersResource usersResource;
@Mock
private UserResource userResource;
@Mock
private RolesResource rolesResource;
@Mock
private RoleResource roleResource;
@Mock
private RoleMappingResource roleMappingResource;
@Mock
private RoleScopeResource roleScopeResource;
private UserRepresentation userRepresentation;
private UserDTO userDTO;
private String testUserId = "test-user-id";
private String testRealmName = "test-realm";
@BeforeEach
void setUp() {
ReflectionTestUtils.setField(userService, "realmName", testRealmName);
userRepresentation = new UserRepresentation();
userRepresentation.setId(testUserId);
userRepresentation.setUsername("testuser");
userRepresentation.setEmail("test@example.com");
userDTO = UserDTO.builder()
.id(testUserId)
.username("testuser")
.email("test@example.com")
.firstName("Test")
.lastName("User")
.enabled(true)
.password("password") // Include password for create/update tests
.roles(List.of("USER"))
.build();
// Common Keycloak resource mocking
when(keycloakAdminClient.realm(testRealmName)).thenReturn(realmResource);
when(realmResource.users()).thenReturn(usersResource);
}
@Test
void getAllUsers_shouldReturnUserDtoList() {
when(usersResource.list(anyInt(), anyInt())).thenReturn(Collections.singletonList(userRepresentation));
when(userMapper.toDtoList(anyList())).thenReturn(Collections.singletonList(userDTO));
List<UserDTO> result = userService.getAllUsers(0, 10);
assertNotNull(result);
assertEquals(1, result.size());
assertEquals(userDTO.getUsername(), result.get(0).getUsername());
verify(usersResource).list(0, 10);
}
@Test
void getUserById_whenFound_shouldReturnUserDto() {
when(usersResource.get(testUserId)).thenReturn(userResource);
when(userResource.toRepresentation()).thenReturn(userRepresentation);
when(userResource.roles()).thenReturn(roleMappingResource);
when(roleMappingResource.realmLevel()).thenReturn(roleScopeResource);
when(roleScopeResource.listEffective()).thenReturn(Collections.emptyList()); // Mock roles as needed
when(userMapper.toDto(userRepresentation)).thenReturn(userDTO);
Optional<UserDTO> result = userService.getUserById(testUserId);
assertTrue(result.isPresent());
assertEquals(userDTO.getUsername(), result.get().getUsername());
}
@Test
void getUserById_whenNotFound_shouldReturnEmpty() {
when(usersResource.get("unknown-id")).thenThrow(new jakarta.ws.rs.NotFoundException());
Optional<UserDTO> result = userService.getUserById("unknown-id");
assertFalse(result.isPresent());
}
@Test
void getUserByUsername_whenFound_shouldReturnUserDto() {
when(usersResource.searchByUsername(userDTO.getUsername(), true)).thenReturn(List.of(userRepresentation));
when(usersResource.get(testUserId)).thenReturn(userResource);
when(userResource.roles()).thenReturn(roleMappingResource);
when(roleMappingResource.realmLevel()).thenReturn(roleScopeResource);
when(roleScopeResource.listEffective()).thenReturn(Collections.emptyList());
when(userMapper.toDto(userRepresentation)).thenReturn(userDTO);
Optional<UserDTO> result = userService.getUserByUsername(userDTO.getUsername());
assertTrue(result.isPresent());
assertEquals(userDTO.getUsername(), result.get().getUsername());
}
@Test
void createUser_shouldCreateAndReturnUserDto() {
Response mockResponse = mock(Response.class);
UriInfo mockUriInfo = mock(UriInfo.class);
when(mockResponse.getStatus()).thenReturn(Response.Status.CREATED.getStatusCode());
when(mockResponse.getLocation()).thenReturn(URI.create("http://localhost/users/" + testUserId));
// when(mockResponse.getUriInfo()).thenReturn(mockUriInfo); // If using getPath()
// when(mockUriInfo.getPath()).thenReturn("/users/" + testUserId);
when(userMapper.toRepresentation(any(UserDTO.class))).thenReturn(userRepresentation);
when(usersResource.create(any(UserRepresentation.class))).thenReturn(mockResponse);
// Mock the follow-up getUserById call
when(usersResource.get(testUserId)).thenReturn(userResource);
when(userResource.toRepresentation()).thenReturn(userRepresentation);
when(userResource.roles()).thenReturn(roleMappingResource);
when(roleMappingResource.realmLevel()).thenReturn(roleScopeResource);
when(roleScopeResource.listEffective()).thenReturn(Collections.emptyList());
when(userMapper.toDto(userRepresentation)).thenReturn(userDTO);
// Mock roles part
when(realmResource.roles()).thenReturn(rolesResource);
RoleRepresentation roleRep = new RoleRepresentation("USER", null, false);
when(rolesResource.get("USER")).thenReturn(roleResource);
when(roleResource.toRepresentation()).thenReturn(roleRep);
UserDTO createdUser = userService.createUser(userDTO);
assertNotNull(createdUser);
assertEquals(userDTO.getUsername(), createdUser.getUsername());
verify(usersResource).create(userRepresentation);
verify(userResource.roles().realmLevel()).add(anyList());
}
@Test
void createUser_whenConflict_shouldThrowConflictException() {
Response mockResponse = mock(Response.class);
when(mockResponse.getStatus()).thenReturn(Response.Status.CONFLICT.getStatusCode());
when(userMapper.toRepresentation(any(UserDTO.class))).thenReturn(userRepresentation);
when(usersResource.create(any(UserRepresentation.class))).thenReturn(mockResponse);
assertThrows(ConflictException.class, () -> userService.createUser(userDTO));
}
@Test
void updateUser_shouldUpdateAndReturnUserDto() {
UserDTO updateRequest = UserDTO.builder()
.id(testUserId)
.firstName("Updated")
.lastName("Name")
.email("updated@example.com")
.enabled(false)
.roles(List.of("ADMIN"))
.build();
UserRepresentation existingUserRep = new UserRepresentation();
existingUserRep.setId(testUserId);
existingUserRep.setUsername("testuser");
existingUserRep.setFirstName("Test");
existingUserRep.setLastName("User");
existingUserRep.setEmail("test@example.com");
existingUserRep.setEnabled(true);
UserRepresentation updatedUserRep = new UserRepresentation();
updatedUserRep.setId(testUserId);
updatedUserRep.setUsername("testuser");
updatedUserRep.setFirstName("Updated");
updatedUserRep.setLastName("Name");
updatedUserRep.setEmail("updated@example.com");
updatedUserRep.setEnabled(false);
// Mock the initial fetch and update operations
when(usersResource.get(testUserId)).thenReturn(userResource);
when(userResource.toRepresentation()).thenReturn(existingUserRep);
when(userMapper.toRepresentation(updateRequest)).thenReturn(updatedUserRep);
doNothing().when(userResource).update(any(UserRepresentation.class));
// Mock role operations
when(userResource.roles()).thenReturn(roleMappingResource);
when(roleMappingResource.realmLevel()).thenReturn(roleScopeResource);
when(roleScopeResource.listEffective()).thenReturn(Collections.singletonList(new RoleRepresentation("USER",null,false)));
when(realmResource.roles()).thenReturn(rolesResource);
RoleRepresentation adminRoleRep = new RoleRepresentation("ADMIN", null, false);
when(rolesResource.get("ADMIN")).thenReturn(roleResource);
when(roleResource.toRepresentation()).thenReturn(adminRoleRep);
doNothing().when(roleScopeResource).add(anyList());
doNothing().when(roleScopeResource).remove(anyList());
// Mock the final getUserById call - create a separate mock chain
UserResource finalUserResource = mock(UserResource.class);
RoleMappingResource finalRoleMappingResource = mock(RoleMappingResource.class);
RoleScopeResource finalRoleScopeResource = mock(RoleScopeResource.class);
// The updateUser method calls getUserById at the end, which needs fresh mocks
when(usersResource.get(testUserId)).thenReturn(userResource, finalUserResource);
when(finalUserResource.toRepresentation()).thenReturn(updatedUserRep);
when(finalUserResource.roles()).thenReturn(finalRoleMappingResource);
when(finalRoleMappingResource.realmLevel()).thenReturn(finalRoleScopeResource);
when(finalRoleScopeResource.listEffective()).thenReturn(Collections.singletonList(new RoleRepresentation("ADMIN",null,false)));
UserDTO finalResult = UserDTO.builder()
.id(testUserId)
.username("testuser")
.firstName("Updated")
.lastName("Name")
.email("updated@example.com")
.enabled(false)
.roles(List.of("ADMIN"))
.build();
when(userMapper.toDto(updatedUserRep)).thenReturn(finalResult);
UserDTO result = userService.updateUser(testUserId, updateRequest);
assertNotNull(result);
assertEquals("Updated", result.getFirstName());
assertFalse(result.isEnabled());
verify(userResource).update(any(UserRepresentation.class));
verify(roleScopeResource).add(anyList());
verify(roleScopeResource).remove(anyList());
}
@Test
void deleteUser_shouldCallRemove() {
when(usersResource.get(testUserId)).thenReturn(userResource);
doNothing().when(userResource).remove();
userService.deleteUser(testUserId);
verify(userResource).remove();
}
@Test
void deleteUser_whenNotFound_shouldThrowNotFound() {
when(usersResource.get("unknown-id")).thenThrow(new jakarta.ws.rs.NotFoundException());
assertThrows(NotFoundException.class, () -> userService.deleteUser("unknown-id"));
}
@Test
void assignRealmRolesToUser_shouldAddRoles() {
when(usersResource.get(testUserId)).thenReturn(userResource);
when(realmResource.roles()).thenReturn(rolesResource);
RoleRepresentation roleRep = new RoleRepresentation("NEW_ROLE", null, false);
when(rolesResource.get("NEW_ROLE")).thenReturn(roleResource);
when(roleResource.toRepresentation()).thenReturn(roleRep);
when(userResource.roles()).thenReturn(roleMappingResource);
when(roleMappingResource.realmLevel()).thenReturn(roleScopeResource);
doNothing().when(roleScopeResource).add(anyList());
userService.assignRealmRolesToUser(testUserId, List.of("NEW_ROLE"));
verify(roleScopeResource).add(List.of(roleRep));
}
@Test
void getAvailableRealmRoles_shouldReturnRoleRepresentations() {
RoleRepresentation roleRep = new RoleRepresentation("TEST_ROLE", "A test role", false);
when(realmResource.roles()).thenReturn(rolesResource);
when(rolesResource.list()).thenReturn(Collections.singletonList(roleRep));
List<RoleRepresentation> roles = userService.getAvailableRealmRoles();
assertNotNull(roles);
assertEquals(1, roles.size());
assertEquals("TEST_ROLE", roles.get(0).getName());
}
@Test
void getUserRealmRoles_shouldReturnUserRoles() {
RoleRepresentation roleRep = new RoleRepresentation("ASSIGNED_ROLE", null, false);
when(usersResource.get(testUserId)).thenReturn(userResource);
when(userResource.roles()).thenReturn(roleMappingResource);
when(roleMappingResource.realmLevel()).thenReturn(roleScopeResource);
when(roleScopeResource.listEffective()).thenReturn(Collections.singletonList(roleRep));
List<RoleRepresentation> roles = userService.getUserRealmRoles(testUserId);
assertNotNull(roles);
assertEquals(1, roles.size());
assertEquals("ASSIGNED_ROLE", roles.get(0).getName());
}
} |