fixed microsoft supported languages bug

deep_translator/microsoft.py

@@ -32,8 +32,6 @@ class MicrosoftTranslator(BaseTranslator):
         @param region: your Microsoft Location
         """
 
-        MICROSOFT_CODES_TO_LANGUAGES = self._get_supported_languages()
-
         if not api_key:
             raise ServerException(401)
 
@@ -51,17 +49,21 @@ class MicrosoftTranslator(BaseTranslator):
             base_url=BASE_URLS.get("MICROSOFT_TRANSLATE"),
             source=source,
             target=target,
-            languages=MICROSOFT_CODES_TO_LANGUAGES,
+            languages=self._get_supported_languages(),
             **kwargs,
         )
 
+    # this function get the actual supported languages of the msft translator and store them in a dict, where
+    # the keys are the abbreviations and the values are the languages
+    # a common variable used in the other translators would be: MICROSOFT_CODES_TO_LANGUAGES
     def _get_supported_languages(self):
 
-        microsoft_languages_api_url = "https://api.cognitive.microsofttranslator.com/languages?api-version=3.0&scope=translation"
+        microsoft_languages_api_url = "https://api.cognitive.microsofttranslator.com/languages?api-version=3.0&scope" \
+                                      "=translation "
         microsoft_languages_response = requests.get(microsoft_languages_api_url)
         translation_dict = microsoft_languages_response.json()["translation"]
 
-        return {translation_dict[k]["name"].lower(): k for k in translation_dict.keys()}
+        return {translation_dict[k]["name"].lower(): k.lower() for k in translation_dict.keys()}
 
     def translate(self, text: str, **kwargs) -> str:
         """
@@ -71,14 +73,14 @@ class MicrosoftTranslator(BaseTranslator):
         """
         # a body must be a list of dicts to process multiple texts;
         # I have not added multiple text processing here since it is covered by the translate_batch method
-
+        response = None
         if is_input_valid(text):
             self._url_params["from"] = self._source
             self._url_params["to"] = self._target
 
             valid_microsoft_json = [{"text": text}]
             try:
-                requested = requests.post(
+                response = requests.post(
                     self._base_url,
                     params=self._url_params,
                     headers=self.headers,
@@ -90,13 +92,14 @@ class MicrosoftTranslator(BaseTranslator):
                 logging.warning(f"Returned error: {exc_type.__name__}")
 
             # Where Microsoft API responds with an api error, it returns a dict in response.json()
-            if type(requested.json()) is dict:
-                error_message = requested.json()["error"]
+            if type(response.json()) is dict:
+                error_message = response.json()["error"]
                 raise MicrosoftAPIerror(error_message)
-            # Where it responds with a translation, its response.json() is a list e.g. [{'translations': [{'text': 'Hello world!', 'to': 'en'}]}]
-            elif type(requested.json()) is list:
+            # Where it responds with a translation, its response.json() is a list
+            # e.g. [{'translations': [{'text':'Hello world!', 'to': 'en'}]}]
+            elif type(response.json()) is list:
                 all_translations = [
-                    i["text"] for i in requested.json()[0]["translations"]
+                    i["text"] for i in response.json()[0]["translations"]
                 ]
                 return "\n".join(all_translations)