Small updates on app.py

app.py

@@ -1,14 +1,15 @@
 import sys
-# IMPORTANT: These lines MUST be at the very top of app.py
-# They ensure that any subsequent import of 'sqlite3' (even indirectly by chromadb)
-# will use the version provided by pysqlite3-binary.
+# CRITICAL: These lines MUST be the absolute first executable lines in app.py.
+# This ensures pysqlite3 is loaded and replaces the standard sqlite3 module
+# in sys.modules before any other module (like chromadb) attempts to import sqlite3.
 try:
     import pysqlite3
     sys.modules['sqlite3'] = pysqlite3
+    print("pysqlite3 successfully imported and set as default sqlite3 module.")
 except ImportError:
-    # This should not happen if pysqlite3-binary is correctly installed via requirements.txt
-    print("Warning: pysqlite3-binary could not be imported. ChromaDB might encounter SQLite version issues.")
-    pass
+    print("ERROR: pysqlite3-binary could not be imported. ChromaDB will likely fail due to old sqlite3 version.")
+    # You might want to raise an exception here or ensure the app exits gracefully
+    # if pysqlite3 is a hard dependency for your deployment.
 
 import os
 from fastapi import FastAPI, HTTPException
@@ -18,22 +19,17 @@ import json
 import base64
 from dotenv import load_dotenv
 
-# Load environment variables at the very top
-# This ensures that variables like FIREBASE_CONFIG_BASE64 are available
-# before other modules (like config.py) attempt to read them.
+# Load environment variables (after pysqlite3 fix)
 load_dotenv() 
 
 # Add the 'src' directory to the Python path
 sys.path.insert(0, os.path.abspath(os.path.join(os.path.dirname(__file__), 'src')))
 
-# Import components from the new modular structure, specifically from src.compassia
-# Ensure config is imported after dotenv for FIREBASE_CONFIG_BASE64
+# Now import components from src.compassia
 from src.config import CHROMADB_PERSIST_DIRECTORY, CHROMADB_COLLECTION_NAME
 from src.compassia import DocumentRAG, embedding_model, initialize_firebase_client, FIRESTORE_DATABASE 
 
 # --- Firebase Initialization (Global, once per process) ---
-# Initialize Firebase Admin SDK using a secret from Hugging Face Spaces
-# This function is now called directly from app.py startup.
 initialize_firebase_client()
 
 
@@ -46,9 +42,6 @@ rag_system = DocumentRAG(
 )
 
 # --- Index documents on startup ---
-# This loop will run when the FastAPI app first starts.
-# It uses ChromaDB's persistence, so documents already indexed will be skipped.
-# Now fetches document URLs directly from Firestore using FIRESTORE_DATABASE
 print("--- FastAPI App Startup: Indexing Documents from Firestore ---")
 if FIRESTORE_DATABASE:
     try:
@@ -58,10 +51,8 @@ if FIRESTORE_DATABASE:
         for doc in docs_ref:
             doc_data = doc.to_dict()
             if 'fileUrl' in doc_data:
-                # IMPORTANT: Pass the full URL and optional name to add_document.
-                # The add_document method in compassia.py now handles PDF filtering.
                 pdf_url = doc_data['fileUrl']
-                display_name = doc_data.get('name_en', None) # Pass None if not present, add_document handles basename
+                display_name = doc_data.get('name_en', None) 
                 documents_found_in_firestore.append({"url": pdf_url, "name": display_name})
             else:
                 print(f"Skipping document ID: {doc.id} - 'fileUrl' field missing.")
@@ -74,8 +65,6 @@ if FIRESTORE_DATABASE:
     except Exception as e:
         print(f"API Error: Error fetching documents from Firestore: {e}")
         print("Please ensure your Firestore database is accessible and the service account key (FIREBASE_CONFIG_BASE64 secret) is correct.")
-        # If document fetching fails, consider if the app should still start or crash.
-        # For now, it will print the error but continue to try to start the API.
 else:
     print("API Error: Firestore client not initialized. Cannot fetch documents from Firestore on startup.")
     print("Ensure FIREBASE_CONFIG_BASE64 secret is correctly set in your Hugging Face Space secrets.")
@@ -94,7 +83,7 @@ app = FastAPI(
 # Pydantic model for request body validation
 class QueryRequest(BaseModel):
     question: str
-    conversation_id: str = None # Optional for new conversations
+    conversation_id: str = None
 
 # --- API Endpoint Definition ---
 @app.post("/compassia/")
@@ -103,9 +92,6 @@ async def compassia_endpoint(request: QueryRequest):
     Answers a question about the indexed PDF documents using RAG, with conversational memory.
     """
     try:
-        # Pass conversation_id to the answer_question function.
-        # The add_document logic is now handled internally by rag_system during initialization
-        # and when new documents are added (though here they are all added at startup).
         answer = rag_system.answer_question(request.question, conversation_id=request.conversation_id)
         return {"answer": answer, "conversation_id": request.conversation_id}
     except Exception as e: