fyp

app/ai/routes/chat_refactored.py

@@ -1,7 +1,7 @@
 # app/ai/routes/chat_refactored.py
 """
 AIDA Chat Endpoint - LangGraph Powered (NO AUTH)
-Uses proper LangGraph architecture - No JWT authentication required
+Fixed ainvoke for proper state passing
 """
 
 from fastapi import APIRouter, HTTPException
@@ -27,11 +27,11 @@ class AskBody(BaseModel):
     """Request body for /ask endpoint"""
     message: str
     session_id: Optional[str] = None
-    user_id: Optional[str] = None  # Optional - will generate if not provided
+    user_id: Optional[str] = None
 
 
 # ============================================================
-# MAIN CHAT ENDPOINT - LANGGRAPH POWERED (NO AUTH)
+# MAIN CHAT ENDPOINT - LANGGRAPH POWERED (FIXED)
 # ============================================================
 
 @router.post("/ask", response_model=AgentResponse)
@@ -39,14 +39,7 @@ async def ask_ai(
     body: AskBody,
 ) -> AgentResponse:
     """
-    Main chat endpoint using LangGraph.
-    NO AUTHENTICATION REQUIRED - Anyone can use it.
-    
-    Flow:
-    1. Generate user_id if not provided (anonymous user)
-    2. Initialize state
-    3. Execute LangGraph
-    4. Return response
+    Main chat endpoint using LangGraph - FIXED VERSION
     """
     
     logger.info("🚀 Chat request received", message_len=len(body.message))
@@ -62,22 +55,17 @@ async def ask_ai(
         
         message = body.message.strip()
         session_id = body.session_id or str(uuid.uuid4())
-        
-        # Generate user_id if not provided (anonymous user)
         user_id = body.user_id or f"anonymous_{uuid.uuid4()}"
-        
-        # Default role for anonymous users
         user_role = "renter"
         
         logger.info(
             "User session started",
             user_id=user_id,
-            user_role=user_role,
             session_id=session_id,
         )
         
         # ============================================================
-        # STEP 2: Initialize state
+        # STEP 2: Create AgentState (NOT a dict!)
         # ============================================================
         
         state = AgentState(
@@ -86,29 +74,26 @@ async def ask_ai(
             user_role=user_role,
         )
         
-        # Add message to history
+        # Add user message to history
         state.add_message("user", message)
         state.last_user_message = message
         
-        logger.info("State initialized", state_summary=state.get_summary())
+        logger.info("State initialized", user_id=user_id)
         
         # ============================================================
-        # STEP 3: Get LangGraph and execute
+        # STEP 3: Get graph and execute with proper state
         # ============================================================
         
         graph = get_aida_graph()
         
-        logger.info("📍 Executing LangGraph")
+        if graph is None:
+            logger.error("❌ Graph is None!")
+            raise HTTPException(status_code=500, detail="Graph initialization failed")
         
-        # Execute the graph
-        # LangGraph handles all node execution and routing
-        final_state = await graph.ainvoke({
-            "user_id": user_id,
-            "session_id": session_id,
-            "user_role": user_role,
-            "last_user_message": message,
-            "conversation_history": state.conversation_history,
-        })
+        logger.info("📍 Executing LangGraph with state")
+        
+        # ✅ FIX: Pass the AgentState object directly, not a dict
+        final_state = await graph.ainvoke(state)
         
         logger.info(
             "✅ LangGraph execution completed",
@@ -117,7 +102,7 @@ async def ask_ai(
         )
         
         # ============================================================
-        # STEP 4: Build response
+        # STEP 4: Build response from final state
         # ============================================================
         
         response_text = final_state.temp_data.get("response_text", "")
@@ -125,6 +110,9 @@ async def ask_ai(
         draft = final_state.temp_data.get("draft")
         draft_ui = final_state.temp_data.get("draft_ui")
         
+        if not response_text:
+            response_text = "I'm here to help! What would you like to do?"
+        
         response = AgentResponse(
             success=final_state.last_error is None,
             text=response_text,
@@ -164,7 +152,7 @@ async def ask_ai(
         logger.error("❌ Chat endpoint error", exc_info=e)
         raise HTTPException(
             status_code=500,
-            detail="Internal server error"
+            detail=f"Internal server error: {str(e)}"
         )
 
 
@@ -177,16 +165,13 @@ async def health_check():
     """Health check for chat service"""
     
     try:
-        # Initialize graph to test it works
         graph = get_aida_graph()
         
         return {
             "status": "healthy",
             "service": "AIDA Chat (LangGraph)",
-            "architecture": "LangGraph (Industry Standard)",
             "version": "2.0.0",
-            "graph_nodes": 10,
-            "authentication": "DISABLED - Public Access",
+            "graph_available": graph is not None,
         }
     except Exception as e:
         logger.error("Health check failed", exc_info=e)
@@ -197,38 +182,12 @@ async def health_check():
 
 
 # ============================================================
-# VISUALIZATION ENDPOINT (Optional - for debugging)
-# ============================================================
-
-@router.get("/graph/structure")
-async def graph_structure():
-    """Get the graph structure as ASCII art"""
-    
-    try:
-        from app.ai.agent.graph import print_graph_structure
-        print_graph_structure()
-        
-        return {
-            "status": "success",
-            "message": "Graph structure printed to logs",
-        }
-    except Exception as e:
-        logger.error("Could not get graph structure", exc_info=e)
-        return {
-            "status": "error",
-            "error": str(e),
-        }
-
-
-# ============================================================
-# HISTORY ENDPOINT (Anonymous users)
+# HISTORY ENDPOINT
 # ============================================================
 
 @router.get("/history/{session_id}")
-async def get_history(
-    session_id: str,
-):
-    """Get conversation history for a session (no auth required)"""
+async def get_history(session_id: str):
+    """Get conversation history for a session"""
     
     try:
         logger.info("Retrieved history", session_id=session_id)
@@ -236,7 +195,7 @@ async def get_history(
         return {
             "success": True,
             "session_id": session_id,
-            "messages": [],  # TODO: Fetch from Redis
+            "messages": [],
         }
     
     except Exception as e:
@@ -249,10 +208,8 @@ async def get_history(
 # ============================================================
 
 @router.post("/reset-session/{session_id}")
-async def reset_session(
-    session_id: str,
-):
-    """Reset a session to fresh state (no auth required)"""
+async def reset_session(session_id: str):
+    """Reset a session to fresh state"""
     
     try:
         logger.info("Session reset", session_id=session_id)