Spaces:

devaanand
/

ccr-platform

Running

devaanand commited on 25 days ago

Commit

c49bb09

1 Parent(s): dc9da41

feat: audit trail for AI drafts + disabled-button reasons everywhere

- ConstructGeneration.items stores the ORIGINAL drafted items (PI request
2026-08-07): run metadata now shows the as-drafted text alongside the
researcher's saved/edited items
- Draft-items button disabled until Name + Description exist, reason
inline (same pattern as Save; errors in the top banner go unseen)
- Run button gets a 'To run, still needed: ...' line when disabled
- AI generation quota shown from tab-open via auth/me, not only after
the first draft

Files changed (6) hide show

backend/app/main.py +4 -1
backend/app/schemas.py +4 -0
backend/static/assets/{index-T4JgSqf6.js → index-C3sV34vl.js} +0 -0
backend/static/index.html +1 -1
backend/tests/test_item_generation.py +7 -1
frontend/src/Workspace.jsx +48 -4

backend/app/main.py CHANGED Viewed

@@ -789,7 +789,10 @@ def generate_construct_items(
     return GenerateItemsOut(
         items=draft.items,
         notes=draft.notes,
-        generation=ConstructGeneration(**stamp),
         generations_used_today=used + 1,
         max_generations_per_day=cap,
     )

     return GenerateItemsOut(
         items=draft.items,
         notes=draft.notes,
+        # items ride inside the stamp so the client echoes the full audit
+        # record on save: what the AI drafted, distinct from what the
+        # researcher edits and saves.
+        generation=ConstructGeneration(**stamp, items=draft.items),
         generations_used_today=used + 1,
         max_generations_per_day=cap,
     )

backend/app/schemas.py CHANGED Viewed

@@ -55,6 +55,10 @@ class ConstructGeneration(BaseModel):
     model: str = Field(min_length=1, max_length=120)
     prompt_version: str = Field(min_length=1, max_length=40)
     generated_at: str = Field(min_length=1, max_length=40)
 class ConstructCreate(BaseModel):

     model: str = Field(min_length=1, max_length=120)
     prompt_version: str = Field(min_length=1, max_length=40)
     generated_at: str = Field(min_length=1, max_length=40)
+    # The items exactly as drafted, BEFORE the researcher's edits - the audit
+    # trail that lets metadata show original draft vs. saved items (PI request
+    # 2026-08-07). Caps sized to the generation limits, not user needs.
+    items: list[str] | None = Field(default=None, max_length=30)
 class ConstructCreate(BaseModel):

backend/static/assets/{index-T4JgSqf6.js → index-C3sV34vl.js} RENAMED Viewed

The diff for this file is too large to render. See raw diff

backend/static/index.html CHANGED Viewed

@@ -5,7 +5,7 @@
     <meta name="viewport" content="width=device-width, initial-scale=1.0" />
     <link rel="icon" type="image/svg+xml" href="/ccr-logo.svg" />
     <title>CCR Platform - Contextualized Construct Representations</title>
-    <script type="module" crossorigin src="/assets/index-T4JgSqf6.js"></script>
     <link rel="stylesheet" crossorigin href="/assets/index-Ckv10U9Q.css">
   </head>
   <body>

     <meta name="viewport" content="width=device-width, initial-scale=1.0" />
     <link rel="icon" type="image/svg+xml" href="/ccr-logo.svg" />
     <title>CCR Platform - Contextualized Construct Representations</title>
+    <script type="module" crossorigin src="/assets/index-C3sV34vl.js"></script>
     <link rel="stylesheet" crossorigin href="/assets/index-Ckv10U9Q.css">
   </head>
   <body>

backend/tests/test_item_generation.py CHANGED Viewed

@@ -193,12 +193,15 @@ def test_saved_generated_construct_carries_provenance(client, monkeypatch):
     register(client, "genprov@test.edu")
     draft = client.post("/api/constructs/generate-items", json=GEN_BODY).json()
     created = client.post(
         "/api/constructs",
         json={
             "name": "Gratitude (generated)",
             "description": GEN_BODY["description"],
-            "items": draft["items"],
             "generation": draft["generation"],
         },
     ).json()
@@ -220,6 +223,9 @@ def test_saved_generated_construct_carries_provenance(client, monkeypatch):
     assert snapshot["source_type"] == "llm_generated"
     assert snapshot["generation"]["prompt_version"] == item_generation.PROMPT_VERSION
     assert "AI-generated" in snapshot["items_source_note"]
     client.cookies.clear()

     register(client, "genprov@test.edu")
     draft = client.post("/api/constructs/generate-items", json=GEN_BODY).json()
+    # The stamp carries the as-drafted items (the audit record).
+    assert draft["generation"]["items"] == FAKE_DRAFT.items
+    edited = [draft["items"][0] + " (edited)"] + draft["items"][1:]
     created = client.post(
         "/api/constructs",
         json={
             "name": "Gratitude (generated)",
             "description": GEN_BODY["description"],
+            "items": edited,  # researcher edits; original draft stays in generation
             "generation": draft["generation"],
         },
     ).json()
     assert snapshot["source_type"] == "llm_generated"
     assert snapshot["generation"]["prompt_version"] == item_generation.PROMPT_VERSION
     assert "AI-generated" in snapshot["items_source_note"]
+    # Audit trail: metadata shows BOTH the original draft and the saved items.
+    assert snapshot["generation"]["items"] == FAKE_DRAFT.items
+    assert snapshot["items"][0]["text"].endswith("(edited)")
     client.cookies.clear()

frontend/src/Workspace.jsx CHANGED Viewed

@@ -447,6 +447,22 @@ export default function Workspace({ project, auth, onAuthRefresh, onProjectChang
                 : "Run CCR analysis"}
           </button>
         </div>
         {auth && !auth.signed_in && auth.usage?.max_runs_per_day != null && (
           <p className="small muted">
             {Math.min(auth.usage.runs_used_today, auth.usage.max_runs_per_day)} of{" "}
@@ -552,6 +568,17 @@ function NewConstructForm({ auth, constructs, source, onSourceChange, onCreated,
   const itemsRef = useRef(null);
   const setSource = onSourceChange;
   // Simple library name-match (v1 guardrail, PI-approved): if a validated
   // scale with a similar name exists, say so before anyone generates.
   const nameQuery = name.trim().toLowerCase();
@@ -654,12 +681,15 @@ function NewConstructForm({ auth, constructs, source, onSourceChange, onCreated,
         description: description.trim(),
         items: parsed.map((i) => i.text),
         reverse_scored: parsed.map((i) => i.reverse),
-        // provenance stamp when AI-drafted (schema fields only)
         generation: genInfo
           ? {
               model: genInfo.model,
               prompt_version: genInfo.prompt_version,
               generated_at: genInfo.generated_at,
             }
           : undefined,
       });
@@ -777,18 +807,32 @@ function NewConstructForm({ auth, constructs, source, onSourceChange, onCreated,
                 ))}
               </select>
             </label>
             <button
               type="button"
               className="primary"
               onClick={handleGenerate}
-              disabled={generating || saving || parsing}
             >
               {generating ? "Drafting…" : "Draft items"}
             </button>
           </div>
-          {genUsage && (
             <p className="small muted">
-              {genUsage.used} of {genUsage.max} AI generations used today.
             </p>
           )}
           {genInfo && (

                 : "Run CCR analysis"}
           </button>
         </div>
+        {/* Disabled-until-valid with the reason inline (same pattern as the
+            construct form's Save) - a dead button with no visible cause is
+            the top tester confusion. */}
+        {!canRun && !running && !fileMissing && (
+          <p className="small muted">
+            To run, still needed:{" "}
+            {[
+              !corpusId && "a dataset (Step 1)",
+              corpusId && !textColumn && "a text column (Step 1)",
+              constructIds.length === 0 && "at least one construct (Step 2)",
+            ]
+              .filter(Boolean)
+              .join(", ")}
+            .
+          </p>
+        )}
         {auth && !auth.signed_in && auth.usage?.max_runs_per_day != null && (
           <p className="small muted">
             {Math.min(auth.usage.runs_used_today, auth.usage.max_runs_per_day)} of{" "}
   const itemsRef = useRef(null);
   const setSource = onSourceChange;
+  // Quota shown from the first tab-open (auth/me carries it), replaced by the
+  // fresher count from each generate response.
+  const quotaInfo =
+    genUsage ||
+    (auth?.usage?.max_generations_per_day != null
+      ? {
+          used: auth.usage.generations_used_today,
+          max: auth.usage.max_generations_per_day,
+        }
+      : null);
   // Simple library name-match (v1 guardrail, PI-approved): if a validated
   // scale with a similar name exists, say so before anyone generates.
   const nameQuery = name.trim().toLowerCase();
         description: description.trim(),
         items: parsed.map((i) => i.text),
         reverse_scored: parsed.map((i) => i.reverse),
+        // provenance stamp when AI-drafted (schema fields only); `items` is
+        // the ORIGINAL draft - the audit record of what the AI produced
+        // before the researcher's edits
         generation: genInfo
           ? {
               model: genInfo.model,
               prompt_version: genInfo.prompt_version,
               generated_at: genInfo.generated_at,
+              items: genInfo.items,
             }
           : undefined,
       });
                 ))}
               </select>
             </label>
+            {/* Disabled-until-valid with the reason inline - same pattern as
+                Save; a clickable button whose error lands in the far-away top
+                banner reads as broken. */}
             <button
               type="button"
               className="primary"
               onClick={handleGenerate}
+              disabled={
+                generating || saving || parsing || !name.trim() || !description.trim()
+              }
             >
               {generating ? "Drafting…" : "Draft items"}
             </button>
           </div>
+          {(!name.trim() || !description.trim()) && (
+            <p className="small muted">
+              To draft, first fill in
+              {!name.trim() ? " the Name" : ""}
+              {!name.trim() && !description.trim() ? " and" : ""}
+              {!description.trim() ? " the Description (a few sentences on what the construct means)" : ""}
+              {" "}above.
+            </p>
+          )}
+          {quotaInfo && (
             <p className="small muted">
+              {quotaInfo.used} of {quotaInfo.max} AI generations used today.
             </p>
           )}
           {genInfo && (