V5.7.1: Unified Product State Authority - Fixed post-pricing amnesia & enabled multi-product support

controllers/chatController.js

@@ -80,7 +80,7 @@ async function handleChat(req, res) {
                 if (compilation.deleted_items && compilation.deleted_items.length > 0) {
                     compilation.deleted_items.forEach(product => {
                         session.cart = session.cart.filter(item => item.product !== product);
-                        delete session.draftAttributes[product];
+                        // session.active_products deletion is handled by the planner
                     });
                 }
 
@@ -92,11 +92,14 @@ async function handleChat(req, res) {
                         ...item.params
                     });
                     pushToSessionCart(session, productionItem);
-                    delete session.draftAttributes[item.product];
+
+                    // Spec v5.7.1: Keep the product in the session state but mark it as priced
+                    const activeProd = (session.active_products || []).find(p => p.type === item.product && p.status !== 'confirmed');
+                    if (activeProd) activeProd.status = 'priced';
                 });
 
                 // C. Status Updates (Only append if LLM didn't explain the status)
-                const draftProducts = Object.keys(session.draftAttributes || {});
+                const draftProducts = (session.active_products || []).filter(p => p.status === 'draft').map(p => p.type);
                 if (draftProducts.length > 0 && !responseMsg.includes("📌") && !responseMsg.includes("חסר")) {
                     const pendingLabels = draftProducts.map(p => DOMAIN_TEMPLATES.products[p]?.label || p);
                     const readyLabels = session.cart.map(i => i.displayName);
@@ -125,7 +128,8 @@ async function handleChat(req, res) {
             }
 
             const uiCart = [...session.cart];
-            Object.keys(session.draftAttributes || {}).forEach(prodKey => {
+            (session.active_products || []).filter(p => p.status === 'draft').forEach(draftItem => {
+                const prodKey = draftItem.type;
                 if (!uiCart.find(c => c.product === prodKey)) {
                     const meta = DOMAIN_TEMPLATES.products[prodKey] || {};
                     uiCart.push({
@@ -133,7 +137,7 @@ async function handleChat(req, res) {
                         displayName: meta.label || prodKey,
                         isPending: true,
                         client_price: 0,
-                        qty: session.draftAttributes[prodKey].params?.qty || 0
+                        qty: draftItem.attributes?.qty || 0
                     });
                 }
             });

db/usage.json

@@ -1,4 +1,4 @@
 {
-  "dailyCost": 0.023361750000000004,
-  "lastReset": "2026-02-26"
+  "dailyCost": 0.0012441000000000002,
+  "lastReset": "2026-02-27"
 }

engine/planner.js

@@ -81,16 +81,16 @@ function applyDeterministicSanitizer(extractedData, session) {
  */
 function buildSessionStateContext(session) {
     const product = session.currentProduct || "unknown";
-    const draft = session.draftAttributes[product] || { params: {} };
+    const activeProduct = (session.active_products || []).find(p => p.type === product && p.status !== 'confirmed') || { attributes: {} };
     let missing = [];
     const template = DOMAIN_TEMPLATES.products[product];
     if (template && template.mandatory) {
-        missing = template.mandatory.filter(p => !draft.params[p]);
+        missing = template.mandatory.filter(p => !activeProduct.attributes[p]);
     }
     return {
         current_intent: session.lastIntent || "unknown",
         active_product: product,
-        extracted_slots: draft.params,
+        extracted_slots: activeProduct.attributes,
         missing_mandatory_slots: missing,
         conversation_phase: missing.length > 0 ? "slot_filling" : (product !== "unknown" ? "ready_for_quote" : "discovery"),
         last_bot_question: session.lastBotMessage || "None"
@@ -161,8 +161,8 @@ function getJITKnowledge(text, extraction = null) {
  */
 function compileOrder(extractedData, session) {
     try {
-        console.log("🧩 [COMPILER] Processing turn (v5.7 - Stateful Advisor)...");
-        if (!session.draftAttributes) session.draftAttributes = {};
+        console.log("🧩 [COMPILER] Processing turn (v5.7.1 - Unified Product State)...");
+        if (!session.active_products) session.active_products = [];
         applyDeterministicSanitizer(extractedData, session);
 
         let buckets = {};
@@ -183,12 +183,17 @@ function compileOrder(extractedData, session) {
         extractedData.products_detected.forEach(item => {
             const normProduct = normalizeEntity(item.product);
             if (!DOMAIN_TEMPLATES.products[normProduct]) return;
-            if (!session.draftAttributes[normProduct]) {
-                session.draftAttributes[normProduct] = { params: {}, history: {}, status: 'PENDING' };
+
+            let activeItem = session.active_products.find(p => p.type === normProduct && p.status !== 'confirmed');
+            if (!activeItem) {
+                activeItem = { type: normProduct, status: 'draft', attributes: {}, history: {} };
+                session.active_products.push(activeItem);
             }
-            if (item.confidence >= 0.6) session.draftAttributes[normProduct].status = 'EXTRACTED';
+
+            if (item.confidence >= 0.6 && activeItem.status === 'draft') activeItem.status = 'extracted';
+
             if (isDeleteIntent && (extractedData.raw_text.includes(normProduct) || extractedData.raw_text.includes(DOMAIN_TEMPLATES.products[normProduct]?.label))) {
-                delete session.draftAttributes[normProduct];
+                session.active_products = session.active_products.filter(p => p !== activeItem);
                 if (session.cart) session.cart = session.cart.filter(c => c.product !== normProduct);
                 deletedItems.push(normProduct);
             }
@@ -199,28 +204,33 @@ function compileOrder(extractedData, session) {
             const contextKey = normalizeEntity(param.context);
             if (contextKey === 'global') return;
             if (!DOMAIN_TEMPLATES.products[contextKey]) return;
-            if (!session.draftAttributes[contextKey]) {
-                session.draftAttributes[contextKey] = { params: {}, history: {}, status: 'PENDING' };
+
+            let activeItem = session.active_products.find(p => p.type === contextKey && p.status !== 'confirmed');
+            if (!activeItem) {
+                activeItem = { type: contextKey, status: 'draft', attributes: {}, history: {} };
+                session.active_products.push(activeItem);
             }
-            const target = session.draftAttributes[contextKey];
+
             const allowedParams = PRODUCT_WHITELIST[contextKey] || [];
             if (allowedParams.includes(param.key)) {
-                if (!target.history[param.key]) target.history[param.key] = [];
-                target.history[param.key].push(param.value);
-                target.params[param.key] = param.value;
+                if (!activeItem.history[param.key]) activeItem.history[param.key] = [];
+                activeItem.history[param.key].push(param.value);
+                activeItem.attributes[param.key] = param.value;
                 session.lastSpecChangeTime = Date.now();
             }
         });
 
-        for (const [product, data] of Object.entries(session.draftAttributes)) {
+        for (const activeItem of session.active_products) {
+            if (activeItem.status === 'confirmed') continue;
+
             let itemUnstable = false;
-            for (const [key, history] of Object.entries(data.history)) {
+            for (const [key, history] of Object.entries(activeItem.history || {})) {
                 const uniqueValues = new Set(history.map(v => String(v)));
                 if (uniqueValues.size > 1) itemUnstable = true;
             }
-            let finalParams = { ...data.params };
-            buckets[product] = {
-                status: data.status === 'EXTRACTED' ? "READY_FOR_INTEGRITY" : "PENDING_CONFIRMATION",
+            let finalParams = { ...activeItem.attributes };
+            buckets[activeItem.type] = {
+                status: activeItem.status === 'extracted' ? "READY_FOR_INTEGRITY" : "PENDING_CONFIRMATION",
                 params: finalParams,
                 unstable: itemUnstable
             };

sanity_results.json

@@ -0,0 +1,94 @@
+{
+  "test1": {
+    "input": "צריך 1000 כרטיסי ביקור",
+    "classification": {
+      "intent": "quote",
+      "answer_text": "אוקיי, 1000 כרטיסי ביקור. איזה סוג נייר תרצה?",
+      "products_detected": [
+        {
+          "product": "bc",
+          "confidence": 0.95
+        }
+      ],
+      "parameters_detected": [
+        {
+          "key": "qty",
+          "value": "1000",
+          "context": "bc",
+          "confidence": 1
+        }
+      ],
+      "_debug": {
+        "tokens": {
+          "in": 857,
+          "out": 133,
+          "total": 990
+        },
+        "governance": "v5.7-StatefulAdvisor"
+      },
+      "raw_text": "צריך 1000 כרטיסי ביקור",
+      "technicalMetadata": null
+    }
+  },
+  "test2": {
+    "input": "אהלן פיני, מה העניינים? אני רוצה להדפיס חוברת שירים לסבתא שלי.",
+    "classification": {
+      "intent": "quote",
+      "answer_text": "שלום! אני שמח לעזור לך עם חוברת השירים לסבתא. כדי שאוכל לתת לך הצעת מחיר מדויקת, אני צריך לדעת כמה עמודים יהיו בחוברת וכמה עותקים תרצי להדפיס?",
+      "products_detected": [
+        {
+          "product": "booklet",
+          "confidence": 0.95
+        }
+      ],
+      "parameters_detected": [],
+      "_debug": {
+        "tokens": {
+          "in": 871,
+          "out": 124,
+          "total": 995
+        },
+        "governance": "v5.7-StatefulAdvisor"
+      },
+      "raw_text": "אהלן פיני, מה העניינים? אני רוצה להדפיס חוברת שירים לסבתא שלי.",
+      "technicalMetadata": null
+    },
+    "planner_status": "CONSULTATIVE_ACTIVE",
+    "planner_guidance": [
+      "כדי לתמחר ספר, אני צריך לדעת: כמה עמודים יש בו? מה הגודל (A4/A5)? ואיזה סוג כריכה (רכה/קשה/סיכות)?"
+    ]
+  },
+  "test3": {
+    "input": "אני רוצה רולאפ קטן, מטר על מטר.",
+    "classification": {
+      "intent": "quote",
+      "answer_text": "הבנתי, אתה רוצה רולאפ בגודל מטר על מטר. מצוין! איזה סוג חומר אתה מעדיף לרולאפ שלך?",
+      "products_detected": [
+        {
+          "product": "rollup",
+          "confidence": 1
+        }
+      ],
+      "parameters_detected": [
+        {
+          "key": "size",
+          "value": "1x1",
+          "context": "rollup",
+          "confidence": 0.95
+        }
+      ],
+      "_debug": {
+        "tokens": {
+          "in": 860,
+          "out": 147,
+          "total": 1007
+        },
+        "governance": "v5.7-StatefulAdvisor"
+      },
+      "raw_text": "אני רוצה רולאפ קטן, מטר על מטר.",
+      "technicalMetadata": null
+    },
+    "planner_status": "CONSULTATIVE_ACTIVE",
+    "planner_validation": []
+  }
+}

services/sessionManager.js

@@ -22,7 +22,7 @@ function getSession(userId) {
             id: userId,
             cart: [],           // המוצרים שנוספו לעגלה
             currentProduct: null, // המוצר שעליו מדברים כרגע
-            draftAttributes: {},  // תשובות זמניות (לפני חישוב)
+            active_products: [],  // [Spec v5.7.1] מודל שיחה שומר סטטוס של מוצרים: draft, priced
             processedRequests: new Map(),
             lastActive: Date.now(),
             lastSpecChangeTime: Date.now(), // Tracking for Semantic Aging
@@ -48,7 +48,7 @@ function getSession(userId) {
 
     // Phase 5.3: Semantic Aging (Drift Detection)
     const driftDelta = (Date.now() - session.lastSpecChangeTime) / 1000 / 60; // in minutes
-    if (driftDelta >= 8 && driftDelta <= 12 && session.draftAttributes && Object.keys(session.draftAttributes).length > 0) {
+    if (driftDelta >= 8 && driftDelta <= 12 && session.active_products && session.active_products.length > 0) {
         session.driftDetected = true;
         console.log(`⏳ [SESSION] Semantic Aging detected for ${userId}: ${driftDelta.toFixed(1)}m`);
     } else {
@@ -133,7 +133,7 @@ function releaseFailedRequest(session, requestId) {
 function clearSession(userId) {
     if (sessions[userId]) {
         sessions[userId].currentProduct = null;
-        sessions[userId].draftAttributes = {};
+        sessions[userId].active_products = [];
         sessions[userId].history = [];
         sessions[userId].lastBotMessage = null;
         console.log(`🧹 Session context cleared for: ${userId}`);
@@ -144,7 +144,7 @@ function clearCart(userId) {
     if (sessions[userId]) {
         sessions[userId].cart = [];
         sessions[userId].currentProduct = null;
-        sessions[userId].draftAttributes = {};
+        sessions[userId].active_products = [];
         sessions[userId].history = [];
         sessions[userId].lastBotMessage = null;
         console.log(`🗑️ Cart emptied for: ${userId}`);

tests/test_sanity.js

@@ -1,6 +1,6 @@
 require('dotenv').config({ path: '../.env' });
 const { classifyMessage } = require('../engine/classifier');
-const { planActions } = require('../engine/planner');
+const { compileOrder } = require('../engine/planner');
 const fs = require('fs');
 
 async function runSanityTests() {
@@ -11,17 +11,17 @@ async function runSanityTests() {
     let intent1 = await classifyMessage(text1, session1);
     report.test1 = { input: text1, classification: intent1 };
 
-    let session2 = { cart: [], currentProduct: null };
+    let session2 = { cart: [], currentProduct: null, active_products: [] };
     let text2 = "אהלן פיני, מה העניינים? אני רוצה להדפיס חוברת שירים לסבתא שלי.";
     let intent2 = await classifyMessage(text2, session2);
-    let plan2 = planActions(intent2, session2);
-    report.test2 = { input: text2, classification: intent2, planner_question: plan2.actions[0].question };
+    let plan2 = compileOrder(intent2, session2);
+    report.test2 = { input: text2, classification: intent2, planner_status: plan2.status, planner_guidance: plan2.fallback_guidance };
 
-    let session3 = { cart: [], currentProduct: 'alucobond', draftAttributes: { qty: 1 } };
-    let text3 = "אני רוצה שלט אלוקובונד קטן, 10 על 10 ס\"מ.";
+    let session3 = { cart: [], currentProduct: 'rollup', active_products: [{ type: 'rollup', status: 'draft', attributes: { qty: 1 }, history: { qty: [1] } }] };
+    let text3 = "אני רוצה רולאפ קטן, מטר על מטר.";
     let intent3 = await classifyMessage(text3, session3);
-    let plan3 = planActions(intent3, session3);
-    report.test3 = { input: text3, classification: intent3, planner_actions: plan3.actions };
+    let plan3 = compileOrder(intent3, session3);
+    report.test3 = { input: text3, classification: intent3, planner_status: plan3.status, planner_validation: plan3.items };
 
     fs.writeFileSync('sanity_results.json', JSON.stringify(report, null, 2), 'utf8');
     console.log("DONE");

tests/test_v5_7_state.js

@@ -0,0 +1,75 @@
+require('dotenv').config({ path: '../.env' });
+const { classifyMessage } = require('../engine/classifier');
+const { compileOrder, buildSessionStateContext } = require('../engine/planner');
+const { calculate_custom_job } = require('../engine/calculation');
+
+async function runTest() {
+    console.log("🚀 Starting Spec v5.7.1 State Persistence Test...\n");
+
+    let session = {
+        cart: [],
+        currentProduct: null,
+        active_products: [],
+        history: [],
+        processedRequests: new Map()
+    };
+
+    // --- TURN 1: Initial Request (Draft State) ---
+    console.log("🗣️ User: אני רוצה להדפיס חוברות כרומו מאט A4, כמות 300, סגירת סיכות");
+    let text1 = "אני רוצה להדפיס חוברות כרומו מאט A4, כמות 300, סגירת סיכות";
+    let intent1 = await classifyMessage(text1, session);
+    let comp1 = compileOrder(intent1, session);
+
+    console.log("📦 State after Turn 1:");
+    console.log(JSON.stringify(session.active_products, null, 2));
+    console.log("🤖 System Status:", comp1.status);
+    console.log("🤖 System Fallback Guidance:", comp1.fallback_guidance);
+    // Should be MISSING pages.
+
+    console.log("\n------------------------------------------------\n");
+
+    // --- TURN 2: Provide Missing Parameter (Priced State) ---
+    console.log("🗣️ User: 120 עמודים");
+    let text2 = "120 עמודים";
+    let intent2 = await classifyMessage(text2, session);
+    let comp2 = compileOrder(intent2, session);
+
+    // Simulate ChatController transition to cart
+    if (comp2.items && comp2.items.length > 0) {
+        comp2.items.forEach(item => {
+            if (calculate_custom_job) {
+                // mock pricing since it might require other deps
+                session.cart.push({ product: item.product, ...item.params, price: 500 });
+            }
+            const activeItem = session.active_products.find(p => p.type === item.product && p.status !== 'confirmed');
+            if (activeItem) activeItem.status = 'priced';
+        });
+    }
+
+    console.log("🛒 Cart:", session.cart.length, "items.");
+    console.log("📦 State after Turn 2 (Should be 'priced' but NOT deleted):");
+    console.log(JSON.stringify(session.active_products, null, 2));
+
+    console.log("\n------------------------------------------------\n");
+
+    // --- TURN 3: Up-sell / Modification on Priced Item ---
+    console.log("🗣️ User: בעצם תשנה את הכמות ל-500");
+    let text3 = "בעצם תשנה את הכמות ל-500";
+    let intent3 = await classifyMessage(text3, session);
+    let comp3 = compileOrder(intent3, session);
+
+    console.log("📦 State after Turn 3 (Checking Amnesia Resistance):");
+    console.log(JSON.stringify(session.active_products, null, 2));
+
+    // If it remembered all attributes, missing should be empty or strictly related to stability, not missing mandatory fields like paper_type.
+    let activeBooklet = session.active_products.find(p => p.type === 'booklet');
+
+    console.log("\n🧪 TEST RESULT:");
+    if (activeBooklet && activeBooklet.attributes.paper_type && activeBooklet.attributes.qty == 500 && activeBooklet.attributes.pages) {
+        console.log("✅ SUCCESS - LLM retained full context without parsing from UI.");
+    } else {
+        console.log("❌ FAILED - LLM suffered from amnesia.");
+    }
+}
+
+runTest().catch(console.error);