Deploy from GitHub Actions

analysis.py

@@ -2411,6 +2411,7 @@ def plot_seasonal_line(
     parameter: str,
     period: str = "quarterly",
     thresh: float | None = None,
+    sector: str | None = None,
 ) -> tuple[Figure, pd.DataFrame, pd.DataFrame]:
     """
     Create a line chart showing seasonal trends for a parameter across all years.
@@ -2425,7 +2426,8 @@ def plot_seasonal_line(
         'monthly' or 'quarterly' aggregation period
     thresh : float | None
         Optional threshold value to display on plot
-
+    sector : str | None
+        Optional sector name to include in title
     Returns:
     --------
     tuple[Figure, pd.DataFrame]
@@ -2463,12 +2465,23 @@ def plot_seasonal_line(
     # Calculate overall average for dotted line
     stats_df["overall_avg"] = param_data["Org_Result_Value"].mean()
 
-    # Create figure
     fig, ax = plt.subplots(figsize=(10, 6))
 
     # Get the unit
     unit = param_data["Org_Result_Unit"].iloc[0]
 
+    # Set log scale for specific parameters
+    if parameter in [
+        "Turbidity",
+        "Fecal Coliform (MPN)",
+        "Total Nitrogen",
+        "Total Phosphorus",
+    ]:
+        ax.set_yscale("log")
+        ax.yaxis.set_major_formatter(
+            plt.ScalarFormatter()  # type: ignore
+        )
+
     # Plot mean line
     mean_line = ax.plot(
         stats_df[group_col],
@@ -2483,9 +2496,9 @@ def plot_seasonal_line(
     ax.annotate(
         "Mean",
         xy=(stats_df[group_col].iloc[0], stats_df["mean"].iloc[0]),
-        xytext=(-5, 0),  # Shifted left of the point
+        xytext=(-5, 0),
         textcoords="offset points",
-        ha="right",  # Right-align text to point left
+        ha="right",
         va="center",
         color=mean_line.get_color(),
         fontsize=9,
@@ -2573,6 +2586,19 @@ def plot_seasonal_line(
             label=f"Threshold: {thresh} {unit}",
             zorder=1,
         )
+        # Add legend for threshold only
+        ax.legend(
+            [
+                ax.axhline(
+                    y=thresh, color="red", linestyle=":", alpha=0.9, linewidth=1.5
+                )
+            ],
+            [f"Threshold: {thresh} {unit}"],
+            loc="upper right",
+            frameon=False,
+            handletextpad=0.5,
+            fontsize=9,
+        )
 
     # Customize plot
     ax.set_xticks(x_ticks)
@@ -2631,7 +2657,7 @@ def plot_seasonal_line(
         # Remove tick marks but keep labels
         ax2.tick_params(axis="y", which="both", length=0)
     else:
-        ax.set_ylabel(f"{parameter} ({unit})")
+        ax.set_ylabel(f"{unit}")
 
     # Get year range for title
     start_year = param_data["Activity_Start_Date_Time"].dt.year.min()
@@ -2639,7 +2665,11 @@ def plot_seasonal_line(
     year_range = (
         f" ({start_year}-{end_year})" if start_year != end_year else f" ({start_year})"
     )
-    ax.set_title(f"Seasonal {parameter} Trends{year_range}")
+    title = f"Seasonal {parameter} Trends{year_range}"
+    if sector:
+        title = f"{title} - {sector}"
+    ax.set_title(title)
+
     ax.grid(True, axis="y", alpha=0.15, linestyle="-", color="gray")
 
     # Customize spines
@@ -2648,15 +2678,11 @@ def plot_seasonal_line(
     ax.spines["left"].set_visible(False)
 
     # Remove tick marks but keep labels
-    ax.tick_params(
-        axis="y", which="both", length=0
-    )  # Add this line to remove tick marks
+    ax.tick_params(axis="y", which="both", length=0)
 
     # Adjust layout based on unit type
     if unit == "deg C":
-        plt.tight_layout(
-            rect=(0, 0, 0.95, 1)
-        )  # Less right margin for temperature plots
+        plt.tight_layout(rect=(0, 0, 0.95, 1))
     else:
         plt.tight_layout(rect=(0, 0, 0.9, 1))
     stats_df.insert(0, "parameter", parameter)

ui/pages/seasonal_line_charts.py

@@ -67,6 +67,9 @@ plot_df = plot_df[
 # Apply sector filter
 if sector_filter != "All":
     plot_df = plot_df[plot_df["Sector"] == sector_filter]
+    sector = sector_filter
+else:
+    sector = None
 
 if not plot_df.empty:
     # Create plot for the selected parameter
@@ -84,7 +87,11 @@ if not plot_df.empty:
             thresh = None
 
         fig, param_data, stats_df = plot_seasonal_line(
-            plot_df, selected_parameter, period=period.lower(), thresh=thresh
+            plot_df,
+            selected_parameter,
+            period=period.lower(),
+            thresh=thresh,
+            sector=sector,
         )
         st.pyplot(fig)