test claude suggestions

hls_download.py

@@ -1,35 +1,34 @@
 import subprocess
 import os
-# import m3u8
-# import numpy as np
-# import matplotlib.pyplot as plt
-# from tqdm import tqdm
-# from moviepy.editor import VideoFileClip
-# from scipy.signal import correlate, find_peaks
-# from scipy.io import wavfile
-
 
 def download_clips(stream_url, out_dir, start_time, end_time, resize=True):
     output_file = os.path.join(out_dir, f"train_{len(os.listdir(out_dir))}.mp4")
-    # output video at 30fps
-    if resize:
-        subprocess.run(['ffmpeg', '-f', 'hls', '-i', stream_url, 
-                        '-ss', str(start_time - 2), 
-                        '-to', str(end_time + 2),  # pad end time by a couple of seconds
-                        '-r', str(30), 
-                        '-vcodec', 'libx264',
-                        '-crf', str(24),
-                        '-preset', 'fast',
-                        '-vf', 'scale=-2:360',
-                        '-c:a', 'copy', output_file])
-    else:
-        subprocess.run(['ffmpeg', '-f', 'hls', '-i', stream_url, 
-                        '-ss', str(start_time - 2), 
-                        '-to', str(end_time + 2),  # pad end time by a couple of seconds
-                        '-r', str(30), 
-                        '-vcodec', 'libx264',
-                        '-crf', str(24),
-                        '-preset', 'fast',
-                        '-vf', 'scale=-2:720',
-                        '-c:a', 'copy', output_file])
-    return output_file
+    
+    ffmpeg_cmd = [
+        'ffmpeg',
+        '-loglevel', 'warning',  # Reduce log output
+        '-f', 'hls',
+        '-i', stream_url,
+        '-ss', str(max(0, start_time - 2)),  # Ensure start time is not negative
+        '-to', str(end_time + 2),
+        '-r', '30',
+        '-c:v', 'libx264',
+        '-preset', 'ultrafast',  # Use fastest encoding preset
+        '-crf', '23',  # Slightly lower CRF for better quality
+        '-maxrate', '1M',  # Limit bitrate
+        '-bufsize', '2M',
+        '-vf', f"scale=-2:{360 if resize else 720}",
+        '-c:a', 'aac',  # Re-encode audio for better compatibility
+        '-b:a', '128k',
+        '-max_muxing_queue_size', '1024',  # Increase muxing queue size
+        '-y',  # Overwrite output file if it exists
+        output_file
+    ]
+    
+    try:
+        subprocess.run(ffmpeg_cmd, check=True, capture_output=True, text=True)
+        return output_file
+    except subprocess.CalledProcessError as e:
+        print(f"Error occurred: {e}")
+        print(f"FFmpeg output: {e.output}")
+        return None