Spaces:
Sleeping
Sleeping
File size: 11,294 Bytes
ab34aa7 | 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 | """
Node 3 (Grader): Reference Audit Grader β Sub-env 1.
This module implements the grader logic for Sub-env 1. The Node 3 grader
evaluates two upstream agent outputs:
- ``grade_image_diagnostics`` β Node 1 (Image Diagnostician)
- ``grade_anomaly_detection`` β Node 2 (Parameter Anomaly Detector)
The Node 1 and Node 2 graders are both exposed publicly in this module:
- ``grade_image_diagnostics``
- ``grade_anomaly_detection``
Risk calibration uses **ordinal distance**, not binary equality.
``failure_mode_prediction`` delegates to ``set_f1`` from
``src/utils/grader_utils`` β it is not re-implemented here.
"""
from __future__ import annotations
from src.schemas.ground_truth import GroundTruthImageAnnotation, GroundTruthParamAnnotation
from src.schemas.subenv1 import (
DirectionalFix,
ImageDiagnosticsAction,
ParamAnomalyAction,
ReferenceAuditHandoff,
)
from src.utils.grader_utils import set_f1
# Ordered risk levels used for ordinal-distance calibration (Node 2).
_RISK_LEVELS: list[str] = ["safe", "marginal", "risky", "dangerous"]
# ---------------------------------------------------------------------------
# Private helper
# ---------------------------------------------------------------------------
def _evaluate_directional_fixes(
agent_fixes: list[DirectionalFix],
valid_fixes: list[DirectionalFix],
) -> float:
"""Score the agent's directional fixes against the groud-truth valid set.
A fix is considered valid when both its ``target`` and ``direction``
match an entry in ``valid_fixes``. The score is the precision of
the agent's fix list against that valid set:
score = |matched| / |agent_fixes|
Special cases mirror the ``set_f1`` empty-set convention:
- Both empty β 1.0 (both sides agree: no fixes needed)
- Agent empty only β 0.0 (agent missed all required fixes)
- Valid empty only β 0.0 (agent hallucinated fixes)
Args:
agent_fixes: Fixes recommended by the agent (``ParamAnomalyAction``).
valid_fixes: Ground-truth valid fix directions
(``GroundTruthParamAnnotation.valid_fix_directions``).
Returns:
A float in [0.0, 1.0].
"""
if not agent_fixes and not valid_fixes:
return 1.0
if not agent_fixes or not valid_fixes:
return 0.0
valid_pairs: set[tuple[str, str]] = {
(fix.target, fix.direction) for fix in valid_fixes
}
matched = sum(
1 for fix in agent_fixes if (fix.target, fix.direction) in valid_pairs
)
return matched / len(agent_fixes)
# ---------------------------------------------------------------------------
# Node 2 grader
# ---------------------------------------------------------------------------
def grade_anomaly_detection(
agent_action: ParamAnomalyAction,
ground_truth: GroundTruthParamAnnotation,
) -> float:
"""Grade the Parameter Anomaly Detector agent output (Node 2).
Evaluates four dimensions and returns a weighted composite score in
[0.0, 1.0]:
1. **Anomaly detection** (weight 0.30) β macro-averaged F1 over the set of
flagged parameter names. Handles three cases explicitly:
- Both empty β 1.0 (agent correctly found nothing).
- True set empty β 0.0 (agent hallucinated anomalies).
- Otherwise β 0.5 * recall + 0.5 * precision.
2. **Failure mode prediction** (weight 0.25) β set F1 over predicted
failure mode strings, delegated to ``set_f1()`` from
``src.utils.grader_utils``.
3. **Directional fix quality** (weight 0.30) β precision of the agent's
(target, direction) fix pairs against the ground-truth valid set.
4. **Risk level calibration** (weight 0.15) β ordinal distance between the
agent's ``config_risk_level`` and the ground-truth level on the ordered
scale ``["safe", "marginal", "risky", "dangerous"]``. NOT binary β
adjacent misses are penalised less than distant misses.
Args:
agent_action: The ``ParamAnomalyAction`` produced by the Node 2 agent.
ground_truth: The ``GroundTruthParamAnnotation`` for this test case.
Returns:
A float in [0.0, 1.0] representing the composite grader score.
"""
scores: dict[str, float] = {}
# ------------------------------------------------------------------
# 1. Anomaly detection β F1 over flagged parameters
# ------------------------------------------------------------------
predicted_params: set[str] = {a.parameter for a in agent_action.anomalies}
true_params: set[str] = {a.parameter for a in ground_truth.anomalies}
if not predicted_params and not true_params:
scores["anomaly_detection"] = 1.0
elif not true_params:
scores["anomaly_detection"] = 0.0 # agent hallucinated anomalies
else:
recall = len(predicted_params & true_params) / len(true_params)
precision = (
len(predicted_params & true_params) / len(predicted_params)
if predicted_params
else 0.0
)
scores["anomaly_detection"] = 0.5 * recall + 0.5 * precision
# ------------------------------------------------------------------
# 2. Failure mode prediction β set F1
# ------------------------------------------------------------------
scores["failure_mode_prediction"] = set_f1(
set(agent_action.predicted_failure_modes),
set(ground_truth.predicted_failure_modes),
)
# ------------------------------------------------------------------
# 3. Directional fix quality
# ------------------------------------------------------------------
scores["fix_quality"] = _evaluate_directional_fixes(
agent_action.directional_fixes,
ground_truth.valid_fix_directions,
)
# ------------------------------------------------------------------
# 4. Risk level calibration β ordinal distance (NOT binary)
# ------------------------------------------------------------------
agent_idx = _RISK_LEVELS.index(agent_action.config_risk_level)
true_idx = _RISK_LEVELS.index(ground_truth.config_risk_level)
scores["risk_calibration"] = 1.0 - abs(agent_idx - true_idx) / (
len(_RISK_LEVELS) - 1
)
# ------------------------------------------------------------------
# Weighted composite
# ------------------------------------------------------------------
return (
0.30 * scores["anomaly_detection"]
+ 0.25 * scores["failure_mode_prediction"]
+ 0.30 * scores["fix_quality"]
+ 0.15 * scores["risk_calibration"]
)
def grade_image_diagnostics(
agent_action: ImageDiagnosticsAction,
ground_truth: GroundTruthImageAnnotation,
) -> float:
"""Grade the Image Diagnostician agent output (Node 1)."""
scores: dict[str, float] = {}
if agent_action.regime_classification == ground_truth.regime_classification:
scores["regime_accuracy"] = 1.0
elif agent_action.regime_classification in ground_truth.acceptable_regimes:
scores["regime_accuracy"] = 0.7
else:
scores["regime_accuracy"] = 0.0
predicted_risks = set(agent_action.identified_risk_factors)
true_risks = set(ground_truth.identified_risk_factors)
scores["risk_factor_recall"] = (
len(predicted_risks & true_risks) / len(true_risks) if true_risks else 1.0
)
valid_mods = set(ground_truth.valid_prompt_modifications)
agent_mods = set(agent_action.recommended_prompt_modifications)
if agent_mods:
scores["prompt_modification_validity"] = (
len(agent_mods & valid_mods) / len(agent_mods)
)
else:
scores["prompt_modification_validity"] = 0.0 if valid_mods else 1.0
return (
0.35 * scores["regime_accuracy"]
+ 0.35 * scores["risk_factor_recall"]
+ 0.30 * scores["prompt_modification_validity"]
)
# ---------------------------------------------------------------------------
# Node 3 β produce ReferenceAuditHandoff (public entry-point)
# ---------------------------------------------------------------------------
def produce_reference_audit_handoff(
node1_action: ImageDiagnosticsAction,
node2_action: ParamAnomalyAction,
img_gt: GroundTruthImageAnnotation,
param_gt: GroundTruthParamAnnotation,
) -> ReferenceAuditHandoff:
"""Grade both upstream nodes and return the Sub-env 1 β 2 coupling object.
Computes ``node1_score`` (image diagnostics) and ``node2_score`` (anomaly
detection), combines them with equal weight into ``subenv1_score``, and
packages the result into a :class:`ReferenceAuditHandoff`.
This is the public equivalent of ``pipeline._build_reference_audit_handoff``
and is intended for direct use in unit and integration tests.
Args:
node1_action: Output of the Image Diagnostician agent (Node 1).
node2_action: Output of the Parameter Anomaly Detector agent (Node 2).
img_gt: Ground-truth annotation for Node 1 grading.
param_gt: Ground-truth annotation for Node 2 grading.
Returns:
A fully populated :class:`ReferenceAuditHandoff`.
"""
# --- grade both nodes (re-use local graders) ----------------------------
node1_score = grade_image_diagnostics(node1_action, img_gt)
node2_score = grade_anomaly_detection(node2_action, param_gt)
subenv1_score = 0.50 * node1_score + 0.50 * node2_score
# --- risk profile from Node 2 risk level --------------------------------
risk_map = {"safe": "low", "marginal": "low", "risky": "medium", "dangerous": "high"}
risk_profile = risk_map.get(node2_action.config_risk_level, "medium")
# --- config quality: invert risk ordinal --------------------------------
risk_ordinal = {"safe": 1.0, "marginal": 0.75, "risky": 0.40, "dangerous": 0.10}
config_quality_score = risk_ordinal.get(node2_action.config_risk_level, 0.5)
# --- estimated drift risk: proportion of severe anomalies ---------------
total_anomalies = len(node2_action.anomalies)
severe = sum(1 for a in node2_action.anomalies if a.severity == "severe")
estimated_drift_risk = severe / total_anomalies if total_anomalies else 0.0
return ReferenceAuditHandoff(
image_usability_score=node1_action.image_usability_score,
regime=node1_action.regime_classification,
identified_risk_factors=node1_action.identified_risk_factors,
config_quality_score=config_quality_score,
risk_profile=risk_profile,
estimated_drift_risk=estimated_drift_risk,
prompt_strength=max(0.0, 1.0 - float(len(node1_action.prompt_issues)) * 0.1),
recommended_config={},
subenv1_score=subenv1_score,
)
# ---------------------------------------------------------------------------
# Private helper (image diagnostics grader β mirrors pipeline._grade_image_diagnostics)
# ---------------------------------------------------------------------------
def _grade_image_diagnostics_local(
agent_action: ImageDiagnosticsAction,
ground_truth: GroundTruthImageAnnotation,
) -> float:
"""Backward-compatible alias for callers using the old private helper name."""
return grade_image_diagnostics(agent_action, ground_truth)
|