Update app.py

app.py

@@ -2,7 +2,9 @@
 TALib + mplfinance + Gradio
 - Clean dashboard layout
 - Pattern names without CDL
-- Max chart space
+- Chart type dropdown
+- Pattern dropdown (auto-disabled for Line)
+- Pattern name shown on chart
 """
 
 import yfinance as yf
@@ -21,7 +23,15 @@ from typing import Optional, List
 
 TALIB_PATTERNS = sorted([n for n in dir(talib) if n.startswith("CDL")])
 PATTERN_DISPLAY_MAP = {n.replace("CDL", ""): n for n in TALIB_PATTERNS}
-DISPLAY_PATTERNS = list(PATTERN_DISPLAY_MAP.keys())
+
+DISPLAY_PATTERNS = ["None"] + list(PATTERN_DISPLAY_MAP.keys())
+
+# Chart type mapping
+CHART_TYPE_MAP = {
+    "Candlestick": "candle",
+    "OHLC": "ohlc",
+    "Line": "line"
+}
 
 # =====================================================
 # Data utilities
@@ -88,8 +98,6 @@ def clean_ohlc(df: pd.DataFrame) -> pd.DataFrame:
 def find_candlestick_patterns(df, talib_pattern):
     func = getattr(talib, talib_pattern)
 
-    df = clean_ohlc(df)
-
     o, h, l, c = (
         df["Open"].values,
         df["High"].values,
@@ -107,8 +115,9 @@ def find_candlestick_patterns(df, talib_pattern):
         bull[s > 0] = df.loc[s > 0, "Low"] * 0.98
         apds.append(
             mpf.make_addplot(
-                bull, type="scatter", marker="^",
-                markersize=90, color="green", alpha=0.85
+                bull, type="scatter",
+                marker="^", markersize=90,
+                color="green", alpha=0.85
             )
         )
 
@@ -117,53 +126,48 @@ def find_candlestick_patterns(df, talib_pattern):
         bear[s < 0] = df.loc[s < 0, "High"] * 1.02
         apds.append(
             mpf.make_addplot(
-                bear, type="scatter", marker="v",
-                markersize=90, color="red", alpha=0.85
+                bear, type="scatter",
+                marker="v", markersize=90,
+                color="red", alpha=0.85
             )
         )
 
-    return apds, None
+    return apds
 
 # =====================================================
 # Main plot function
 # =====================================================
 
-def plot_stock_with_patterns(symbol, start, end, selected):
+def plot_stock_with_patterns(symbol, start, end, chart_type, pattern):
     if not symbol:
         return None, "Stock symbol required"
 
-    try:
-        df = yf.download(symbol, start=start, end=end, progress=False)
-    except Exception as e:
-        return None, str(e)
-
+    df = yf.download(symbol, start=start, end=end, progress=False)
     if df.empty:
         return None, "No data found"
 
-    try:
-        df_clean = clean_ohlc(df)
-    except Exception as e:
-        return None, str(e)
+    df_clean = clean_ohlc(df)
 
     addplots = []
+    pattern_label = ""
+
+    if chart_type != "Line" and pattern != "None":
+        talib_name = PATTERN_DISPLAY_MAP.get(pattern)
+        addplots = find_candlestick_patterns(df_clean, talib_name)
+        pattern_label = f" | Pattern: {pattern}"
 
-    for name in selected or []:
-        talib_name = PATTERN_DISPLAY_MAP[name]
-        apds, err = find_candlestick_patterns(df_clean, talib_name)
-        if err:
-            return None, err
-        addplots.extend(apds)
+    mpf_type = CHART_TYPE_MAP[chart_type]
 
     os.makedirs("/tmp", exist_ok=True)
     path = f"/tmp/{symbol}_{pd.Timestamp.now().strftime('%Y%m%d%H%M%S')}.png"
 
     fig, _ = mpf.plot(
         df_clean,
-        type="candle",
-        volume="Volume" in df_clean.columns,
-        addplot=addplots if addplots else None,
+        type=mpf_type,
+        volume="Volume" in df_clean.columns and mpf_type != "line",
+        addplot=addplots if addplots and mpf_type != "line" else None,
         style="yahoo",
-        title=f"{symbol} • Candlestick Chart",
+        title=f"{symbol} • {chart_type}{pattern_label}",
         figscale=1.7,
         returnfig=True
     )
@@ -178,7 +182,7 @@ def plot_stock_with_patterns(symbol, start, end, selected):
 with gr.Blocks(fill_height=True, theme=gr.themes.Soft()) as iface:
     gr.Markdown(
         """
-        # 📊 TALib Candlestick Pattern Dashboard
+        # 📊 TALib Candlestick Pattern Dashboard  
         **Bullish = Green ▲ | Bearish = Red ▼**
         """
     )
@@ -189,45 +193,40 @@ with gr.Blocks(fill_height=True, theme=gr.themes.Soft()) as iface:
 
             symbol = gr.Textbox(
                 label="Stock / Index Symbol",
-                value="MSFT",
-                placeholder="AAPL, MSFT, ^NSEI, ^GSPC"
+                value="MSFT"
             )
 
-            start = gr.Textbox(
-                label="Start Date",
-                value="2024-01-01"
-            )
+            start = gr.Textbox(label="Start Date", value="2024-01-01")
+            end = gr.Textbox(label="End Date", value=date.today().strftime("%Y-%m-%d"))
 
-            end = gr.Textbox(
-                label="End Date",
-                value=date.today().strftime("%Y-%m-%d")
+            chart_type = gr.Dropdown(
+                label="Chart Type",
+                choices=list(CHART_TYPE_MAP.keys()),
+                value="Candlestick"
             )
 
-            patterns = gr.CheckboxGroup(
-                label="Candlestick Patterns",
+            pattern = gr.Dropdown(
+                label="Candlestick Pattern",
                 choices=DISPLAY_PATTERNS,
-                value=["HAMMER", "SHOOTINGSTAR"],
-                interactive=True
+                value="HAMMER"
             )
 
             run = gr.Button("📈 Generate Chart", variant="primary")
-
-            status = gr.Textbox(
-                label="Status",
-                interactive=False
-            )
+            status = gr.Textbox(label="Status", interactive=False)
 
         with gr.Column(scale=3):
-            gr.Markdown("### 📉 Price Chart")
-            chart = gr.Image(
-                type="filepath",
-                height=700,
-                show_label=False
-            )
+            chart = gr.Image(type="filepath", height=720, show_label=False)
+
+    # 🔥 Auto-disable pattern when Line chart is selected
+    chart_type.change(
+        lambda ct: gr.update(interactive=(ct != "Line")),
+        inputs=chart_type,
+        outputs=pattern
+    )
 
     run.click(
         plot_stock_with_patterns,
-        inputs=[symbol, start, end, patterns],
+        inputs=[symbol, start, end, chart_type, pattern],
         outputs=[chart, status]
     )