update tabs

app.py

@@ -9,7 +9,10 @@ from typing import Dict, List, Tuple, Optional
 import math
 
 from espnet_leaderboard.display.css_html_js import CUSTOM_CSS
-from espnet_leaderboard.display.task_tab import create_leaderboard_tab
+from espnet_leaderboard.display.tabs import (
+    create_leaderboard_tab,
+    create_submit_tab
+)
 from espnet_leaderboard.leaderboard.data import LeaderboardData
 
 
@@ -56,7 +59,7 @@ def create_app():
             with gr.Tab("Speaker Recognition"):
                 create_leaderboard_tab("Speaker Recognition", leaderboard_data, rows_per_page=20)
 
-            with gr.Tab("Request a model here!"):
+            with gr.Tab("Request a model"):
                 create_submit_tab()
 
             with gr.Tab("About"):
@@ -69,7 +72,7 @@ def create_app():
 
                 To submit your model results:
                 1. Prepare your results in the required format
-                2. Submit via the `Request a model` tab
+                2. Submit via the **Request a model** tab
                 3. Results will be automatically updated on the leaderboard
 
                 ### Data Sources

espnet_leaderboard/display/tabs.py

@@ -1,5 +1,8 @@
 import gradio as gr
 import math
+import re
+
+import json
 
 from espnet_leaderboard.leaderboard.data import LeaderboardData
 
@@ -109,17 +112,82 @@ def create_leaderboard_tab(
 
 def create_submit_tab():
     gr.Markdown("## Request a model here!")
-    def submit_model(model_text):
+    def _submit_model(model_text):
         if (model_text is None) or len(model_text) < 1:
-            raise gr.Error("Please enter a model name.")
+            return model_text
         splits = model_text.split("/")
         if len(splits) != 2:
-            raise gr.Error("Incorrect request format. Expected format: 'user_name/model_name'")
-        if len(splits[0]) < 1 or len(splits[1]) < 1:
-            raise gr.Error("Incorrect request format. Both user name and model name are required.")
-        gr.Info(f"Submitted {model_text}")
+            gr.Warning("Incorrect request format.")
+            return model_text
+        for split in splits:
+            if len(split) == 0:
+                gr.Warning("Incorrect request format.")
+                return model_text
+            # Check if split contains only valid GitHub repository characters
+            # Valid characters: alphanumeric, hyphens, underscores, dots
+            if not re.match(r'^[a-zA-Z0-9._-]+$', split):
+                gr.Warning(
+                    "Invalid characters in repository name. "
+                    "Only alphanumeric characters, hyphens, "
+                    "underscores, and dots are allowed."
+                )
+                return model_text
+
+        gr.Info(
+            f"Model id <b>{model_text}</b> submitted.<br/>"
+            "Thank you for your submission."
+        )
         return ""
 
+    def _check_custom_file(json_file):
+        # Check if file is None or empty
+        if json_file is None:
+            return
+        
+        # Get the file path
+        file_path = json_file.name if hasattr(json_file, 'name') else str(json_file)
+        
+        # Check if the file has .json extension
+        if not file_path.lower().endswith('.json'):
+            gr.Warning(
+                "Invalid file format. Please upload a JSON file with .json extension."
+            )
+            return
+        
+        # Try to validate JSON content
+        try:
+            with open(file_path, 'r') as f:
+                json_content = json.load(f)
+            gr.Info(
+                f"JSON file <b>{file_path.split('/')[-1]}</b> uploaded successfully.<br/>"  
+                "File is being validated."
+            )
+            # Return None to clear the file component after successful upload
+            return json_file
+        except json.JSONDecodeError as e:
+            gr.Warning(
+                f"Invalid JSON format: {str(e)}"
+            )
+            return
+        except Exception as e:
+            gr.Warning(
+                f"Error reading file: {str(e)}"
+            )
+            return
+
+    def _submit_custom(json_file):
+        if json_file is None:
+            return json_file
+
+        with open(json_file, "r", encoding="utf-8") as reader:
+            # Here the content is loaded as string to be saved in the database.
+            content = reader.read()
+        gr.Info(
+            f"Custom results <b>{json_file}</b> submitted.<br/>"
+            "Thank you for your submission."
+        )
+        return
+
     with gr.Tabs():
         with gr.Tab("From Huggingface Hub"):
             with gr.Row():
@@ -135,20 +203,45 @@ def create_submit_tab():
 
             with gr.Row():
                 with gr.Column(scale=1):
-                    next_btn = gr.Button("Submit ✉️")
+                    submit_model_btn = gr.Button("Submit ✉️")
                 with gr.Column(scale=2):
                     pass
 
         with gr.Tab("From Custom results"):
             gr.Markdown("Submit your results in JSON format here: ")
             gr.Markdown("The file needs to have the fields detailed [here](https://github.com/espnet/espnet).")
-            custom_model_box = gr.UploadButton(
-                label="Search Models",
-            )
+            with gr.Row():
+                with gr.Column(scale=2):
+                    custom_file = gr.File(file_types=[".json"])
+                    with gr.Row():
+                        with gr.Column():
+                            upload_button = gr.UploadButton(
+                                label="Upload JSON File",
+                                file_types=[".json"],
+                                file_count="single",
+                            )
+                        with gr.Column():
+                            submit_custom_button = gr.Button(
+                                "Submit ✉️"
+                            )
+                with gr.Column(scale=1):
+                    pass
+                
 
-    next_btn.click(
-        fn=submit_model,
+    submit_model_btn.click(
+        fn=_submit_model,
         inputs=[model_box],
         outputs=[model_box]
     )
+    submit_custom_button.click(
+        fn=_submit_custom,
+        inputs=[custom_file],
+        outputs=[custom_file]
+    )
+    upload_button.upload(
+        fn=_check_custom_file,
+        inputs=[upload_button],
+        outputs=[custom_file]
+    )
+    
     return