Update app.py

app.py

@@ -1157,32 +1157,46 @@ def create_genesis_animation(prediction_data, enable_animation=True):
         month = prediction_data['month']
         oni_value = prediction_data['oni_value']
         year = prediction_data.get('year', 2025)
-        
-        # ---- Build animation frames ----
-        frames = []
-        
-        # Determine map bounds from all storm tracks
-        all_lats, all_lons = [], []
+
+        # ---- 1) Prepare static full-track routes ----
+        static_routes = []
         for storm in storm_predictions:
             track = storm.get('track', [])
-            for pt in track:
-                all_lats.append(pt['lat'])
-                all_lons.append(pt['lon'])
+            if not track:
+                continue
+            lats = [pt['lat'] for pt in track]
+            lons = [pt['lon'] for pt in track]
+            static_routes.append(
+                go.Scattergeo(
+                    lat=lats,
+                    lon=lons,
+                    mode='lines',
+                    line=dict(width=2, dash='dash', color='gray'),
+                    showlegend=False,
+                    hoverinfo='skip'
+                )
+            )
+
+        # ---- 2) Build animation frames ----
+        frames = []
+        # determine map bounds from all storm tracks
+        all_lats = [pt['lat'] for storm in storm_predictions for pt in storm.get('track', [])]
+        all_lons = [pt['lon'] for storm in storm_predictions for pt in storm.get('track', [])]
         map_bounds = {
             'lat_min': min(5, min(all_lats) - 5) if all_lats else 5,
             'lat_max': max(35, max(all_lats) + 5) if all_lats else 35,
             'lon_min': min(110, min(all_lons) - 10) if all_lons else 110,
             'lon_max': max(180, max(all_lons) + 10) if all_lons else 180
         }
-        
+
         for day_idx, day_data in enumerate(daily_maps):
             day = day_data['day']
             gpi = day_data['gpi_field']
             lats = day_data['lat_range']
             lons = day_data['lon_range']
-            
+
             traces = []
-            # 1) Genesis Potential dots
+            # Genesis potential dots
             traces.append(go.Scattergeo(
                 lat=np.repeat(lats, len(lons)),
                 lon=np.tile(lons, len(lats)),
@@ -1194,10 +1208,7 @@ def create_genesis_animation(prediction_data, enable_animation=True):
                     cmin=0, cmax=3, opacity=0.6,
                     showscale=(day_idx == 0),
                     colorbar=(dict(
-                        title=dict(
-                            text="Genesis<br>Potential<br>Index",
-                            side="right"
-                        )
+                        title=dict(text="Genesis<br>Potential<br>Index", side="right")
                     ) if day_idx == 0 else None)
                 ),
                 name='Genesis Potential',
@@ -1209,38 +1220,38 @@ def create_genesis_animation(prediction_data, enable_animation=True):
                     f'Day {day} of {month:02d}/{year}<extra></extra>'
                 )
             ))
-            
-            # 2) Storm tracks up to this day
+
+            # Storm positions up to this day
             for storm in storm_predictions:
-                track = [pt for pt in storm.get('track', []) if pt['day'] <= day]
-                if not track:
+                past = [pt for pt in storm.get('track', []) if pt['day'] <= day]
+                if not past:
                     continue
-                track_lats = [pt['lat'] for pt in track]
-                track_lons = [pt['lon'] for pt in track]
-                intensities = [pt['intensity'] for pt in track]
-                categories = [pt['category'] for pt in track]
-                
-                # a) historical line
+                lats_p = [pt['lat'] for pt in past]
+                lons_p = [pt['lon'] for pt in past]
+                intens = [pt['intensity'] for pt in past]
+                cats = [pt['category'] for pt in past]
+
+                # historical line
                 traces.append(go.Scattergeo(
-                    lat=track_lats, lon=track_lons, mode='lines',
+                    lat=lats_p, lon=lons_p, mode='lines',
                     line=dict(width=2, color='gray'),
                     name=f"{storm['storm_id']} Track",
                     showlegend=(day_idx == 0),
                     hoverinfo='skip'
                 ))
-                # b) current position
+                # current position
                 traces.append(go.Scattergeo(
-                    lat=[track_lats[-1]], lon=[track_lons[-1]], mode='markers',
+                    lat=[lats_p[-1]], lon=[lons_p[-1]], mode='markers',
                     marker=dict(size=10, symbol='circle', color='red'),
                     name=f"{storm['storm_id']} Position",
                     showlegend=(day_idx == 0),
                     hovertemplate=(
                         f"{storm['storm_id']}<br>"
-                        f"Intensity: {intensities[-1]} kt<br>"
-                        f"Category: {categories[-1]}<extra></extra>"
+                        f"Intensity: {intens[-1]} kt<br>"
+                        f"Category: {cats[-1]}<extra></extra>"
                     )
                 ))
-            
+
             frames.append(go.Frame(
                 data=traces,
                 name=str(day),
@@ -1261,49 +1272,56 @@ def create_genesis_animation(prediction_data, enable_animation=True):
                     title=f"Day {day} of {month:02d}/{year}   ONI: {oni_value:.2f}"
                 )
             ))
-        
-        # ---- Initialize Figure with first frame’s data ----
+
+        # ---- 3) Initialize figure with static routes + first frame ----
+        initial_data = static_routes + list(frames[0].data)
+        fig = go.Figure(data=initial_data, frames=frames)
+
+        # ---- 4) Add play/pause buttons with redraw=True ----
         if enable_animation and len(frames) > 1:
-            fig = go.Figure(
-                data=frames[0].data,
-                frames=frames
-            )
-            
-            # Build slider steps
-            steps = []
-            for fr in frames:
-                steps.append(dict(
-                    method="animate",
-                    args=[[fr.name], {"mode":"immediate","frame":{"duration":600,"redraw":True},"transition":{"duration":0}}],
-                    label=fr.name
-                ))
-            
+            # slider steps
+            steps = [
+                dict(method="animate",
+                     args=[[fr.name],
+                           {"mode": "immediate",
+                            "frame": {"duration": 600, "redraw": True},
+                            "transition": {"duration": 0}}],
+                     label=fr.name)
+                for fr in frames
+            ]
+
             fig.update_layout(
                 updatemenus=[dict(
                     type="buttons", showactive=False,
                     x=1.05, y=0.05, xanchor="right", yanchor="bottom",
                     buttons=[
-                        dict(label="▶ Play", method="animate",
-                             args=[None, {"frame":{"duration":600,"redraw":True},"fromcurrent":True,"transition":{"duration":0}}]),
-                        dict(label="⏸ Pause", method="animate",
-                             args=[[None], {"frame":{"duration":0,"redraw":False},"mode":"immediate"}])
+                        dict(label="▶ Play",
+                             method="animate",
+                             args=[None,  # None means “all frames”
+                                   {"frame": {"duration": 600, "redraw": True},
+                                    "fromcurrent": True,
+                                    "transition": {"duration": 0}}
+                                  ]),  # redraw=True fixes the dead play button :contentReference[oaicite:1]{index=1}
+                        dict(label="⏸ Pause",
+                             method="animate",
+                             args=[[None],
+                                   {"frame": {"duration": 0, "redraw": False},
+                                    "mode": "immediate"}])
                     ]
                 )],
-                sliders=[dict(
-                    active=0, pad=dict(t=50),
-                    steps=steps
-                )]
+                sliders=[dict(active=0, pad=dict(t=50), steps=steps)]
             )
+        # No-animation fallback: just show final day + routes
         else:
-            # STATIC fallback: show only final day
-            final = frames[-1].data
+            final = static_routes + list(frames[-1].data)
             fig = go.Figure(data=final)
-        
-        # ---- Shared final layout styling ----
+
+        # ---- 5) Common layout styling ----
         fig.update_layout(
             title={
-                'text': f"🌊 Typhoon Genesis & Development Forecast<br><sub>{month:02d}/{year} | ONI: {oni_value:.2f}</sub>",
-                'x':0.5, 'font':{'size':18}
+                'text': f"🌊 Typhoon Genesis & Development Forecast<br>"
+                        f"<sub>{month:02d}/{year} | ONI: {oni_value:.2f}</sub>",
+                'x': 0.5, 'font': {'size': 18}
             },
             geo=dict(
                 projection_type="natural earth",
@@ -1314,19 +1332,23 @@ def create_genesis_animation(prediction_data, enable_animation=True):
                 showcountries=True, countrycolor="gray",
                 resolution=50,
                 center=dict(lat=20, lon=140),
-                lonaxis_range=[110,180], lataxis_range=[5,35]
+                lonaxis_range=[110, 180], lataxis_range=[5, 35]
             ),
             width=1100, height=750,
             showlegend=True,
-            legend=dict(x=0.02, y=0.98, bgcolor="rgba(255,255,255,0.7)", bordercolor="gray", borderwidth=1)
+            legend=dict(x=0.02, y=0.98,
+                        bgcolor="rgba(255,255,255,0.7)",
+                        bordercolor="gray", borderwidth=1)
         )
-        
+
         return fig
 
     except Exception as e:
         logging.error(f"Error creating professional genesis animation: {e}")
         import traceback; traceback.print_exc()
         return create_error_plot(f"Animation error: {e}")
+
+
 def create_error_plot(error_message):
     """Create a simple error plot"""
     fig = go.Figure()