Update app.py

app.py

@@ -5,7 +5,7 @@ import requests
 import random
 import re
 
-# --- CORE FUNCTIONS (No changes needed here, the logic is solid) ---
+# --- CORE FUNCTIONS ---
 
 def get_client():
     """Get Hugging Face client, handle token error."""
@@ -16,12 +16,12 @@ def get_client():
         except Exception:
             pass
     if not token:
-        return None, "❌ **HuggingFace Token Required**\n\n**Setup:**\n1. Go to Space Settings → Repository Secrets\n2. Add secret: Name=`HF_TOKEN`, Value=(your token)\n3. Get token: https://huggingface.co/settings/tokens\n4. Restart Space"
+        return None, "❌ **HuggingFace Token Required**\n\n**Setup:**\n1. Go to Space Settings → Repository Secrets\n2. Add secret: Name=`HF_TOKEN`, Value=(your HF token)\n3. Get token: https://huggingface.co/settings/tokens\n4. Restart Space"
     return InferenceClient(token=token), None
 
 def generate_meme_text(idea: str):
     """
-    Generate meme text by trying a list of models until one succeeds.
+    Generate meme text by trying a list of models using the correct chat API.
     """
     client, error = get_client()
     if error:
@@ -30,23 +30,35 @@ def generate_meme_text(idea: str):
     MODELS_TO_TRY = [
         "mistralai/Mistral-7B-Instruct-v0.2",
         "HuggingFaceH4/zephyr-7b-beta",
-        "google/flan-t5-large",
-        "tiiuae/falcon-7b-instruct",
+        "google/flan-t5-large", # This one is older but often works as a fallback
     ]
 
     failed_models = []
     for model_id in MODELS_TO_TRY:
         try:
+            # --- FIX: Use the chat_completion API for modern instruct models ---
             prompt = f"""Task: Create a funny, two-line meme caption for the idea: "{idea}".
 
 Format your response exactly like this, with no extra text:
 Top: [The first line of the meme]
 Bottom: [The second line, the punchline]"""
 
-            response = client.text_generation(
-                prompt, model=model_id, max_new_tokens=60, temperature=0.8, do_sample=True
+            # Format the prompt as a list of messages for the chat API
+            messages = [{"role": "user", "content": prompt}]
+            
+            # Use the correct client method: chat_completion
+            response_stream = client.chat_completion(
+                messages,
+                model=model_id,
+                max_tokens=60,
+                temperature=0.8,
+                stream=False, # We want the full response, not a stream
             )
             
+            # --- FIX: Parse the new response structure ---
+            response = response_stream.choices[0].message.content
+            
+            # --- Robust Parsing Logic (no changes needed here) ---
             top_text, bottom_text = "",""
             top_match = re.search(r"Top:\s*(.*)", response, re.IGNORECASE)
             bottom_match = re.search(r"Bottom:\s*(.*)", response, re.IGNORECASE)
@@ -60,8 +72,9 @@ Bottom: [The second line, the punchline]"""
                 if len(lines) >= 2: bottom_text = lines[1].replace("Bottom:", "").strip()
             
             if not top_text.strip() or not bottom_text.strip():
-                continue 
+                continue
 
+            # SUCCESS!
             return top_text.strip(), bottom_text.strip(), None, model_id
 
         except Exception as e:
@@ -70,10 +83,11 @@ Bottom: [The second line, the punchline]"""
                 failed_models.append(model_id.split('/')[-1])
                 continue
             else:
-                return None, None, f"❌ **AI Error:** {str(e)[:200]}", model_id
+                return None, None, f"❌ **AI Error:** {str(e)[:250]}", model_id
 
     return None, None, f"❌ **All AI Models Are Offline**\n\nI'm sorry, all reliable free models are currently unavailable or busy. This is a Hugging Face issue. Please try again in a few minutes.\n\n**Models Tried:** {', '.join(failed_models)}", None
 
+
 def create_meme(idea: str, template: str):
     """Main function to generate the complete meme."""
     if not idea or len(idea.strip()) < 3:
@@ -101,9 +115,10 @@ def create_meme(idea: str, template: str):
             img_response = requests.get(meme_url, timeout=20)
             img_response.raise_for_status()
 
-            temp_path = f"/tmp/meme_{random.randint(1000, 9999)}.jpg"
-            with open(temp_path, 'wb') as f:
-                f.write(img_response.content)
+            # Use a temporary file path compatible with Gradio
+            with tempfile.NamedTemporaryFile(delete=False, suffix=".jpg") as tmpfile:
+                tmpfile.write(img_response.content)
+                temp_path = tmpfile.name
             
             status_message = (f"✅ **Success!**\n\n"
                             f"📝 **Top Text:** {top}\n"
@@ -118,7 +133,7 @@ def create_meme(idea: str, template: str):
     except Exception as e:
         return None, f"❌ **An unexpected error occurred:** {str(e)}"
 
-# --- CONFIGURATION & UI ---
+# --- CONFIGURATION & UI (No changes needed) ---
 
 MEME_TEMPLATES = {
     "Drake": "181913649",
@@ -132,7 +147,6 @@ MEME_TEMPLATES = {
     "Surprised Pikachu": "155067746",
 }
 
-# ✅ ADDED more general and relatable examples
 examples = [
     ["When you fix a bug you don't understand"],
     ["My plans for the weekend vs. what I actually do"],
@@ -142,7 +156,6 @@ examples = [
     ["Trying to assemble IKEA furniture with the instructions"],
 ]
 
-# --- Gradio UI ---
 with gr.Blocks(theme=gr.themes.Soft(primary_hue="blue", secondary_hue="sky"), title="AI Meme Generator") as demo:
     
     gr.HTML("""
@@ -152,7 +165,6 @@ with gr.Blocks(theme=gr.themes.Soft(primary_hue="blue", secondary_hue="sky"), ti
         <h3>Auto-Healing AI that ALWAYS Finds a Working Model 🤗</h3>
     </div>
     """)
-    # 
 
     with gr.Row():
         with gr.Column(scale=2):
@@ -165,16 +177,10 @@ with gr.Blocks(theme=gr.themes.Soft(primary_hue="blue", secondary_hue="sky"), ti
 
     output_status = gr.Textbox(label="📊 Status & Details", lines=4, show_copy_button=True)
     
-    # ✅ CLEANED UP UI: Moved instructions into a collapsible accordion
     with gr.Accordion("How does this work?", open=False):
         gr.Markdown("""
         This app is **resilient**. It has a list of reliable free models from Hugging Face and automatically tries them in order until it finds one that is online and working.
-        
-        1.  **Enter Your Idea** & **Pick a Template.**
-        2.  **Click Generate.**
-        3.  The app does the hard work of finding an active AI model for you!
-        
-        **No more model selection. No more 404 errors.** If your `HF_TOKEN` is set up correctly in your Space Secrets, this app should always work.
+        If your `HF_TOKEN` is set up correctly in your Space Secrets, this app should always work.
         """)
 
     gr.Examples(examples=examples, inputs=[idea_input], label="💡 Meme Ideas to Try")