Deploy AIOS web (React glide grid + FastAPI slice)

RELEASES.json

@@ -1,5 +1,5 @@
 {
- "current": "85374f1",
+ "current": "624b9af",
  "releases": [
   {
    "version": "v29",

VERSION

@@ -1 +1 @@
-85374f1
+624b9af

web/src/customer-grid/MapView.tsx

@@ -384,6 +384,9 @@ export function MapView({
   /** A finished drag must not also read as a click on the pin underneath — the
    *  kanban card's lesson (viewModes.tsx), same fix. */
   const movedRef = useRef(false);
+  /** Where a gesture began, in CLIENT pixels, so `onPointerMove` can take the pointer capture
+   *  only once it has become a drag. See the block in `onPointerDown` (W38-T09). */
+  const downRef = useRef<{ id: number; cx: number; cy: number } | null>(null);
   /** Once the user has zoomed or panned, a data change must NOT yank the view
    *  back. Before that, refitting on new data is the helpful behaviour. */
   const touchedRef = useRef(false);
@@ -1035,7 +1038,24 @@ export function MapView({
       if (e.button !== 0 || !view) return;
       const { x, y } = localPoint(e.clientX, e.clientY);
       movedRef.current = false;
-      e.currentTarget.setPointerCapture(e.pointerId);
+      // ⛔⛔ THE CAPTURE IS TAKEN LAZILY, IN `onPointerMove`, AND MOVING IT THERE IS THE WHOLE
+      // FIX FOR W38-T09 (found by wave-38 QA on the deployed build). This line used to read
+      // `e.currentTarget.setPointerCapture(e.pointerId)`, unconditionally, on every pointerdown
+      // anywhere in the SVG -- including on a pin. Pointer capture retargets the REST of the
+      // gesture to the capture element, so `pointerup`, `mouseup` and the synthesised `click`
+      // all landed on the `<svg>` and a pin's own `onClick` NEVER RAN. Measured live:
+      //     pointerdown -> cg-map-pin      mousedown -> cg-map-pin
+      //     pointerup   -> cg-map-svg      mouseup   -> cg-map-svg      click -> cg-map-svg
+      // ⚠ RELEASING ON `pointerup` DOES NOT SAVE IT, and that was the tempting wrong fix: the
+      // release below already ran and the click was still retargeted. Reproduced in a 20-line
+      // isolation page with zero app code, IDENTICALLY in headed and headless Chromium, so it is
+      // browser behaviour rather than a test-harness artifact.
+      // ⭐ THE PIN'S HANDLER WAS ALWAYS CORRECT. `onOpen`, `pinSelect`, the drawer and the cohort
+      // path were all provably healthy (keyboard Enter opened the record; shift-drag, which the
+      // SVG handles itself and so is immune to the retargeting, selected 2,381 pins). Only
+      // pointer DELIVERY to a pin was broken -- and it had been since wave 8, thirty waves before
+      // the ticket that wired this handler. `git log -S "setPointerCapture"` returns one commit.
+      downRef.current = { id: e.pointerId, cx: e.clientX, cy: e.clientY };
       // Shift (or Ctrl/Cmd) turns the drag into a SELECTION rectangle; a plain
       // drag pans. Both gestures are on the same button because a map that
       // needs a mode toggle to select is a map people never select on.
@@ -1048,6 +1068,21 @@ export function MapView({
 
   const onPointerMove = useCallback(
     (e: ReactPointerEvent<SVGSVGElement>) => {
+      // ⭐⭐ THE LAZY CAPTURE (W38-T09's fix). A gesture only becomes a drag once it has TRAVELLED,
+      // so the capture is taken here rather than on pointerdown. A zero-movement click therefore
+      // never captures and reaches the pin it was aimed at; a pan or a marquee captures the
+      // instant it stops being a click, which is what keeps the pointer inside this handler when
+      // the cursor leaves the SVG mid-drag. Both directions proven in isolation before this
+      // landed: a plain click fires the pin's own `onClick`, and a real drag still logs the
+      // capture and retargets exactly as it did before.
+      // ⚠ THE THRESHOLD IS IN CLIENT PIXELS, deliberately unlike the two below it. Those compare
+      // LOCAL (viewBox) coordinates to decide whether a gesture counts as travel for selection;
+      // this one asks whether the BROWSER should stop delivering events to what is under the
+      // cursor, which is a screen-space question at every zoom.
+      const dn = downRef.current;
+      if (dn && dn.id === e.pointerId && !e.currentTarget.hasPointerCapture(e.pointerId)
+          && Math.abs(e.clientX - dn.cx) + Math.abs(e.clientY - dn.cy) > 3)
+        e.currentTarget.setPointerCapture(e.pointerId);
       const { x, y } = localPoint(e.clientX, e.clientY);
       if (drag) {
         // ⚠ W37-T30: this used to set `movedRef` UNCONDITIONALLY, and that is what swallowed a

web/src/settings/PermsEditor.tsx

@@ -84,6 +84,7 @@ import {
   setAccess,
   setFilter,
   setHidden,
+  setMetrics,
   toPutBody,
   toggleHidden,
 } from "./permsModel";
@@ -733,6 +734,22 @@ export function PermsEditor({
               of JSX here; it is `settings/ModulePermsList.tsx` now, and
               `manage-agent/ManageAgentPane` mounts the SAME component. Nothing
               about the list is duplicated, so nothing about it can drift. */}
+          {/* ⛔⛔ `onMetrics` BELOW IS THE LINE W38-T19 SHIPPED WITHOUT, AND EVERY GATE WAS GREEN
+              OVER ITS ABSENCE. The capability was complete on both sides — `perm_scope.may_metrics`,
+              four gated read doors, `_clean_perms`'s fourth entry field, `parseEntry`/`toPutBody`,
+              and the checkbox itself in `ModulePermsList` — with 39 new gate checks across
+              `api_scopes`, `web_login` and `web_ui`. What did not exist was this prop, so the
+              component's own `{on && !schemaless && onMetrics}` render gate never fired and the
+              toggle the `done-when` names had NO MOUNT SITE anywhere in the product. Found by
+              wave-38 QA on the deployed build, by opening the screen and looking.
+              ⭐ THE PROP IS OPTIONAL AND THAT IS PRECISELY WHAT LET IT SHIP: `tsc` cannot name a
+              call site that forgot an optional prop. It STAYS optional because `manage-agent`
+              legitimately does not want it (an agent's reads never open a grid door, so the rule
+              would be stored and never applied) — so what pins this line is `verify_ui.py`'s
+              `metrics_toggle_has_a_mount_site`, not the type system.
+              ⚠ AND THIS COMMENT SITS HERE, NOT BETWEEN THE ATTRIBUTES, because a JSX comment in
+              the attribute list TYPE-CHECKS under `tsc --noEmit` and then EMITS a bare `...` into
+              the props object — invalid JS that only the render smoke catches. */}
           <ModulePermsList
             modules={payload.modules}
             entries={draft}
@@ -740,6 +757,7 @@ export function PermsEditor({
             onFilter={(key, next) => setDraft((d) => setFilter(d, key, next))}
             onToggleHidden={(key, fk) => setDraft((d) => toggleHidden(d, key, fk))}
             onSetHidden={(key, keys) => setDraft((d) => setHidden(d, key, keys))}
+            onMetrics={(key, on) => setDraft((d) => setMetrics(d, key, on))}
             userOptions={userOptions}
             emptyNote="This deployment declares no modules that can be restricted."
             headExtra={(m) =>