File size: 10,876 Bytes
aec3094 | 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 | import type { ExecutionRepository } from '@n8n/db';
import { captor, mock } from 'jest-mock-extended';
import type {
IDeferredPromise,
IExecuteResponsePromiseData,
IRun,
IWorkflowExecutionDataProcess,
} from 'n8n-workflow';
import { ExecutionCancelledError, randomInt, sleep } from 'n8n-workflow';
import PCancelable from 'p-cancelable';
import { v4 as uuid } from 'uuid';
import { ActiveExecutions } from '@/active-executions';
import { ConcurrencyControlService } from '@/concurrency/concurrency-control.service';
import config from '@/config';
import { mockInstance } from '@test/mocking';
jest.mock('n8n-workflow', () => ({
...jest.requireActual('n8n-workflow'),
sleep: jest.fn(),
}));
const FAKE_EXECUTION_ID = '15';
const FAKE_SECOND_EXECUTION_ID = '20';
const executionRepository = mock<ExecutionRepository>();
const concurrencyControl = mockInstance(ConcurrencyControlService, {
// @ts-expect-error Private property
isEnabled: false,
});
describe('ActiveExecutions', () => {
let activeExecutions: ActiveExecutions;
let responsePromise: IDeferredPromise<IExecuteResponsePromiseData>;
let workflowExecution: PCancelable<IRun>;
let postExecutePromise: Promise<IRun | undefined>;
const fullRunData: IRun = {
data: {
resultData: {
runData: {},
},
},
mode: 'manual',
startedAt: new Date(),
status: 'new',
};
const executionData: IWorkflowExecutionDataProcess = {
executionMode: 'manual',
workflowData: {
id: '123',
name: 'Test workflow 1',
active: false,
isArchived: false,
createdAt: new Date(),
updatedAt: new Date(),
nodes: [],
connections: {},
},
userId: uuid(),
};
beforeEach(() => {
activeExecutions = new ActiveExecutions(mock(), executionRepository, concurrencyControl);
executionRepository.createNewExecution.mockResolvedValue(FAKE_EXECUTION_ID);
workflowExecution = new PCancelable<IRun>((resolve) => resolve());
workflowExecution.cancel = jest.fn();
responsePromise = mock<IDeferredPromise<IExecuteResponsePromiseData>>();
});
afterEach(() => {
jest.clearAllMocks();
});
test('Should initialize activeExecutions with empty list', () => {
expect(activeExecutions.getActiveExecutions()).toHaveLength(0);
});
test('Should add execution to active execution list', async () => {
const executionId = await activeExecutions.add(executionData);
expect(executionId).toBe(FAKE_EXECUTION_ID);
expect(activeExecutions.getActiveExecutions()).toHaveLength(1);
expect(executionRepository.createNewExecution).toHaveBeenCalledTimes(1);
expect(executionRepository.updateExistingExecution).toHaveBeenCalledTimes(0);
});
test('Should update execution if add is called with execution ID', async () => {
const executionId = await activeExecutions.add(executionData, FAKE_SECOND_EXECUTION_ID);
expect(executionId).toBe(FAKE_SECOND_EXECUTION_ID);
expect(activeExecutions.getActiveExecutions()).toHaveLength(1);
expect(executionRepository.createNewExecution).toHaveBeenCalledTimes(0);
expect(executionRepository.updateExistingExecution).toHaveBeenCalledTimes(1);
});
describe('attachWorkflowExecution', () => {
test('Should fail attaching execution to invalid executionId', async () => {
expect(() => {
activeExecutions.attachWorkflowExecution(FAKE_EXECUTION_ID, workflowExecution);
}).toThrow();
});
test('Should successfully attach execution to valid executionId', async () => {
await activeExecutions.add(executionData, FAKE_EXECUTION_ID);
expect(() =>
activeExecutions.attachWorkflowExecution(FAKE_EXECUTION_ID, workflowExecution),
).not.toThrow();
});
});
test('Should attach and resolve response promise to existing execution', async () => {
await activeExecutions.add(executionData, FAKE_EXECUTION_ID);
activeExecutions.attachResponsePromise(FAKE_EXECUTION_ID, responsePromise);
const fakeResponse = { data: { resultData: { runData: {} } } };
activeExecutions.resolveResponsePromise(FAKE_EXECUTION_ID, fakeResponse);
expect(responsePromise.resolve).toHaveBeenCalledWith(fakeResponse);
});
test('Should copy over startedAt and responsePromise when resuming a waiting execution', async () => {
const executionId = await activeExecutions.add(executionData);
activeExecutions.setStatus(executionId, 'waiting');
activeExecutions.attachResponsePromise(executionId, responsePromise);
const waitingExecution = activeExecutions.getExecutionOrFail(executionId);
expect(waitingExecution.responsePromise).toBeDefined();
// Resume the execution
await activeExecutions.add(executionData, executionId);
const resumedExecution = activeExecutions.getExecutionOrFail(executionId);
expect(resumedExecution.startedAt).toBe(waitingExecution.startedAt);
expect(resumedExecution.responsePromise).toBe(responsePromise);
});
describe('finalizeExecution', () => {
test('Should not remove a waiting execution', async () => {
const executionId = await activeExecutions.add(executionData);
activeExecutions.setStatus(executionId, 'waiting');
activeExecutions.finalizeExecution(executionId);
// Wait until the next tick to ensure that the post-execution promise has settled
await new Promise(setImmediate);
// Execution should still be in activeExecutions
expect(activeExecutions.getActiveExecutions()).toHaveLength(1);
expect(activeExecutions.getStatus(executionId)).toBe('waiting');
});
test('Should remove an existing execution', async () => {
const executionId = await activeExecutions.add(executionData);
activeExecutions.finalizeExecution(executionId);
await new Promise(setImmediate);
expect(activeExecutions.getActiveExecutions()).toHaveLength(0);
});
test('Should not try to resolve a post-execute promise for an inactive execution', async () => {
const getExecutionSpy = jest.spyOn(activeExecutions, 'getExecutionOrFail');
activeExecutions.finalizeExecution('inactive-execution-id', fullRunData);
expect(getExecutionSpy).not.toHaveBeenCalled();
});
test('Should resolve post execute promise on removal', async () => {
const executionId = await activeExecutions.add(executionData);
const postExecutePromise = activeExecutions.getPostExecutePromise(executionId);
await new Promise(setImmediate);
activeExecutions.finalizeExecution(executionId, fullRunData);
await expect(postExecutePromise).resolves.toEqual(fullRunData);
});
});
describe('getPostExecutePromise', () => {
test('Should throw error when trying to create a promise with invalid execution', async () => {
await expect(activeExecutions.getPostExecutePromise(FAKE_EXECUTION_ID)).rejects.toThrow();
});
});
describe('stopExecution', () => {
let executionId: string;
beforeEach(async () => {
executionId = await activeExecutions.add(executionData);
postExecutePromise = activeExecutions.getPostExecutePromise(executionId);
activeExecutions.attachWorkflowExecution(executionId, workflowExecution);
activeExecutions.attachResponsePromise(executionId, responsePromise);
});
test('Should cancel ongoing executions', async () => {
activeExecutions.stopExecution(executionId);
expect(responsePromise.reject).toHaveBeenCalledWith(expect.any(ExecutionCancelledError));
expect(workflowExecution.cancel).toHaveBeenCalledTimes(1);
await expect(postExecutePromise).rejects.toThrow(ExecutionCancelledError);
});
test('Should cancel waiting executions', async () => {
activeExecutions.setStatus(executionId, 'waiting');
activeExecutions.stopExecution(executionId);
expect(responsePromise.reject).toHaveBeenCalledWith(expect.any(ExecutionCancelledError));
expect(workflowExecution.cancel).not.toHaveBeenCalled();
});
});
describe('shutdown', () => {
let newExecutionId1: string, newExecutionId2: string;
let waitingExecutionId1: string, waitingExecutionId2: string;
beforeEach(async () => {
config.set('executions.mode', 'regular');
executionRepository.createNewExecution.mockImplementation(async () =>
randomInt(1000, 2000).toString(),
);
(sleep as jest.Mock).mockImplementation(() => {
// @ts-expect-error private property
activeExecutions.activeExecutions = {};
});
newExecutionId1 = await activeExecutions.add(executionData);
activeExecutions.setStatus(newExecutionId1, 'new');
activeExecutions.attachResponsePromise(newExecutionId1, responsePromise);
newExecutionId2 = await activeExecutions.add(executionData);
activeExecutions.setStatus(newExecutionId2, 'new');
waitingExecutionId1 = await activeExecutions.add(executionData);
activeExecutions.setStatus(waitingExecutionId1, 'waiting');
activeExecutions.attachResponsePromise(waitingExecutionId1, responsePromise);
waitingExecutionId2 = await activeExecutions.add(executionData);
activeExecutions.setStatus(waitingExecutionId2, 'waiting');
});
test('Should cancel only executions with response-promises by default', async () => {
const stopExecutionSpy = jest.spyOn(activeExecutions, 'stopExecution');
expect(activeExecutions.getActiveExecutions()).toHaveLength(4);
await activeExecutions.shutdown();
expect(concurrencyControl.disable).toHaveBeenCalled();
const removeAllCaptor = captor<string[]>();
expect(concurrencyControl.removeAll).toHaveBeenCalledWith(removeAllCaptor);
expect(removeAllCaptor.value.sort()).toEqual([newExecutionId1, waitingExecutionId1].sort());
expect(stopExecutionSpy).toHaveBeenCalledTimes(2);
expect(stopExecutionSpy).toHaveBeenCalledWith(newExecutionId1);
expect(stopExecutionSpy).toHaveBeenCalledWith(waitingExecutionId1);
expect(stopExecutionSpy).not.toHaveBeenCalledWith(newExecutionId2);
expect(stopExecutionSpy).not.toHaveBeenCalledWith(waitingExecutionId2);
await new Promise(setImmediate);
// the other two executions aren't cancelled, but still removed from memory
expect(activeExecutions.getActiveExecutions()).toHaveLength(0);
});
test('Should cancel all executions when cancelAll is true', async () => {
const stopExecutionSpy = jest.spyOn(activeExecutions, 'stopExecution');
expect(activeExecutions.getActiveExecutions()).toHaveLength(4);
await activeExecutions.shutdown(true);
expect(concurrencyControl.disable).toHaveBeenCalled();
const removeAllCaptor = captor<string[]>();
expect(concurrencyControl.removeAll).toHaveBeenCalledWith(removeAllCaptor);
expect(removeAllCaptor.value.sort()).toEqual(
[newExecutionId1, newExecutionId2, waitingExecutionId1, waitingExecutionId2].sort(),
);
expect(stopExecutionSpy).toHaveBeenCalledTimes(4);
expect(stopExecutionSpy).toHaveBeenCalledWith(newExecutionId1);
expect(stopExecutionSpy).toHaveBeenCalledWith(waitingExecutionId1);
expect(stopExecutionSpy).toHaveBeenCalledWith(newExecutionId2);
expect(stopExecutionSpy).toHaveBeenCalledWith(waitingExecutionId2);
});
});
});
|