Update app.py

app.py

@@ -23,6 +23,10 @@ TARGET_FPS = 6.0
 # Minimum rep duration in seconds (keeps behavior stable when stride changes)
 MIN_REP_SECONDS = 0.33
 
+# NEW (from our efficient logic): Maximum rep duration in seconds
+# Prevents very long false reps when tracking fails.
+MAX_REP_SECONDS = 8.0
+
 # Downscale only (no crop) for YOLO inference
 # 640 is a safe default across varying camera angles.
 MAX_INFER_SIDE = 640
@@ -132,15 +136,18 @@ def analyze_pushup_video_yolo(video_path: str, out_dir: str):
     frame_stride = max(1, int(round(float(fps) / float(TARGET_FPS))))
     effective_fps = float(fps) / float(frame_stride)
 
-    # Convert time-based minimum rep duration to sampled frames
+    # Convert time-based rep duration limits to sampled frames (matches our efficient logic)
     min_rep_frames = int(math.ceil(MIN_REP_SECONDS * effective_fps))
-    # Clamp so we don't reject real reps at low fps
     min_rep_frames = max(2, min_rep_frames)
 
+    max_rep_frames = int(math.ceil(MAX_REP_SECONDS * effective_fps))
+    max_rep_frames = max(min_rep_frames + 2, max_rep_frames)
+
     print(
         f"[speed] video_fps={fps:.2f} target_fps={TARGET_FPS:.2f} "
         f"stride={frame_stride} effective_fps={effective_fps:.2f} "
-        f"min_rep_frames={min_rep_frames} infer_max_side={MAX_INFER_SIDE}"
+        f"min_rep_frames={min_rep_frames} max_rep_frames={max_rep_frames} "
+        f"infer_max_side={MAX_INFER_SIDE}"
     )
 
     # 1) First pass: compute angles + confs per sampled frame
@@ -204,12 +211,15 @@ def analyze_pushup_video_yolo(video_path: str, out_dir: str):
     elif not np.any(mask):
         raise RuntimeError("No valid pose angles detected.")
 
-    # Smooth
-    win = min(31, (len(angles) // 2) * 2 + 1)
-    win = max(win, 5)
+    # Smooth (updated to match our efficient logic: ~1 second window scaled by effective_fps)
+    win = int(round(effective_fps * 1.0))
+    win = max(5, win)
+    if win % 2 == 0:
+        win += 1
+    win = min(win, (len(angles) // 2) * 2 + 1)
     angles_smooth = savgol_filter(angles, win, 2)
 
-    # 2) Rep detection on smoothed angles
+    # 2) Rep detection on smoothed angles (updated to match our efficient logic)
     reps = []
     state = "WAIT_DOWN"
     rep_min = rep_max = rep_conf_sum = rep_len = rep_start = None
@@ -230,6 +240,11 @@ def analyze_pushup_video_yolo(video_path: str, out_dir: str):
             rep_conf_sum += cf
             rep_len += 1
 
+            # Abort absurdly long reps (tracking failure / stall)
+            if rep_len > max_rep_frames:
+                state = "WAIT_DOWN"
+                continue
+
             if ang >= UP_ANGLE:
                 if rep_len >= min_rep_frames:
                     mean_cf = float(rep_conf_sum / rep_len)
@@ -369,4 +384,4 @@ with gr.Blocks(title="Pushup API (YOLO)") as demo:
     )
 
 if __name__ == "__main__":
-    demo.launch()
+    demo.launch()