Spaces:

headway
/

medicode

Runtime error

timgremore commited on Feb 8, 2024

Commit

3a8280c

1 Parent(s): 2dfe07a

feat: Account for not founds

Files changed (6) hide show

lib/medical_transcription/transcription_server.ex CHANGED Viewed

@@ -25,11 +25,20 @@ defmodule MedicalTranscription.TranscriptionServer do
   @impl GenServer
   def handle_continue(:start, {:transcription, transcription} = state) do
     stream_transcription_and_search(transcription.filename)
     {:noreply, state}
   end
   @impl GenServer
-  def handle_info({:chunk, result}, {:transcription, transcription} = state) do
     %Transcription{id: id} = transcription
     Transcriptions.create_chunk(%{
@@ -58,6 +67,16 @@ defmodule MedicalTranscription.TranscriptionServer do
   @impl GenServer
   def terminate(reason, state) do
     reason
   end

   @impl GenServer
   def handle_continue(:start, {:transcription, transcription} = state) do
     stream_transcription_and_search(transcription.filename)
+    Phoenix.PubSub.broadcast(
+      :medicode_pubsub,
+      "transcriptions:#{transcription.id}",
+      {:transcription_started, transcription.id}
+    )
     {:noreply, state}
   end
   @impl GenServer
+  def handle_info({:chunk, result}, state) do
+    {:transcription, transcription} = state
     %Transcription{id: id} = transcription
     Transcriptions.create_chunk(%{
   @impl GenServer
   def terminate(reason, state) do
+    {:transcription, transcription} = state
+    %Transcription{id: id} = transcription
+    Phoenix.PubSub.broadcast(
+      :medicode_pubsub,
+      "transcriptions:#{id}",
+      {:transcription_finished, reason}
+    )
     reason
   end

lib/medical_transcription/transcriptions.ex CHANGED Viewed

@@ -38,6 +38,32 @@ defmodule MedicalTranscription.Transcriptions do
   @doc """
   Gets a single transcription.
   Raises `Ecto.NoResultsError` if the Transcription does not exist.
   ## Examples

   @doc """
   Gets a single transcription.
+  Returns `nil` if the Transcription does not exist.
+  ## Examples
+      iex> get_transcription(123)
+      %Transcription{}
+      iex> get_transcription(456)
+      nil
+  """
+  def get_transcription(id, preload_transcription_chunks \\ false) do
+    query =
+      if preload_transcription_chunks do
+        Transcription
+        |> preload(:chunks)
+      else
+        Transcription
+      end
+    Repo.get(query, id)
+  end
+  @doc """
+  Gets a single transcription.
   Raises `Ecto.NoResultsError` if the Transcription does not exist.
   ## Examples

lib/medical_transcription_web/controllers/error_html/404.html.heex ADDED Viewed

+<!DOCTYPE html>
+<html lang="en" class="[scrollbar-gutter:stable]">
+  <head>
+    <meta charset="utf-8" />
+    <meta name="viewport" content="width=device-width, initial-scale=1" />
+    <meta name="csrf-token" content={get_csrf_token()} />
+    <.live_title suffix=" · Phoenix Framework">
+      <%= assigns[:page_title] || "MedicalTranscription" %>
+    </.live_title>
+    <link phx-track-static rel="stylesheet" href={~p"/assets/app.css"} />
+    <script defer phx-track-static type="text/javascript" src={~p"/assets/app.js"}>
+    </script>
+  </head>
+  <body class="bg-white antialiased px-5 py-7">
+    <h1>Not Found</h1>
+  </body>
+</html>

lib/medical_transcription_web/fallback.ex ADDED Viewed

+defmodule MedicalTranscription.Fallback do
+  defexception message: "Not found", plug_status: 404
+end

lib/medical_transcription_web/live/transcriptions_live/show.ex CHANGED Viewed

@@ -10,6 +10,8 @@ defmodule MedicalTranscriptionWeb.TranscriptionsLive.Show do
   def mount(params, session, socket) do
     transcription = get_transcription(params["id"])
     if connected?(socket),
       do: Phoenix.PubSub.subscribe(:medicode_pubsub, "transcriptions:#{transcription.id}")
@@ -174,6 +176,6 @@ defmodule MedicalTranscriptionWeb.TranscriptionsLive.Show do
     {:noreply, assign(socket, :status, :success)}
   end
-  defp get_transcription(id), do: Transcriptions.get_transcription!(id)
   defp list_transcriptions(user), do: Transcriptions.list_transcriptions(user)
 end

   def mount(params, session, socket) do
     transcription = get_transcription(params["id"])
+    if is_nil(transcription), do: raise MedicalTranscription.Fallback
     if connected?(socket),
       do: Phoenix.PubSub.subscribe(:medicode_pubsub, "transcriptions:#{transcription.id}")
     {:noreply, assign(socket, :status, :success)}
   end
+  defp get_transcription(id), do: Transcriptions.get_transcription(id)
   defp list_transcriptions(user), do: Transcriptions.list_transcriptions(user)
 end

test/medical_transcription_web/live/transcriptions_live_show_test.exs ADDED Viewed

+defmodule MedicalTranscriptionWeb.TranscriptionsLive.ShowTest do
+  use MedicalTranscriptionWeb.ConnCase, async: true
+  import Phoenix.LiveViewTest
+  import MedicalTranscription.{AccountsFixtures, TranscriptionsFixtures}
+  setup %{conn: conn} do
+    password = valid_user_password()
+    user = user_fixture(%{password: password})
+    transcription = transcription_fixture(%{filename: "my-audio.mp3"})
+    %{conn: log_in_user(conn, user), current_user: user, transcription: transcription}
+  end
+  describe "/" do
+    test "renders transcription show screen", %{conn: conn, transcription: transcription} do
+      conn = get(conn, "/transcriptions/#{transcription.id}")
+      assert html_response(conn, 200) =~ "Medical Code Transcriber"
+      {:ok, view, html} = live(conn)
+      assert html =~ "my-audio.mp3"
+      assert_redirected view, ~p"/transcriptions/#{transcription.id}"
+    end
+    test "renders 'Not Found' for 404", %{conn: conn} do
+      invalid_id = Ecto.UUID.generate()
+      conn = get(conn, "/transcriptions/#{invalid_id}")
+      assert html_response(conn, 404) =~ "Transcription not found"
+    end
+  end
+end