File size: 20,701 Bytes
f0743f4 | 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 | import { Providers } from '@librechat/agents';
import { mbToBytes } from 'librechat-data-provider';
import { validatePdf, validateVideo, validateAudio } from './validation';
describe('PDF Validation with fileConfig.endpoints.*.fileSizeLimit', () => {
/** Helper to create a PDF buffer with valid header */
const createMockPdfBuffer = (sizeInMB: number): Buffer => {
const bytes = Math.floor(sizeInMB * 1024 * 1024);
const buffer = Buffer.alloc(bytes);
buffer.write('%PDF-1.4\n', 0);
return buffer;
};
describe('validatePdf - OpenAI provider', () => {
const provider = Providers.OPENAI;
it('should accept PDF within provider limit when no config provided', async () => {
const pdfBuffer = createMockPdfBuffer(8);
const result = await validatePdf(pdfBuffer, pdfBuffer.length, provider);
expect(result.isValid).toBe(true);
expect(result.error).toBeUndefined();
});
it('should reject PDF exceeding provider limit when no config provided', async () => {
const pdfBuffer = createMockPdfBuffer(12);
const result = await validatePdf(pdfBuffer, pdfBuffer.length, provider);
expect(result.isValid).toBe(false);
expect(result.error).toContain('12MB');
expect(result.error).toContain('10MB');
});
it('should use configured limit when it is lower than provider limit', async () => {
const configuredLimit = 5 * 1024 * 1024; // 5MB
const pdfBuffer = createMockPdfBuffer(7); // Between configured and provider limit
const result = await validatePdf(pdfBuffer, pdfBuffer.length, provider, configuredLimit);
expect(result.isValid).toBe(false);
expect(result.error).toContain('7MB');
expect(result.error).toContain('5MB');
});
it('should allow configured limit higher than provider default', async () => {
const configuredLimit = 50 * 1024 * 1024; // 50MB (higher than 10MB provider default)
const pdfBuffer = createMockPdfBuffer(12); // Between provider default and configured limit
const result = await validatePdf(pdfBuffer, pdfBuffer.length, provider, configuredLimit);
expect(result.isValid).toBe(true);
expect(result.error).toBeUndefined();
});
it('should accept PDF within both configured and provider limits', async () => {
const configuredLimit = 50 * 1024 * 1024; // 50MB
const pdfBuffer = createMockPdfBuffer(8);
const result = await validatePdf(pdfBuffer, pdfBuffer.length, provider, configuredLimit);
expect(result.isValid).toBe(true);
expect(result.error).toBeUndefined();
});
it('should accept PDF within lower configured limit', async () => {
const configuredLimit = 5 * 1024 * 1024; // 5MB
const pdfBuffer = createMockPdfBuffer(4);
const result = await validatePdf(pdfBuffer, pdfBuffer.length, provider, configuredLimit);
expect(result.isValid).toBe(true);
expect(result.error).toBeUndefined();
});
it('should handle exact limit size correctly', async () => {
const configuredLimit = 10 * 1024 * 1024; // Exactly 10MB
const pdfBuffer = Buffer.alloc(10 * 1024 * 1024);
pdfBuffer.write('%PDF-1.4\n', 0);
const result = await validatePdf(pdfBuffer, pdfBuffer.length, provider, configuredLimit);
expect(result.isValid).toBe(true);
});
});
describe('validatePdf - Anthropic provider', () => {
const provider = Providers.ANTHROPIC;
it('should accept PDF within provider limit when no config provided', async () => {
const pdfBuffer = createMockPdfBuffer(20);
const result = await validatePdf(pdfBuffer, pdfBuffer.length, provider);
expect(result.isValid).toBe(true);
expect(result.error).toBeUndefined();
});
it('should reject PDF exceeding provider limit when no config provided', async () => {
const pdfBuffer = createMockPdfBuffer(35);
const result = await validatePdf(pdfBuffer, pdfBuffer.length, provider);
expect(result.isValid).toBe(false);
expect(result.error).toContain('35MB');
expect(result.error).toContain('32MB');
});
it('should use configured limit when it is lower than provider limit', async () => {
const configuredLimit = mbToBytes(15); // 15MB
const pdfBuffer = createMockPdfBuffer(20); // Between configured and provider limit
const result = await validatePdf(pdfBuffer, pdfBuffer.length, provider, configuredLimit);
expect(result.isValid).toBe(false);
expect(result.error).toContain('20MB');
expect(result.error).toContain('15MB');
});
it('should allow configured limit higher than provider default', async () => {
const configuredLimit = mbToBytes(50); // 50MB (higher than 32MB provider default)
const pdfBuffer = createMockPdfBuffer(35); // Between provider default and configured limit
const result = await validatePdf(pdfBuffer, pdfBuffer.length, provider, configuredLimit);
expect(result.isValid).toBe(true);
expect(result.error).toBeUndefined();
});
it('should reject encrypted PDFs regardless of size', async () => {
const pdfBuffer = Buffer.alloc(1024);
pdfBuffer.write('%PDF-1.4\n', 0);
pdfBuffer.write('/Encrypt ', 100);
const result = await validatePdf(pdfBuffer, pdfBuffer.length, provider);
expect(result.isValid).toBe(false);
expect(result.error).toContain('encrypted');
});
it('should reject PDFs with invalid header', async () => {
const pdfBuffer = Buffer.alloc(1024);
pdfBuffer.write('INVALID', 0);
const result = await validatePdf(pdfBuffer, pdfBuffer.length, provider);
expect(result.isValid).toBe(false);
expect(result.error).toContain('PDF header');
});
it('should reject PDFs that are too small', async () => {
const pdfBuffer = Buffer.alloc(3);
const result = await validatePdf(pdfBuffer, pdfBuffer.length, provider);
expect(result.isValid).toBe(false);
expect(result.error).toContain('too small');
});
});
describe('validatePdf - Google provider', () => {
const provider = Providers.GOOGLE;
it('should accept PDF within provider limit when no config provided', async () => {
const pdfBuffer = createMockPdfBuffer(15);
const result = await validatePdf(pdfBuffer, pdfBuffer.length, provider);
expect(result.isValid).toBe(true);
expect(result.error).toBeUndefined();
});
it('should reject PDF exceeding provider limit when no config provided', async () => {
const pdfBuffer = createMockPdfBuffer(25);
const result = await validatePdf(pdfBuffer, pdfBuffer.length, provider);
expect(result.isValid).toBe(false);
expect(result.error).toContain('25MB');
expect(result.error).toContain('20MB');
});
it('should use configured limit when it is lower than provider limit', async () => {
const configuredLimit = 10 * 1024 * 1024; // 10MB
const pdfBuffer = createMockPdfBuffer(15); // Between configured and provider limit
const result = await validatePdf(pdfBuffer, pdfBuffer.length, provider, configuredLimit);
expect(result.isValid).toBe(false);
expect(result.error).toContain('15MB');
expect(result.error).toContain('10MB');
});
it('should allow configured limit higher than provider default', async () => {
const configuredLimit = 50 * 1024 * 1024; // 50MB (higher than 20MB provider default)
const pdfBuffer = createMockPdfBuffer(25); // Between provider default and configured limit
const result = await validatePdf(pdfBuffer, pdfBuffer.length, provider, configuredLimit);
expect(result.isValid).toBe(true);
expect(result.error).toBeUndefined();
});
});
describe('validatePdf - VertexAI provider', () => {
const provider = Providers.VERTEXAI;
it('should accept PDF within provider limit', async () => {
const pdfBuffer = createMockPdfBuffer(15);
const result = await validatePdf(pdfBuffer, pdfBuffer.length, provider);
expect(result.isValid).toBe(true);
});
it('should respect configured limit', async () => {
const configuredLimit = 10 * 1024 * 1024;
const pdfBuffer = createMockPdfBuffer(15);
const result = await validatePdf(pdfBuffer, pdfBuffer.length, provider, configuredLimit);
expect(result.isValid).toBe(false);
expect(result.error).toContain('10MB');
});
});
describe('validatePdf - Azure OpenAI provider', () => {
const provider = Providers.AZURE;
it('should accept PDF within OpenAI-like provider limit', async () => {
const pdfBuffer = createMockPdfBuffer(8);
const result = await validatePdf(pdfBuffer, pdfBuffer.length, provider);
expect(result.isValid).toBe(true);
});
it('should respect configured limit for Azure', async () => {
const configuredLimit = 5 * 1024 * 1024;
const pdfBuffer = createMockPdfBuffer(7);
const result = await validatePdf(pdfBuffer, pdfBuffer.length, provider, configuredLimit);
expect(result.isValid).toBe(false);
});
});
describe('validatePdf - Unsupported providers', () => {
it('should return valid for providers without specific validation', async () => {
const pdfBuffer = createMockPdfBuffer(100); // Very large file
const provider = 'unsupported' as Providers;
const result = await validatePdf(pdfBuffer, pdfBuffer.length, provider);
expect(result.isValid).toBe(true);
});
});
describe('Edge cases', () => {
it('should handle zero-configured limit', async () => {
const configuredLimit = 0;
const pdfBuffer = createMockPdfBuffer(1);
const result = await validatePdf(
pdfBuffer,
pdfBuffer.length,
Providers.OPENAI,
configuredLimit,
);
expect(result.isValid).toBe(false);
expect(result.error).toContain('0MB');
});
it('should handle very small PDF files', async () => {
const pdfBuffer = Buffer.alloc(100);
pdfBuffer.write('%PDF-1.4\n', 0);
const result = await validatePdf(
pdfBuffer,
pdfBuffer.length,
Providers.OPENAI,
10 * 1024 * 1024,
);
expect(result.isValid).toBe(true);
});
it('should handle configured limit equal to provider limit', async () => {
const configuredLimit = 10 * 1024 * 1024; // Same as OpenAI provider limit
const pdfBuffer = createMockPdfBuffer(12);
const result = await validatePdf(
pdfBuffer,
pdfBuffer.length,
Providers.OPENAI,
configuredLimit,
);
expect(result.isValid).toBe(false);
expect(result.error).toContain('10MB');
});
it('should use provider limit when configured limit is undefined', async () => {
const pdfBuffer = createMockPdfBuffer(12);
const result = await validatePdf(pdfBuffer, pdfBuffer.length, Providers.OPENAI, undefined);
expect(result.isValid).toBe(false);
expect(result.error).toContain('10MB');
});
});
describe('Bug reproduction - Original issue', () => {
it('should reproduce the original bug scenario from issue description', async () => {
/**
* Original bug: User configures openAI.fileSizeLimit = 50MB in librechat.yaml
* Uploads a 15MB PDF to OpenAI endpoint
* Expected: Should be accepted (within 50MB config)
* Actual (before fix): Rejected with "exceeds 10MB limit"
*/
const configuredLimit = mbToBytes(50); // User configured 50MB
const pdfBuffer = createMockPdfBuffer(15); // User uploads 15MB file
const result = await validatePdf(
pdfBuffer,
pdfBuffer.length,
Providers.OPENAI,
configuredLimit,
);
/**
* After fix: Should be accepted because configured limit (50MB) overrides
* provider default (10MB), allowing for API changes
*/
expect(result.isValid).toBe(true);
expect(result.error).toBeUndefined();
});
it('should allow user to set stricter limits than provider', async () => {
/**
* Use case: User wants to enforce stricter limits than provider allows
* User configures openAI.fileSizeLimit = 5MB
* Uploads a 7MB PDF to OpenAI endpoint
* Expected: Should be rejected (exceeds 5MB configured limit)
*/
const configuredLimit = mbToBytes(5); // User configured 5MB
const pdfBuffer = createMockPdfBuffer(7); // User uploads 7MB file
const result = await validatePdf(
pdfBuffer,
pdfBuffer.length,
Providers.OPENAI,
configuredLimit,
);
expect(result.isValid).toBe(false);
expect(result.error).toContain('7MB');
expect(result.error).toContain('5MB');
});
it('should allow upload within stricter user-configured limit', async () => {
/**
* User configures openAI.fileSizeLimit = 5MB
* Uploads a 4MB PDF
* Expected: Should be accepted
*/
const configuredLimit = mbToBytes(5);
const pdfBuffer = createMockPdfBuffer(4);
const result = await validatePdf(
pdfBuffer,
pdfBuffer.length,
Providers.OPENAI,
configuredLimit,
);
expect(result.isValid).toBe(true);
expect(result.error).toBeUndefined();
});
});
describe('Video and Audio Validation with fileConfig', () => {
/** Helper to create a mock video/audio buffer */
const createMockMediaBuffer = (sizeInMB: number): Buffer => {
const bytes = Math.floor(sizeInMB * 1024 * 1024);
return Buffer.alloc(bytes);
};
describe('validateVideo - Google provider', () => {
const provider = Providers.GOOGLE;
it('should accept video within provider limit when no config provided', async () => {
const videoBuffer = createMockMediaBuffer(15);
const result = await validateVideo(videoBuffer, videoBuffer.length, provider);
expect(result.isValid).toBe(true);
expect(result.error).toBeUndefined();
});
it('should reject video exceeding provider limit when no config provided', async () => {
const videoBuffer = createMockMediaBuffer(25);
const result = await validateVideo(videoBuffer, videoBuffer.length, provider);
expect(result.isValid).toBe(false);
expect(result.error).toContain('25MB');
expect(result.error).toContain('20MB');
});
it('should use configured limit when it is lower than provider limit', async () => {
const configuredLimit = mbToBytes(10); // 10MB
const videoBuffer = createMockMediaBuffer(15); // Between configured and provider limit
const result = await validateVideo(
videoBuffer,
videoBuffer.length,
provider,
configuredLimit,
);
expect(result.isValid).toBe(false);
expect(result.error).toContain('15MB');
expect(result.error).toContain('10MB');
});
it('should allow configured limit higher than provider default', async () => {
const configuredLimit = mbToBytes(50); // 50MB (higher than 20MB provider default)
const videoBuffer = createMockMediaBuffer(25); // Between provider default and configured limit
const result = await validateVideo(
videoBuffer,
videoBuffer.length,
provider,
configuredLimit,
);
expect(result.isValid).toBe(true);
expect(result.error).toBeUndefined();
});
it('should accept video within lower configured limit', async () => {
const configuredLimit = mbToBytes(8);
const videoBuffer = createMockMediaBuffer(7);
const result = await validateVideo(
videoBuffer,
videoBuffer.length,
provider,
configuredLimit,
);
expect(result.isValid).toBe(true);
expect(result.error).toBeUndefined();
});
it('should reject videos that are too small', async () => {
const videoBuffer = Buffer.alloc(5);
const result = await validateVideo(videoBuffer, videoBuffer.length, provider);
expect(result.isValid).toBe(false);
expect(result.error).toContain('too small');
});
});
describe('validateAudio - Google provider', () => {
const provider = Providers.GOOGLE;
it('should accept audio within provider limit when no config provided', async () => {
const audioBuffer = createMockMediaBuffer(15);
const result = await validateAudio(audioBuffer, audioBuffer.length, provider);
expect(result.isValid).toBe(true);
expect(result.error).toBeUndefined();
});
it('should reject audio exceeding provider limit when no config provided', async () => {
const audioBuffer = createMockMediaBuffer(25);
const result = await validateAudio(audioBuffer, audioBuffer.length, provider);
expect(result.isValid).toBe(false);
expect(result.error).toContain('25MB');
expect(result.error).toContain('20MB');
});
it('should use configured limit when it is lower than provider limit', async () => {
const configuredLimit = mbToBytes(10); // 10MB
const audioBuffer = createMockMediaBuffer(15); // Between configured and provider limit
const result = await validateAudio(
audioBuffer,
audioBuffer.length,
provider,
configuredLimit,
);
expect(result.isValid).toBe(false);
expect(result.error).toContain('15MB');
expect(result.error).toContain('10MB');
});
it('should allow configured limit higher than provider default', async () => {
const configuredLimit = mbToBytes(50); // 50MB (higher than 20MB provider default)
const audioBuffer = createMockMediaBuffer(25); // Between provider default and configured limit
const result = await validateAudio(
audioBuffer,
audioBuffer.length,
provider,
configuredLimit,
);
expect(result.isValid).toBe(true);
expect(result.error).toBeUndefined();
});
it('should accept audio within lower configured limit', async () => {
const configuredLimit = mbToBytes(8);
const audioBuffer = createMockMediaBuffer(7);
const result = await validateAudio(
audioBuffer,
audioBuffer.length,
provider,
configuredLimit,
);
expect(result.isValid).toBe(true);
expect(result.error).toBeUndefined();
});
it('should reject audio files that are too small', async () => {
const audioBuffer = Buffer.alloc(5);
const result = await validateAudio(audioBuffer, audioBuffer.length, provider);
expect(result.isValid).toBe(false);
expect(result.error).toContain('too small');
});
});
describe('validateVideo and validateAudio - VertexAI provider', () => {
const provider = Providers.VERTEXAI;
it('should respect configured video limit for VertexAI', async () => {
const configuredLimit = mbToBytes(10);
const videoBuffer = createMockMediaBuffer(15);
const result = await validateVideo(
videoBuffer,
videoBuffer.length,
provider,
configuredLimit,
);
expect(result.isValid).toBe(false);
expect(result.error).toContain('10MB');
});
it('should respect configured audio limit for VertexAI', async () => {
const configuredLimit = mbToBytes(10);
const audioBuffer = createMockMediaBuffer(15);
const result = await validateAudio(
audioBuffer,
audioBuffer.length,
provider,
configuredLimit,
);
expect(result.isValid).toBe(false);
expect(result.error).toContain('10MB');
});
});
describe('validateVideo and validateAudio - Unsupported providers', () => {
it('should return valid for video from unsupported provider', async () => {
const videoBuffer = createMockMediaBuffer(100);
const provider = Providers.OPENAI;
const result = await validateVideo(videoBuffer, videoBuffer.length, provider);
expect(result.isValid).toBe(true);
});
it('should return valid for audio from unsupported provider', async () => {
const audioBuffer = createMockMediaBuffer(100);
const provider = Providers.OPENAI;
const result = await validateAudio(audioBuffer, audioBuffer.length, provider);
expect(result.isValid).toBe(true);
});
});
});
});
|