Update app.py

app.py

@@ -19,7 +19,7 @@ def format_time(seconds):
     secs = seconds % 60
     return f"{hrs:02}:{mins:02}:{secs:02},{millis:03}"
 
-# Function to generate SRT with accurate timing per batch
+# Function to generate SRT with accurate timing per batch and cross-check timing
 async def generate_accurate_srt(batch_text, batch_num, start_offset):
     audio_file = f"batch_{batch_num}_audio.wav"
     
@@ -38,25 +38,32 @@ async def generate_accurate_srt(batch_text, batch_num, start_offset):
     start_time = start_offset
     min_display_duration = 1.5  # Set a minimum display time of 1.5 seconds per subtitle
 
-    # Build SRT content with accurate timing
-    for i in range(0, len(words), 15):  # Process ~15 words per subtitle
+    # Build SRT content with accurate timing, ensuring no segment exceeds audio length
+    for i in range(0, len(words), 15):
         segment_words = words[i:i+15]
-        end_time = start_time + max(segment_duration, min_display_duration)  # Ensure each subtitle shows at least min_display_duration
+        end_time = start_time + max(segment_duration, min_display_duration)
+        
+        # If end_time exceeds actual audio length of the batch, adjust it
+        if end_time > start_offset + actual_length:
+            end_time = start_offset + actual_length
+
         srt_content += f"{i // 15 + 1 + (batch_num * 100)}\n"
         srt_content += f"{format_time(start_time)} --> {format_time(end_time)}\n"
         srt_content += " ".join(segment_words) + "\n\n"
+        
+        # Update start time for next segment
         start_time = end_time
 
     return srt_content, audio_file, start_time  # Return updated start time for cumulative tracking
 
-# Batch processing function with cumulative timing and progress indicator
+# Batch processing function with cumulative timing, progress indicator, and final SRT validation
 async def batch_process_srt_and_audio(script_text, progress=gr.Progress()):
     batches = [script_text[i:i+500] for i in range(0, len(script_text), 500)]
     all_srt_content = ""
     combined_audio = AudioSegment.empty()
     start_offset = 0.0  # Track cumulative time offset for SRT timing
 
-    # Prepare tasks for concurrent batch processing
+    # Process each batch sequentially to ensure proper timing and cumulative offset tracking
     for batch_num, batch_text in enumerate(batches):
         srt_content, audio_file, end_offset = await generate_accurate_srt(batch_text, batch_num, start_offset)
         all_srt_content += srt_content
@@ -72,15 +79,28 @@ async def batch_process_srt_and_audio(script_text, progress=gr.Progress()):
         # Update progress
         progress((batch_num + 1) / len(batches))
 
+    # Final cross-check: Adjust any subtitle that exceeds the total audio length
+    total_audio_length = combined_audio.duration_seconds
+    validated_srt_content = ""
+    for line in all_srt_content.strip().splitlines():
+        if '-->' in line:
+            start_str, end_str = line.split(' --> ')
+            start_time = sum(x * float(t) for x, t in zip([3600, 60, 1, 0.001], start_str.replace(',', ':').split(':')))
+            end_time = sum(x * float(t) for x, t in zip([3600, 60, 1, 0.001], end_str.replace(',', ':').split(':')))
+            if end_time > total_audio_length:
+                end_time = total_audio_length
+            line = f"{format_time(start_time)} --> {format_time(end_time)}"
+        validated_srt_content += line + "\n"
+
     # Generate unique names for the final files
     unique_id = uuid.uuid4()
     final_audio_path = f"final_audio_{unique_id}.wav"
     final_srt_path = f"final_subtitles_{unique_id}.srt"
 
-    # Export combined audio and SRT with unique names
+    # Export combined audio and validated SRT with unique names
     combined_audio.export(final_audio_path, format="wav")
     with open(final_srt_path, "w") as srt_file:
-        srt_file.write(all_srt_content)
+        srt_file.write(validated_srt_content)
 
     return final_srt_path, final_audio_path