🔧 Fix Failure and Optimization Type Field Names

CRITICAL FIX: Corrected field names causing failures and optimizations to display as 'OTHER' type in AgentGraph UI

🚨 ROOT CAUSE: Wrong field names in knowledge graphs
- Failures used 'type' instead of 'risk_type'
- Optimizations used 'type' instead of 'recommendation_type'

🔧 FIXES APPLIED:

1. ✅ Failure Field Names:
BEFORE: "type": "EXECUTION_ERROR" (wrong)
AFTER: "risk_type": "EXECUTION_ERROR" (correct)

2. ✅ Optimization Field Names:
BEFORE: "type": "TOOL_ENHANCEMENT" (wrong)
AFTER: "recommendation_type": "TOOL_ENHANCEMENT" (correct)

3. 🧹 Cleanup Extra Fields:
- Removed 'severity' from failures (not in model)
- Removed 'priority' from optimizations (not in model)

📊 AFFECTED FILES & COUNTS:
- kg_algorithm_sample_1.json: 2 failures + 3 optimizations ✅
- kg_algorithm_sample_3.json: 2 failures + 3 optimizations ✅
- kg_algorithm_sample_14.json: 2 failures + 3 optimizations ✅
- kg_algorithm_sample_16.json: 2 failures + 3 optimizations ✅

✅ VALIDATION RESULTS:
- 8 failures with correct risk_type field
- 12 optimizations with correct recommendation_type field
- All types match predefined valid types:
- EXECUTION_ERROR, RETRIEVAL_ERROR, PLANNING_ERROR
- TOOL_ENHANCEMENT, WORKFLOW_SIMPLIFICATION, PROMPT_REFINEMENT, AGENT_MERGING
- 0 type errors remaining

🎯 OUTCOME: Failures and optimizations will now display with proper type categories in AgentGraph UI instead of 'OTHER'

backend/database/samples/knowledge_graphs/kg_algorithm_sample_1.json

@@ -301,8 +301,6 @@
     "failures": [
       {
         "id": "failure_001",
-        "type": "EXECUTION_ERROR",
-        "severity": "HIGH",
         "description": "Data Verification Expert failed to properly validate restaurant operating hours due to incorrect Python code implementation, leading to inaccurate 11pm availability data",
         "raw_text": "",
         "raw_text_ref": [
@@ -312,12 +310,11 @@
             "confidence": 0.9
           }
         ],
-        "affected_id": "agent_003"
+        "affected_id": "agent_003",
+        "risk_type": "EXECUTION_ERROR"
       },
       {
         "id": "failure_002",
-        "type": "RETRIEVAL_ERROR",
-        "severity": "MEDIUM",
         "description": "Location-Based Services Expert encountered API limitations when accessing real-time restaurant data, resulting in incomplete proximity analysis",
         "raw_text": "",
         "raw_text_ref": [
@@ -327,14 +324,13 @@
             "confidence": 0.85
           }
         ],
-        "affected_id": "agent_001"
+        "affected_id": "agent_001",
+        "risk_type": "RETRIEVAL_ERROR"
       }
     ],
     "optimizations": [
       {
         "id": "opt_001",
-        "type": "TOOL_ENHANCEMENT",
-        "priority": "HIGH",
         "description": "Enhance location-based services with caching mechanisms and fallback data sources to improve reliability and reduce API dependency",
         "raw_text": "Implement robust location service tools with redundancy",
         "raw_text_ref": [
@@ -346,12 +342,11 @@
         ],
         "affected_ids": [
           "agent_001"
-        ]
+        ],
+        "recommendation_type": "TOOL_ENHANCEMENT"
       },
       {
         "id": "opt_002",
-        "type": "WORKFLOW_SIMPLIFICATION",
-        "priority": "MEDIUM",
         "description": "Combine restaurant data collection and operating hours validation into a single integrated task to reduce coordination overhead and improve data consistency",
         "raw_text": "Merge data collection and validation workflows",
         "raw_text_ref": [
@@ -366,12 +361,11 @@
           "agent_003",
           "task_002",
           "task_003"
-        ]
+        ],
+        "recommendation_type": "WORKFLOW_SIMPLIFICATION"
       },
       {
         "id": "opt_003",
-        "type": "PROMPT_REFINEMENT",
-        "priority": "MEDIUM",
         "description": "Refine Data Verification Expert prompts to include specific error handling and validation procedures for time-sensitive restaurant data",
         "raw_text": "Improve validation prompts with error handling",
         "raw_text_ref": [
@@ -383,7 +377,8 @@
         ],
         "affected_ids": [
           "agent_003"
-        ]
+        ],
+        "recommendation_type": "PROMPT_REFINEMENT"
       }
     ]
   },

backend/database/samples/knowledge_graphs/kg_algorithm_sample_14.json

@@ -301,8 +301,6 @@
     "failures": [
       {
         "id": "failure_001",
-        "type": "RETRIEVAL_ERROR",
-        "severity": "HIGH",
         "description": "Literary Analysis Expert incorrectly used arxiv_search tool instead of appropriate academic database tools, leading to failed literature retrieval and incomplete analysis",
         "raw_text": "",
         "raw_text_ref": [
@@ -312,12 +310,11 @@
             "confidence": 0.9
           }
         ],
-        "affected_id": "agent_001"
+        "affected_id": "agent_001",
+        "risk_type": "RETRIEVAL_ERROR"
       },
       {
         "id": "failure_002",
-        "type": "PLANNING_ERROR",
-        "severity": "MEDIUM",
         "description": "Inadequate coordination between literary and mythological analysis phases, resulting in fragmented research approach and missed interdisciplinary connections",
         "raw_text": "",
         "raw_text_ref": [
@@ -327,14 +324,13 @@
             "confidence": 0.85
           }
         ],
-        "affected_id": "agent_002"
+        "affected_id": "agent_002",
+        "risk_type": "PLANNING_ERROR"
       }
     ],
     "optimizations": [
       {
         "id": "opt_001",
-        "type": "TOOL_ENHANCEMENT",
-        "priority": "HIGH",
         "description": "Implement specialized academic database search tools with proper journal and publication filtering to replace generic search mechanisms",
         "raw_text": "Enhanced academic database search capabilities",
         "raw_text_ref": [
@@ -347,12 +343,11 @@
         "affected_ids": [
           "agent_001",
           "agent_004"
-        ]
+        ],
+        "recommendation_type": "TOOL_ENHANCEMENT"
       },
       {
         "id": "opt_002",
-        "type": "WORKFLOW_SIMPLIFICATION",
-        "priority": "MEDIUM",
         "description": "Create integrated literary-mythological analysis workflow to improve coordination between specialized experts and reduce research fragmentation",
         "raw_text": "Unified interdisciplinary analysis workflow",
         "raw_text_ref": [
@@ -365,12 +360,11 @@
         "affected_ids": [
           "task_001",
           "task_002"
-        ]
+        ],
+        "recommendation_type": "WORKFLOW_SIMPLIFICATION"
       },
       {
         "id": "opt_003",
-        "type": "PROMPT_REFINEMENT",
-        "priority": "MEDIUM",
         "description": "Enhance Literary Analysis Expert prompts with specific guidance for academic database selection and interdisciplinary research methodologies",
         "raw_text": "Improved academic research prompts and methodologies",
         "raw_text_ref": [
@@ -382,7 +376,8 @@
         ],
         "affected_ids": [
           "agent_001"
-        ]
+        ],
+        "recommendation_type": "PROMPT_REFINEMENT"
       }
     ]
   },

backend/database/samples/knowledge_graphs/kg_algorithm_sample_16.json

@@ -301,8 +301,6 @@
     "failures": [
       {
         "id": "failure_001",
-        "type": "RETRIEVAL_ERROR",
-        "severity": "HIGH",
         "description": "Data Analysis Expert failed to locate the correct USGS dataset URL, preventing access to essential wildlife monitoring data and compromising the entire analysis pipeline",
         "raw_text": "",
         "raw_text_ref": [
@@ -312,12 +310,11 @@
             "confidence": 0.89
           }
         ],
-        "affected_id": "agent_001"
+        "affected_id": "agent_001",
+        "risk_type": "RETRIEVAL_ERROR"
       },
       {
         "id": "failure_002",
-        "type": "EXECUTION_ERROR",
-        "severity": "MEDIUM",
         "description": "Statistical Analysis Expert encountered data format incompatibilities when processing government datasets, leading to calculation errors and incomplete population statistics",
         "raw_text": "",
         "raw_text_ref": [
@@ -327,14 +324,13 @@
             "confidence": 0.84
           }
         ],
-        "affected_id": "agent_002"
+        "affected_id": "agent_002",
+        "risk_type": "EXECUTION_ERROR"
       }
     ],
     "optimizations": [
       {
         "id": "opt_001",
-        "type": "TOOL_ENHANCEMENT",
-        "priority": "HIGH",
         "description": "Implement specialized government data access tools with automated URL discovery and dataset validation to improve reliability of ecological data retrieval",
         "raw_text": "Enhanced government dataset access and validation tools",
         "raw_text_ref": [
@@ -347,12 +343,11 @@
         "affected_ids": [
           "agent_001",
           "agent_004"
-        ]
+        ],
+        "recommendation_type": "TOOL_ENHANCEMENT"
       },
       {
         "id": "opt_002",
-        "type": "WORKFLOW_SIMPLIFICATION",
-        "priority": "MEDIUM",
         "description": "Create integrated ecological data pipeline combining data processing, statistical analysis, and validation into a streamlined workflow to reduce coordination overhead",
         "raw_text": "Unified ecological data analysis pipeline",
         "raw_text_ref": [
@@ -366,12 +361,11 @@
           "task_001",
           "task_002",
           "task_003"
-        ]
+        ],
+        "recommendation_type": "WORKFLOW_SIMPLIFICATION"
       },
       {
         "id": "opt_003",
-        "type": "AGENT_MERGING",
-        "priority": "LOW",
         "description": "Consider merging Data Analysis and Statistical Analysis experts for ecological projects to reduce handoff delays and improve data consistency in population studies",
         "raw_text": "Merge data and statistical analysis roles for efficiency",
         "raw_text_ref": [
@@ -384,7 +378,8 @@
         "affected_ids": [
           "agent_001",
           "agent_002"
-        ]
+        ],
+        "recommendation_type": "AGENT_MERGING"
       }
     ]
   },

backend/database/samples/knowledge_graphs/kg_algorithm_sample_3.json

@@ -301,8 +301,6 @@
     "failures": [
       {
         "id": "failure_001",
-        "type": "EXECUTION_ERROR",
-        "severity": "HIGH",
         "description": "Probability Expert made critical errors in simulation implementation, leading to incorrect probability distributions and unreliable game theory predictions",
         "raw_text": "",
         "raw_text_ref": [
@@ -312,12 +310,11 @@
             "confidence": 0.91
           }
         ],
-        "affected_id": "agent_001"
+        "affected_id": "agent_001",
+        "risk_type": "EXECUTION_ERROR"
       },
       {
         "id": "failure_002",
-        "type": "PLANNING_ERROR",
-        "severity": "MEDIUM",
         "description": "Interdisciplinary coordination breakdown between probability and chemistry experts, resulting in misaligned analytical approaches and conflicting methodologies",
         "raw_text": "",
         "raw_text_ref": [
@@ -327,14 +324,13 @@
             "confidence": 0.86
           }
         ],
-        "affected_id": "agent_002"
+        "affected_id": "agent_002",
+        "risk_type": "PLANNING_ERROR"
       }
     ],
     "optimizations": [
       {
         "id": "opt_001",
-        "type": "TOOL_ENHANCEMENT",
-        "priority": "HIGH",
         "description": "Develop specialized simulation tools with built-in error checking and validation to improve probability calculation accuracy and reduce execution errors",
         "raw_text": "Enhance probability simulation tools with validation",
         "raw_text_ref": [
@@ -347,12 +343,11 @@
         "affected_ids": [
           "agent_001",
           "agent_004"
-        ]
+        ],
+        "recommendation_type": "TOOL_ENHANCEMENT"
       },
       {
         "id": "opt_002",
-        "type": "AGENT_MERGING",
-        "priority": "MEDIUM",
         "description": "Create unified interdisciplinary expert combining probability and chemistry knowledge to reduce coordination overhead and improve cross-domain integration",
         "raw_text": "Merge probability and chemistry expertise for better integration",
         "raw_text_ref": [
@@ -365,12 +360,11 @@
         "affected_ids": [
           "agent_001",
           "agent_002"
-        ]
+        ],
+        "recommendation_type": "AGENT_MERGING"
       },
       {
         "id": "opt_003",
-        "type": "WORKFLOW_SIMPLIFICATION",
-        "priority": "MEDIUM",
         "description": "Implement parallel processing for probability and chemistry analyses to reduce sequential dependencies and improve overall system efficiency",
         "raw_text": "Enable parallel interdisciplinary analysis",
         "raw_text_ref": [
@@ -383,7 +377,8 @@
         "affected_ids": [
           "task_001",
           "task_002"
-        ]
+        ],
+        "recommendation_type": "WORKFLOW_SIMPLIFICATION"
       }
     ]
   },