Simplify authentication flow to fix login issues

🔧 Simplification:
- Remove complex URL parameter handling
- Remove unnecessary OAuth success detection
- Simplify AuthContext initialization
- Add comprehensive logging for debugging
- Remove redundant event listeners

🎯 Goal:
Return to a more reliable authentication flow like the
original full-page login system but with popup modal.

The previous complex state management was causing
authentication loops and unreliable state detection.

backend/routers/auth.py

@@ -249,8 +249,8 @@ async def oauth_callback(request: Request, code: str, state: str):
     
     logger.info(f"User logged in: {user_info.get('name')} ({user_info.get('login')})")
     
-    # Redirect to main application with auth success indicator
-    return RedirectResponse(url="/?auth=success", status_code=302)
+    # Redirect to main application
+    return RedirectResponse(url="/", status_code=302)
 
 
 @router.get("/logout")

frontend/src/context/AuthContext.tsx

@@ -57,16 +57,20 @@ export function AuthProvider({ children }: AuthProviderProps) {
   const checkAuthStatus = async () => {
     try {
       setIsLoading(true);
+      console.log("🔍 Checking authentication status...");
+
       const response = await fetch("/auth/status");
       const data = await response.json();
 
+      console.log("📊 Auth status response:", data);
+
       setIsHFSpaces(data.environment === "huggingface_spaces");
       setAuthRequired(
         data.login_required && data.environment === "huggingface_spaces"
       );
 
       if (data.user_authenticated && data.user_info) {
-        setUser({
+        const userData = {
           id: data.user_info.id || "unknown",
           username: data.user_info.username || "Unknown User",
           name:
@@ -74,26 +78,36 @@ export function AuthProvider({ children }: AuthProviderProps) {
           email: data.user_info.email,
           avatar_url: data.user_info.avatar_url,
           auth_method: data.user_info.auth_method || "unknown",
-        });
+        };
+
+        setUser(userData);
         setShowLoginModal(false);
-        console.log(
-          "✅ User authenticated successfully:",
-          data.user_info.username
-        );
+        console.log("✅ User authenticated successfully:", userData.username);
       } else {
         setUser(null);
-        console.log("❌ User not authenticated - showing login modal");
-        // Show login modal if in HF Spaces and auth is required
+        console.log(
+          "❌ User not authenticated, environment:",
+          data.environment,
+          "auth required:",
+          data.login_required
+        );
+
+        // Only show login modal in HF Spaces when auth is required
         if (data.environment === "huggingface_spaces" && data.login_required) {
+          console.log("🔐 Showing login modal for HF Spaces");
           setShowLoginModal(true);
+        } else {
+          console.log("🏠 Local development - no login required");
+          setShowLoginModal(false);
         }
       }
     } catch (error) {
-      console.error("Failed to check auth status:", error);
+      console.error("❌ Failed to check auth status:", error);
       setUser(null);
       // Assume local development if fetch fails
       setIsHFSpaces(false);
       setAuthRequired(false);
+      setShowLoginModal(false);
     } finally {
       setIsLoading(false);
     }
@@ -130,37 +144,21 @@ export function AuthProvider({ children }: AuthProviderProps) {
   };
 
   useEffect(() => {
-    // Check for auth success parameter in URL
-    const urlParams = new URLSearchParams(window.location.search);
-    if (urlParams.get('auth') === 'success') {
-      console.log("Authentication success detected - refreshing status");
-      // Remove the parameter from URL
-      window.history.replaceState({}, document.title, window.location.pathname);
-      // Force auth status check
-      setTimeout(() => checkAuthStatus(), 100);
-    } else {
-      checkAuthStatus();
-    }
+    // Initial auth check
+    checkAuthStatus();
 
     // Listen for auth-required events from API calls
     const handleAuthRequired = () => {
+      console.log("🔐 Auth required event received");
       if (authRequired && !isAuthenticated) {
         setShowLoginModal(true);
       }
     };
 
-    // Listen for page focus to refresh auth status (useful after OAuth redirect)
-    const handleFocus = () => {
-      console.log("Page focused - checking auth status");
-      checkAuthStatus();
-    };
-
     window.addEventListener("auth-required", handleAuthRequired);
-    window.addEventListener("focus", handleFocus);
 
     return () => {
       window.removeEventListener("auth-required", handleAuthRequired);
-      window.removeEventListener("focus", handleFocus);
     };
   }, []);