do not pass subprocess object to gradio State

app.py

@@ -67,7 +67,6 @@ with gr.Blocks(title="RFD3 Test") as demo:
 
     gen_directory = gr.State(None) # the directory where generation results are saved, used to trigger the download of results as zip file
     gen_results = gr.State(None) # the results of the generation, which is a list of dicts where each dict contains batch number "batch", design number "design", path to cif file "cif_path", and path to pdb file "pdb_path".
-    process = gr.State(None) # to store the subprocess.Popen object for the generation process, used to terminate the process when the stop button is clicked.
 
     # inputs from user
     with gr.Row():
@@ -139,7 +138,7 @@ with gr.Blocks(title="RFD3 Test") as demo:
         lambda: (gr.update(visible=False), gr.update(visible=True)),
         outputs=[run_btn, stop_btn]
     ).then(
-        generation_with_input_config, inputs=[config_upload, scaffold_upload, num_batches, num_designs_per_batch, extra_args, max_duration], outputs=[runtextbox, gen_directory, gen_results, process]
+        generation_with_input_config, inputs=[config_upload, scaffold_upload, num_batches, num_designs_per_batch, extra_args, max_duration], outputs=[runtextbox, gen_directory, gen_results]
     ).then(
         update_batch_choices,
         inputs=gen_results,
@@ -153,18 +152,8 @@ with gr.Blocks(title="RFD3 Test") as demo:
         outputs=[run_btn, stop_btn]
     )
 
-    def stop_generation(proc_state):
-        #if proc_state is not None and proc_state.poll() is None:
-        #    try:
-        #        # Kill whole process group so child processes die too
-        #        os.killpg(os.getpgid(proc_state.pid), signal.SIGTERM)
-        #    except Exception:
-        #        proc_state.terminate()
-        return gr.update(value="Generation cancelled by user.") 
-    
     stop_btn.click(
-        stop_generation,
-        inputs=process,
+        lambda: gr.update(value="Generation cancelled by user."),
         outputs=runtextbox,
         cancels=[generation_event]
     ).then(

utils/pipelines.py

@@ -42,7 +42,7 @@ def generation_with_input_config(input_file, pdb_file, num_batches, num_designs_
 
 
     if input_file is None:        
-        return gr.update(value="Please ensure you have uploaded a configuration file: .yaml or .json"), gr.update(), gr.update(), gr.update()
+        return gr.update(value="Please ensure you have uploaded a configuration file: .yaml or .json"), gr.update(), gr.update()
     elif pdb_file is None:
         status_update = f"Running generation for {num_batches} batches of {num_designs_per_batch}\n job configuration uploaded from file {os.path.basename(input_file)}\n no scaffold/target provided"
     else:
@@ -83,12 +83,12 @@ def generation_with_input_config(input_file, pdb_file, num_batches, num_designs_
         )
         
         # Immediately yield to make process available in State
-        yield gr.update(value=status_update), gr.update(), gr.update(), process
+        yield gr.update(value=status_update), gr.update(), gr.update()
         
         # Poll the process - yield regularly to allow Gradio to stop calling the generator
         while process.poll() is None:
             time.sleep(2)  # Wait before checking again
-            yield gr.update(value=status_update), gr.update(), gr.update(), process
+            yield gr.update(value=status_update), gr.update(), gr.update()
         
         # Get the output after process completes
         stdout, stderr = process.communicate()
@@ -115,11 +115,11 @@ def generation_with_input_config(input_file, pdb_file, num_batches, num_designs_
                 results.append({"batch": batch, "design": design, "cif_path": cif_path, "pdb_path": pdb_path})
             
         print(results)
-        return gr.update(value=status_update), directory, results, process
+        return gr.update(value=status_update), directory, results
     
     except subprocess.CalledProcessError as e:
         print("subprocess threw an error", e.stderr)
-        return gr.update(value=f"Generation failed:\n{e.stderr}"), None, None, None
+        return gr.update(value=f"Generation failed:\n{e.stderr}"), None, None
     
     except Exception as e:
         # Handle cancellation or other errors - terminate the subprocess if it's still running