updated

backend/services/report_generator.py

@@ -139,6 +139,11 @@ def generate_llm_interview_report(application) -> str:
                 for idx, entry in enumerate(qa_log, 1):
                     q = entry.get("question", "N/A")
                     a = entry.get("answer", "N/A")
+                    
+                    # Handle salary question specifically
+                    if "salary" in q.lower() and (a == "0$" or a == "0" or a == "$0"):
+                        a = "Prefer not to disclose"
+                    
                     eval_score = entry.get("evaluation", {}).get("score", "N/A")
                     eval_feedback = entry.get("evaluation", {}).get("feedback", "N/A")
                     
@@ -542,151 +547,190 @@ def _add_section_header(ax, x: float, y: float, title: str, width: float):
     ax.add_line(line)
 
 
+def _calculate_dynamic_box_height(text: str, width_chars: int = 75, base_height: float = 0.8) -> float:
+    """Calculate dynamic height for text box based on content."""
+    wrapped_lines = textwrap.wrap(text, width=width_chars)
+    num_lines = len(wrapped_lines)
+    # Base height + additional height per line
+    return base_height + (max(0, num_lines - 2) * 0.15)
+
+
 def _create_transcript_pages(pdf, qa_log: List[Dict], page_width: float, page_height: float,
                            left_margin: float, right_margin: float,
                            top_margin: float, bottom_margin: float):
-    """Create professional pages for interview transcript."""
+    """Create professional pages for interview transcript with dynamic text wrapping."""
     content_width = page_width - left_margin - right_margin
     wrapper = textwrap.TextWrapper(width=75)
     
-    # Group questions for pagination
-    questions_per_page = 2  # Reduced for better spacing
-    total_pages = (len(qa_log) + questions_per_page - 1) // questions_per_page
+    # Create pages dynamically based on content
+    fig = plt.figure(figsize=(page_width, page_height))
+    fig.patch.set_facecolor('white')
+    ax = fig.add_subplot(111)
+    ax.set_xlim(0, page_width)
+    ax.set_ylim(0, page_height)
+    ax.axis('off')
     
-    for page_num in range(total_pages):
-        fig = plt.figure(figsize=(page_width, page_height))
-        fig.patch.set_facecolor('white')
-        ax = fig.add_subplot(111)
-        ax.set_xlim(0, page_width)
-        ax.set_ylim(0, page_height)
-        ax.axis('off')
-        
-        # Page header
-        y_pos = page_height - top_margin
-        
-        # Header background
-        header_rect = FancyBboxPatch(
-            (left_margin, y_pos - 0.6), content_width, 0.6,
-            boxstyle="round,pad=0.02",
-            facecolor='#1e40af',
-            edgecolor='none'
+    # Initialize page
+    y_pos = page_height - top_margin
+    page_num = 0
+    
+    # Header for first transcript page
+    _add_transcript_header(ax, left_margin, y_pos, content_width, page_num + 2)
+    y_pos -= 1.0
+    
+    for idx, qa in enumerate(qa_log):
+        # Calculate space needed for this Q&A
+        q_height = _calculate_dynamic_box_height(qa['question'])
+        a_height = _calculate_dynamic_box_height(qa['answer'], width_chars=70)
+        total_height = q_height + a_height + 2.5  # Include spacing
+        
+        # Check if we need a new page
+        if y_pos - total_height < bottom_margin + 1.0:
+            # Save current page
+            pdf.savefig(fig, bbox_inches='tight', pad_inches=0)
+            plt.close(fig)
+            
+            # Create new page
+            fig = plt.figure(figsize=(page_width, page_height))
+            fig.patch.set_facecolor('white')
+            ax = fig.add_subplot(111)
+            ax.set_xlim(0, page_width)
+            ax.set_ylim(0, page_height)
+            ax.axis('off')
+            
+            y_pos = page_height - top_margin
+            page_num += 1
+            _add_transcript_header(ax, left_margin, y_pos, content_width, page_num + 2)
+            y_pos -= 1.0
+        
+        # Question section with dynamic height
+        q_box = FancyBboxPatch(
+            (left_margin, y_pos - q_height), content_width, q_height,
+            boxstyle="round,pad=0.05",
+            facecolor='#eff6ff',
+            edgecolor='#3b82f6',
+            linewidth=2
         )
-        ax.add_patch(header_rect)
+        ax.add_patch(q_box)
         
-        ax.text(left_margin + 0.2, y_pos - 0.3, 'INTERVIEW TRANSCRIPT',
-                fontsize=14, fontweight='bold', color='white')
+        # Question number badge
+        q_badge = Circle((left_margin + 0.4, y_pos - q_height/2), 0.2,
+                       facecolor='#3b82f6', edgecolor='white', linewidth=2)
+        ax.add_patch(q_badge)
         
-        # Page number
-        ax.text(page_width - right_margin - 0.2, y_pos - 0.3, f'Page {page_num + 2}',
-                fontsize=10, color='white', horizontalalignment='right')
+        ax.text(left_margin + 0.4, y_pos - q_height/2, f'{idx+1}',
+                fontsize=12, fontweight='bold', color='white',
+                horizontalalignment='center', verticalalignment='center')
         
-        y_pos -= 1.0
+        # Question text with proper wrapping
+        ax.text(left_margin + 0.8, y_pos - 0.2, 'QUESTION',
+                fontsize=9, fontweight='bold', color='#1e40af')
         
-        # Questions for this page
-        start_idx = page_num * questions_per_page
-        end_idx = min(start_idx + questions_per_page, len(qa_log))
+        q_wrapped = wrapper.wrap(qa['question'])
+        for j, line in enumerate(q_wrapped):
+            ax.text(left_margin + 0.8, y_pos - 0.4 - (j * 0.15), line,
+                    fontsize=11, fontweight='bold', color='#1e293b')
         
-        for i in range(start_idx, end_idx):
-            qa = qa_log[i]
-            
-            # Question section
-            q_box = FancyBboxPatch(
-                (left_margin, y_pos - 1.0), content_width, 1.0,
-                boxstyle="round,pad=0.05",
-                facecolor='#eff6ff',
-                edgecolor='#3b82f6',
-                linewidth=2
-            )
-            ax.add_patch(q_box)
-            
-            # Question number badge
-            q_badge = Circle((left_margin + 0.4, y_pos - 0.5), 0.2,
-                           facecolor='#3b82f6', edgecolor='white', linewidth=2)
-            ax.add_patch(q_badge)
-            
-            ax.text(left_margin + 0.4, y_pos - 0.5, f'{i+1}',
-                    fontsize=12, fontweight='bold', color='white',
-                    horizontalalignment='center', verticalalignment='center')
-            
-            # Question text
-            ax.text(left_margin + 0.8, y_pos - 0.3, 'QUESTION',
-                    fontsize=9, fontweight='bold', color='#1e40af')
-            
-            q_wrapped = wrapper.wrap(qa['question'])
-            for j, line in enumerate(q_wrapped[:3]):  # Max 3 lines
-                ax.text(left_margin + 0.8, y_pos - 0.5 - (j * 0.15), line,
-                        fontsize=11, fontweight='bold', color='#1e293b')
-            
-            y_pos -= 1.4
-            
-            # Answer section
-            answer_box = FancyBboxPatch(
-                (left_margin + 0.2, y_pos - 1.2), content_width - 0.4, 1.2,
-                boxstyle="round,pad=0.05",
-                facecolor='#f9fafb',
-                edgecolor='#d1d5db',
-                linewidth=1
-            )
-            ax.add_patch(answer_box)
-            
-            ax.text(left_margin + 0.4, y_pos - 0.2, 'CANDIDATE RESPONSE',
-                    fontsize=9, fontweight='bold', color='#6b7280')
+        y_pos -= (q_height + 0.3)
+        
+        # Answer section with dynamic height
+        answer_text = qa['answer']
+        # Handle salary question replacement
+        if "salary" in qa['question'].lower() and (answer_text == "0$" or answer_text == "0" or answer_text == "$0"):
+            answer_text = "Prefer not to disclose"
             
-            a_wrapped = wrapper.wrap(qa['answer'])
-            for j, line in enumerate(a_wrapped[:4]):  # Max 4 lines
+        answer_box = FancyBboxPatch(
+            (left_margin + 0.2, y_pos - a_height), content_width - 0.4, a_height,
+            boxstyle="round,pad=0.05",
+            facecolor='#f9fafb',
+            edgecolor='#d1d5db',
+            linewidth=1
+        )
+        ax.add_patch(answer_box)
+        
+        ax.text(left_margin + 0.4, y_pos - 0.2, 'CANDIDATE RESPONSE',
+                fontsize=9, fontweight='bold', color='#6b7280')
+        
+        a_wrapped = wrapper.wrap(answer_text)
+        for j, line in enumerate(a_wrapped):
+            if j * 0.15 < a_height - 0.4:  # Ensure text fits in box
                 ax.text(left_margin + 0.4, y_pos - 0.4 - (j * 0.15), line,
                         fontsize=10, color='#374151')
+        
+        y_pos -= (a_height + 0.4)
+        
+        # Evaluation section
+        eval_box = FancyBboxPatch(
+            (left_margin + 0.4, y_pos - 0.8), content_width - 0.8, 0.8,
+            boxstyle="round,pad=0.05",
+            facecolor='#fefefe',
+            edgecolor='#e5e7eb',
+            linewidth=1
+        )
+        ax.add_patch(eval_box)
+        
+        # Score badge
+        score_color = _get_score_color(qa['score'])
+        score_badge = FancyBboxPatch(
+            (left_margin + 0.6, y_pos - 0.35), 1.2, 0.25,
+            boxstyle="round,pad=0.02",
+            facecolor=score_color,
+            alpha=0.2,
+            edgecolor=score_color,
+            linewidth=1
+        )
+        ax.add_patch(score_badge)
+        
+        ax.text(left_margin + 1.2, y_pos - 0.225, qa['score'],
+                fontsize=10, fontweight='bold', color=score_color,
+                horizontalalignment='center', verticalalignment='center')
+        
+        # Feedback with proper wrapping
+        if qa['feedback'] and qa['feedback'] != 'N/A':
+            ax.text(left_margin + 2.2, y_pos - 0.15, 'Feedback:',
+                    fontsize=9, fontweight='bold', color='#6b7280')
             
-            y_pos -= 1.6
-            
-            # Evaluation section
-            eval_box = FancyBboxPatch(
-                (left_margin + 0.4, y_pos - 0.8), content_width - 0.8, 0.8,
-                boxstyle="round,pad=0.05",
-                facecolor='#fefefe',
-                edgecolor='#e5e7eb',
-                linewidth=1
-            )
-            ax.add_patch(eval_box)
-            
-            # Score badge
-            score_color = _get_score_color(qa['score'])
-            score_badge = FancyBboxPatch(
-                (left_margin + 0.6, y_pos - 0.35), 1.2, 0.25,
-                boxstyle="round,pad=0.02",
-                facecolor=score_color,
-                alpha=0.2,
-                edgecolor=score_color,
-                linewidth=1
-            )
-            ax.add_patch(score_badge)
-            
-            ax.text(left_margin + 1.2, y_pos - 0.225, qa['score'],
-                    fontsize=10, fontweight='bold', color=score_color,
-                    horizontalalignment='center', verticalalignment='center')
-            
-            # Feedback
-            if qa['feedback'] and qa['feedback'] != 'N/A':
-                ax.text(left_margin + 2.2, y_pos - 0.15, 'Feedback:',
-                        fontsize=9, fontweight='bold', color='#6b7280')
-                
-                f_wrapped = wrapper.wrap(qa['feedback'])
-                for j, line in enumerate(f_wrapped[:2]):  # Max 2 lines
-                    ax.text(left_margin + 2.2, y_pos - 0.35 - (j * 0.15), line,
-                            fontsize=9, color='#6b7280', style='italic')
-            
-            y_pos -= 1.2
+            # Calculate feedback area width
+            feedback_width = content_width - 2.6
+            feedback_wrapper = textwrap.TextWrapper(width=int(feedback_width * 10))
+            f_wrapped = feedback_wrapper.wrap(qa['feedback'])
             
-            # Add separator between questions (except last)
-            if i < end_idx - 1:
-                separator = plt.Line2D([left_margin + 1, left_margin + content_width - 1],
-                                     [y_pos + 0.3, y_pos + 0.3],
-                                     color='#e5e7eb', linewidth=1, linestyle='--')
-                ax.add_line(separator)
-                y_pos -= 0.3
-        
-        pdf.savefig(fig, bbox_inches='tight', pad_inches=0)
-        plt.close(fig)
+            for j, line in enumerate(f_wrapped[:2]):  # Max 2 lines
+                ax.text(left_margin + 2.2, y_pos - 0.35 - (j * 0.15), line,
+                        fontsize=9, color='#6b7280', style='italic')
+        
+        y_pos -= 1.2
+        
+        # Add separator between questions (except last)
+        if idx < len(qa_log) - 1:
+            separator = plt.Line2D([left_margin + 1, left_margin + content_width - 1],
+                                 [y_pos + 0.3, y_pos + 0.3],
+                                 color='#e5e7eb', linewidth=1, linestyle='--')
+            ax.add_line(separator)
+            y_pos -= 0.3
+    
+    # Save last page
+    pdf.savefig(fig, bbox_inches='tight', pad_inches=0)
+    plt.close(fig)
+
+
+def _add_transcript_header(ax, left_margin: float, y_pos: float, content_width: float, page_num: int):
+    """Add header for transcript pages."""
+    # Header background
+    header_rect = FancyBboxPatch(
+        (left_margin, y_pos - 0.6), content_width, 0.6,
+        boxstyle="round,pad=0.02",
+        facecolor='#1e40af',
+        edgecolor='none'
+    )
+    ax.add_patch(header_rect)
+    
+    ax.text(left_margin + 0.2, y_pos - 0.3, 'INTERVIEW TRANSCRIPT',
+            fontsize=14, fontweight='bold', color='white')
+    
+    # Page number
+    ax.text(left_margin + content_width - 0.2, y_pos - 0.3, f'Page {page_num}',
+            fontsize=10, color='white', horizontalalignment='right')
 
 
 # Keep the original advanced version as fallback
@@ -800,6 +844,9 @@ def create_pdf_report_advanced(report_text: str) -> BytesIO:
             elif stripped.startswith('Question'):
                 story.append(Paragraph(stripped, question_style))
             elif stripped.startswith('Answer:'):
+                # Handle salary replacement
+                if "0$" in stripped or " 0 " in stripped or "$0" in stripped:
+                    stripped = stripped.replace("0$", "Prefer not to disclose").replace(" 0 ", " Prefer not to disclose ").replace("$0", "Prefer not to disclose")
                 story.append(Paragraph(stripped, answer_style))
             elif stripped.startswith('Score:'):
                 story.append(Paragraph(stripped, score_style))
@@ -830,4 +877,4 @@ def create_pdf_report_advanced(report_text: str) -> BytesIO:
         return create_pdf_report(report_text)
 
 
-__all__ = ['generate_llm_interview_report', 'create_pdf_report']
+__all__ = ['generate_llm_interview_report', 'create_pdf_report']