Update app.py

app.py

@@ -57,54 +57,63 @@ def call_groq_api(prompt):
 def analyze_requirement(requirement):
     try:
         # 1. Classify requirement type
-        type_prompt = f"Classify this requirement as Functional or Non-Functional (one word only):\n{requirement}"
+        type_prompt = f"Classify exactly as either 'Functional' or 'Non-Functional':\n{requirement}"
         req_type = call_mistral_api(type_prompt).strip()
         
         # 2. Identify domain
-        domain_prompt = f"Identify the domain for this requirement (one word only, e.g., Healthcare, Finance):\n{requirement}"
+        domain_prompt = f"Identify the business domain in one word (e.g., Healthcare, Finance):\n{requirement}"
         domain = call_mistral_api(domain_prompt).strip()
         
-        # 3. Detect defects
-        defects_prompt = f"""List ONLY the major defects in this requirement 
-        (EXACTLY 3 bullet points, each defect 1-2 words maximum):
-        - Defect1
-        - Defect2
-        - Defect3
+        # 3. Detect defects - more explicit prompt
+        defects_prompt = f"""Analyze this software requirement and list EXACTLY 3 defects using ONLY these formats:
+        - Ambiguity: [specific unclear part]
+        - Incompleteness: [missing element]
+        - Unverifiability: [unmeasurable aspect]
         
         Requirement: {requirement}
         Defects:"""
         defects_response = call_groq_api(defects_prompt).strip()
         
-        # Process defects
+        # Process defects - more robust parsing
         defects = []
         if "API Error" not in defects_response:
-            defects = [line.strip()[2:] for line in defects_response.split("\n") 
-                      if line.strip().startswith("- ")]
-        if not defects:
-            defects = ["No major defects found"]
+            # Extract all lines starting with "-"
+            defect_lines = [line.strip() for line in defects_response.split("\n") if line.strip().startswith("-")]
+            if defect_lines:
+                defects = [line[2:].split(":")[0].strip() for line in defect_lines[:3]]  # Take first 3 defects
+            else:
+                defects = ["No defects found"]
+        else:
+            defects = ["Analysis error"]
         
-        # 4. Rewrite requirement
-        rewrite_prompt = f"""Rewrite this requirement to fix defects while keeping it concise 
-        (1-2 sentences maximum):\n{requirement}"""
+        # 4. Rewrite requirement - more constrained prompt
+        rewrite_prompt = f"""Improve this requirement by fixing defects while keeping it concise (1 sentence):
+        Original: {requirement}
+        Improved:"""
         rewritten = call_groq_api(rewrite_prompt).strip()
         
+        # Clean rewritten output
+        if "Improved:" in rewritten:
+            rewritten = rewritten.split("Improved:")[-1].strip()
+        
         return {
             "Requirement": requirement,
-            "Type": req_type if "HTTP Error" not in req_type else "Unknown",
-            "Domain": domain if "HTTP Error" not in domain else "Unknown",
-            "Defects": defects,
-            "Rewritten": rewritten if "HTTP Error" not in rewritten else requirement
+            "Type": req_type,
+            "Domain": domain,
+            "Defects": defects if defects else ["No defects found"],
+            "Rewritten": rewritten if rewritten and "API Error" not in rewritten else requirement
         }
         
     except Exception as e:
-        st.error(f"Analysis failed: {str(e)}")
         return {
             "Requirement": requirement,
             "Type": "Error",
             "Domain": "Error",
-            "Defects": ["Analysis Failed"],
+            "Defects": ["Analysis failed"],
             "Rewritten": requirement
         }
+
+        
 # Function to generate a PDF report
 def generate_pdf_report(results):
     pdf = FPDF()
@@ -247,39 +256,30 @@ def main():
                 time.sleep(0.5)
                 st.session_state.results = results
 
-    # Display Results
-    if 'results' in st.session_state:
-        st.subheader("📊 Analysis Results")
-        with st.container():
-            for i, result in enumerate(st.session_state.results, 1):
-                with st.expander(f"Requirement #{i}: {result['Requirement'][:50]}...", expanded=True):
-                    st.markdown(f"""
-                        <div class="requirement-card">
-                            <div style="margin-bottom: 1.5rem;">
-                                <div class="analysis-badge { 'type-functional' if 'functional' in result['Type'].lower() else 'type-non-functional' }">
-                                    📌 Type: {result['Type']}
-                                </div>
-                                <div class="analysis-badge" style="background: #e8eaf6; color: #303f9f;">
-                                    🏷️ Domain: {result['Domain']}
-                                </div>
-                            </div>
-                            
-                            <div style="margin: 1rem 0;">
-                                <h4>🔎 Identified Issues</h4>
-                                <div style="display: flex; gap: 0.5rem; flex-wrap: wrap;">
-                                    {''.join([f'<div class="analysis-badge defect-badge">⚠️ {d}</div>' 
-                                            for d in result["Defects"]])}
-                                </div>
-                            </div>
-                            
-                            <div style="margin: 1rem 0;">
-                                <h4>✨ Improved Version</h4>
-                                <div class="analysis-badge improved-badge">
-                                    📝 {result["Rewritten"]}
-                                </div>
-                            </div>
-                        </div>
-                    """, unsafe_allow_html=True)
+# In your results display section:
+for i, result in enumerate(st.session_state.results, 1):
+    with st.expander(f"Requirement #{i}: {result['Requirement'][:50]}...", expanded=True):
+        st.markdown(f"""
+        <div class="requirement-card">
+            <!-- Type and Domain sections remain the same -->
+            
+            <div style="margin: 1rem 0;">
+                <h4>🔎 Identified Issues</h4>
+                <div style="display: flex; gap: 0.5rem; flex-wrap: wrap;">
+                    {''.join([f'<div class="analysis-badge defect-badge">⚠️ {d}</div>' 
+                             for d in result["Defects"] if d and d != "No defects found"]) or 
+                    '<div class="analysis-badge" style="background:#e8f5e9;color:#2e7d32;">✓ No major defects found</div>'}
+                </div>
+            </div>
+            
+            <div style="margin: 1rem 0;">
+                <h4>✨ Improved Version</h4>
+                <div class="analysis-badge improved-badge">
+                    📝 {result["Rewritten"] if result["Rewritten"] != result["Requirement"] else "No improvements suggested"}
+                </div>
+            </div>
+        </div>
+        """, unsafe_allow_html=True)
 
         # PDF Report Section
         st.subheader("📤 Generate Report")