Update app.py

app.py

@@ -28,6 +28,7 @@ async def create_game(request: Request):
     if pin in games:
         raise HTTPException(status_code=400, detail="Game already exists.")
 
+    # Initialize permissions as a dictionary with proper keys.
     games[pin] = {
         "pin": pin,
         "players": [player_name],
@@ -94,6 +95,7 @@ async def handle_action(request: Request):
         return {"success": True, "challenge": game.get("challenge", None)}
 
     if action == 'steal':
+        # Check if the player has permission to steal
         if game["permissions"].get(player, {}).get("steal", True):
             game["challenge"] = {
                 "action": 'steal',
@@ -109,6 +111,7 @@ async def handle_action(request: Request):
         if not game.get("challenge"):
             return {"success": False, "message": "No challenge pending."}
 
+        # Assuming game["players"] now contains player dictionaries with a "name" key.
         challenger = next(p for p in game["players"] if p["name"] == game["challenge"]["challenger"])
         target_player = next(p for p in game["players"] if p["name"] == game["challenge"]["target"])
 
@@ -141,12 +144,13 @@ async def handle_action(request: Request):
             return {"success": False, "message": f"Card {target} not found in {challenger['name']}'s hand."}
 
     if action == 'income':
-        # Check if the game has started and update coins only if player's permission is True
+        # Find the player in the players list
         player_found = False
         for p in game["players"]:
             if p["name"] == player:
                 player_found = True
-                if game["permissions"].get(player, {}).get("gain", True):
+                # If gain permission is not available, then income has already been taken.
+                if not game["permissions"].get(player, {}).get("gain", True):
                     raise HTTPException(status_code=403, detail="You already took coins, and cannot take income.")
                 p["coins"] += 1
                 game["permissions"][player]["gain"] = False
@@ -166,8 +170,14 @@ async def join_game(request: Request):
     if not game:
         raise HTTPException(status_code=404, detail="Game not found.")
 
+    # Prevent duplicate player names.
+    if player_name in game["permissions"]:
+        raise HTTPException(status_code=400, detail="Player name already taken.")
+
     game["players"].append(player_name)
+    # Properly initialize the new player's permissions.
     game["permissions"][player_name] = {"steal": True, "gain": True}
+    
     return {"success": True, "message": "Player joined successfully!"}
 
 @app.put("/api/startGame")
@@ -185,9 +195,10 @@ async def start_game(request: Request):
     if len(game["players"]) == 0:
         raise HTTPException(status_code=400, detail="No players in the game.")
 
-    # Initialize players with 2 coins and cards, and reset permissions to True for all
+    # Initialize players with 2 coins and cards.
     game["players"] = [{"name": name, "coins": 2, "cards": generate_cards()} for name in game["players"]]
-    game["permissions"] = {player["name"]: True for player in game["players"]}
+    # Reset permissions to a dictionary with proper keys for each player.
+    game["permissions"] = {player["name"]: {"steal": True, "gain": True} for player in game["players"]}
     game["gameStarted"] = True
     game["turn"] = game["players"][0]["name"]