fix: Delete race condition - properly track ChromaDB items during deletion

app.py

@@ -759,7 +759,21 @@ def delete_card_endpoint(mode, item_id):
         _save_user_data(user_api_key, mode, user_data)
     
     # Step 1.5: Delete from ChromaDB (RAG knowledge base)
+    item_found_in_chroma = False
     try:
+        # Check if item exists in ChromaDB before deleting
+        chroma_data = rag_core.load_all_metadata_from_chroma(user_api_key, mode)
+        if chroma_data:
+            if mode == 'cards':
+                item_found_in_chroma = any(c.get('id') == item_id for c in chroma_data)
+            elif mode == 'brochures':
+                if contact_id:
+                    brochure = next((b for b in chroma_data if b.get('id') == item_id), None)
+                    if brochure:
+                        item_found_in_chroma = any(c.get('id') == contact_id for c in brochure.get('contacts', []))
+                else:
+                    item_found_in_chroma = any(b.get('id') == item_id for b in chroma_data)
+        
         if mode == 'cards':
             # Remove card document from ChromaDB
             rag_core.remove_document_from_knowledge_base(user_api_key, item_id, mode)
@@ -770,6 +784,12 @@ def delete_card_endpoint(mode, item_id):
             if contact_id:
                 # Contact deleted - re-index the brochure's contacts document
                 brochure = next((b for b in user_data if b.get('id') == item_id), None)
+                # Also check ChromaDB data if not found in JSON
+                if not brochure and chroma_data:
+                    brochure = next((b for b in chroma_data if b.get('id') == item_id), None)
+                    if brochure:
+                        # Remove the contact from the brochure in ChromaDB
+                        brochure['contacts'] = [c for c in brochure.get('contacts', []) if c.get('id') != contact_id]
                 if brochure:
                     contacts_doc_id = f"{item_id}_contacts"
                     rag_core.remove_document_from_knowledge_base(user_api_key, contacts_doc_id, mode)
@@ -797,6 +817,7 @@ def delete_card_endpoint(mode, item_id):
                 print(f"ChromaDB: Removed brochure {item_id} documents and metadata from knowledge base")
     except Exception as e:
         print(f"ChromaDB removal warning: {e}")
+
     
     # ## FINAL DATABASE CODE ##
     # Step 2: Delete from Database (New Logic)
@@ -825,8 +846,8 @@ def delete_card_endpoint(mode, item_id):
                     print(f"Database record deleted for brochure json_id: {item_id}")
                     return jsonify({"success": True})
 
-        if not item_found_in_json:
-            # Try to find in ChromaDB if not in JSON
+        if not item_found_in_json and not item_found_in_chroma:
+            # Try to find in ChromaDB if not in JSON (should rarely happen now)
             chroma_data = rag_core.load_all_metadata_from_chroma(user_api_key, mode)
             if chroma_data:
                 if mode == 'cards':