File size: 10,625 Bytes
8c77cd6
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
# 🧪 TESTING & VERIFICATION GUIDE

## Quick Manual Verification (No pytest needed)

### Prerequisites
- Backend running on `http://localhost:7860` (or your configured port)
- Supabase database configured in `.env`

### Test Scenario: Complete Workflow

#### Step 1: Register User
```bash
curl -X POST http://localhost:7860/auth/register \
  -H "Content-Type: application/json" \
  -d '{
    "email": "alice@example.com",
    "name": "Alice",
    "password": "SecurePass123!"
  }'
```

**Expected Response:**
```json
{
  "id": 1,
  "email": "alice@example.com",
  "name": "Alice",
  "created_at": "2024-01-10T12:00:00Z"
}
```

#### Step 2: Login & Get Token
```bash
curl -X POST http://localhost:7860/auth/login \
  -H "Content-Type: application/json" \
  -d '{
    "email": "alice@example.com",
    "password": "SecurePass123!"
  }'
```

**Expected Response:**
```json
{
  "access_token": "eyJ0eXAiOiJKV1QiLCJhbGc...",
  "token_type": "bearer"
}
```

**Save token:** `TOKEN="eyJ0eXAiOiJKV1QiLCJhbGc..."`

---

#### Step 3: Send First Message (Create Conversation)
```bash
curl -X POST http://localhost:7860/chat/send \
  -H "Content-Type: application/json" \
  -H "Authorization: Bearer $TOKEN" \
  -d '{
    "query": "What is machine learning?"
  }'
```

**Expected Response:**
```json
{
  "conversation_id": 1,
  "response": "Machine learning is a subset of artificial intelligence...",
  "timestamp": "2024-01-10T12:00:05Z"
}
```

**Verify in Database:**
```sql
SELECT * FROM conversations WHERE user_id = 1;
-- Should show: id=1, user_id=1, is_deleted=false, last_message_at=NOW()

SELECT * FROM messages WHERE conversation_id = 1 ORDER BY created_at;
-- Should show 2 messages: user query + AI response
```

---

#### Step 4: Send Follow-up Message (Same Conversation)
```bash
curl -X POST http://localhost:7860/chat/send \
  -H "Content-Type: application/json" \
  -H "Authorization: Bearer $TOKEN" \
  -d '{
    "conversation_id": 1,
    "query": "Tell me about neural networks"
  }'
```

**Expected Response:**
```json
{
  "conversation_id": 1,
  "response": "Neural networks are computing systems...",
  "timestamp": "2024-01-10T12:00:10Z"
}
```

**Verify:**
```sql
-- conversation_id should still be 1
-- last_message_at should be updated
-- message count should be 4 (2 exchanges)
SELECT COUNT(*) FROM messages WHERE conversation_id = 1;
-- Result: 4
```

---

#### Step 5: List Conversations
```bash
curl -X GET http://localhost:7860/chat/conversations \
  -H "Authorization: Bearer $TOKEN"
```

**Expected Response:**
```json
{
  "conversations": [
    {
      "id": 1,
      "title": null,
      "created_at": "2024-01-10T12:00:00Z",
      "last_message_at": "2024-01-10T12:00:10Z",
      "message_count": 4
    }
  ],
  "total": 1,
  "skip": 0,
  "limit": 20
}
```

---

#### Step 6: Retrieve Full Conversation
```bash
curl -X GET http://localhost:7860/chat/conversations/1 \
  -H "Authorization: Bearer $TOKEN"
```

**Expected Response:**
```json
{
  "id": 1,
  "title": null,
  "created_at": "2024-01-10T12:00:00Z",
  "last_message_at": "2024-01-10T12:00:10Z",
  "messages": [
    {
      "id": 1,
      "sender_id": 1,
      "content": "What is machine learning?",
      "created_at": "2024-01-10T12:00:05Z"
    },
    {
      "id": 2,
      "sender_id": 1,
      "content": "Machine learning is...",
      "created_at": "2024-01-10T12:00:05Z"
    },
    {
      "id": 3,
      "sender_id": 1,
      "content": "Tell me about neural networks",
      "created_at": "2024-01-10T12:00:10Z"
    },
    {
      "id": 4,
      "sender_id": 1,
      "content": "Neural networks are...",
      "created_at": "2024-01-10T12:00:10Z"
    }
  ]
}
```

---

#### Step 7: Search Conversations
```bash
curl -X GET "http://localhost:7860/chat/search?q=neural" \
  -H "Authorization: Bearer $TOKEN"
```

**Expected Response:**
```json
{
  "conversations": [
    {
      "id": 1,
      "title": null,
      "created_at": "2024-01-10T12:00:00Z",
      "last_message_at": "2024-01-10T12:00:10Z",
      "message_count": 4
    }
  ],
  "total": 1,
  "skip": 0,
  "limit": 20
}
```

---

#### Step 8: Auto-Generate Title (via Service - Optional)
The conversation title can be auto-generated:
```python
# In backend code
from src.services.conversation_service import ConversationService

await ConversationService.auto_generate_title(
    conversation_id=1,
    session=session
)
```

Then list conversations again to see title:
```json
{
  "title": "What is machine learning?",
  "message_count": 4
}
```

---

#### Step 9: Delete Conversation (Soft Delete)
```bash
curl -X DELETE http://localhost:7860/chat/conversations/1 \
  -H "Authorization: Bearer $TOKEN"
```

**Expected Response:**
```json
{
  "message": "Conversation deleted successfully"
}
```

**Verify:**
```sql
-- Mark as deleted
SELECT * FROM conversations WHERE id = 1;
-- Result: is_deleted = true

-- But data is preserved
SELECT COUNT(*) FROM messages WHERE conversation_id = 1;
-- Result: 4 (messages still exist)

-- Should not appear in list
SELECT * FROM conversations WHERE user_id = 1 AND is_deleted = false;
-- Result: (empty set)
```

---

## Security Verification

### Test: User Isolation (403 Forbidden)

#### Create Second User:
```bash
curl -X POST http://localhost:7860/auth/register \
  -H "Content-Type: application/json" \
  -d '{
    "email": "bob@example.com",
    "name": "Bob",
    "password": "SecurePass123!"
  }'
```

#### Login as Bob:
```bash
curl -X POST http://localhost:7860/auth/login \
  -H "Content-Type: application/json" \
  -d '{
    "email": "bob@example.com",
    "password": "SecurePass123!"
  }'
```

**Save token:** `BOB_TOKEN="..."`

#### Try to Access Alice's Conversation:
```bash
curl -X GET http://localhost:7860/chat/conversations/1 \
  -H "Authorization: Bearer $BOB_TOKEN"
```

**Expected Response (403):**
```json
{
  "detail": "You do not have access to this conversation"
}
```

**HTTP Status:** `403 Forbidden` ✅

---

### Test: Missing Authorization (401/403)

```bash
curl -X GET http://localhost:7860/chat/conversations/1
```

**Expected Response:**
```json
{
  "detail": "Not authenticated"
}
```

**HTTP Status:** `403 Forbidden` (HTTPBearer rejects missing credentials) ✅

---

### Test: Deleted Conversation Not in List

```bash
# After deleting conversation 1
curl -X GET http://localhost:7860/chat/conversations \
  -H "Authorization: Bearer $TOKEN"
```

**Expected Response:** `{"conversations": [], "total": 0}` ✅

---

## Error Handling Verification

### Test 1: Invalid Conversation ID (404)
```bash
curl -X GET http://localhost:7860/chat/conversations/99999 \
  -H "Authorization: Bearer $TOKEN"
```

**Expected:** `404 Not Found`
```json
{
  "detail": "Conversation not found"
}
```

---

### Test 2: Invalid Query (Empty - 422)
```bash
curl -X POST http://localhost:7860/chat/send \
  -H "Content-Type: application/json" \
  -H "Authorization: Bearer $TOKEN" \
  -d '{"query": ""}'
```

**Expected:** `422 Unprocessable Entity`
```json
{
  "detail": [
    {
      "loc": ["body", "query"],
      "msg": "ensure this value has at least 1 character",
      "type": "value_error.any_str.min_length"
    }
  ]
}
```

---

### Test 3: Conversation Not Found (404)
```bash
curl -X POST http://localhost:7860/chat/send \
  -H "Content-Type: application/json" \
  -H "Authorization: Bearer $TOKEN" \
  -d '{
    "conversation_id": 99999,
    "query": "Hello?"
  }'
```

**Expected:** `404 Not Found`
```json
{
  "detail": "Conversation not found"
}
```

---

## Performance Verification

### Pagination Test
```bash
# Get first page (10 conversations)
curl -X GET "http://localhost:7860/chat/conversations?skip=0&limit=10" \
  -H "Authorization: Bearer $TOKEN"

# Get second page (next 10)
curl -X GET "http://localhost:7860/chat/conversations?skip=10&limit=10" \
  -H "Authorization: Bearer $TOKEN"
```

Should handle large numbers efficiently without N+1 queries.

---

### Search Performance
```bash
curl -X GET "http://localhost:7860/chat/search?q=python&skip=0&limit=20" \
  -H "Authorization: Bearer $TOKEN"
```

Should complete in < 1 second with indexes.

---

## Database Verification

### Check Schema
```sql
-- Check conversation columns
\d conversations;

-- Verify indexes exist
SELECT * FROM pg_indexes WHERE tablename = 'conversations';
-- Should include: conversations_user_id_idx, conversations_last_message_at_idx

-- Check message volume
SELECT 
  conversation_id,
  COUNT(*) as message_count,
  MAX(created_at) as last_message
FROM messages
GROUP BY conversation_id
ORDER BY last_message DESC;
```

---

## Logging Verification

### Check Application Logs
```bash
# Watch logs in real-time
tail -f app.log

# Should see:
# - User login: "User logged in: alice@example.com"
# - Conversation creation: "Created conversation 1 for user 1"
# - Message storage: "Saved user message to conversation 1"
# - AI response: "Saved AI response to conversation 1"
# - Retrieve attempt: "Retrieved conversation 1 with 4 messages"
# - Access denied: "User 2 attempted to access conversation 1 belonging to user 1"
# - Deletion: "Soft deleted conversation 1"
```

---

## Troubleshooting

### Issue: 403 on login-required endpoints
**Cause:** JWT token expired or invalid
**Fix:** Re-login to get fresh token

### Issue: Conversation ID not in response
**Cause:** Agent service error
**Fix:** Check agent.service() is working, check OpenRouter API key

### Issue: Cross-user access still works (bug!)
**Cause:** Authorization check not implemented
**Fix:** Verify `permission` check in service method

### Issue: Deleted conversations still visible
**Cause:** `is_deleted` filter not applied
**Fix:** Check queries include `WHERE is_deleted = false`

### Issue: Message count incorrect
**Cause:** Soft-deleted messages counted
**Fix:** Check message join condition works properly

---

## ✅ Complete Verification Checklist

- [ ] User registration works
- [ ] Login returns JWT token
- [ ] New conversation by message creation
- [ ] Follow-up messages use same conversation_id
- [ ] List shows all user's conversations
- [ ] Retrieve shows full message history
- [ ] Search finds conversations by keyword
- [ ] Delete soft-removes conversation
- [ ] Other user can't access conversation (403)
- [ ] Other user can't delete conversation (403)
- [ ] Pagination works with skip/limit
- [ ] Search pagination works
- [ ] Error messages are Clear (404, 403)
- [ ] Empty query rejected (422)
- [ ] Logs show all operations
- [ ] Message ordering is chronological
- [ ] Soft deleted data preserved in DB
- [ ] Soft deleted not in lists/searches

**Status:** Ready for production deployment ✅