Update app.py

app.py

@@ -1323,7 +1323,7 @@ def remove_loading_animations(chat_history):
 def add_user_message(message, chat_history, conversation_state):
     """
     Add user message with proper state management.
-    ✅ FIXED: Uses Gradio state instead of overwriting with global manager.
+    ✅ FIXED: Creates new lists to avoid reference issues with Gradio state.
     """
     callback_start = log_step("add_user_message")
     
@@ -1331,23 +1331,23 @@ def add_user_message(message, chat_history, conversation_state):
         log_step("add_user_message", callback_start)
         return "", chat_history, conversation_state
     
-    # Add to both states
-    conversation_state.append({"role": "user", "content": message})
-    chat_history.append({"role": "user", "content": message})
+    # Create new lists with the user message appended
+    new_conversation_state = conversation_state + [{"role": "user", "content": message}]
+    new_chat_history = chat_history + [{"role": "user", "content": message}]
     
     # Update global state for persistence
-    global_state_manager.update_conversation_state(chat_history, conversation_state)
+    global_state_manager.update_conversation_state(new_chat_history, new_conversation_state)
     
     log_step("add_user_message", callback_start)
     
-    # Return updated states to Gradio
-    return "", chat_history, conversation_state
+    # Return NEW states to Gradio
+    return "", new_chat_history, new_conversation_state
 
 
 def add_loading_animation(chat_history, conversation_state):
     """
     Add loading animation with proper state management.
-    ✅ FIXED: Uses Gradio state instead of overwriting.
+    ✅ FIXED: Creates new lists to avoid reference issues.
     """
     callback_start = log_step("add_loading_animation")
     
@@ -1356,24 +1356,24 @@ def add_loading_animation(chat_history, conversation_state):
         return chat_history, conversation_state
     
     # Remove any existing loading animations
-    chat_history = remove_loading_animations(chat_history)
+    new_chat_history = remove_loading_animations(chat_history)
     
-    # Add loading animation
+    # Add loading animation to NEW list
     gif_data = get_loading_animation_base64()
     if gif_data:
         loading_html = f'<div class="loading-animation" style="display: flex; align-items: center; justify-content: center; padding: 0.5px;"><img src="{gif_data}" alt="Thinking..." style="height: 64px; width: auto; max-width: 80px;" /></div>'
     else:
         loading_html = '<div class="loading-animation" style="display: flex; align-items: center; justify-content: center; padding: 0.5px;"><div style="width: 64px; height: 64px;"></div></div>'
     
-    chat_history.append({"role": "assistant", "content": loading_html})
+    new_chat_history = new_chat_history + [{"role": "assistant", "content": loading_html}]
     
     # Update global state for persistence
-    global_state_manager.update_conversation_state(chat_history, conversation_state)
+    global_state_manager.update_conversation_state(new_chat_history, conversation_state)
     
     log_step("add_loading_animation", callback_start)
     
-    # Return updated states to Gradio
-    return chat_history, conversation_state
+    # Return NEW states to Gradio
+    return new_chat_history, conversation_state
 
 
 def generate_response(chat_history, conversation_state):
@@ -1420,24 +1420,28 @@ def generate_response(chat_history, conversation_state):
                 chat_history = remove_loading_animations(chat_history)
                 first_chunk = False
             
-            # Update chat display
+            # Update chat display - create new list for Gradio to detect change
             if chat_history and chat_history[-1]["role"] == "assistant":
-                chat_history[-1]["content"] = chunk
+                # Update existing assistant message
+                new_chat_history = chat_history[:-1] + [{"role": "assistant", "content": chunk}]
             else:
-                chat_history.append({"role": "assistant", "content": chunk})
+                # Add new assistant message
+                new_chat_history = chat_history + [{"role": "assistant", "content": chunk}]
+            
+            chat_history = new_chat_history
             
             # Yield to update UI during streaming
             yield chat_history, conversation_state
         
-        # Add final response to conversation state
+        # Add final response to conversation state (create new list)
         final_response = chunk if 'chunk' in locals() else raw_response
-        conversation_state.append({"role": "assistant", "content": final_response})
+        new_conversation_state = conversation_state + [{"role": "assistant", "content": final_response}]
         
         # Update global state with final conversation
-        global_state_manager.update_conversation_state(chat_history, conversation_state)
+        global_state_manager.update_conversation_state(chat_history, new_conversation_state)
         
         # Final yield with complete states
-        yield chat_history, conversation_state
+        yield chat_history, new_conversation_state
         
     except Exception as e:
         logger.error(f"Response generation error: {e}")
@@ -1446,13 +1450,12 @@ def generate_response(chat_history, conversation_state):
         
         error_msg = f"I encountered an error: {str(e)}"
         
-        # Clean up and show error
-        chat_history = remove_loading_animations(chat_history)
-        chat_history.append({"role": "assistant", "content": error_msg})
-        conversation_state.append({"role": "assistant", "content": error_msg})
+        # Clean up and show error (create new lists)
+        new_chat_history = remove_loading_animations(chat_history) + [{"role": "assistant", "content": error_msg}]
+        new_conversation_state = conversation_state + [{"role": "assistant", "content": error_msg}]
         
-        global_state_manager.update_conversation_state(chat_history, conversation_state)
-        yield chat_history, conversation_state
+        global_state_manager.update_conversation_state(new_chat_history, new_conversation_state)
+        yield new_chat_history, new_conversation_state
     
     log_step("generate_response", callback_start)