Spaces:
Sleeping
Sleeping
File size: 17,726 Bytes
5ecbd0f a42ab7e 5ecbd0f a42ab7e 5ecbd0f a42ab7e 5ecbd0f a42ab7e 5ecbd0f a42ab7e 5ecbd0f |
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 |
"""
Rigorous Tests for Payments Router.
Tests cover:
1. Helper functions (generate_transaction_id, update_verified_by, process_successful_payment)
2. GET /packages endpoint
3. POST /create-order endpoint
4. POST /verify endpoint
5. POST /webhook/razorpay endpoint
6. GET /history endpoint
Uses mocked Razorpay service and database.
"""
import pytest
import json
from datetime import datetime
from unittest.mock import patch, MagicMock, AsyncMock
from fastapi.testclient import TestClient
# =============================================================================
# 1. Helper Function Tests
# =============================================================================
class TestHelperFunctions:
"""Test helper functions in payments router."""
def test_generate_transaction_id_format(self):
"""Generated transaction IDs have correct format."""
from routers.payments import generate_transaction_id
txn_id = generate_transaction_id()
assert txn_id.startswith("txn_")
assert len(txn_id) == 20 # "txn_" + 16 hex chars
def test_generate_transaction_id_unique(self):
"""Each generated ID is unique."""
from routers.payments import generate_transaction_id
ids = [generate_transaction_id() for _ in range(100)]
assert len(set(ids)) == 100 # All unique
def test_update_verified_by_client_first(self):
"""First verification by client sets verified_by to 'client'."""
from routers.payments import update_verified_by
transaction = MagicMock()
transaction.verified_by = None
changed = update_verified_by(transaction, "client")
assert transaction.verified_by == "client"
assert changed == True
def test_update_verified_by_webhook_first(self):
"""First verification by webhook sets verified_by to 'webhook'."""
from routers.payments import update_verified_by
transaction = MagicMock()
transaction.verified_by = None
changed = update_verified_by(transaction, "webhook")
assert transaction.verified_by == "webhook"
assert changed == True
def test_update_verified_by_both_sources(self):
"""Second verification from other source sets verified_by to 'both'."""
from routers.payments import update_verified_by
# Client first, then webhook
transaction = MagicMock()
transaction.verified_by = "client"
changed = update_verified_by(transaction, "webhook")
assert transaction.verified_by == "both"
assert changed == True
def test_update_verified_by_same_source_no_change(self):
"""Same source verification doesn't change value."""
from routers.payments import update_verified_by
transaction = MagicMock()
transaction.verified_by = "client"
changed = update_verified_by(transaction, "client")
assert transaction.verified_by == "client"
assert changed == False
# =============================================================================
# 2. GET /packages Tests
# =============================================================================
class TestGetPackages:
"""Test GET /packages endpoint."""
def test_list_packages_returns_all(self):
"""List all available packages."""
from routers.payments import router
from fastapi import FastAPI
app = FastAPI()
app.include_router(router)
client = TestClient(app)
response = client.get("/payments/packages")
assert response.status_code == 200
data = response.json()
assert "packages" in data
assert len(data["packages"]) >= 3 # At least starter, standard, pro
def test_packages_have_required_fields(self):
"""Each package has all required fields."""
from routers.payments import router
from fastapi import FastAPI
app = FastAPI()
app.include_router(router)
client = TestClient(app)
response = client.get("/payments/packages")
data = response.json()
for pkg in data["packages"]:
assert "id" in pkg
assert "name" in pkg
assert "credits" in pkg
assert "amount_paise" in pkg
assert "currency" in pkg
# =============================================================================
# 3. POST /create-order Tests
# =============================================================================
class TestCreateOrder:
"""Test POST /create-order endpoint."""
def test_create_order_requires_auth(self):
"""Create order requires authentication."""
from routers.payments import router
from fastapi import FastAPI
app = FastAPI()
app.include_router(router)
client = TestClient(app)
response = client.post(
"/payments/create-order",
json={"package_id": "starter"}
)
# Should fail with auth error (401 or 403)
assert response.status_code in [401, 403, 422]
def test_create_order_invalid_package(self):
"""Reject invalid package_id."""
from routers.payments import router
from fastapi import FastAPI
from core.dependencies import get_current_user
app = FastAPI()
# Mock authenticated user
mock_user = MagicMock()
mock_user.user_id = "test-user"
mock_user.credits = 100
app.dependency_overrides[get_current_user] = lambda: mock_user
app.include_router(router)
client = TestClient(app)
with patch('routers.payments.is_razorpay_configured', return_value=True):
response = client.post(
"/payments/create-order",
json={"package_id": "invalid_package"}
)
assert response.status_code == 400
assert "Invalid package" in response.json()["detail"]
def test_create_order_razorpay_not_configured(self):
"""Return 503 if Razorpay not configured."""
from routers.payments import router
from fastapi import FastAPI
from core.dependencies import get_current_user
app = FastAPI()
mock_user = MagicMock()
mock_user.user_id = "test-user"
app.dependency_overrides[get_current_user] = lambda: mock_user
app.include_router(router)
client = TestClient(app)
with patch('routers.payments.is_razorpay_configured', return_value=False):
response = client.post(
"/payments/create-order",
json={"package_id": "starter"}
)
assert response.status_code == 503
assert "not configured" in response.json()["detail"]
# =============================================================================
# 4. POST /verify Tests
# =============================================================================
class TestVerifyPayment:
"""Test POST /verify endpoint."""
def test_verify_requires_auth(self):
"""Verify requires authentication."""
from routers.payments import router
from fastapi import FastAPI
app = FastAPI()
app.include_router(router)
client = TestClient(app)
response = client.post(
"/payments/verify",
json={
"razorpay_order_id": "order_123",
"razorpay_payment_id": "pay_123",
"razorpay_signature": "sig_123"
}
)
assert response.status_code in [401, 403, 422]
def test_verify_transaction_not_found(self):
"""Return 404 for unknown transaction."""
from routers.payments import router
from fastapi import FastAPI
from core.dependencies import get_current_user
from core.database import get_db
app = FastAPI()
mock_user = MagicMock()
mock_user.user_id = "test-user"
mock_user.credits = 100
# Mock database that returns no transaction
async def mock_get_db():
mock_db = AsyncMock()
mock_result = MagicMock()
mock_result.scalar_one_or_none.return_value = None
mock_db.execute.return_value = mock_result
yield mock_db
app.dependency_overrides[get_current_user] = lambda: mock_user
app.dependency_overrides[get_db] = mock_get_db
app.include_router(router)
client = TestClient(app)
with patch('routers.payments.get_razorpay_service') as mock_service:
mock_service.return_value = MagicMock()
response = client.post(
"/payments/verify",
json={
"razorpay_order_id": "order_unknown",
"razorpay_payment_id": "pay_123",
"razorpay_signature": "sig_123"
}
)
assert response.status_code == 404
assert "not found" in response.json()["detail"].lower()
# =============================================================================
# 5. POST /webhook/razorpay Tests
# =============================================================================
class TestWebhook:
"""Test POST /webhook/razorpay endpoint."""
def test_webhook_requires_signature(self):
"""Webhook requires X-Razorpay-Signature header."""
from routers.payments import router
from fastapi import FastAPI
from core.database import get_db
app = FastAPI()
async def mock_get_db():
mock_db = AsyncMock()
yield mock_db
app.dependency_overrides[get_db] = mock_get_db
app.include_router(router)
client = TestClient(app)
response = client.post(
"/payments/webhook/razorpay",
json={"event": "payment.captured"}
)
assert response.status_code == 401
assert "signature" in response.json()["detail"].lower()
def test_webhook_rejects_invalid_signature(self):
"""Webhook rejects invalid signature."""
from routers.payments import router
from fastapi import FastAPI
from core.database import get_db
app = FastAPI()
async def mock_get_db():
mock_db = AsyncMock()
yield mock_db
app.dependency_overrides[get_db] = mock_get_db
app.include_router(router)
client = TestClient(app)
with patch('routers.payments.get_razorpay_service') as mock_service:
service_instance = MagicMock()
service_instance.verify_webhook_signature.return_value = False
mock_service.return_value = service_instance
response = client.post(
"/payments/webhook/razorpay",
json={"event": "payment.captured"},
headers={"X-Razorpay-Signature": "invalid-sig"}
)
assert response.status_code == 401
assert "invalid" in response.json()["detail"].lower()
def test_webhook_accepts_valid_signature(self):
"""Webhook accepts valid signature."""
from routers.payments import router
from fastapi import FastAPI
from core.database import get_db
app = FastAPI()
async def mock_get_db():
mock_db = AsyncMock()
yield mock_db
app.dependency_overrides[get_db] = mock_get_db
app.include_router(router)
client = TestClient(app)
with patch('routers.payments.get_razorpay_service') as mock_service:
service_instance = MagicMock()
service_instance.verify_webhook_signature.return_value = True
mock_service.return_value = service_instance
response = client.post(
"/payments/webhook/razorpay",
json={"event": "unknown.event"},
headers={"X-Razorpay-Signature": "valid-sig"}
)
assert response.status_code == 200
assert response.json()["status"] == "ok"
# =============================================================================
# 6. GET /history Tests
# =============================================================================
class TestPaymentHistory:
"""Test GET /history endpoint."""
def test_history_requires_auth(self):
"""History requires authentication."""
from routers.payments import router
from fastapi import FastAPI
app = FastAPI()
app.include_router(router)
client = TestClient(app)
response = client.get("/payments/history")
assert response.status_code in [401, 403, 422]
def test_history_returns_empty_list(self):
"""History returns empty list for user with no transactions."""
from routers.payments import router
from fastapi import FastAPI
from core.dependencies import get_current_user
from core.database import get_db
app = FastAPI()
mock_user = MagicMock()
mock_user.user_id = "test-user"
async def mock_get_db():
mock_db = AsyncMock()
# Mock count query
mock_count_result = MagicMock()
mock_count_result.scalar.return_value = 0
# Mock transactions query
mock_txn_result = MagicMock()
mock_txn_result.scalars.return_value.all.return_value = []
mock_db.execute.side_effect = [mock_count_result, mock_txn_result]
yield mock_db
app.dependency_overrides[get_current_user] = lambda: mock_user
app.dependency_overrides[get_db] = mock_get_db
app.include_router(router)
client = TestClient(app)
response = client.get("/payments/history")
assert response.status_code == 200
data = response.json()
assert data["transactions"] == []
assert data["total_count"] == 0
def test_history_pagination_params(self):
"""History respects pagination parameters."""
from routers.payments import router
from fastapi import FastAPI
from core.dependencies import get_current_user
from core.database import get_db
app = FastAPI()
mock_user = MagicMock()
mock_user.user_id = "test-user"
async def mock_get_db():
mock_db = AsyncMock()
mock_count_result = MagicMock()
mock_count_result.scalar.return_value = 50
mock_txn_result = MagicMock()
mock_txn_result.scalars.return_value.all.return_value = []
mock_db.execute.side_effect = [mock_count_result, mock_txn_result]
yield mock_db
app.dependency_overrides[get_current_user] = lambda: mock_user
app.dependency_overrides[get_db] = mock_get_db
app.include_router(router)
client = TestClient(app)
response = client.get("/payments/history?page=2&limit=10")
assert response.status_code == 200
data = response.json()
assert data["page"] == 2
assert data["limit"] == 10
assert data["total_count"] == 50
# =============================================================================
# 7. Response Model Tests
# =============================================================================
class TestResponseModels:
"""Test response model schemas."""
def test_package_response_model(self):
"""PackageResponse model validates correctly."""
from routers.payments import PackageResponse
pkg = PackageResponse(
id="starter",
name="Starter",
credits=100,
amount_paise=9900,
amount_rupees=99.0,
currency="INR"
)
assert pkg.id == "starter"
assert pkg.credits == 100
def test_verify_payment_response_model(self):
"""VerifyPaymentResponse model validates correctly."""
from routers.payments import VerifyPaymentResponse
resp = VerifyPaymentResponse(
success=True,
message="Payment successful",
transaction_id="txn_abc123",
credits_added=100,
new_balance=500
)
assert resp.success == True
assert resp.credits_added == 100
def test_payment_history_item_model(self):
"""PaymentHistoryItem model validates correctly."""
from routers.payments import PaymentHistoryItem
item = PaymentHistoryItem(
transaction_id="txn_123",
package_id="starter",
credits_amount=100,
amount_paise=9900,
currency="INR",
status="paid",
gateway="razorpay",
created_at="2024-01-01T00:00:00"
)
assert item.transaction_id == "txn_123"
assert item.status == "paid"
if __name__ == "__main__":
pytest.main([__file__, "-v"])
|