on demand url

routers/gemini.py

@@ -325,6 +325,7 @@ async def get_job_status(
     """
     Get the status of a job.
     Poll this endpoint until status is 'completed' or 'failed'.
+    For processing video jobs, this will check the Gemini API status and update the job.
     """
     query = select(GeminiJob).where(
         GeminiJob.job_id == job_id,
@@ -339,6 +340,14 @@ async def get_job_status(
             detail="Job not found"
         )
     
+    # If job is processing and is a video job, check Gemini API status and update
+    if job.status == "processing" and job.job_type == "video" and job.third_party_id:
+        from services.gemini_job_worker import GeminiJobProcessor
+        processor = GeminiJobProcessor()
+        job = await processor.check_status(job, db)
+        await db.commit()
+        await db.refresh(job)
+    
     response = {
         "success": True,
         "job_id": job.job_id,
@@ -348,6 +357,10 @@ async def get_job_status(
         "credits_remaining": user.credits
     }
     
+    # Include prompt for video jobs
+    if job.job_type == "video" and job.input_data:
+        response["prompt"] = job.input_data.get("prompt")
+    
     if job.status == "queued":
         response["position"] = await get_queue_position(db, job.job_id)
     
@@ -359,7 +372,7 @@ async def get_job_status(
         response["output"] = job.output_data
         
         # For video jobs, add download URL
-        if job.job_type == "video" and job.output_data and job.output_data.get("filename"):
+        if job.job_type == "video" and job.output_data and (job.output_data.get("filename") or job.output_data.get("video_url")):
             response["download_url"] = f"/gemini/download/{job.job_id}"
     
     if job.status == "failed":
@@ -377,6 +390,7 @@ async def download_video(
 ):
     """
     Download a generated video.
+    If the video hasn't been downloaded yet, downloads it from the stored URL.
     """
     query = select(GeminiJob).where(
         GeminiJob.job_id == job_id,
@@ -392,24 +406,53 @@ async def download_video(
             detail="Job not found"
         )
     
-    if job.status != "completed" or not job.output_data or not job.output_data.get("filename"):
+    if job.status != "completed" or not job.output_data:
         raise HTTPException(
             status_code=status.HTTP_400_BAD_REQUEST,
             detail="Video not ready for download"
         )
     
-    filepath = os.path.join(DOWNLOADS_DIR, job.output_data["filename"])
-    if not os.path.exists(filepath):
+    # Check if video is already downloaded
+    filename = job.output_data.get("filename")
+    if filename:
+        filepath = os.path.join(DOWNLOADS_DIR, filename)
+        if os.path.exists(filepath):
+            return FileResponse(
+                path=filepath,
+                media_type="video/mp4",
+                filename=f"video_{job_id}.mp4"
+            )
+    
+    # Video not downloaded yet, download from stored URL
+    video_url = job.output_data.get("video_url")
+    if not video_url:
         raise HTTPException(
-            status_code=status.HTTP_404_NOT_FOUND,
-            detail="Video file not found"
+            status_code=status.HTTP_400_BAD_REQUEST,
+            detail="No video URL available"
         )
     
-    return FileResponse(
-        path=filepath,
-        media_type="video/mp4",
-        filename=f"video_{job_id}.mp4"
-    )
+    # Download the video on-demand
+    from services.gemini_service import GeminiService
+    service = GeminiService()  # Uses default API key
+    
+    try:
+        filename = await service.download_video(video_url, job.job_id)
+        
+        # Update job with downloaded filename
+        job.output_data = {**job.output_data, "filename": filename}
+        await db.commit()
+        
+        filepath = os.path.join(DOWNLOADS_DIR, filename)
+        return FileResponse(
+            path=filepath,
+            media_type="video/mp4",
+            filename=f"video_{job_id}.mp4"
+        )
+    except Exception as e:
+        raise HTTPException(
+            status_code=status.HTTP_500_INTERNAL_SERVER_ERROR,
+            detail=f"Failed to download video: {str(e)}"
+        )
 
 
 @router.post("/job/{job_id}/cancel")

services/gemini_job_worker.py

@@ -112,29 +112,12 @@ class GeminiJobProcessor(JobProcessor[GeminiJob]):
                 if status_result.get("status") == "completed":
                     video_url = status_result.get("video_url")
                     if video_url:
-                        try:
-                            filename = await service.download_video(video_url, job.job_id)
-                            job.status = "completed"
-                            job.output_data = {"filename": filename}
-                            job.error_message = None  # Clear any previous error
-                            success = True
-                        except Exception as download_error:
-                            # Download failed - track separately
-                            error_msg = f"Download failed: {download_error}"
-                            logger.error(f"Error downloading video for {job.job_id}: {download_error}")
-                            
-                            # Fail job after 5 download attempts (don't retry forever)
-                            if job.retry_count >= 5:
-                                job.status = "failed"
-                                job.error_message = error_msg
-                                job.completed_at = datetime.utcnow()
-                            else:
-                                # Retry
-                                job.retry_count += 1
-                                job.error_message = f"Download attempt {job.retry_count} failed: {download_error}"
-                                config = WorkerConfig.from_env()
-                                interval = get_interval_for_priority(job.priority, config)
-                                job.next_process_at = datetime.utcnow() + timedelta(seconds=interval)
+                        # Store video URL - download will happen on-demand when client requests
+                        job.status = "completed"
+                        job.output_data = {"video_url": video_url}
+                        job.error_message = None  # Clear any previous error
+                        job.completed_at = datetime.utcnow()
+                        success = True
                     else:
                         job.status = "failed"
                         job.error_message = "No video URL returned"