Spaces:
Running
Topic-preview resume: also forward summaries, not just titles
Browse filesThe topic-scene-preview endpoint computes Claude's per-topic summaries
and stores them in the preview cache alongside titles, but /jobs only
read out and forwarded titles. On the resume path the orchestrator's
topic_summaries list stayed empty, so the "In brief:" advance-organizer
line never appeared in the final guide — even though the editor
showed the summary value correctly in the per-segment edit panel
(because the preview's initial render came straight from the cache).
Forward summaries through the same preview→/jobs→worker→run_pipeline
seam as titles:
- Read topic_summaries from the preview cache entry, filter by the
user's curated indices, store as preselected_topic_summaries.
- Thread it through _run_job_in_thread → run_pipeline as a new
optional kwarg, mirroring preselected_topic_titles.
- run_pipeline pre-populates its topic_summaries local from
preselected_topic_summaries so the existing apply loop fires
without needing a re-segmentation.
- app/main.py +12 -0
- app/pipeline/orchestrator.py +4 -1
|
@@ -224,6 +224,7 @@ def _run_job_in_thread(
|
|
| 224 |
module: str | None,
|
| 225 |
preselected_frames: list[SceneFrame] | None = None,
|
| 226 |
preselected_topic_titles: list[str] | None = None,
|
|
|
|
| 227 |
preview_dir: Path | None = None,
|
| 228 |
) -> None:
|
| 229 |
def progress_cb(ev: ProgressEvent) -> None:
|
|
@@ -241,6 +242,7 @@ def _run_job_in_thread(
|
|
| 241 |
progress=progress_cb,
|
| 242 |
preselected_frames=preselected_frames,
|
| 243 |
preselected_topic_titles=preselected_topic_titles,
|
|
|
|
| 244 |
)
|
| 245 |
# Snapshot alt-frame bytes into the Job before workdir cleanup so the
|
| 246 |
# editor can lazy-fetch them via /alts/{job_id}/{filename}.
|
|
@@ -620,6 +622,7 @@ async def start_job(
|
|
| 620 |
preview_entry: dict | None = None
|
| 621 |
preselected_frames: list[SceneFrame] | None = None
|
| 622 |
preselected_topic_titles: list[str] | None = None
|
|
|
|
| 623 |
is_topic_preview = False
|
| 624 |
if preview_token:
|
| 625 |
with _preview_cache_lock:
|
|
@@ -687,12 +690,20 @@ async def start_job(
|
|
| 687 |
# Topic preview indices are positional (the order topics
|
| 688 |
# came back in /topic-scene-preview), not the .index field.
|
| 689 |
topic_titles = preview_entry.get("topic_titles") or []
|
|
|
|
| 690 |
preselected_frames = [
|
| 691 |
f for i, f in enumerate(all_frames) if i in idx_set
|
| 692 |
]
|
| 693 |
preselected_topic_titles = [
|
| 694 |
t for i, t in enumerate(topic_titles) if i in idx_set
|
| 695 |
]
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 696 |
else:
|
| 697 |
preselected_frames = [f for f in all_frames if f.index in idx_set]
|
| 698 |
if not preselected_frames:
|
|
@@ -784,6 +795,7 @@ async def start_job(
|
|
| 784 |
module=module or None,
|
| 785 |
preselected_frames=preselected_frames,
|
| 786 |
preselected_topic_titles=preselected_topic_titles,
|
|
|
|
| 787 |
preview_dir=preview_entry["dir"] if preview_entry else None,
|
| 788 |
),
|
| 789 |
daemon=True,
|
|
|
|
| 224 |
module: str | None,
|
| 225 |
preselected_frames: list[SceneFrame] | None = None,
|
| 226 |
preselected_topic_titles: list[str] | None = None,
|
| 227 |
+
preselected_topic_summaries: list[str] | None = None,
|
| 228 |
preview_dir: Path | None = None,
|
| 229 |
) -> None:
|
| 230 |
def progress_cb(ev: ProgressEvent) -> None:
|
|
|
|
| 242 |
progress=progress_cb,
|
| 243 |
preselected_frames=preselected_frames,
|
| 244 |
preselected_topic_titles=preselected_topic_titles,
|
| 245 |
+
preselected_topic_summaries=preselected_topic_summaries,
|
| 246 |
)
|
| 247 |
# Snapshot alt-frame bytes into the Job before workdir cleanup so the
|
| 248 |
# editor can lazy-fetch them via /alts/{job_id}/{filename}.
|
|
|
|
| 622 |
preview_entry: dict | None = None
|
| 623 |
preselected_frames: list[SceneFrame] | None = None
|
| 624 |
preselected_topic_titles: list[str] | None = None
|
| 625 |
+
preselected_topic_summaries: list[str] | None = None
|
| 626 |
is_topic_preview = False
|
| 627 |
if preview_token:
|
| 628 |
with _preview_cache_lock:
|
|
|
|
| 690 |
# Topic preview indices are positional (the order topics
|
| 691 |
# came back in /topic-scene-preview), not the .index field.
|
| 692 |
topic_titles = preview_entry.get("topic_titles") or []
|
| 693 |
+
topic_summaries = preview_entry.get("topic_summaries") or []
|
| 694 |
preselected_frames = [
|
| 695 |
f for i, f in enumerate(all_frames) if i in idx_set
|
| 696 |
]
|
| 697 |
preselected_topic_titles = [
|
| 698 |
t for i, t in enumerate(topic_titles) if i in idx_set
|
| 699 |
]
|
| 700 |
+
# Forward summaries too — without this the resumed
|
| 701 |
+
# pipeline has no topic-segmentation pass (it was done
|
| 702 |
+
# in the preview) so the "In brief:" advance organizer
|
| 703 |
+
# would silently fall back to "" for every section.
|
| 704 |
+
preselected_topic_summaries = [
|
| 705 |
+
s for i, s in enumerate(topic_summaries) if i in idx_set
|
| 706 |
+
]
|
| 707 |
else:
|
| 708 |
preselected_frames = [f for f in all_frames if f.index in idx_set]
|
| 709 |
if not preselected_frames:
|
|
|
|
| 795 |
module=module or None,
|
| 796 |
preselected_frames=preselected_frames,
|
| 797 |
preselected_topic_titles=preselected_topic_titles,
|
| 798 |
+
preselected_topic_summaries=preselected_topic_summaries,
|
| 799 |
preview_dir=preview_entry["dir"] if preview_entry else None,
|
| 800 |
),
|
| 801 |
daemon=True,
|
|
@@ -256,6 +256,7 @@ def run_pipeline(
|
|
| 256 |
progress: ProgressCallback | None = None,
|
| 257 |
preselected_frames: list[SceneFrame] | None = None,
|
| 258 |
preselected_topic_titles: list[str] | None = None,
|
|
|
|
| 259 |
) -> PipelineResult:
|
| 260 |
def _emit(percent: float, stage: str, message: str) -> None:
|
| 261 |
if progress:
|
|
@@ -359,7 +360,9 @@ def run_pipeline(
|
|
| 359 |
# include; the chosen titles arrive aligned to `kept` and we'll
|
| 360 |
# apply them after extraction without re-segmenting.
|
| 361 |
topic_titles: list[str] = list(preselected_topic_titles) if preselected_topic_titles else []
|
| 362 |
-
topic_summaries: list[str] =
|
|
|
|
|
|
|
| 363 |
if inputs.llm_toggles.topic_segmentation:
|
| 364 |
with_images = inputs.llm_toggles.topic_segmentation_with_images
|
| 365 |
_emit(
|
|
|
|
| 256 |
progress: ProgressCallback | None = None,
|
| 257 |
preselected_frames: list[SceneFrame] | None = None,
|
| 258 |
preselected_topic_titles: list[str] | None = None,
|
| 259 |
+
preselected_topic_summaries: list[str] | None = None,
|
| 260 |
) -> PipelineResult:
|
| 261 |
def _emit(percent: float, stage: str, message: str) -> None:
|
| 262 |
if progress:
|
|
|
|
| 360 |
# include; the chosen titles arrive aligned to `kept` and we'll
|
| 361 |
# apply them after extraction without re-segmenting.
|
| 362 |
topic_titles: list[str] = list(preselected_topic_titles) if preselected_topic_titles else []
|
| 363 |
+
topic_summaries: list[str] = (
|
| 364 |
+
list(preselected_topic_summaries) if preselected_topic_summaries else []
|
| 365 |
+
)
|
| 366 |
if inputs.llm_toggles.topic_segmentation:
|
| 367 |
with_images = inputs.llm_toggles.topic_segmentation_with_images
|
| 368 |
_emit(
|