juras3k commited on
Commit
bf88ffc
·
1 Parent(s): fbefe31

add exception handling to feedback

Browse files
Files changed (1) hide show
  1. src/feedback.py +11 -3
src/feedback.py CHANGED
@@ -22,15 +22,21 @@ VOTE_FIELDS = [
22
 
23
  def _get_sheet(sheet_name):
24
  creds_json = os.environ.get("GCP_SERVICE_ACCOUNT")
 
 
25
  if not creds_json:
26
  raise RuntimeError("GCP_SERVICE_ACCOUNT env var not set")
 
 
 
 
27
  creds_dict = json.loads(creds_json)
28
  creds = Credentials.from_service_account_info(
29
  creds_dict,
30
  scopes=["https://www.googleapis.com/auth/spreadsheets"],
31
  )
32
  client = gspread.authorize(creds)
33
- spreadsheet = client.open_by_key(os.environ.get("SPREADSHEET_ID"))
34
  try:
35
  return spreadsheet.worksheet(sheet_name)
36
  except gspread.WorksheetNotFound:
@@ -75,7 +81,8 @@ def save_session(features, quality_score, recs, rating=None, comment=""):
75
  ]
76
  sheet.append_row(row)
77
  except Exception as e:
78
- pass
 
79
 
80
 
81
  def save_vote(style_name: str, vote: str, features: dict, gender: str = ""):
@@ -105,7 +112,8 @@ def save_vote(style_name: str, vote: str, features: dict, gender: str = ""):
105
  ]
106
  sheet.append_row(row)
107
  except Exception as e:
108
- pass
 
109
 
110
  def load_feedback():
111
  try:
 
22
 
23
  def _get_sheet(sheet_name):
24
  creds_json = os.environ.get("GCP_SERVICE_ACCOUNT")
25
+ spreadsheet_id = os.environ.get("SPREADSHEET_ID")
26
+
27
  if not creds_json:
28
  raise RuntimeError("GCP_SERVICE_ACCOUNT env var not set")
29
+
30
+ if not spreadsheet_id:
31
+ raise RuntimeError("SPREADSHEET_ID env var not set")
32
+
33
  creds_dict = json.loads(creds_json)
34
  creds = Credentials.from_service_account_info(
35
  creds_dict,
36
  scopes=["https://www.googleapis.com/auth/spreadsheets"],
37
  )
38
  client = gspread.authorize(creds)
39
+ spreadsheet = client.open_by_key(spreadsheet_id)
40
  try:
41
  return spreadsheet.worksheet(sheet_name)
42
  except gspread.WorksheetNotFound:
 
81
  ]
82
  sheet.append_row(row)
83
  except Exception as e:
84
+ print(f"Google Sheets save_session error: {repr(e)}")
85
+ raise
86
 
87
 
88
  def save_vote(style_name: str, vote: str, features: dict, gender: str = ""):
 
112
  ]
113
  sheet.append_row(row)
114
  except Exception as e:
115
+ print(f"Google Sheets save_vote error: {repr(e)}")
116
+ raise
117
 
118
  def load_feedback():
119
  try: