fix(sqlalchemy): replace deprecated subquery() usages with select().scalar_subquery() across services to eliminate warnings

docs/devlogs/server/runtimeerror.txt

@@ -1,113 +1,55 @@
-===== Application Startup at 2025-12-08 12:51:08 =====
+===== Application Startup at 2025-12-08 13:11:53 =====
 
-Traceback (most recent call last):
-  File "/usr/local/bin/uvicorn", line 8, in <module>
-    sys.exit(main())
-             ^^^^^^
-  File "/usr/local/lib/python3.11/site-packages/click/core.py", line 1485, in __call__
-    return self.main(*args, **kwargs)
-           ^^^^^^^^^^^^^^^^^^^^^^^^^^
-  File "/usr/local/lib/python3.11/site-packages/click/core.py", line 1406, in main
-    rv = self.invoke(ctx)
-         ^^^^^^^^^^^^^^^^
-  File "/usr/local/lib/python3.11/site-packages/click/core.py", line 1269, in invoke
-    return ctx.invoke(self.callback, **ctx.params)
-           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
-  File "/usr/local/lib/python3.11/site-packages/click/core.py", line 824, in invoke
-    return callback(*args, **kwargs)
-           ^^^^^^^^^^^^^^^^^^^^^^^^^
-  File "/usr/local/lib/python3.11/site-packages/uvicorn/main.py", line 416, in main
-    run(
-  File "/usr/local/lib/python3.11/site-packages/uvicorn/main.py", line 587, in run
-    server.run()
-  File "/usr/local/lib/python3.11/site-packages/uvicorn/server.py", line 61, in run
-    return asyncio.run(self.serve(sockets=sockets))
-           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
-  File "/usr/local/lib/python3.11/asyncio/runners.py", line 190, in run
-    return runner.run(main)
-           ^^^^^^^^^^^^^^^^
-  File "/usr/local/lib/python3.11/asyncio/runners.py", line 118, in run
-    return self._loop.run_until_complete(task)
-           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
-  File "uvloop/loop.pyx", line 1518, in uvloop.loop.Loop.run_until_complete
-  File "/usr/local/lib/python3.11/site-packages/uvicorn/server.py", line 68, in serve
-    config.load()
-  File "/usr/local/lib/python3.11/site-packages/uvicorn/config.py", line 467, in load
-    self.loaded_app = import_from_string(self.app)
-                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
-  File "/usr/local/lib/python3.11/site-packages/uvicorn/importer.py", line 21, in import_from_string
-    module = importlib.import_module(module_str)
-             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
-  File "/usr/local/lib/python3.11/importlib/__init__.py", line 126, in import_module
-    return _bootstrap._gcd_import(name[level:], package, level)
-           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
-  File "<frozen importlib._bootstrap>", line 1204, in _gcd_import
-  File "<frozen importlib._bootstrap>", line 1176, in _find_and_load
-  File "<frozen importlib._bootstrap>", line 1147, in _find_and_load_unlocked
-  File "<frozen importlib._bootstrap>", line 690, in _load_unlocked
-  File "<frozen importlib._bootstrap_external>", line 940, in exec_module
-  File "<frozen importlib._bootstrap>", line 241, in _call_with_frames_removed
-  File "/app/src/app/main.py", line 142, in <module>
-    from app.api.v1.router import api_router
-  File "/app/src/app/api/v1/router.py", line 5, in <module>
-    from app.api.v1 import (
-  File "/app/src/app/api/v1/projects.py", line 111, in <module>
-    planned_start_from: Optional[date] = Query(None),
-                                 ^^^^
-NameError: name 'date' is not defined
-Traceback (most recent call last):
-  File "/usr/local/bin/uvicorn", line 8, in <module>
-    sys.exit(main())
-             ^^^^^^
-  File "/usr/local/lib/python3.11/site-packages/click/core.py", line 1485, in __call__
-    return self.main(*args, **kwargs)
-           ^^^^^^^^^^^^^^^^^^^^^^^^^^
-  File "/usr/local/lib/python3.11/site-packages/click/core.py", line 1406, in main
-    rv = self.invoke(ctx)
-         ^^^^^^^^^^^^^^^^
-  File "/usr/local/lib/python3.11/site-packages/click/core.py", line 1269, in invoke
-    return ctx.invoke(self.callback, **ctx.params)
-           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
-  File "/usr/local/lib/python3.11/site-packages/click/core.py", line 824, in invoke
-    return callback(*args, **kwargs)
-           ^^^^^^^^^^^^^^^^^^^^^^^^^
-  File "/usr/local/lib/python3.11/site-packages/uvicorn/main.py", line 416, in main
-    run(
-  File "/usr/local/lib/python3.11/site-packages/uvicorn/main.py", line 587, in run
-    server.run()
-  File "/usr/local/lib/python3.11/site-packages/uvicorn/server.py", line 61, in run
-    return asyncio.run(self.serve(sockets=sockets))
-           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
-  File "/usr/local/lib/python3.11/asyncio/runners.py", line 190, in run
-    return runner.run(main)
-           ^^^^^^^^^^^^^^^^
-  File "/usr/local/lib/python3.11/asyncio/runners.py", line 118, in run
-    return self._loop.run_until_complete(task)
-           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
-  File "uvloop/loop.pyx", line 1518, in uvloop.loop.Loop.run_until_complete
-  File "/usr/local/lib/python3.11/site-packages/uvicorn/server.py", line 68, in serve
-    config.load()
-  File "/usr/local/lib/python3.11/site-packages/uvicorn/config.py", line 467, in load
-    self.loaded_app = import_from_string(self.app)
-                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
-  File "/usr/local/lib/python3.11/site-packages/uvicorn/importer.py", line 21, in import_from_string
-    module = importlib.import_module(module_str)
-             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
-  File "/usr/local/lib/python3.11/importlib/__init__.py", line 126, in import_module
-    return _bootstrap._gcd_import(name[level:], package, level)
-           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
-  File "<frozen importlib._bootstrap>", line 1204, in _gcd_import
-  File "<frozen importlib._bootstrap>", line 1176, in _find_and_load
-  File "<frozen importlib._bootstrap>", line 1147, in _find_and_load_unlocked
-  File "<frozen importlib._bootstrap>", line 690, in _load_unlocked
-  File "<frozen importlib._bootstrap_external>", line 940, in exec_module
-  File "<frozen importlib._bootstrap>", line 241, in _call_with_frames_removed
-  File "/app/src/app/main.py", line 142, in <module>
-    from app.api.v1.router import api_router
-  File "/app/src/app/api/v1/router.py", line 5, in <module>
-    from app.api.v1 import (
-  File "/app/src/app/api/v1/projects.py", line 111, in <module>
-    planned_start_from: Optional[date] = Query(None),
-                                 ^^^^
-NameError: name 'date' is not defined
- 
+INFO: 2025-12-08T13:12:13 - app.main: ============================================================
+INFO:     Started server process [7]
+INFO: 2025-12-08T13:12:13 - app.main: 🚀 SwiftOps API v1.0.0 | PRODUCTION
+INFO:     Waiting for application startup.
+INFO: 2025-12-08T13:12:13 - app.main: 📊 Dashboard: Enabled
+INFO: 2025-12-08T13:12:13 - app.main: ============================================================
+INFO: 2025-12-08T13:12:13 - app.main: 📦 Database:
+INFO: 2025-12-08T13:12:13 - app.main:    ✓ Connected | 45 tables | 6 users
+INFO: 2025-12-08T13:12:13 - app.main: 💾 Cache & Sessions:
+INFO: 2025-12-08T13:12:14 - app.services.otp_service: ✅ OTP Service initialized with Redis storage
+INFO: 2025-12-08T13:12:14 - app.main:    ✓ Redis: Connected
+INFO: 2025-12-08T13:12:14 - app.main: 🔌 External Services:
+INFO: 2025-12-08T13:12:15 - app.main:    ✓ Cloudinary: Connected
+INFO: 2025-12-08T13:12:15 - app.main:    ✓ Resend: Configured
+INFO: 2025-12-08T13:12:15 - app.main:    ○ WASender: Disconnected
+INFO: 2025-12-08T13:12:15 - app.main:    ✓ Supabase: Connected | 6 buckets
+INFO: 2025-12-08T13:12:15 - app.main: ============================================================
+INFO: 2025-12-08T13:12:15 - app.main: ✅ Startup complete | Ready to serve requests
+INFO: 2025-12-08T13:12:15 - app.main: ============================================================
+INFO:     Application startup complete.
+INFO:     Uvicorn running on http://0.0.0.0:7860 (Press CTRL+C to quit)
+INFO:     10.16.37.13:39871 - "GET /health HTTP/1.1" 200 OK
+INFO:     10.16.13.79:21557 - "GET /health HTTP/1.1" 200 OK
+INFO:     10.16.37.13:15177 - "GET /health HTTP/1.1" 200 OK
+INFO: 2025-12-08T13:12:39 - app.api.deps: Checking active user: 43b778b0-2062-4724-abbb-916a4835a9b0, is_active: True, type: <class 'bool'>
+INFO: 2025-12-08T13:12:39 - app.api.deps: User 43b778b0-2062-4724-abbb-916a4835a9b0 is active - proceeding
+INFO:     10.16.37.13:15177 - "GET /api/v1/auth/me HTTP/1.1" 200 OK
+INFO: 2025-12-08T13:12:39 - app.api.deps: Checking active user: 43b778b0-2062-4724-abbb-916a4835a9b0, is_active: True, type: <class 'bool'>
+INFO: 2025-12-08T13:12:39 - app.api.deps: User 43b778b0-2062-4724-abbb-916a4835a9b0 is active - proceeding
+INFO:     10.16.37.13:15177 - "GET /api/v1/auth/me/preferences/available-apps HTTP/1.1" 200 OK
+INFO: 2025-12-08T13:12:39 - app.api.deps: Checking active user: 43b778b0-2062-4724-abbb-916a4835a9b0, is_active: True, type: <class 'bool'>
+INFO: 2025-12-08T13:12:39 - app.api.deps: User 43b778b0-2062-4724-abbb-916a4835a9b0 is active - proceeding
+INFO:     10.16.13.79:49016 - "GET /api/v1/auth/me/preferences HTTP/1.1" 200 OK
+INFO: 2025-12-08T13:12:40 - app.api.deps: Checking active user: 43b778b0-2062-4724-abbb-916a4835a9b0, is_active: True, type: <class 'bool'>
+INFO: 2025-12-08T13:12:40 - app.api.deps: User 43b778b0-2062-4724-abbb-916a4835a9b0 is active - proceeding
+INFO:     10.16.13.79:49016 - "GET /api/v1/analytics/user/overview?limit=50 HTTP/1.1" 200 OK
+INFO: 2025-12-08T13:12:41 - app.api.deps: Checking active user: 43b778b0-2062-4724-abbb-916a4835a9b0, is_active: True, type: <class 'bool'>
+INFO: 2025-12-08T13:12:41 - app.api.deps: User 43b778b0-2062-4724-abbb-916a4835a9b0 is active - proceeding
+INFO: 2025-12-08T13:12:41 - app.services.project_service: Listed 1 projects (total: 1) for user 43b778b0-2062-4724-abbb-916a4835a9b0
+INFO:     10.16.13.79:49016 - "GET /api/v1/projects?page=1&per_page=100&status=active HTTP/1.1" 200 OK
+INFO: 2025-12-08T13:12:45 - app.api.deps: Checking active user: 43b778b0-2062-4724-abbb-916a4835a9b0, is_active: True, type: <class 'bool'>
+INFO: 2025-12-08T13:12:45 - app.api.deps: User 43b778b0-2062-4724-abbb-916a4835a9b0 is active - proceeding
+INFO: 2025-12-08T13:12:45 - app.services.dashboard_service: Dashboard cache MISS for project 0ade6bd1-e492-4e25-b681-59f42058d29a, user 43b778b0-2062-4724-abbb-916a4835a9b0 - building fresh data
+INFO: 2025-12-08T13:12:45 - app.services.dashboard_service: Built and cached dashboard for project 0ade6bd1-e492-4e25-b681-59f42058d29a
+INFO:     10.16.13.79:1190 - "GET /api/v1/projects/0ade6bd1-e492-4e25-b681-59f42058d29a/dashboard HTTP/1.1" 200 OK
+INFO: 2025-12-08T13:12:47 - app.api.deps: Checking active user: 43b778b0-2062-4724-abbb-916a4835a9b0, is_active: True, type: <class 'bool'>
+INFO: 2025-12-08T13:12:47 - app.api.deps: User 43b778b0-2062-4724-abbb-916a4835a9b0 is active - proceeding
+INFO:     10.16.13.79:1190 - "GET /api/v1/projects/0ade6bd1-e492-4e25-b681-59f42058d29a/regions HTTP/1.1" 200 OK
+INFO:     10.16.37.13:61170 - "GET /api/v1/tickets/stats?project_id=0ade6bd1-e492-4e25-b681-59f42058d29a&status=open HTTP/1.1" 200 OK
+/app/src/app/services/ticket_service.py:792: SAWarning: Coercing Subquery object into a select() for use in IN(); please pass a select() construct explicitly
+  query = query.filter(Ticket.project_id.in_(team_projects))
+INFO: 2025-12-08T13:12:48 - app.services.ticket_service: Listed 6 tickets (total: 6) for user 43b778b0-2062-4724-abbb-916a4835a9b0
+INFO:     10.16.37.13:1625 - "GET /api/v1/tickets?project_id=0ade6bd1-e492-4e25-b681-59f42058d29a&page=1&page_size=50&status=open HTTP/1.1" 200 OK

src/app/api/v1/map.py

@@ -9,6 +9,7 @@ from typing import List, Optional
 from uuid import UUID
 from fastapi import APIRouter, Depends, HTTPException, Query, status
 from sqlalchemy.orm import Session
+from sqlalchemy import select
 
 from app.api.deps import get_db, get_current_user
 from app.models.user import User
@@ -241,10 +242,10 @@ async def get_agent_journey_history(
         can_view = True
     else:
         # Check if current user is a manager in any project where target user is a team member
-        target_projects = db.query(ProjectTeam.project_id).filter(
+        target_projects = select(ProjectTeam.project_id).filter(
             ProjectTeam.user_id == user_id,
             ProjectTeam.deleted_at.is_(None)
-        ).subquery()
+        ).scalar_subquery()
         
         manager_membership = db.query(ProjectTeam).filter(
             ProjectTeam.user_id == current_user.id,

src/app/services/ticket_service.py

@@ -20,7 +20,7 @@ Authorization:
 - client_admin: View their organization's tickets
 """
 from sqlalchemy.orm import Session, joinedload
-from sqlalchemy import and_, or_, func, desc, case
+from sqlalchemy import and_, or_, func, desc, case, select
 from fastapi import HTTPException, status
 from typing import List, Tuple, Optional
 from uuid import UUID
@@ -687,11 +687,11 @@ class TicketService(BaseFilterService):
             from app.models.project_team import ProjectTeam
             
             # Get projects the field agent is assigned to
-            team_projects = db.query(ProjectTeam.project_id).filter(
+            team_projects = select(ProjectTeam.project_id).filter(
                 ProjectTeam.user_id == current_user.id,
                 ProjectTeam.deleted_at.is_(None),
                 ProjectTeam.removed_at.is_(None)
-            ).subquery()
+            ).scalar_subquery()
             
             query = query.filter(Ticket.project_id.in_(team_projects))
         else:
@@ -784,11 +784,11 @@ class TicketService(BaseFilterService):
             query = query.filter(Project.client_id == current_user.client_id)
         elif current_user.role in [AppRole.FIELD_AGENT.value, AppRole.SALES_AGENT.value]:
             from app.models.project_team import ProjectTeam
-            team_projects = db.query(ProjectTeam.project_id).filter(
+            team_projects = select(ProjectTeam.project_id).filter(
                 ProjectTeam.user_id == current_user.id,
                 ProjectTeam.deleted_at.is_(None),
                 ProjectTeam.removed_at.is_(None)
-            ).subquery()
+            ).scalar_subquery()
             query = query.filter(Ticket.project_id.in_(team_projects))
         else:
             raise HTTPException(