fix(api): replace Pydantic Depends model with custom query parser to correctly handle multi-value filters

docs/devlogs/server/runtimeerror.txt

@@ -1,41 +1,57 @@
-Dec 08 12:23:32  INFO:     Started server process [2]
-Dec 08 12:23:32  INFO:     Waiting for application startup.
-Dec 08 12:23:32  INFO: 2025-12-08T12:23:32 - app.main: ============================================================
-Dec 08 12:23:32  INFO: 2025-12-08T12:23:32 - app.main: 🚀 SwiftOps API v1.0.0 | PRODUCTION
-Dec 08 12:23:32  INFO: 2025-12-08T12:23:32 - app.main: 📊 Dashboard: Enabled
-Dec 08 12:23:32  INFO: 2025-12-08T12:23:32 - app.main: ============================================================
-Dec 08 12:23:32  INFO: 2025-12-08T12:23:32 - app.main: 📦 Database:
-Dec 08 12:23:33  INFO: 2025-12-08T12:23:33 - app.main:    ✓ Connected | 45 tables | 6 users
-Dec 08 12:23:33  INFO: 2025-12-08T12:23:33 - app.main: 💾 Cache & Sessions:
-Dec 08 12:23:34  INFO: 2025-12-08T12:23:34 - app.services.otp_service: ✅ OTP Service initialized with Redis storage
-Dec 08 12:23:34  INFO: 2025-12-08T12:23:34 - app.main:    ✓ Redis: Connected
-Dec 08 12:23:34  INFO: 2025-12-08T12:23:34 - app.main: 🔌 External Services:
-Dec 08 12:23:35  INFO: 2025-12-08T12:23:35 - app.main:    ✓ Cloudinary: Connected
-Dec 08 12:23:35  INFO: 2025-12-08T12:23:35 - app.main:    ✓ Resend: Configured
-Dec 08 12:23:35  INFO: 2025-12-08T12:23:35 - app.main:    ○ WASender: Disconnected
-Dec 08 12:23:35  INFO: 2025-12-08T12:23:35 - app.main:    ✓ Supabase: Connected | 6 buckets
-Dec 08 12:23:35  INFO: 2025-12-08T12:23:35 - app.main: ============================================================
-Dec 08 12:23:35  INFO: 2025-12-08T12:23:35 - app.main: ✅ Startup complete | Ready to serve requests
-Dec 08 12:23:35  INFO: 2025-12-08T12:23:35 - app.main: ============================================================
-Dec 08 12:23:35  INFO:     Application startup complete.
-Dec 08 12:23:35  INFO:     Uvicorn running on http://0.0.0.0:7860 (Press CTRL+C to quit)
-Dec 08 12:24:01  INFO:     10.244.45.245:37314 - "GET /health HTTP/1.1" 200 OK
-Dec 08 12:24:12  INFO:     10.244.45.245:37116 - "GET /health HTTP/1.1" 200 OK
-Dec 08 12:24:14  INFO:     10.244.45.245:37116 - "GET /health HTTP/1.1" 200 OK
-Dec 08 12:24:15  INFO: 2025-12-08T12:24:15 - app.api.deps: Checking active user: 43b778b0-2062-4724-abbb-916a4835a9b0, is_active: True, type: <class 'bool'>
-Dec 08 12:24:15  INFO: 2025-12-08T12:24:15 - app.api.deps: User 43b778b0-2062-4724-abbb-916a4835a9b0 is active - proceeding
-Dec 08 12:24:15  INFO:     10.244.16.189:44694 - "GET /api/v1/auth/me HTTP/1.1" 200 OK
-Dec 08 12:24:15  INFO: 2025-12-08T12:24:15 - app.api.deps: Checking active user: 43b778b0-2062-4724-abbb-916a4835a9b0, is_active: True, type: <class 'bool'>
-Dec 08 12:24:15  INFO: 2025-12-08T12:24:15 - app.api.deps: User 43b778b0-2062-4724-abbb-916a4835a9b0 is active - proceeding
-Dec 08 12:24:15  INFO:     10.244.20.101:42996 - "GET /api/v1/auth/me/preferences/available-apps HTTP/1.1" 200 OK
-Dec 08 12:24:15  INFO: 2025-12-08T12:24:15 - app.api.deps: Checking active user: 43b778b0-2062-4724-abbb-916a4835a9b0, is_active: True, type: <class 'bool'>
-Dec 08 12:24:15  INFO: 2025-12-08T12:24:15 - app.api.deps: User 43b778b0-2062-4724-abbb-916a4835a9b0 is active - proceeding
-Dec 08 12:24:15  INFO:     10.244.32.6:51172 - "GET /api/v1/auth/me/preferences HTTP/1.1" 200 OK
-Dec 08 12:24:16  /app/src/app/services/ticket_service.py:792: SAWarning: Coercing Subquery object into a select() for use in IN(); please pass a select() construct explicitly
-Dec 08 12:24:16    query = query.filter(Ticket.project_id.in_(team_projects))
-Dec 08 12:24:16  INFO: 2025-12-08T12:24:16 - app.services.ticket_service: Listed 13 tickets (total: 13) for user 43b778b0-2062-4724-abbb-916a4835a9b0
-Dec 08 12:24:16  INFO: 2025-12-08T12:24:16 - app.api.deps: Checking active user: 43b778b0-2062-4724-abbb-916a4835a9b0, is_active: True, type: <class 'bool'>
-Dec 08 12:24:16  INFO: 2025-12-08T12:24:16 - app.api.deps: User 43b778b0-2062-4724-abbb-916a4835a9b0 is active - proceeding
-Dec 08 12:24:16  INFO:     10.244.32.6:51184 - "GET /api/v1/projects/0ade6bd1-e492-4e25-b681-59f42058d29a/regions HTTP/1.1" 200 OK
-Dec 08 12:24:16  INFO:     10.244.20.101:43012 - "GET /api/v1/tickets?project_id=0ade6bd1-e492-4e25-b681-59f42058d29a&page=1&page_size=50&status=open HTTP/1.1" 200 OK
-Dec 08 12:24:16  INFO:     10.244.45.245:58490 - "GET /api/v1/tickets/stats?project_id=0ade6bd1-e492-4e25-b681-59f42058d29a&status=open HTTP/1.1" 200 OK
+===== Application Startup at 2025-12-08 12:33:13 =====
+
+INFO:     Started server process [7]
+INFO:     Waiting for application startup.
+INFO: 2025-12-08T12:33:24 - app.main: ============================================================
+INFO: 2025-12-08T12:33:24 - app.main: 🚀 SwiftOps API v1.0.0 | PRODUCTION
+INFO: 2025-12-08T12:33:24 - app.main: 📊 Dashboard: Enabled
+INFO: 2025-12-08T12:33:24 - app.main: ============================================================
+INFO: 2025-12-08T12:33:24 - app.main: 📦 Database:
+INFO: 2025-12-08T12:33:24 - app.main:    ✓ Connected | 45 tables | 6 users
+INFO: 2025-12-08T12:33:24 - app.main: 💾 Cache & Sessions:
+INFO: 2025-12-08T12:33:25 - app.services.otp_service: ✅ OTP Service initialized with Redis storage
+INFO: 2025-12-08T12:33:26 - app.main:    ✓ Redis: Connected
+INFO: 2025-12-08T12:33:26 - app.main: 🔌 External Services:
+INFO: 2025-12-08T12:33:27 - app.main:    ✓ Cloudinary: Connected
+INFO: 2025-12-08T12:33:27 - app.main:    ✓ Resend: Configured
+INFO: 2025-12-08T12:33:27 - app.main:    ○ WASender: Disconnected
+INFO: 2025-12-08T12:33:27 - app.main:    ✓ Supabase: Connected | 6 buckets
+INFO: 2025-12-08T12:33:27 - app.main: ============================================================
+INFO: 2025-12-08T12:33:27 - app.main: ✅ Startup complete | Ready to serve requests
+INFO: 2025-12-08T12:33:27 - app.main: ============================================================
+INFO:     Application startup complete.
+INFO:     Uvicorn running on http://0.0.0.0:7860 (Press CTRL+C to quit)
+INFO:     10.16.37.13:50728 - "GET / HTTP/1.1" 200 OK
+INFO:     10.16.13.79:55356 - "GET /health HTTP/1.1" 200 OK
+INFO: 2025-12-08T12:37:16 - app.api.deps: Checking active user: 43b778b0-2062-4724-abbb-916a4835a9b0, is_active: True, type: <class 'bool'>
+INFO: 2025-12-08T12:37:16 - app.api.deps: User 43b778b0-2062-4724-abbb-916a4835a9b0 is active - proceeding
+INFO:     10.16.13.79:55356 - "GET /api/v1/auth/me HTTP/1.1" 200 OK
+INFO: 2025-12-08T12:37:17 - app.api.deps: Checking active user: 43b778b0-2062-4724-abbb-916a4835a9b0, is_active: True, type: <class 'bool'>
+INFO: 2025-12-08T12:37:17 - app.api.deps: User 43b778b0-2062-4724-abbb-916a4835a9b0 is active - proceeding
+INFO:     10.16.13.79:55356 - "GET /api/v1/auth/me/preferences HTTP/1.1" 200 OK
+INFO: 2025-12-08T12:37:17 - app.api.deps: Checking active user: 43b778b0-2062-4724-abbb-916a4835a9b0, is_active: True, type: <class 'bool'>
+INFO: 2025-12-08T12:37:17 - app.api.deps: User 43b778b0-2062-4724-abbb-916a4835a9b0 is active - proceeding
+INFO:     10.16.37.13:46511 - "GET /api/v1/auth/me/preferences/available-apps HTTP/1.1" 200 OK
+/app/src/app/services/ticket_service.py:792: SAWarning: Coercing Subquery object into a select() for use in IN(); please pass a select() construct explicitly
+  query = query.filter(Ticket.project_id.in_(team_projects))
+INFO: 2025-12-08T12:37:18 - app.services.ticket_service: DEBUG: filters.status = None, type = <class 'NoneType'>
+INFO: 2025-12-08T12:37:18 - app.services.base_filter_service: DEBUG apply_multi_value_filter: field=status, values=None, type=<class 'NoneType'>
+INFO: 2025-12-08T12:37:18 - app.services.base_filter_service: DEBUG: Skipping filter - values=None, has_field=True
+INFO: 2025-12-08T12:37:18 - app.services.base_filter_service: DEBUG apply_multi_value_filter: field=ticket_type, values=None, type=<class 'NoneType'>
+INFO: 2025-12-08T12:37:18 - app.services.base_filter_service: DEBUG: Skipping filter - values=None, has_field=True
+INFO: 2025-12-08T12:37:18 - app.services.base_filter_service: DEBUG apply_multi_value_filter: field=priority, values=None, type=<class 'NoneType'>
+INFO: 2025-12-08T12:37:18 - app.services.base_filter_service: DEBUG: Skipping filter - values=None, has_field=True
+INFO: 2025-12-08T12:37:18 - app.services.base_filter_service: DEBUG apply_multi_value_filter: field=source, values=None, type=<class 'NoneType'>
+INFO: 2025-12-08T12:37:18 - app.services.base_filter_service: DEBUG: Skipping filter - values=None, has_field=True
+INFO: 2025-12-08T12:37:18 - app.services.base_filter_service: DEBUG apply_multi_value_filter: field=service_type, values=None, type=<class 'NoneType'>
+INFO: 2025-12-08T12:37:18 - app.services.base_filter_service: DEBUG: Skipping filter - values=None, has_field=True
+INFO: 2025-12-08T12:37:18 - app.services.ticket_service: Listed 13 tickets (total: 13) for user 43b778b0-2062-4724-abbb-916a4835a9b0
+INFO: 2025-12-08T12:37:18 - app.api.deps: Checking active user: 43b778b0-2062-4724-abbb-916a4835a9b0, is_active: True, type: <class 'bool'>
+INFO: 2025-12-08T12:37:18 - app.api.deps: User 43b778b0-2062-4724-abbb-916a4835a9b0 is active - proceeding
+INFO:     10.16.13.79:34696 - "GET /api/v1/projects/0ade6bd1-e492-4e25-b681-59f42058d29a/regions HTTP/1.1" 200 OK
+INFO:     10.16.13.79:55356 - "GET /api/v1/tickets/stats?project_id=0ade6bd1-e492-4e25-b681-59f42058d29a&status=open HTTP/1.1" 200 OK
+INFO:     10.16.37.13:46511 - "GET /api/v1/tickets?project_id=0ade6bd1-e492-4e25-b681-59f42058d29a&page=1&page_size=50&status=open HTTP/1.1" 200 OK
+INFO:     10.16.37.13:23303 - "GET /health HTTP/1.1" 200 OK
+INFO:     10.16.37.13:47886 - "GET /health HTTP/1.1" 200 OK
+INFO:     10.16.37.13:47993 - "GET /health HTTP/1.1" 200 OK
+INFO:     10.16.13.79:30151 - "GET /health HTTP/1.1" 200 OK

src/app/api/v1/tickets.py

@@ -278,6 +278,75 @@ def bulk_create_tickets_from_tasks(
 # LIST/GET TICKETS
 # ============================================
 
+def parse_ticket_filters(
+    project_id: Optional[UUID] = Query(None),
+    project_region_id: Optional[UUID] = Query(None),
+    contractor_invoice_id: Optional[UUID] = Query(None),
+    status: Optional[str] = Query(None),
+    ticket_type: Optional[str] = Query(None),
+    priority: Optional[str] = Query(None),
+    source: Optional[str] = Query(None),
+    service_type: Optional[str] = Query(None),
+    scheduled_date: Optional[date] = Query(None),
+    scheduled_date_from: Optional[date] = Query(None),
+    scheduled_date_to: Optional[date] = Query(None),
+    due_date_from: Optional[date] = Query(None),
+    due_date_to: Optional[date] = Query(None),
+    is_overdue: Optional[bool] = Query(None),
+    is_assigned: Optional[bool] = Query(None),
+    has_expenses: Optional[bool] = Query(None),
+    has_location: Optional[bool] = Query(None),
+    is_invoiced: Optional[bool] = Query(None),
+    sla_violated: Optional[bool] = Query(None),
+    completion_photos_verified: Optional[bool] = Query(None),
+    completion_data_verified: Optional[bool] = Query(None),
+    search: Optional[str] = Query(None),
+    sort_by: Optional[str] = Query(None),
+    sort_order: str = Query("desc"),
+    page: int = Query(1, ge=1),
+    page_size: int = Query(50, ge=1, le=100),
+    from_date: Optional[date] = Query(None),
+    to_date: Optional[date] = Query(None),
+) -> TicketFilters:
+    """Parse and convert query parameters to TicketFilters"""
+    # Parse comma-separated multi-value filters
+    def parse_csv(value: Optional[str]) -> Optional[List[str]]:
+        if value is None:
+            return None
+        return [item.strip() for item in value.split(',') if item.strip()]
+    
+    return TicketFilters(
+        project_id=project_id,
+        project_region_id=project_region_id,
+        contractor_invoice_id=contractor_invoice_id,
+        status=parse_csv(status),
+        ticket_type=parse_csv(ticket_type),
+        priority=parse_csv(priority),
+        source=parse_csv(source),
+        service_type=parse_csv(service_type),
+        scheduled_date=scheduled_date,
+        scheduled_date_from=scheduled_date_from,
+        scheduled_date_to=scheduled_date_to,
+        due_date_from=due_date_from,
+        due_date_to=due_date_to,
+        is_overdue=is_overdue,
+        is_assigned=is_assigned,
+        has_expenses=has_expenses,
+        has_location=has_location,
+        is_invoiced=is_invoiced,
+        sla_violated=sla_violated,
+        completion_photos_verified=completion_photos_verified,
+        completion_data_verified=completion_data_verified,
+        search=search,
+        sort_by=sort_by,
+        sort_order=sort_order,
+        page=page,
+        page_size=page_size,
+        from_date=from_date,
+        to_date=to_date,
+    )
+
+
 @router.get(
     "",
     response_model=TicketListResponse,
@@ -285,7 +354,7 @@ def bulk_create_tickets_from_tasks(
 )
 def list_tickets(
     # New pattern (preferred) - supports all filters via TicketFilters schema
-    filters: TicketFilters = Depends(),
+    filters: TicketFilters = Depends(parse_ticket_filters),
     
     # Legacy support for backward compatibility
     skip: Optional[int] = Query(None, ge=0, description="DEPRECATED: Use page instead"),

src/app/schemas/filters.py

@@ -34,11 +34,11 @@ class TicketFilters(BaseListFilters):
     contractor_invoice_id: Optional[UUID] = Field(None, description="Filter by contractor invoice")
     
     # Multi-value filters (comma-separated in query string)
-    status: Optional[Union[str, List[str]]] = Field(None, description="Filter by status: open,assigned,in_progress,pending_review,completed,cancelled")
-    ticket_type: Optional[Union[str, List[str]]] = Field(None, description="Filter by type: installation,support,infrastructure")
-    priority: Optional[Union[str, List[str]]] = Field(None, description="Filter by priority: low,normal,high,urgent")
-    source: Optional[Union[str, List[str]]] = Field(None, description="Filter by source: sales_order,incident,task")
-    service_type: Optional[Union[str, List[str]]] = Field(None, description="Filter by service: ftth,fttb,fixed_wireless,dsl,adsl,cable,other")
+    status: Optional[List[str]] = Field(None, description="Filter by status: open,assigned,in_progress,pending_review,completed,cancelled")
+    ticket_type: Optional[List[str]] = Field(None, description="Filter by type: installation,support,infrastructure")
+    priority: Optional[List[str]] = Field(None, description="Filter by priority: low,normal,high,urgent")
+    source: Optional[List[str]] = Field(None, description="Filter by source: sales_order,incident,task")
+    service_type: Optional[List[str]] = Field(None, description="Filter by service: ftth,fttb,fixed_wireless,dsl,adsl,cable,other")
     
     # Date filters
     scheduled_date: Optional[date] = Field(None, description="Filter by exact scheduled date")
@@ -56,15 +56,6 @@ class TicketFilters(BaseListFilters):
     sla_violated: Optional[bool] = Field(None, description="Filter SLA violations")
     completion_photos_verified: Optional[bool] = Field(None, description="Filter by photo verification status")
     completion_data_verified: Optional[bool] = Field(None, description="Filter by data verification status")
-    
-    @validator('status', 'ticket_type', 'priority', 'source', 'service_type', pre=True)
-    def parse_comma_separated(cls, v):
-        """Parse comma-separated strings into lists"""
-        if v is None:
-            return None
-        if isinstance(v, str):
-            return [item.strip() for item in v.split(',') if item.strip()]
-        return v
 
 
 class ProjectFilters(BaseListFilters):

src/app/services/base_filter_service.py

@@ -137,14 +137,11 @@ class BaseFilterService:
         Returns:
             Query with filter applied
         """
-        logger.info(f"DEBUG apply_multi_value_filter: field={field_name}, values={values}, type={type(values)}")
         if not values or not hasattr(model, field_name):
-            logger.info(f"DEBUG: Skipping filter - values={values}, has_field={hasattr(model, field_name)}")
             return query
         
         try:
             field = getattr(model, field_name)
-            logger.info(f"DEBUG: Applying filter {field_name} IN {values}")
             return query.filter(field.in_(values))
         except Exception as e:
             logger.error(f"Error applying multi-value filter on {field_name}: {str(e)}")

src/app/services/ticket_service.py

@@ -802,7 +802,6 @@ class TicketService(BaseFilterService):
         query = TicketService.apply_uuid_filter(query, Ticket, 'contractor_invoice_id', filters.contractor_invoice_id)
         
         # Apply multi-value filters
-        logger.info(f"DEBUG: filters.status = {filters.status}, type = {type(filters.status)}")
         query = TicketService.apply_multi_value_filter(query, Ticket, 'status', filters.status)
         query = TicketService.apply_multi_value_filter(query, Ticket, 'ticket_type', filters.ticket_type)
         query = TicketService.apply_multi_value_filter(query, Ticket, 'priority', filters.priority)

test_fastapi_filter.py

@@ -1,44 +0,0 @@
-"""
-Test to understand how FastAPI handles query parameters with Depends()
-"""
-from fastapi import FastAPI, Depends, Query
-from typing import Optional, List
-from pydantic import BaseModel, validator
-
-app = FastAPI()
-
-class TestFilters(BaseModel):
-    status: Optional[List[str]] = None
-    
-    @validator('status', pre=True)
-    def parse_comma_separated(cls, v):
-        print(f"Validator called with: {v}, type: {type(v)}")
-        if v is None:
-            return None
-        if isinstance(v, str):
-            return [item.strip() for item in v.split(',') if item.strip()]
-        return v
-
-@app.get("/test1")
-def test_with_depends(filters: TestFilters = Depends()):
-    """Using Depends() - this is what we currently have"""
-    print(f"Endpoint received: {filters.status}, type: {type(filters.status)}")
-    return {"status": filters.status, "type": str(type(filters.status))}
-
-@app.get("/test2")
-def test_with_query(status: Optional[str] = Query(None)):
-    """Using Query() directly"""
-    if status:
-        status_list = [item.strip() for item in status.split(',') if item.strip()]
-    else:
-        status_list = None
-    print(f"Endpoint received: {status_list}, type: {type(status_list)}")
-    return {"status": status_list, "type": str(type(status_list))}
-
-if __name__ == "__main__":
-    import uvicorn
-    print("Testing FastAPI query parameter handling...")
-    print("\nTest URLs:")
-    print("  http://localhost:8000/test1?status=open")
-    print("  http://localhost:8000/test2?status=open")
-    uvicorn.run(app, host="0.0.0.0", port=8000, log_level="info")